Skip to content
Snippets Groups Projects
Commit 976da2d6 authored by Treehugger Robot's avatar Treehugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Mitigate CropView invalid Range crash" into main

parents 793a7090 646174c9
No related branches found
No related tags found
No related merge requests found
......@@ -504,6 +504,15 @@ flag {
}
}
flag {
name: "screenshot_scroll_crop_view_crash_fix"
namespace: "systemui"
description: "Mitigate crash on invalid computed range in CropView"
bug: "232633995"
metadata {
purpose: PURPOSE_BUGFIX
}
}
flag {
name: "screenshot_private_profile_behavior_fix"
......
......@@ -45,6 +45,7 @@ import androidx.customview.widget.ExploreByTouchHelper;
import androidx.interpolator.view.animation.FastOutSlowInInterpolator;
import com.android.internal.graphics.ColorUtils;
import com.android.systemui.Flags;
import com.android.systemui.res.R;
import java.util.List;
......@@ -378,8 +379,14 @@ public class CropView extends View {
upper = 1;
break;
}
Log.i(TAG, "getAllowedValues: " + boundary + ", "
+ "result=[lower=" + lower + ", upper=" + upper + "]");
if (lower >= upper) {
Log.wtf(TAG, "getAllowedValues computed an invalid range "
+ "[" + lower + ", " + upper + "]");
if (Flags.screenshotScrollCropViewCrashFix()) {
lower = Math.min(lower, upper);
upper = lower;
}
}
return new Range<>(lower, upper);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment