Skip to content
Snippets Groups Projects
Commit 9a240462 authored by Josh Gao's avatar Josh Gao Committed by Edgar Arriaga
Browse files

CachedAppOptimizer: fix fd leak.

errno isn't modified when a syscall returns successfully: this would
leak if errno was already non-zero before entering this function.

Bug: 172518739
Test: none
Change-Id: I38050863ceca226a9c2d143c85e0713c6a6fe511
Merged-In: I38050863ceca226a9c2d143c85e0713c6a6fe511
parent a4ecb890
No related branches found
No related tags found
No related merge requests found
......@@ -86,7 +86,7 @@ static int compactMemory(const std::vector<Vma>& vmas, int pid, int madviseType)
int pidfd = syscall(__NR_pidfd_open, pid, 0);
err = -errno;
if (err < 0) {
if (pidfd < 0) {
// Skip compaction if failed to open pidfd with any error
return err;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment