Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
P
platform_frameworks_base-old
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Farzin Kazemzadeh
platform_frameworks_base-old
Commits
a6b9b072
Commit
a6b9b072
authored
5 years ago
by
Muhammad Qureshi
Committed by
Android (Google) Code Review
5 years ago
Browse files
Options
Downloads
Plain Diff
Merge "Use FrameworkStatsLog instead of StatsLog"
parents
2f764044
73107044
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
core/java/com/android/internal/compat/ChangeReporter.java
+8
-8
8 additions, 8 deletions
core/java/com/android/internal/compat/ChangeReporter.java
services/core/java/com/android/server/compat/PlatformCompat.java
+8
-7
8 additions, 7 deletions
...s/core/java/com/android/server/compat/PlatformCompat.java
with
16 additions
and
15 deletions
core/java/com/android/internal/compat/ChangeReporter.java
+
8
−
8
View file @
a6b9b072
...
...
@@ -18,10 +18,10 @@ package com.android.internal.compat;
import
android.util.Log
;
import
android.util.Slog
;
import
android.util.StatsLog
;
import
com.android.internal.annotations.GuardedBy
;
import
com.android.internal.annotations.VisibleForTesting
;
import
com.android.internal.util.FrameworkStatsLog
;
import
java.util.HashMap
;
import
java.util.HashSet
;
...
...
@@ -85,8 +85,8 @@ public final class ChangeReporter {
*/
public
void
reportChange
(
int
uid
,
long
changeId
,
int
state
)
{
if
(
shouldWriteToStatsLog
(
uid
,
changeId
,
state
))
{
StatsLog
.
write
(
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED
,
uid
,
changeId
,
state
,
mSource
);
Framework
StatsLog
.
write
(
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED
,
uid
,
changeId
,
state
,
mSource
);
}
if
(
shouldWriteToDebug
(
uid
,
changeId
,
state
))
{
debugLog
(
uid
,
changeId
,
state
);
...
...
@@ -174,7 +174,7 @@ public final class ChangeReporter {
private
void
debugLog
(
int
uid
,
long
changeId
,
int
state
)
{
String
message
=
String
.
format
(
"Compat change id reported: %d; UID %d; state: %s"
,
changeId
,
uid
,
stateToString
(
state
));
if
(
mSource
==
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__SOURCE__SYSTEM_SERVER
)
{
if
(
mSource
==
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__SOURCE__SYSTEM_SERVER
)
{
Slog
.
d
(
TAG
,
message
);
}
else
{
Log
.
d
(
TAG
,
message
);
...
...
@@ -183,18 +183,18 @@ public final class ChangeReporter {
}
/**
* Transforms StatsLog.APP_COMPATIBILITY_CHANGE_REPORTED__STATE enum to a string.
* Transforms
Framework
StatsLog.APP_COMPATIBILITY_CHANGE_REPORTED__STATE enum to a string.
*
* @param state to transform
* @return a string representing the state
*/
private
static
String
stateToString
(
int
state
)
{
switch
(
state
)
{
case
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__LOGGED
:
case
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__LOGGED
:
return
"LOGGED"
;
case
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__ENABLED
:
case
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__ENABLED
:
return
"ENABLED"
;
case
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__DISABLED
:
case
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__DISABLED
:
return
"DISABLED"
;
default
:
return
"UNKNOWN"
;
...
...
This diff is collapsed.
Click to expand it.
services/core/java/com/android/server/compat/PlatformCompat.java
+
8
−
7
View file @
a6b9b072
...
...
@@ -30,7 +30,6 @@ import android.os.Binder;
import
android.os.RemoteException
;
import
android.os.UserHandle
;
import
android.util.Slog
;
import
android.util.StatsLog
;
import
com.android.internal.annotations.VisibleForTesting
;
import
com.android.internal.compat.AndroidBuildClassifier
;
...
...
@@ -40,6 +39,7 @@ import com.android.internal.compat.CompatibilityChangeInfo;
import
com.android.internal.compat.IOverrideValidator
;
import
com.android.internal.compat.IPlatformCompat
;
import
com.android.internal.util.DumpUtils
;
import
com.android.internal.util.FrameworkStatsLog
;
import
com.android.server.LocalServices
;
import
java.io.FileDescriptor
;
...
...
@@ -59,7 +59,7 @@ public class PlatformCompat extends IPlatformCompat.Stub {
public
PlatformCompat
(
Context
context
)
{
mContext
=
context
;
mChangeReporter
=
new
ChangeReporter
(
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__SOURCE__SYSTEM_SERVER
);
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__SOURCE__SYSTEM_SERVER
);
mCompatConfig
=
CompatConfig
.
create
(
new
AndroidBuildClassifier
(),
mContext
);
}
...
...
@@ -67,7 +67,7 @@ public class PlatformCompat extends IPlatformCompat.Stub {
PlatformCompat
(
Context
context
,
CompatConfig
compatConfig
)
{
mContext
=
context
;
mChangeReporter
=
new
ChangeReporter
(
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__SOURCE__SYSTEM_SERVER
);
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__SOURCE__SYSTEM_SERVER
);
mCompatConfig
=
compatConfig
;
}
...
...
@@ -75,7 +75,7 @@ public class PlatformCompat extends IPlatformCompat.Stub {
public
void
reportChange
(
long
changeId
,
ApplicationInfo
appInfo
)
{
checkCompatChangeLogPermission
();
reportChange
(
changeId
,
appInfo
.
uid
,
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__LOGGED
);
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__LOGGED
);
}
@Override
...
...
@@ -91,7 +91,8 @@ public class PlatformCompat extends IPlatformCompat.Stub {
@Override
public
void
reportChangeByUid
(
long
changeId
,
int
uid
)
{
checkCompatChangeLogPermission
();
reportChange
(
changeId
,
uid
,
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__LOGGED
);
reportChange
(
changeId
,
uid
,
FrameworkStatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__LOGGED
);
}
@Override
...
...
@@ -99,11 +100,11 @@ public class PlatformCompat extends IPlatformCompat.Stub {
checkCompatChangeReadPermission
();
if
(
mCompatConfig
.
isChangeEnabled
(
changeId
,
appInfo
))
{
reportChange
(
changeId
,
appInfo
.
uid
,
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__ENABLED
);
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__ENABLED
);
return
true
;
}
reportChange
(
changeId
,
appInfo
.
uid
,
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__DISABLED
);
Framework
StatsLog
.
APP_COMPATIBILITY_CHANGE_REPORTED__STATE__DISABLED
);
return
false
;
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment