Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
P
platform_frameworks_base-old
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Farzin Kazemzadeh
platform_frameworks_base-old
Commits
fb1c4009
Commit
fb1c4009
authored
1 year ago
by
Chris Göllner
Committed by
Android (Google) Code Review
1 year ago
Browse files
Options
Downloads
Plain Diff
Merge "Improve toString readability in StatusBarModePerDisplayRepository" into main
parents
2a2beb98
4c38f88e
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
packages/SystemUI/src/com/android/systemui/statusbar/data/repository/StatusBarModePerDisplayRepository.kt
+41
-4
41 additions, 4 deletions
...sbar/data/repository/StatusBarModePerDisplayRepository.kt
with
41 additions
and
4 deletions
packages/SystemUI/src/com/android/systemui/statusbar/data/repository/StatusBarModePerDisplayRepository.kt
+
41
−
4
View file @
fb1c4009
...
...
@@ -17,6 +17,8 @@
package
com.android.systemui.statusbar.data.repository
import
android.graphics.Rect
import
android.view.InsetsFlags
import
android.view.ViewDebug
import
android.view.WindowInsets
import
android.view.WindowInsetsController
import
android.view.WindowInsetsController.APPEARANCE_LOW_PROFILE_BARS
...
...
@@ -305,8 +307,8 @@ constructor(
letterboxDetails
.
isNotEmpty
()
override
fun
dump
(
pw
:
PrintWriter
,
args
:
Array
<
out
String
>)
{
pw
.
println
(
"
originalStatusBarAttributes:
${_originalStatusBarAttributes.value}"
)
pw
.
println
(
"
modifiedStatusBarAttributes:
${modifiedStatusBarAttributes.value}"
)
pw
.
println
(
"${_originalStatusBarAttributes.value}"
)
pw
.
println
(
"${modifiedStatusBarAttributes.value}"
)
pw
.
println
(
"statusBarMode: ${statusBarMode.value}"
)
}
...
...
@@ -320,7 +322,20 @@ constructor(
val
navbarColorManagedByIme
:
Boolean
,
@WindowInsets
.
Type
.
InsetsType
val
requestedVisibleTypes
:
Int
,
val
letterboxDetails
:
List
<
LetterboxDetails
>,
)
)
{
override
fun
toString
():
String
{
return
"""
StatusBarAttributes(
appearance=${appearance.toAppearanceString()},
appearanceRegions=$appearanceRegions,
navbarColorManagedByIme=$navbarColorManagedByIme,
requestedVisibleTypes=${requestedVisibleTypes.toWindowInsetsString()},
letterboxDetails=$letterboxDetails
)
"""
.
trimIndent
()
}
}
/**
* Internal class keeping track of how [StatusBarAttributes] were transformed into new
...
...
@@ -331,9 +346,31 @@ constructor(
val
appearanceRegions
:
List
<
AppearanceRegion
>,
val
navbarColorManagedByIme
:
Boolean
,
val
statusBarBounds
:
BoundsPair
,
)
)
{
override
fun
toString
():
String
{
return
"""
ModifiedStatusBarAttributes(
appearance=${appearance.toAppearanceString()},
appearanceRegions=$appearanceRegions,
navbarColorManagedByIme=$navbarColorManagedByIme,
statusBarBounds=$statusBarBounds
)
"""
.
trimIndent
()
}
}
}
private
fun
@
receiver
:
WindowInsets
.
Type
.
InsetsType
Int
.
toWindowInsetsString
()
=
"[${WindowInsets.Type.toString(this).replace("
", "
,
")}]"
private
fun
@
receiver
:
Appearance
Int
.
toAppearanceString
()
=
if
(
this
==
0
)
{
"NONE"
}
else
{
ViewDebug
.
flagsToString
(
InsetsFlags
::
class
.
java
,
"appearance"
,
this
)
}
@AssistedFactory
interface
StatusBarModePerDisplayRepositoryFactory
{
fun
create
(
@Assisted
(
"displayId"
)
displayId
:
Int
):
StatusBarModePerDisplayRepositoryImpl
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment