Skip to content
Snippets Groups Projects
Commit fb1c4009 authored by Chris Göllner's avatar Chris Göllner Committed by Android (Google) Code Review
Browse files

Merge "Improve toString readability in StatusBarModePerDisplayRepository" into main

parents 2a2beb98 4c38f88e
No related branches found
No related tags found
No related merge requests found
......@@ -17,6 +17,8 @@
package com.android.systemui.statusbar.data.repository
import android.graphics.Rect
import android.view.InsetsFlags
import android.view.ViewDebug
import android.view.WindowInsets
import android.view.WindowInsetsController
import android.view.WindowInsetsController.APPEARANCE_LOW_PROFILE_BARS
......@@ -305,8 +307,8 @@ constructor(
letterboxDetails.isNotEmpty()
override fun dump(pw: PrintWriter, args: Array<out String>) {
pw.println("originalStatusBarAttributes: ${_originalStatusBarAttributes.value}")
pw.println("modifiedStatusBarAttributes: ${modifiedStatusBarAttributes.value}")
pw.println("${_originalStatusBarAttributes.value}")
pw.println("${modifiedStatusBarAttributes.value}")
pw.println("statusBarMode: ${statusBarMode.value}")
}
......@@ -320,7 +322,20 @@ constructor(
val navbarColorManagedByIme: Boolean,
@WindowInsets.Type.InsetsType val requestedVisibleTypes: Int,
val letterboxDetails: List<LetterboxDetails>,
)
) {
override fun toString(): String {
return """
StatusBarAttributes(
appearance=${appearance.toAppearanceString()},
appearanceRegions=$appearanceRegions,
navbarColorManagedByIme=$navbarColorManagedByIme,
requestedVisibleTypes=${requestedVisibleTypes.toWindowInsetsString()},
letterboxDetails=$letterboxDetails
)
"""
.trimIndent()
}
}
/**
* Internal class keeping track of how [StatusBarAttributes] were transformed into new
......@@ -331,9 +346,31 @@ constructor(
val appearanceRegions: List<AppearanceRegion>,
val navbarColorManagedByIme: Boolean,
val statusBarBounds: BoundsPair,
)
) {
override fun toString(): String {
return """
ModifiedStatusBarAttributes(
appearance=${appearance.toAppearanceString()},
appearanceRegions=$appearanceRegions,
navbarColorManagedByIme=$navbarColorManagedByIme,
statusBarBounds=$statusBarBounds
)
"""
.trimIndent()
}
}
}
private fun @receiver:WindowInsets.Type.InsetsType Int.toWindowInsetsString() =
"[${WindowInsets.Type.toString(this).replace(" ", ", ")}]"
private fun @receiver:Appearance Int.toAppearanceString() =
if (this == 0) {
"NONE"
} else {
ViewDebug.flagsToString(InsetsFlags::class.java, "appearance", this)
}
@AssistedFactory
interface StatusBarModePerDisplayRepositoryFactory {
fun create(@Assisted("displayId") displayId: Int): StatusBarModePerDisplayRepositoryImpl
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment