Skip to content
Snippets Groups Projects
Commit fdace52c authored by Zekan Qian's avatar Zekan Qian
Browse files

Remember entries / title in default Page fn.

Bug: 244122804
Test: unit-test & local build gallery
Change-Id: Iadfe4b2c7f6994767af3fcce54c3d791567dff0a
parent 5d3f6f39
No related branches found
No related tags found
No related merge requests found
......@@ -139,9 +139,7 @@ private fun NavControllerWrapperImpl.NavContent(allProvider: Collection<Settings
) + fadeOut(animationSpec = fadeEffect)
},
) { navBackStackEntry ->
val page = remember(navBackStackEntry.arguments) {
spp.createSettingsPage(navBackStackEntry.arguments)
}
val page = remember { spp.createSettingsPage(navBackStackEntry.arguments) }
page.PageWithEvent()
}
}
......
......@@ -18,6 +18,7 @@ package com.android.settingslib.spa.framework.common
import android.os.Bundle
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.navigation.NamedNavArgument
import com.android.settingslib.spa.widget.scaffold.RegularScaffold
......@@ -52,8 +53,10 @@ interface SettingsPageProvider {
/** The [Composable] used to render this page. */
@Composable
fun Page(arguments: Bundle?) {
RegularScaffold(title = getTitle(arguments)) {
for (entry in buildEntry(arguments)) {
val title = remember { getTitle(arguments) }
val entries = remember { buildEntry(arguments) }
RegularScaffold(title) {
for (entry in entries) {
entry.UiLayout()
}
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment