Skip to content
Snippets Groups Projects
  1. Jan 25, 2024
    • Nick's avatar
      SystemUI: fix missing rotate suggestion in 2 button nav mode · 021c8297
      Nick authored and Dhina17's avatar Dhina17 committed
      "contextual", "menu_ime" and "right", we get three different variants
      for one and the same thing. Or well, that's how it was, until Google
      decided to break it. "contextual", which was used for 2-button nav due
      to a Google change, now contains the floating rotation button, but the
      code expects the in-navbar rotation button (and that makes more sense
      too). This was broken by a more or less recent Google commit moving the
      floating rotation button handler to Launcher3 for taskbar. Manually
      changing this to "menu_ime" in this overlay however gets 2-button nav
      back on track.
      Accessibility button, rotation suggestion button, IME switcher and menu
      button (with extra downstream commit that returns support for this) now
      work in 2-button again.
      
      Thanks to SirRGB for bringing this issue to my attention.
      
      Change-Id: I0a09ec0aa8b7dbfef02d1aaf0dedd2128156a6e7
      021c8297
    • Nick's avatar
      SystemUI: show ime switcher + cursor keys if we have space · 20131890
      Nick authored and Dhina17's avatar Dhina17 committed
      Change-Id: I930d9dcb23756aafbf9048066455b5fc5a280e17
      20131890
    • Nick's avatar
      PhoneWindowManager: only handle long press on back key if using it · 961bf332
      Nick authored and Dhina17's avatar Dhina17 committed
      Apps can handle long press back
      
      Test: CtsViewTestCases android.view.cts.LongPressBackTest#testAppIsNotDismissed
      Change-Id: I8c71a0282d98efd2ce69f5ea301f93833733ffae
      961bf332
    • LuK1337's avatar
      VolumeDialogImpl: Add STREAM_NOTIFICATION row · 52621aaf
      LuK1337 authored and Dhina17's avatar Dhina17 committed
      Change-Id: Ia851c70871ef561398203b358e8c4b32995f30cd
      52621aaf
    • Nick's avatar
      SystemUI: Enable cast tile without Wi-Fi connection · 91dd8def
      Nick authored and Dhina17's avatar Dhina17 committed
      * Match Settings behaviour
      * Miracast does not need Wi-Fi connection, it's Wi-Fi Direct
      
      Change-Id: I46c1394f35f993875beaaad547c9709a4355a342
      91dd8def
    • ganeshi4u's avatar
      SystemUI: screenshot: Add delete action chip intent · f7adbc30
      ganeshi4u authored and Dhina17's avatar Dhina17 committed
      
      [ghostrider-reborn] updated to android 12, 13
      
      Co-authored-by: default avatarAdithya R <gh0strider.2k18.reborn@gmail.com>
      Change-Id: Ia55ac91c2db2f44062674a699f8df63c96e1de5c
      f7adbc30
    • Weijie Wang's avatar
      SystemUI: Check whether the selected WFD route is available · 84379c8d
      Weijie Wang authored and Dhina17's avatar Dhina17 committed
      When the selected WFD route is not available, the cast tile in
      quick settings and the cast slot in the status bar are both shown
      as a connected icon, it is not reasonable. This CL checks whether
      the selected route is available when getting the cast devices.
      
      Bug: 247925238
      Test: Mannual
      Change-Id: Ifdbf4c61e95504ae7fc24933695e6fd348d75750
      84379c8d
    • Tommy Webb's avatar
      Fix multi-user silent notifications on lockscreen · 8f2f66da
      Tommy Webb authored and Dhina17's avatar Dhina17 committed
      Read the current user's setting for showing silent notifications
      on the lockscreen whenever user switching occurs. Otherwise, when
      switching to another user, the former user's setting will be in
      effect for the new user, which may cause silent notifications to
      be unexpectedly hidden or visible on the lockscreen.
      
      Change-Id: I65b10f82307cf8eecaafcd1a76ddb5f98bd7c326
      8f2f66da
    • Michael W's avatar
      SystemUI: SideFpsEventHandler: Don't crash without FingerprintManager · ac7cdb3a
      Michael W authored and Dhina17's avatar Dhina17 committed
      * On devices without FP, no FingerprintManager service is published
        resulting in a crash when accessing it
      * Since notifyPowerPressed is sent unconditionally, make sure we even
        have a FPS
      
      Change-Id: I74dbd6357aac4d3a0fb108018755b08968330156
      ac7cdb3a
    • Michael W's avatar
      SystemUI: Prevent NPE when checking for powerbutton FPS · aa818842
      Michael W authored and Dhina17's avatar Dhina17 committed
      * Without a fingerprint sensor at all we also have no access to a
        FingerprintManager, resulting in a NPE
      * Check the FingerprintManager before accessign it
      
      Change-Id: Ia5019524fdf195a9477392fc0264ead8d4d31994
      aa818842
    • Demon000's avatar
      DozeSensors: only use proximity sensor if supported · 8a2fac88
      Demon000 authored and Dhina17's avatar Dhina17 committed
      On msm-4.14 devices, when the proximity sensor is in use,
      the smp2p-sleepstate IRQ is fired multiple times a second,
      with each one holding a 200ms wakelock.
      This is probably a bug in the DSP firmware.
      To fix this, avoid using the proximity sensor in doze mode,
      because sleep is preferred to turning off the screen.
      
      Change-Id: I57750afd77267abdc49780f70636626d20e666ad
      8a2fac88
    • Sean McCreary's avatar
      InputDevices: Fix Hungarian language overlay · 0a31dea1
      Sean McCreary authored and Dhina17's avatar Dhina17 committed
      Correct mistake in keyboard_layout_hungarian.kcm:
      
          Shift + 1 -> '
      
      and add two missing combinations:
      
          AltGr + M -> <
          AltGr + . -> >
      
      Change-Id: I238cec3e23df36e054f35fb9a3847389fd844e6b
      0a31dea1
    • Sean McCreary's avatar
      MetaKeyKeyListener: Disable locking of toggled modifier keys · 9da8fe4d
      Sean McCreary authored and Dhina17's avatar Dhina17 committed
      Toggled (or 'sticky') modifier keys that lock when pressed twice
      cause unexpected behavior that confuses users. Shift is especially
      problematic, as there are three distinct Caps Lock states in
      Android: The Caps Lock key, Alt + Meta, and Shift pressed twice.
      Only the first illuminates the Caps Lock LED, and each can only be
      disabled by pressing the right key/combination again. This forces
      users to 'hunt' to find the right one, and pressing Alt twice will
      lock that modifier leading to yet more unexpected behavior...
      
      Get rid of locking for toggled modifier keys to improve this mess.
      
      Change-Id: I94de5d8d051b2d518457a1a44c9ee939508b9abb
      9da8fe4d
    • Michael W's avatar
      SystemUI: Make battery clickable again · e6eee43a
      Michael W authored and Dhina17's avatar Dhina17 committed
      Change-Id: I66751353944b4cf8a5b5827c3ce53129ec84f1e7
      e6eee43a
    • kyasu's avatar
      PhoneWindowManager: Fix wakeup and long-press actions of assistant key · 1752d190
      kyasu authored and Dhina17's avatar Dhina17 committed
      Added wakeup action and moved long-press action from
      interceptKeyBeforeQueueing to interceptKeyBeforeDispatching
      to handle long-press events.
      
      Change-Id: I77c8093db0e1a9a3b544723302a13df7bf199ba1
      1752d190
    • Aayush Gupta's avatar
      Settings: Add package name to installed app details [2/2] · 077b73d1
      Aayush Gupta authored and Dhina17's avatar Dhina17 committed
      
      Change-Id: I71d9379f9bfdce9efaec1e431a58daeb705d142b
      Signed-off-by: default avatarAayush Gupta <aayushgupta219@gmail.com>
      077b73d1
    • Tommy Webb's avatar
      SystemUI: React to PrivacyConfig changes properly · fa15ba61
      Tommy Webb authored and Dhina17's avatar Dhina17 committed
      Store normal callback references in PrivacyConfig, rather than
      WeakReference. This prevents the callbacks from becoming phantom
      reachable (finalized) shortly after SystemUI starts.
      
      Prior to this change, devices with an overlay config to enable location
      indicators may not properly utilize the indicator until the device is
      rebooted at least once after first install, if the garbage collector
      wins the race and finalizes the necessary PrivacyConfig callback.
      
      Test: Manual: Boot and unlock a device and wait about a minute for it
      to settle. Run `adb shell "dumpsys activity service \
      com.android.systemui | grep locationAvailable"`. It will return two
      results with matching values. Then, run `adb shell cmd device_config \
      put privacy location_indicators_enabled false` (or `true`; whichever
      does not match the value seen earlier) to change the values. Finally,
      run the first adb command again to verify that both of the values for
      locationAvailable match and reflect the newly-specified value.
      
      Issue: calyxos#1648
      Change-Id: I4ee1d5054a8bb294cea267034169c6615490a735
      fa15ba61
    • Tommy Webb's avatar
      JobScheduler: Respect allow-in-power-save perm · 48b78a05
      Tommy Webb authored and Dhina17's avatar Dhina17 committed
      Apps like Messaging may be allowlisted to be unaffected by doze mode
      using the allow-in-power-save permission, but prior to this change,
      their jobs are still restricted from running when the device is idle,
      leading to delayed processing. On the other hand, jobs scheduled by
      packages that are user-exempted via the "Unrestricted" app battery
      usage option do not experience such delays. This change causes system-
      exempted packages to be treated the same as user-exempted packages.
      
      Issue: calyxos#1525
      Bug: 223643513
      Test: CtsJobSchedulerTestCases
      Change-Id: I6d95b3940e536e93aae4b2b48706069e964bdb99
      48b78a05
    • Oliver Scott's avatar
      Increase maximum password length to 64 · 6831be6c
      Oliver Scott authored and Dhina17's avatar Dhina17 committed
      Change-Id: I9570db3ecb4e160eb759d48ae1c4aa70436b624f
      6831be6c
    • Michael Bestas's avatar
      SystemUI: Respect single-touch wakeup setting on rear & front fps devices · 9b04754c
      Michael Bestas authored and Dhina17's avatar Dhina17 committed
      Change-Id: I8c279d5c9ccb2298e84a0af18758c3604a70d9d7
      9b04754c
    • Adithya R's avatar
      SystemUI: Add FingerprintInteractiveToAuthProvider implementation · 170018fc
      Adithya R authored and Dhina17's avatar Dhina17 committed
      This is required for the "touch to unlock anytime" setting on devices
      with side mounted fingerprint sensor.
      
      Ref: 66a048d6
      
      Change-Id: If3308860a428d9966f2b0a0024764df95f8f9a8b
      170018fc
    • LuK1337's avatar
      SystemUI: Don't require AOD for screen off UDFPS · cd3c656c
      LuK1337 authored and Dhina17's avatar Dhina17 committed
      Change-Id: I47eceb1e99146c6793f9bd4e3b86d4f6878a11eb
      cd3c656c
    • Ido Ben-Hur's avatar
      SystemUI: DreamTile: Enable for everyone · eab563fd
      Ido Ben-Hur authored and Dhina17's avatar Dhina17 committed
      We all have dreams, thank you.
      
      Change-Id: I392b833f8a8617165aae8a8e96a5d552a0b249e6
      eab563fd
    • SagarMakhar's avatar
      Apply monet to fingerprint authentication ripple animation · 6bd70b31
      SagarMakhar authored and Dhina17's avatar Dhina17 committed
      Change-Id: I15d0f9fee13647062c651219b527e01a539b6909
      6bd70b31
    • mydongistiny's avatar
      SystemUI: Update string for add tiles with one click · e55ef951
      mydongistiny authored and Dhina17's avatar Dhina17 committed
      The QS panel explains how to add/remove tiles, however after
      'SystemUI: Allow user to add/remove QS with one click' the
      description is wrong. Update the string to suggest both ways.
      
      Change-Id: I2912e9254f9ed14436119addc913fe9907dc7f4e
      e55ef951
    • Andrzej Ressel's avatar
      SystemUI: Allow user to add/remove QS with one click · c6481b66
      Andrzej Ressel authored and Dhina17's avatar Dhina17 committed
      Change-Id: Ied86dcfb6179d936786273867a50610900f1c5e5
      c6481b66
    • Ido Ben-Hur's avatar
      SystemUI: Fix uneven DND icon padding in status bar · d903c00c
      Ido Ben-Hur authored and Dhina17's avatar Dhina17 committed
      Change-Id: I8f7f88d6451371458632b7949ef74bedbeccbaf8
      d903c00c
    • Michael Bestas's avatar
      GnssLocationProvider: Implement xtra-daemon toggle · c4da8040
      Michael Bestas authored and Dhina17's avatar Dhina17 committed
      Emergency location is handled through emergencyCallCallback
      that calls reloadGpsProperties() which in turn runs toggleXtraDaemon()
      before and after the emergency call
      
      Change-Id: I96dd4504f597ed71693c04d9d1806de1c1b73c38
      c4da8040
    • Michael Bestas's avatar
      GnssLocationProvider: Implement PSDS periodic download toggle · 31e0947b
      Michael Bestas authored and Dhina17's avatar Dhina17 committed
      It can be toggled using the existing Assisted GPS setting
      to avoid user confusion.
      
      Change-Id: Ic4c551d1726eac540e47faf214a963ec2adbf7f3
      31e0947b
    • Chirayu Desai's avatar
      GnssLocationProvider: Disable AGPS by default, it'll be enabled in SetupWizard · 65d42c24
      Chirayu Desai authored and Dhina17's avatar Dhina17 committed
      * This way the user can choose to turn it off, and it'll
        never have been enabled
      * If they just keep it as the default (toggle will be on in SuW),
        then it'll be enabled, which is the default we want
      
      Change-Id: I878200a0351d0b0018a975e432602de2badc4eef
      65d42c24
    • Chirayu Desai's avatar
      Ignore AGPS toggle during user-initiated emergency calls · c08f4140
      Chirayu Desai authored and Dhina17's avatar Dhina17 committed
      * The location toggle itself is already ignored during
        emergency calls.
      * Also ignore the AGPS toggle during that to not
        change behavior around emergency calls, we never
        want to affect those, because life is everything.
      
      Issue: calyxos#1490
      Change-Id: Iab13be99ccd65e0fdabcb67a25d73944ef24556a
      c08f4140
    • Tommy Webb's avatar
      Remove sensitive info from SUPL requests · 5c91efdd
      Tommy Webb authored and Dhina17's avatar Dhina17 committed
      
      Except in case of emergency, do not include sensitive subscriber
      information in SUPL requests (A-GPS).
      
      Issue: calyxos#618
      Co-Authored-By: default avatarMSe1969 <mse1969@posteo.de>
      Co-Authored-By: default avatarMichael Bestas <mkbestas@gmail.com>
      Change-Id: I9f372cfcf02d3b768bd5cf1de220eea1fe8c1dbb
      5c91efdd
    • Tommy Webb's avatar
      Fix stuck screen from display change timeout · f4040667
      Tommy Webb authored and Dhina17's avatar Dhina17 committed
      Occasionally, a remote display change is not processed within the
      timeout period. One prominent example is when a device is not able
      to complete its rotation from landscape back to portrait in time after
      the display is turned off. When this happens, and the callback is
      called after the timeout instead, DisplayContent.sendNewConfiguration
      abandons its effort when it sees there are pending display changes, but
      this callback itself might be the pending display change, and it does
      not expect itself to be included as part of this decision. Remove all
      callbacks before calling the last one to prevent this.
      
      Test: Manual: Build and run with REMOTE_DISPLAY_CHANGE_TIMEOUT_MS = 50,
      or some other low value. Enter landscape mode, e.g. by playing a video.
      Turn off the screen. Wait 3 seconds. Turn the screen back on. The lock
      screen will appear as normal. Previously, the screen would remain
      black until a restart or `adb shell wm` change interaction.
      
      Issue: calyxos#1392
      Change-Id: I53659d5580cdd70b4c7138dcca770b11f5397194
      f4040667
    • HZ's avatar
      AlertWindowNotification: Correctly load app label · 643f95f1
      HZ authored and Dhina17's avatar Dhina17 committed
      Passes User ID to AlertWindowNotification to make sure that we can
      correctly load app label for the ones installed in work profile.
      
      Test: Install an app that can display over other apps in the work
      profile, watch the notification title and content when it's drawing over
      other apps. It should now display app label, rather than its package
      name.
      
      Change-Id: I872c0c0f6870a09c4ef1c372d7a87dec156f91fc
      643f95f1
    • LuK1337's avatar
      IllustrationPreference: Hide illustration when we fail to play anim · 539cdd22
      LuK1337 authored and Dhina17's avatar Dhina17 committed
      AOSP skips a lot of lottie animations ;(
      
      Change-Id: Ia600a3ce4dcc59c68a151eff26d253db665d8cd7
      539cdd22
    • SuperDroidBond's avatar
      toast: fix bg color not changing with theme change · 90be84dd
      SuperDroidBond authored and Dhina17's avatar Dhina17 committed
      
      Signed-off-by: default avatarSuperDroidBond <superdroidbond@yahoo.com>
      Change-Id: I0d3a1995fa35d47e246cedef670357d31e004b50
      90be84dd
    • Rashed Abdel-Tawab's avatar
      SystemUI: Add double tap to sleep gesture · b2a2568c
      Rashed Abdel-Tawab authored and Dhina17's avatar Dhina17 committed
      
      Author: Roman Birg <roman@cyngn.com>
      Date:   Sun Nov 23 06:54:06 2014 -0800
      
          SystemUI: double tap to sleep improvements
      
          * Make it more reliable
          * Add it to keyguard
          * Add a content observer to not always query Settings.System on every
          touch event
      
          Change-Id: I292c4d9d9f810843590b7a9ec6e15b99ac44009d
      Signed-off-by: default avatarRoman Birg <roman@cyngn.com>
      
      Author: Adnan Begovic <adnan@cyngn.com>
      Date:   Wed Nov 11 12:05:59 2015 -0800
      
          fw: Move DOUBLE_TAP_SLEEP_GESTURE to CMSettings.
      
          Change-Id: I8274b7c241cef6835a1114a702e68c95b6d2e036
      
      Author: Zhao Wei Liew <zhaoweiliew@gmail.com>
      Date:   Fri Oct 7 08:56:25 2016 +0800
      
          SystemUI: Use Tuner API for CM settings
      
          Get rid of all the excess code by implementing TunerService.Tunable
          and observing any changes made to the settings through it.
      
          Remove UserContentObserver as the Tuner API handles user switches.
      
          Also remove some unused imports that were introduced in earlier
          CM commits, but were never removed since.
      
          Change-Id: Iecafafabdaec82b3b3c72293bea865de48f0e90a
      
      Author: Altaf-Mahdi <altaf.mahdi@gmail.com>
      Date:   Wed Nov 11 16:07:49 2015 -0500
      
          Double tap to sleep anywhere on the lock screen [1/3]
      
          Change-Id: I7dd46f3fafeb2e629974c0f32083d4d9774fb1de
          [neo: Using Tuner API.]
      Signed-off-by: default avatarPranav Vashi <neobuddy89@gmail.com>
      
      Author: dianlujitao <dianlujitao@lineageos.org>
      Date:   Thu Feb 27 12:57:07 2020 +0800
      
          SystemUI: Don't sleep on double tap below status bar
      
          Change-Id: Ic64c29eae63e96f34dc37cda355401b7e2cd2d39
      
      Author: Arian <arian.kulmer@web.de>
      Date:   2020-12-27 14:35:33 +0100
      
          NotificationPanelViewController: Fix DT2S gesture handling
      
          Change-Id: I9f2d3c63d397c998bea5137f747a9ad95ae2c746
      
      Author:     maxwen <max.weninger@gmail.com>
      AuthorDate: Mon Nov 18 00:29:15 2019 +0100
      
          SystemUI: use DOUBLE_TAP_TO_WAKE setting also for wake from aod
      
      Co-authored-by: default avatarMichael W <baddaemon87@gmail.com>
          Change-Id: Ib51fdeaaa9a1b18b79f4f311c65565352d909a72
      
      Author:     Dhina17 <dhinalogu@gmail.com>
      AuthorDate: Tue Sep 12 11:08:28 2023 +0530
      
          SystemUI: Move DT2S from PulsingGestureListener
      
          PulsingGestureListener should handle the touch events in the
          dozing state (AOD/ambient).
          Our DT2S should work in non-dozing mode so move out from here.
      
          Test:
          Double tap to sleep on QQS status bar works fine as before.
      
          Change-Id: Ia79df2eb73e54d8b0dcb1d10b18539f4e88a0a18
      
      Author:     Dhina17 <dhinalogu@gmail.com>
      AuthorDate: Mon Sep 11 16:24:24 2023 +0530
      
          SystemUI: Pass touch events to pulsing gesture listener only if dozing
      
          PulsingGestureListener should handle touch events only in the
          dozing state (AOD/ambient).
      
          Otherwise lockscreen DT2S and AOD DT2W will be in conflict.
      
          Explanation:
          Enable AOD, DT2W and DT2S in the display settings.
      
          In the scenerio, touch events are passed to
          first NotificationPanelView then NotificationShadeWindowView.
      
          So first NotificationPanelView(Controller) detects the double tap
          and put the screen to sleep (hence dozing = true).
          Then as the NotificationShadeWindowView(Controller) detects the double tap at dozing,
          it wakes up from the AOD immediately [from PulsingGestureListener].
      
          so it won't let the screen to sleep on double tap the lockscreen
          when AOD and DT2W are available.
      
          PulsingGestureListener is supposed to receive touch events only in
          the dozing state, so it won't cause this conflict.
      
          Test:
          - Enable AOD, DT2W and DT2S in the display settings
          - Double tap in the lockscreen, it will go to AOD screen.
      
          Change-Id: I6ede700e690ad4c37fea64419cfe8a53d64a9e9a
      
      Author: Bruno Martins <bgcngm@gmail.com>
      Date:   Fri Oct 13 14:04:00 2023 +0100
      
          SystemUI: Respect status bar DT2S gesture defaults
      
          Feature can be disabled by default, but if additionally the preference
          is hidden in Settings, it doesn't allow TunerService to set the proper
          default.
      
          Change-Id: I12b37335fba12cf4d5564f1aa19c5e4cf19f8775
      
      [Pig]: Forward port to R
      [bgcngm]: Forward port to S
      
      Co-authored-by: default avatarMichael W <baddaemon87@gmail.com>
      Change-Id: I7489204e348906dcf6e34fa04f2121974c22ddb9
      b2a2568c
    • maxwen's avatar
      SystemUI: use DOUBLE_TAP_TO_WAKE setting also for wake from aod · 0e029ec3
      maxwen authored and Dhina17's avatar Dhina17 committed
      
      Co-authored-by: default avatarMichael W <baddaemon87@gmail.com>
      Change-Id: Ib51fdeaaa9a1b18b79f4f311c65565352d909a72
      0e029ec3
    • Aaron Kling's avatar
      Fallback ESC to BACK · 86a07eea
      Aaron Kling authored and Dhina17's avatar Dhina17 committed
      The current keyboard shortcut for BACK is ctrl-alt-del, which
      doesn't even work. Allowing ESC to act as BACK matches what some
      vendors are already doing downstream.
      
      Change-Id: I5df5dbedb84d364ac5a56cdf159f2ce9747e6ecc
      86a07eea
    • Sam Mortimer's avatar
      SystemUI: Network Traffic [1/3] · c2b460fc
      Sam Mortimer authored and Dhina17's avatar Dhina17 committed
      Author: Sam Mortimer <sam@mortimer.me.uk>
      Date:   Sat Jan 13 23:26:48 2018 -0800
      
          SystemUI: Network Traffic [1/3]
      
          *) Add lineage-sdk internal NetworkTraffic to the statusbar
             using the LineageStatusBarItemHolder helper.
      
          Change-Id: Ib947832860970a3bccfac70d27a4761f6164d3d5
      
      Author: LuK1337 <priv.luk@gmail.com>
      Date:   Thu May 6 13:50:05 2021 +0200
      
          SystemUI: Force left-to-right for network traffic monitor holder
      
          Fixes: https://gitlab.com/LineageOS/issues/android/-/issues/3445
          Change-Id: I19ea852cedfd2a69a47006977f1b74a172008058
      
      Author: Wolfram Liebchen <achalmgucker@googlemail.com>
      Date:   Mon Jan 23 22:03:20 2023 +0100
      
          SystemUI: Network traffic with center cutout [1/3]
      
          Add possible network traffic display locations on the left
          and right side.
      
          Change-Id: Ic209aa1c0816cb22a5cf4ad9f19908746d38fc68
      
      Change-Id: Ib947832860970a3bccfac70d27a4761f6164d3d5
      c2b460fc
Loading