Skip to content
Snippets Groups Projects
Select Git revision
  • test
  • fifteen-qpr0-new
  • fifteen default
3 results
Search by author
  • Any Author
  • Farzin Kazemzadeh Farzin Kazemzadeh itisFarzin
1 author
  1. Feb 03, 2021
  3. Feb 02, 2021
  5. Jan 29, 2021
  7. Jan 28, 2021
  9. Jan 26, 2021
  11. Jan 22, 2021
  13. Jan 12, 2021
    • Winson's avatar
      Only allow BROWSABLE && DEFAULT Intents to be always opened · a154d7a6
      Winson authored 
      Auto verification of app links requires that an intent filter declare
action=VIEW, scheme=HTTP(S), category=BROWSABLE. However,
PackageManagerService was not taking that into account, missing the
category requirement.

But the app info Settings UI did take category into account, so it was
possible for a user to set an application to automatically open web URIs
without understanding that this also granted domains that were not
visible in the app info UI.

To resolve both this, this change makes it so that both auto
verification and the Settings state can only consider the app as
"always" open only if the Intent contains both BROWSABLE and DEFAULT.

Bug: 175139501
Bug: 175319005

Test: manual, see bug for reproduction steps

Merged-In: Ib957258735893bf2779bed19bd400c6726ee6478
Change-Id: Ib957258735893bf2779bed19bd400c6726ee6478
(cherry picked from commit 4266f938)
      a154d7a6
    • Winson's avatar
      Only allow BROWSABLE && DEFAULT Intents to be always opened · 2565d0b3
      Winson authored 
      Auto verification of app links requires that an intent filter declare
action=VIEW, scheme=HTTP(S), category=BROWSABLE. However,
PackageManagerService was not taking that into account, missing the
category requirement.

But the app info Settings UI did take category into account, so it was
possible for a user to set an application to automatically open web URIs
without understanding that this also granted domains that were not
visible in the app info UI.

To resolve both this, this change makes it so that both auto
verification and the Settings state can only consider the app as
"always" open only if the Intent contains both BROWSABLE and DEFAULT.

Bug: 175139501
Bug: 175319005

Test: manual, see bug for reproduction steps

Merged-In: Ib957258735893bf2779bed19bd400c6726ee6478
Change-Id: Ib957258735893bf2779bed19bd400c6726ee6478
(cherry picked from commit 4266f938)
      2565d0b3
  15. Jan 06, 2021
  17. Dec 14, 2020
    • Robert Carr's avatar
      DO NOT MERGE: WM: Only allow system to use NO_INPUT_CHANNEL. · 9661bf7a
      Robert Carr authored 
      NO_INPUT_CHANNEL is a hidden WM flag that allows creation of a window
without an input channel. Unfortunately in releases prior to Android R
this would allow creation of a Window which will not be known to the
InputDispatcher at all. This means that the logic generating
FLAG_OBSCURED will work and a window will be able to overlay another
window without the overlayed window being notified. In Android R and
later this isn't a problem as the InputDispatcher is informed of all
windows, input channel or not. For past Android releases, this patch
disables NO_INPUT_CHANNEL for use outside of the WM.

Bug: 152064592
Test: Existing tests pass
Change-Id: I7e1f45cba139eab92e7df88d1e052baba0ae2cc6
      9661bf7a
    • Robert Carr's avatar
      DO NOT MERGE: WM: Only allow system to use NO_INPUT_CHANNEL. · 0fed2d8e
      Robert Carr authored 
      NO_INPUT_CHANNEL is a hidden WM flag that allows creation of a window
without an input channel. Unfortunately in releases prior to Android R
this would allow creation of a Window which will not be known to the
InputDispatcher at all. This means that the logic generating
FLAG_OBSCURED will work and a window will be able to overlay another
window without the overlayed window being notified. In Android R and
later this isn't a problem as the InputDispatcher is informed of all
windows, input channel or not. For past Android releases, this patch
disables NO_INPUT_CHANNEL for use outside of the WM.

Bug: 152064592
Test: Existing tests pass
Change-Id: I7e1f45cba139eab92e7df88d1e052baba0ae2cc6
      0fed2d8e
    • Dmitry Dementyev's avatar
      Protect account chooser activities against overlay. · fedbadf5
      Dmitry Dementyev authored 
      Bug: 172841550
Test: manual
Merged-In: I1a16808426934f4a8d12410576d769443e4c2a04
Merged-In: I3cd5a94386f15cf60a7fe3095b00815e4a6485ae
Change-Id: I35dc86b5721a4531447a6d99d6c30f23543130cb
      fedbadf5
  19. Dec 08, 2020
  21. Dec 07, 2020
    • Eugene Susla's avatar
      RESTRICT AUTOMERGE · 6a5777dd
      Eugene Susla authored 
      Allow CDM to hide overlays

Since CDM has sensitive user consent UIs, it should be able to hide
non-system overlays

Test: use a 3p overlay app with a visible overlay to ensure overlay disappears when CDM is shown
Bug: 171221090
Change-Id: I3274cb7f03f63e1fa99a9ca06759972ce2a51309
      6a5777dd
    • Eugene Susla's avatar
      RESTRICT AUTOMERGE · 9cbc2c3d
      Eugene Susla authored 
      Prevent non-system overlays from showing over CDM UI

Since CDM grants privileges, it should have the same overlay
policy as permission UI

Test: use an app wit ha visible overlay to ensure
the overlay disappears when CDM is shown
Fixes: 171221090

Change-Id: I4daaee7d8b710a72f6166cbb2252ef8af84c2c60
      9cbc2c3d
    • Eugene Susla's avatar
      RESTRICT AUTOMERGE · 486773ff
      Eugene Susla authored 
      Allow CDM to hide overlays

Since CDM has sensitive user consent UIs, it should be able to hide
non-system overlays

Test: use a 3p overlay app with a visible overlay to ensure overlay disappears when CDM is shown
Bug: 171221090
Change-Id: I3274cb7f03f63e1fa99a9ca06759972ce2a51309
      486773ff
    • Eugene Susla's avatar
      RESTRICT AUTOMERGE · 068221bb
      Eugene Susla authored 
      Prevent non-system overlays from showing over CDM UI

Since CDM grants privileges, it should have the same overlay
policy as permission UI

Test: use an app wit ha visible overlay to ensure
the overlay disappears when CDM is shown
Fixes: 171221090

Change-Id: I4daaee7d8b710a72f6166cbb2252ef8af84c2c60
      068221bb
  23. Dec 03, 2020
  25. Dec 02, 2020
  27. Nov 23, 2020
    • Varun Shah's avatar
      RESTRICT AUTOMERGE · c99b04eb
      Varun Shah authored 
      Ensure caller identity is restored in CP quick-path.

Bug: 172935267
Test: PoC in bug
Change-Id: I469bde7d0a0f89c94f1234cf40983395048962e2
      c99b04eb
    • Varun Shah's avatar
      RESTRICT AUTOMERGE · 79062d79
      Varun Shah authored 
      Ensure caller identity is restored in CP quick-path.

Bug: 172935267
Test: PoC in bug
Change-Id: I469bde7d0a0f89c94f1234cf40983395048962e2
      79062d79
  29. Nov 11, 2020
  31. Nov 10, 2020