Skip to content
Snippets Groups Projects
  1. Jul 04, 2024
  2. Jun 13, 2024
  3. Jun 07, 2024
    • Iván Budnik's avatar
      Add support for showing Output Switcher from proxy routers · cf678431
      Iván Budnik authored
      Also, simplify logic for launching output switcher.
      
      Bug: 344843445
      Test: atest CtsMediaBetterTogetherTestCases
      Flag: EXEMPT Minimal logic addition with no usages.
      Change-Id: Ibd7d7ecbecb7356fb486f94c3a7a94d1a9946881
      cf678431
    • Michael Wright's avatar
      Remove execute bit from non-executable files. · 6a5fcafd
      Michael Wright authored
      This is almost certainly a mistake in all cases, and any files that are
      text-based have been spot checked to make sure they don't contain a
      shebang or have any other indications of intentionally being executable.
      
      Commands run:
          fdfind -t x -e java -x chmod -x
          fdfind -t x -e kt -x chmod -x
          fdfind -t x -e ogg -x chmod -x
          fdfind -t x -e xml -x chmod -x
          fdfind -t x -e aidl -x chmod -x
          fdfind -t x -e html -x chmod -x
          fdfind -t x -e png -x chmod -x
      
      Bug: 345485143
      Test: N/A
      Flag: Exempt, mechanical change
      Change-Id: I2902380611eb51d0c0e18f2f31e41f37163bd922
      6a5fcafd
  4. Jun 04, 2024
    • Jean-Michel Trivi's avatar
      RingtoneManager: allow video ringtone URI · 525db8ea
      Jean-Michel Trivi authored
      When checking the MIME type for the default ringtone, also
      allow it to refer to video content.
      
      Bug: 205837340
      Test: see POC + atest android.media.audio.cts.RingtoneManagerTest
      Change-Id: Id9b81e2db8314bc16df77d0a9221ce93143a8012
      525db8ea
  5. May 30, 2024
    • Vlad Popa's avatar
      AbsVol: send per device the abs volume state to APM · dc8653b2
      Vlad Popa authored
      Sending the normal computed index to the AudioPolicyManager together
      with the devices which are operating in absolute volume mode. The APM is
      responsible for avoiding the double attenuation based on this
      information.
      
      Flag: com.android.media.audio.abs_volume_index_fix
      Test: logs manual - DEBUG_VOL = true
      Bug: 340693050
      Change-Id: I9435723b0bc100f74553ff87c1407355117194b6
      dc8653b2
  6. May 29, 2024
  7. May 28, 2024
    • Santiago Seifert's avatar
      Add trendy team to mediaroutertest · df5683b2
      Santiago Seifert authored
      Bug: b/341345832
      Change-Id: I277df8f43d83a3c74b6709075abc9a03293f927d
      Flag: EXEMPT DOCS_ONLY
      Test: n/a
      df5683b2
    • dakinola's avatar
      Check for target activity with taskid and launch cookie · bd161c0d
      dakinola authored
      Found an issue with screen recording, where if you open an app to be recorded, but close the initial activity before recording starts, the recording fails because we expect to identify the task to the record by looking for an activity with matching launch cookie. As a backup, we also supply the task id (when possible) into the projection and try to find  the opened task that way.
      
      Fix: 333779790
      Flag: None
      Test: manual testing by attempting to screenrecord Google Photos while on the trash acvitity, then navigating back to the home activity before recording starts
      Test: atest FrameworksCoreTests:ContentRecordingSessionTest
      Test: atest FrameworksServicesTests:MediaProjectionManagerServiceTest
      Test: atest WmTests:WindowManagerServiceTests
      Test: atest RecordingServiceTest
      Change-Id: Ied4c8f117ce39288971d293dbcafa022711bf26a
      bd161c0d
  8. May 27, 2024
  9. May 25, 2024
    • Jean-Michel Trivi's avatar
      AudioVolumeGroup: implement hashCode method · 8d4310e0
      Jean-Michel Trivi authored
      Implement Object.hashCode() method.
      Allow AudioVolumeGroup.getAudioVolumeGroups() to be called
       by holders of MODIFY_AUDIO_SETTINGS_PRIVILEGED, like the
       other volume group APIs.
      
      Bug: 340879593
      Test: atest AudioManagerTest#testVolumeGroupHashCode
      Change-Id: Ie4898d013eef9352bb5b9fa7ce7e09fca095356e
      8d4310e0
  10. May 22, 2024
  11. May 21, 2024
  12. May 20, 2024
    • Santiago Seifert's avatar
      Simplify requestCreateSessionWithRouter2 · 783789a3
      Santiago Seifert authored
      Removes some unnecessary code and also fixes what seems to be buggy
      behavior. For example, we are overwriting the initiator package name
      if the user handle is not provided.
      
      Bug: b/279555229
      Flag: EXEMPT refactor
      Test: presubmit
      Change-Id: Ib8eb09d5c22ea251a3a3e043eec889df33f2f789
      783789a3
    • Iván Budnik's avatar
      Fix nullability in onAudioInfoChanged · 8ae5f905
      Iván Budnik authored
      The callback has always returned a @NonNull value, but was never marked
      as such. This change also makes nullability of the MediaController's
      PlaybackInfo consistent with ag/27085155.
      
      Also, simplify downstream nullability for implementers of
      onAudioInfoChanged.
      
      Flag: EXEMPT non-functional refactor
      Test: Presubmit.
      Bug: 333564788
      Change-Id: I9d4799d77158742c13f04de1cec9a3d4dd997fcf
      8ae5f905
    • Santiago Seifert's avatar
      Add human readable dump of volume handling to routing session · 64fef059
      Santiago Seifert authored
      This CL reuses code in MR2Info to provide a human readable string for
      volume adjustment in MR2 info, and in the toString implementations of
      both MR2Info and RoutingSessionInfo.
      
      Test: mp core services && adb shell dumpsys media_router
      Bug: 205124386
      Flag: NONE Minor changes in debug-related logging.
      Change-Id: Id3194d3c7f6eded5c37e2d64b43989de80ed1765
      64fef059
    • Vania Desmonda's avatar
      Use `mContext.getMainLooper()` as the parameter for creating a new · 33941d8d
      Vania Desmonda authored
      Handler if it's null in `registerCallback()`
      
      Test: refactoring CL only, all tests should pass
      Bug: 293436997
      Change-Id: I2a0d4735c3324a7c2e8ae9ef432350613562148f
      33941d8d
  13. May 14, 2024
  14. May 09, 2024
    • Santiago Seifert's avatar
      Fix output switcher initiator data · 122c718f
      Santiago Seifert authored
      Also remove redundant transfer method that takes initiation data as
      parameters. The initiator should always be the target package of the
      router.
      
      Bug: b/319645714
      Flag: com.android.media.flags.enable_built_in_speaker_route_suitability_statuses
      Test: Using the media routing sample app.
      Test: atest SystemMediaRouter2Test
      
      Change-Id: I8ce16d8380b5e6ee04cbcbc6cf57a418595f2cc1
      122c718f
  15. May 07, 2024
    • Santiago Seifert's avatar
      Remove duplicate check before transfer · 310ba607
      Santiago Seifert authored
      Before this check, the transfer is checking for the existence of the
      target route in the list of selected routes twice. This change is
      preliminary work for allowing the selection of the selected system route
      for populating the transfer reason.
      
      Test: Non-functional refactor.
      Flag: EXEMPT refactor
      Bug: b/319645714
      Change-Id: I36a87790df3ffc2be2ab0f1eafee6b3096e7d4a0
      310ba607
  16. May 03, 2024
    • Oriol Prieto Gasco's avatar
      RESTRICT AUTOMERGE · 7b816129
      Oriol Prieto Gasco authored
      Set the container field of aconfig flags
      
      Test: printflags --format='{package}:{container}:' | grep "::"
      Bug: 312769710
      Flag: NONE
      Change-Id: I84fda0d5e9813940609436d825738ff786908ff0
      7b816129
  17. May 02, 2024
  18. May 01, 2024
  19. Apr 30, 2024
  20. Apr 29, 2024
    • Ted Bauer's avatar
      Add deps for new aconfig flagging storage · e7b0c754
      Ted Bauer authored
      Aconfig flagging storage is migrating to a new underlying storage, which
      has new dependencies. Add the dependencies as a defaults.
      
      Bug: 328444881
      Test: m
      Change-Id: Ie59f5cba1ace7bbee179f9c6dbee03e085c7d878
      e7b0c754
  21. Apr 26, 2024
  22. Apr 25, 2024
  23. Apr 24, 2024
    • Iván Budnik's avatar
      Fix nullability in MediaController#getPlaybackInfo() · 5a3013b4
      Iván Budnik authored
      The playback info field is NonNull, so getPlaybackInfo() is artificially
      returning a null value if the Binder transaction to system_server fails.
      As per go/android-api-guidelines#framework-rethrow-remoteexception we should always be rethrowing
      RemoteExceptions to provide a strong signal that the operation failed.
      
      In practice, the returned value is never null, unless system_server has
      died. Several CTS tests already assume this NonNull-ness.
      
      Test: atest CtsMediaBetterTogetherTestCases
      Bug: 333564788
      Change-Id: Id18cce692d8d0b25486da427ef9860eb2f176aef
      5a3013b4
Loading