Commits · 1532447a7b186fc31026231996ade3befe8e9ffa · Farzin Kazemzadeh / platform_frameworks_base-old

Aug 06, 2018

Add @UnsupportedAppUsage annotations · 1532447a

Mathew Inwood authored 6 years ago

For packages:
  android.renderscript

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Change-Id: I016f6e720e79c48afe44f4690b5dd99fc81ae780
Merged-In: I1aa8ebca448547031b426a7b305c5c3d6fcf2652

1532447a

Jun 13, 2017

Do not CloseGuard KernelID or FieldID · 3a84a23f

Yang Ni authored 7 years ago

Bug: 28053584

Stop CloseGuarding for two reasons:

1) KernelID and FieldID objects are constructed in auto-generated
(RenderScript reflected) Java code. It would be impossible for a user to
explicitly call destroy() on them. Guarding them would leave a lot of
noisy warnings in logcat.

2) These KernelID and FieldID objects are not big compared to other
RenderScript objects, e.g. Allocations. They occupy almost no native
resources except for a native pointer. Leaving their destruction to Java
GC would be completely acceptable, since any delay in reclaiming them is
unlikely to cause memory pressure.

Test: CTS on x86_64 emulator
Change-Id: I587b5561a0b2bdbf0b2e95bf2995c20d5f5faf9d

3a84a23f

May 05, 2017

Destroy Allocation right away on exception · 867ac4d5

Yang Ni authored 7 years ago

Bug: 28053584

To avoid holding the resource (surface) for too long.

Test: CTS on x86_64 emulator
Change-Id: I2fdec107c2a16b7dadbf78a9aee79c33423a3676
(cherry picked from commit c48a09cc)

867ac4d5

Destroy Allocation with ScriptIntrinsicLut · 23ce6fa2

Yang Ni authored 7 years ago

Bug: 28053584

On destroying the intrinsic, destroy its contained Allocation right away.

Test: CTS on x86_64 emulator
Change-Id: I5ca0da33b620c3291b7cafda31a6cc83eb7461a0
(cherry picked from commit 8b8f75a7)

23ce6fa2

Destroy Allocation right away on exception · c48a09cc

Yang Ni authored 7 years ago

Bug: 28053584

To avoid holding the resource (surface) for too long.

Test: CTS on x86_64 emulator
Change-Id: I2fdec107c2a16b7dadbf78a9aee79c33423a3676

c48a09cc

May 04, 2017

Destroy Allocation with ScriptIntrinsicLut · 8b8f75a7

Yang Ni authored 7 years ago

Bug: 28053584

On destroying the intrinsic, destroy its contained Allocation right away.

Test: CTS on x86_64 emulator
Change-Id: I5ca0da33b620c3291b7cafda31a6cc83eb7461a0

8b8f75a7

Apr 20, 2017

Validates Intrinsic Blur only takes 2D Allocations · 67c59949

Yang Ni authored 7 years ago

Bug: 24555166

Test: RSTest on x86_64 emulator
Change-Id: I0c8c970ce85989c3213fb4986e517ac0be5beb26
(cherry picked from commit bb671376)

67c59949

Apr 18, 2017

Validates Intrinsic Blur only takes 2D Allocations · bb671376

Yang Ni authored 7 years ago

Bug: 24555166

Test: RSTest on x86_64 emulator
Change-Id: I0c8c970ce85989c3213fb4986e517ac0be5beb26

bb671376

Mar 03, 2017

Removed close guards for Element and Type objects · 45438c94

Yang Ni authored 8 years ago

Bug: 28053769

These objects are tiny and unlikely to cause memory issues.

In addition, llvm-rs-cc auto-generated code contains such objects, which are
not visibible to developers and impossible to manually destroy, leaving
distracting warnings in Strict Mode.

Test: RsTest with StrictMode on and CTS tests

Change-Id: Iec68cca4f1259124b9f503a230c1a28b97ede1f3

45438c94

Jan 26, 2017
- Fix @links in reference docs. · 54de7747
  Elliot Waite authored 8 years ago
  
  Change-Id: I40cea46efd80c448640ff69753698fe8404da40b
  54de7747
Jun 14, 2016

Delete simple reduction implementation. · 11ec9097

David Gross authored 8 years ago

Bug: 27298560
Change-Id: I8a89c9df753d12ee8af06008d424e77bb916cd8f
(cherry picked from commit 4a457853)

11ec9097

Jun 02, 2016
- Delete simple reduction implementation. · 4a457853
  David Gross authored 8 years ago
  
  Bug: 27298560 Change-Id: I8a89c9df753d12ee8af06008d424e77bb916cd8f
  4a457853
May 25, 2016

[RenderScript] Fix ScriptIntrinsicBlur documentation. · 6aaede8c

Miao Wang authored 8 years ago

Bug: 28177406
Change-Id: Icccf35857cf29f827a78704e7751c8791cda0d7b
(cherry picked from commit c242fa6b)

6aaede8c

Update documentation about copyTo and copyFrom. · 1641dc9e

Miao Wang authored 8 years ago

Bug: 23159764
Bug: 26862970

  - Add detailed description of AutoPadding
  - Add comments to all the copy related APIs.
  - Fix typos in the comments.

Change-Id: I2d045e0d90efd94f1407f88d3e35bcd42ea93fb9
(cherry picked from commit 3231e8e0)

1641dc9e

May 18, 2016

[RenderScript] Fix ScriptIntrinsicBlur documentation. · c242fa6b
Miao Wang authored 8 years ago
```
Bug: 28177406
Change-Id: Icccf35857cf29f827a78704e7751c8791cda0d7b
```
c242fa6b

Update documentation about copyTo and copyFrom. · 3231e8e0

Miao Wang authored 8 years ago

Bug: 23159764
Bug: 26862970

  - Add detailed description of AutoPadding
  - Add comments to all the copy related APIs.
  - Fix typos in the comments.

Change-Id: I2d045e0d90efd94f1407f88d3e35bcd42ea93fb9

3231e8e0

May 10, 2016

[RenderScript] Interrupt mMessageThread when tearing down context. · 4a574806

Miao Wang authored 8 years ago

  - Interrupt mMessageThread, so it gets to see immediately
    that mRun is false and exit rightaway.

Change-Id: Ic586ef225a5c6f3a77f89de00b7fb3f3547c9838

4a574806

Apr 22, 2016

Fixed BaseObj finalizer and destroy() · 1b4df169

Yang Ni authored 8 years ago

Bug: 28242626
Bug: 27972184
Bug: 27973681

This is resolving issues in ScriptGroup (V1) again.
In ScriptGroup.destroy(), we also need to consider the old API where
mClosures is not initialized.

Also cleaned up the finalizer for ScriptGroup and Allocation:
Since BaseObj.finalize() calls BaseObj.helpDestroy(), instead of
BaseObj.destroy(), there is no possibility that the finalizers of
child objects may race their parents finalizers. Note that
helpDestroy() does not try to recurse on child objects.

Change-Id: I9dbb2b60f8478f656f8a418c2b5fc8d6848aeef0

1b4df169

Apr 20, 2016

Made Element accessors thread-safe · 6bdfe0fc

Yang Ni authored 8 years ago

Bug: 28177082
Change-Id: I8f3f2d8ce559e93cba29f8eedd5b95d1389deb23
(cherry picked from commit 33703f0c)

6bdfe0fc

Apr 19, 2016

Fixed ScriptGroup finalizer for old API · e04e5d7c

Yang Ni authored 8 years ago

Bug: 28242626

ScriptGroup finalizer clears out the list of closures, which is
uninitialized for the old API.

Need to check null first, before accessing the list.

Change-Id: Ibf914e17a0878c8c561f823c5f6f6f6619594de1
(cherry picked from commit 07837d6d)

e04e5d7c

Made Element accessors thread-safe · 33703f0c
Yang Ni authored 8 years ago
```
Bug: 28177082
Change-Id: I8f3f2d8ce559e93cba29f8eedd5b95d1389deb23
```
33703f0c

Apr 18, 2016

Fixed ScriptGroup finalizer for old API · 07837d6d

Yang Ni authored 8 years ago

Bug: 28242626

ScriptGroup finalizer clears out the list of closures, which is
uninitialized for the old API.

Need to check null first, before accessing the list.

Change-Id: Ibf914e17a0878c8c561f823c5f6f6f6619594de1

07837d6d

Apr 12, 2016

Destroy Type created by Allocation.createSized() · e1798e42

Yang Ni authored 8 years ago

Bug: 27972184
Change-Id: I4f80c74079087eab20b75a701c56cde141322462
(cherry picked from commit 3444dbe0)

e1798e42

Destroy Closures in ScriptGroup · 44d1b3bf

Yang Ni authored 8 years ago

Bug: 27973681

Implemented correct destruction in ScriptGroup.destroy() and
Clsoure.destroy(), which properly destroys child BaseObj's.

Change-Id: I946f62c2979d6a338b8883514cacad472a213c5c
(cherry picked from commit 44e2f45f)

44d1b3bf

Destroy Type created by Allocation.createSized() · 3444dbe0
Yang Ni authored 8 years ago
```
Bug: 27972184
Change-Id: I4f80c74079087eab20b75a701c56cde141322462
```
3444dbe0

Apr 11, 2016

Fix typos for the word "Unsupported". · ad57e330

Stephen Hines authored 8 years ago

Bug: https://code.google.com/p/android/issues/detail?id=206490
Change-Id: Ie1b2c2b0960d8dd8c12ed06d84a16913cd057221

ad57e330

Apr 07, 2016

Destroy Closures in ScriptGroup · 44e2f45f

Yang Ni authored 8 years ago

Bug: 27973681

Implemented correct destruction in ScriptGroup.destroy() and
Clsoure.destroy(), which properly destroys child BaseObj's.

Change-Id: I946f62c2979d6a338b8883514cacad472a213c5c

44e2f45f

Apr 05, 2016

Avoid destroying Device separately · cb939dc4

Yang Ni authored 8 years ago

Bug: 27983025

Device should be destroyed inside the destructor of the associated
Context.

Change-Id: I921a89974e1174f837349a89aef9b03efa4882f5
(cherry picked from commit 4a70df58)

cb939dc4

Apr 04, 2016

Avoid destroying Device separately · 4a70df58

Yang Ni authored 8 years ago

Bug: 27983025

Device should be destroyed inside the destructor of the associated
Context.

Change-Id: I921a89974e1174f837349a89aef9b03efa4882f5

4a70df58

Mar 31, 2016

Added CloseGuard for BaseObj · 6484b6be

Yang Ni authored 9 years ago

Bug: 27719830

To turn on warnings, apps have to add to their Activity.onCreate() method
the following code.

        StrictMode.setVmPolicy(new StrictMode.VmPolicy.Builder()
                               .detectLeakedClosableObjects()
                               .penaltyLog()
                               .build());

For Slang generated ScriptC derived classes, we assume their
constructors won't throw exceptions after calling the ScriptC
constructor. In addition, ScriptIntrinsic derived classes do not seem
to throw exceptions in their constructors either. Therefore, we can
leave the guard.open() call in the Script constructor. This may be
only an approximation, but allows us to add CloseGuard for script
objects without making changes to slang.

Change-Id: I77ed45239a60b85af5c811dee6c124fb53da9060
(cherry picked from commit eb4dd08e)

6484b6be

Added CloseGuard for BaseObj · eb4dd08e

Yang Ni authored 9 years ago

Bug: 27719830

To turn on warnings, apps have to add to their Activity.onCreate() method
the following code.

        StrictMode.setVmPolicy(new StrictMode.VmPolicy.Builder()
                               .detectLeakedClosableObjects()
                               .penaltyLog()
                               .build());

For Slang generated ScriptC derived classes, we assume their
constructors won't throw exceptions after calling the ScriptC
constructor. In addition, ScriptIntrinsic derived classes do not seem
to throw exceptions in their constructors either. Therefore, we can
leave the guard.open() call in the Script constructor. This may be
only an approximation, but allows us to add CloseGuard for script
objects without making changes to slang.

Change-Id: I77ed45239a60b85af5c811dee6c124fb53da9060

eb4dd08e

Mar 30, 2016

[RenderScript] Update documentation for Allocation.setAutoPadding(). · ebfcdb93
Miao Wang authored 8 years ago
```
Bug: 26862970
Change-Id: Iaa88ac0266e5d2cac2837f1d13353aacc6177274
(cherry picked from commit 9ee76076)
```
ebfcdb93

[RenderScript] Fix IntrinsicConvolve documentation. · e58ed9b1

Miao Wang authored 8 years ago

Bug: 25117120

  - Better format.
  - Typo fixes.

Change-Id: Ic6f8d1dacecdaf9993dd8298de7a801f5fd2a937
(cherry picked from commit 3d23dce4)

e58ed9b1

[RenderScript] Update the documentation of Script.LaunchOptions · c7c6364f

Miao Wang authored 8 years ago

Bug: 26916665

  - Add description of the endArg.
  - Update the example.
  - Update the incorrect description.

Change-Id: Idd07db5d790e2d6462fff9cb580115ec45cfd4f0
(cherry picked from commit 53fdcfbe)

c7c6364f

[RenderScript] Update documentation for Allocation.setAutoPadding(). · 9ee76076
Miao Wang authored 8 years ago
```
Bug: 26862970
Change-Id: Iaa88ac0266e5d2cac2837f1d13353aacc6177274
```
9ee76076

Mar 29, 2016

[RenderScript] Fix IntrinsicConvolve documentation. · 3d23dce4

Miao Wang authored 8 years ago

Bug: 25117120

  - Better format.
  - Typo fixes.

Change-Id: Ic6f8d1dacecdaf9993dd8298de7a801f5fd2a937

3d23dce4

[RenderScript] Update the documentation of Script.LaunchOptions · 53fdcfbe

Miao Wang authored 8 years ago

Bug: 26916665

  - Add description of the endArg.
  - Update the example.
  - Update the incorrect description.

Change-Id: Idd07db5d790e2d6462fff9cb580115ec45cfd4f0

53fdcfbe

Mar 28, 2016

[RenderScript] Fail with Exception from validateObjectIsPrimitiveArray · 598d37f6

Pirama Arumuga Nainar authored 8 years ago

Bug: http://b/25982676

Instead of returning null from validateObjectIsPrimitiveArray, fail with
an exception.  The callers of this function do not check for null.

Change-Id: Idd2b50a7b137e8d2db7a334bb9a48c1b19ee2403

598d37f6

[RenderScript] Fail with Exception from validateObjectIsPrimitiveArray · 3934dadd

Pirama Arumuga Nainar authored 8 years ago

Bug: http://b/25982676

Instead of returning null from validateObjectIsPrimitiveArray, fail with
an exception.  The callers of this function do not check for null.

Change-Id: Idd2b50a7b137e8d2db7a334bb9a48c1b19ee2403

3934dadd

Mar 21, 2016

Correctly init code cache path for RS · 15fcf61d

Yang Ni authored 9 years ago

Bug: 27439261

Script Group needs to know the code cache path before it can call bcc to
merge kernels. However, before this change, the code cache path has been
initialized by the ScriptC class.

In the case where a script group (or even the entire app) does not contain any
regular script but only intrinsics, the code cache would remain uninitialized.

Fixed this by initializing the code cache path in the RenderScript class
the first time when the accessor method is called.

Change-Id: I87f9e62e0f3b479f94e43daa3e9695a5b38710db
(cherry picked from commit 689f6377)

15fcf61d