- Oct 26, 2017
-
-
Yohei Yukawa authored
This is a follow up CL to my refactoring CL [1], which unintentionally changed the condition to reset default enabled IMEs when the device boots up. Previously, InputMethodManagerService (IMMS) resets default enabled IMEs upon device boot only for the first boot scenario, by checking whether Settings.Secure.DEFAULT_INPUT_METHOD is already set or not. My refactoring CL accidentally replaced that check with unconditional "true", which means now IMMS always resets default enabled IMEs every time the device boots up. This behavior change is of course unintentional but has no effect after the user unlocks the device because IMMS also discard all the settings change made while UserManager.isUserUnlocked() returns false [2]. Hence the above behavior change is completely hidden on direct-boot disabled devices, where the system behaves as if the user unlocked the device immediately after the boot is completed. The behavior change is observable only on direct-boot devices. Anyway, IMMS should try to do its best to keep the last used IME and user selected IMEs even in user locked state as long as those IMEs are compatible with direct-boot. This CL revives the previous behavior by adding the same condition check again. [1]: I5b37c450db4b25b3e635b6d634293a34eec8b9d4 7924782c [2]: Ifa2225070bf8223f8964cf063c86889e312c5e9a ed4952ad Fixes: 67093433 Fixes: 67491290 Test: Manually verified as follows 1. Check out AOSP master 2. Build an OS image for a direct-boot aware device then flash it. 3. Open development/samples/SoftKeyboard/AndroidManifest.xml then add android:directBootAware="true" to the IME service. 4. Open development/samples/SoftKeyboard/res/xml/method.xml then add android:isAsciiCapable="true" to "en_US" IME subtype. 5. tapas SoftKeyboard 6. make -j 7. adb install -r $OUT/system/app/SoftKeyboard/SoftKeyboard.apk 8. Open system settings: System -> Languages & input -> Virtual keyboard -> Manage keyboards 9. Enable Sample Soft keyboard 10. Disable Android Keyboard (AOSP) 11. Open system settings: Security -> Screen lock -> Password then set up a device password "aaaa". 12. Reboot the device. 13. Make sure that * Sample Soft keyboard is shown in the unlock screen. * AOSP Keyboard is not enabled in the unlock screen. Change-Id: Id624d577d941245cca944498dc6935eb364865cf
-
Hugo Benichi authored
* changes: Remove Parcelable interface from DefaultNetworkEvent Extract logging of default network events
-
Treehugger Robot authored
-
Colin Cross authored
-
Hans Boehm authored
-
- Oct 25, 2017
-
-
Treehugger Robot authored
-
Andreas Gampe authored
Used ScopedUtfChars to handle lifetime, and correctly throw NPE. It is illegal to call JNI String functions with a null argument. Output the service name when starting a thread pool to aid debugging. Bug: 68217725 Test: m Test: Device boots Change-Id: Ie40d3e77a63918330ef1a8a9e0c294f2c451a52a
-
Dianne Hackborn authored
Also add appropriate @NonNull and @Nullable annotations. Test: built Change-Id: I22de48105ef685baf594cfc004dd3e27e2ba09e9 Merged-In: I22de48105ef685baf594cfc004dd3e27e2ba09e9 (cherry picked from commit 4cd650c0)
-
Brad Ebinger authored
-
Yifan Hong authored
Test: pass Change-Id: I54c384abaad7c7aafab31836f34edee5c7c75aac
-
Jordan Liu authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Steven Moreland authored
-
Steven Moreland authored
Appears to be causing problems on 2017 devices. This reverts commit c1f00f8c. Change-Id: I6c1717a612bfa3fe63f08160a1db652c284f6ba4
-
Colin Cross authored
* changes: Convert lockregioncodeinjection to Android.bp Export AIDL for keystore Android.bp.
-
Hugo Benichi authored
This patch takes advantage of the direct DefaultNetworkMetrics interface between ConnectivityService and IpConnectivityMetrics and removes the Parcelable interface from DefaultNetworkEvent. IpConnectivityMetrics, IpConnectivityEventBuilder and associated tests are updated as necessary. Bug: 34901696 Test: runtest frameworks-net Change-Id: I59b6e04fc126051320d08a422cfbd4d27042123e
-
Hugo Benichi authored
This patch extracts the logging of DefaultNetworkEvent from inside ConnectivityService and move it to a new DefaultNetworkMetrics class. The DefaultNetworkMetrics is a singleton owned by the IpConnectivityMetrics singleton implementing the metrics service for core networking. ConnectivityService has access to this singleton via LocalServices. This class layout will allow to remove the Parcelable interface of DefaultNetworkEvent and will instead let the IpConnectivityMetrics service grab metrics from the DefaultNetworkMetrics directly. Bug: 34901696 Test: runtest frameworks-net Change-Id: I55694d89124272732aba114198776462372de18b
-
Jeff Sharkey authored
Add IntDef for constants, and rely on new auto-documentation feature to expand all of them at usage sites. Test: docs-only change Bug: 64133169 Change-Id: I8a6b5f54c8eb9d4fc7ae3d0d3fb673d52320664b
-
Treehugger Robot authored
* changes: Binder: Update to new ScopedLocalRef Binder: Clean up JNI code Binder: Change reaction to Error
-
Treehugger Robot authored
-
Colin Cross authored
See build/soong/README.md for more information. Test: m checkbuild Change-Id: Id7992ff0cc5d631b64c1fa8e82e8a130ea508236
-
Andreas Gampe authored
Follow-up to commit 625e0007 and commit fac8cb2405999d18aefd75387a5bbdb0c6160e7f. (cherry picked from commit 8571ec37) Bug: 64689630 Test: m Merged-In: I119cf83a5a54c15973ed3701ee448a9590bb404d Change-Id: I119cf83a5a54c15973ed3701ee448a9590bb404d
-
Andreas Gampe authored
Factor out Error handling code and clean up. Use ScopedLocalRef, fix minor logic issues. (cherry picked from commit 625e0007) Bug: 64689630 Test: m Test: manual test Merged-In: Icc5a1e38fa66aa79d87d0abb81acef6918ca78f5 Change-Id: Icc5a1e38fa66aa79d87d0abb81acef6918ca78f5
-
Andreas Gampe authored
Instead of aborting immediately with a native error, try to call Thread.dispatchUncaughtException to trigger a Java-side abort. Only fall back to the old strategy if this fails. (cherry picked from commit 1cd76f5c) Bug: 64689630 Test: m Test: manual test Merged-In: If07a04d3769f3b9181c4736220333df9a2871a16 Change-Id: If07a04d3769f3b9181c4736220333df9a2871a16
-
- Oct 24, 2017
-
-
Colin Cross authored
See build/soong/README.md for more information Test: m checkbuild Change-Id: I78e91a70e786df8e6722c6ec3fe762371e8f475a
-
Jeff Sharkey authored
Test: builds, boots Bug: 67041047 Change-Id: Iaff1de1f9c015a824ffc1f4946ced4a13d9bd7c1 Merged-In: Iaff1de1f9c015a824ffc1f4946ced4a13d9bd7c1 (cherry picked from commit 0c686e78)
-
Kazuya Ohshiro authored
Added a new array config that indicating list of FAC (feature access codes) to dial as a normal call. Test: manual - Checked that special codes which configured in CarrierConfig are dialed as a normal call. Bug: 67664279 Change-Id: I1c4b60ae4f28c25e55b38563fe445f831793d466
-
Treehugger Robot authored
-
Malcolm Chen authored
Platform packages other than Settings may also use this layout to be consistent with Settings. Test: manual bug: 62200881 Change-Id: I9e45772abac5aacfabbbafb38e287d0b523ef694 Merged-In: I9e45772abac5aacfabbbafb38e287d0b523ef694
-
Benedict Wong authored
am: 9305fb7e Change-Id: I51705d5db6af560f2423ef7861bfde6734632ec9
-
Benedict Wong authored
-
Benoit Lamarche authored
am: 5aa4dafa Change-Id: Ic8f892399cdfa746a2fab4a841469f41f0fe98f5
-
Benoit Lamarche authored
-
Paul Duffin authored
am: 596bb647 Change-Id: I95c1cd65ded3b3d14b7f916c8a10825399e7b8ec
-
Paul Duffin authored
-
Pulkit Bhuwalka authored
am: 35dc0200 Change-Id: Iec67ef3cc9c990b4d5285b23b51972915cbbd335
-
Treehugger Robot authored
* changes: Add missing intents to protected broadcasts Get Bluetooth Class of Device
-
Pulkit Bhuwalka authored
am: ba45409c Change-Id: I4d28d0b1b52e587285d3b92b66fdc4b6c1b38720
-
Pulkit Bhuwalka authored
Intents broadcasted by the Bluetooth stack need to be added to protected broadcasts else they complain with errors in the log since Bluetooth is considered a system process. A few of these intents, especially AVRCP intents were missing in the list. Bug: None Test: Verified errors don't show up after introducing the intents while playing on a sink device. Change-Id: Ie283c50243d9a1bac3fd937f58bc1ddc20867d2f
-