Skip to content
Snippets Groups Projects
Select Git revision
  • test
  • fifteen-qpr0-new
  • fifteen default
3 results
Search by author
  • Any Author
  • Farzin Kazemzadeh Farzin Kazemzadeh itisFarzin
1 author
  1. Oct 13, 2023
    • Anton Hansson's avatar
      Fix broken framework documentation · 2ccbeb75
      Anton Hansson authored 
      Various issues here, but the most recurring one is referencing SystemApi
from public javadoc. Remove or rewrite such references.

Also common is trying to @link IntDefs. Usually this is not necessary,
as the presence of IntDef in the @param/@return auto-generates relevant
documentation.

Bug: 303184203
Test: m docs
Change-Id: Ie59e61881c45c73fbbe08250493bd35eca268ef6
      2ccbeb75
  3. Sep 29, 2023
  5. Sep 05, 2023
  7. Aug 30, 2023
  9. Aug 29, 2023
  11. Aug 23, 2023
  13. Aug 22, 2023
  15. Aug 10, 2023
  17. Aug 07, 2023
    • Sam Dubey's avatar
      Exclude ScanningSettingsTest tests · 7abb5482
      Sam Dubey authored 
      While we mitigated the system wide presubmit blockage due to failing
test, it's been brought to attention that the test has been flaky for
sometime. And still uses junit3, which means it hasn't been maintained
for sometime.

Bug: 293934372
Test: N/A
Change-Id: Iea48daf39e8d40667f635e68b4c8e341abf4341a
      7abb5482
  19. Aug 03, 2023
  21. Jun 13, 2023
  23. Apr 01, 2023
  25. Mar 29, 2023
    • Yu-Han Yang's avatar
      Correct getExtras("satellites") · 5b7e2b63
      Yu-Han Yang authored 
      To return the number of satellites instead of signals

Bug: 275611082
Test: manual
Change-Id: I766159baf6cb16f902cb1395f9d12f8bbda9e8f0
      5b7e2b63
  27. Mar 20, 2023
    • mattgilbride's avatar
      @EnforcePermission migrations · c4a45bd7
      mattgilbride authored 
      Migrates call sites to use the @EnforcePermission annotation
instead of manually checking permissions.

These are fully behavior-preserving changes that can be identified by
Android Lint (see SimpleManualPermissionEnforcementDetector)

Bug: 232058525
Test: TH

Change-Id: Ic654ed1de23462b982ec2ea9853f9a22e3c03dd7
      c4a45bd7
  29. Mar 09, 2023
  31. Mar 08, 2023
    • Zhanghao Wen's avatar
      Update the Javadoc of getReceivedSvTimeNanos() · 9a28d068
      Zhanghao Wen authored 
      Added GPS L1C(P), BDS B1C(P) with value: CODE_LOCK(10 ms), STATE_2ND_CODE_LOCK(18000 ms), TOW_KNOWN(1 week).
Added BDS B2AQ: Same as E5AQ
Added IRNSS: Same as GPS L1 C/A

Bug: 264588057
Test: Javadoc only
Change-Id: I187ecd0452efa97700a141a1837801b45f82da2d
      9a28d068
  33. Mar 07, 2023
    • Zhanghao Wen's avatar
      Update the Javadoc of getReceivedSvTimeNanos() · 5f5c8188
      Zhanghao Wen authored 
      Added GPS L1C(P), BDS B1C(P) with value: CODE_LOCK(10 ms), STATE_2ND_CODE_LOCK(18000 ms), TOW_KNOWN(1 week).
Added BDS B2AQ: Same as E5AQ
Added IRNSS: Same as GPS L1 C/A

Bug: 264588057
Test: Javadoc only
Change-Id: I187ecd0452efa97700a141a1837801b45f82da2d
      5f5c8188
  35. Mar 03, 2023
  37. Mar 02, 2023
  39. Feb 07, 2023
  41. Jan 27, 2023
  43. Jan 25, 2023
    • Andrew Solovay's avatar
      docs: Fixing typo (i.e without closing period) · 062f767d
      Andrew Solovay authored 
      The CommonTypos linter complained about "i.e" without a closing period.
Since our tech writing style guide says to avoid "i.e." in general, I
rephrased as "that is".

Per go/fix-refdocs, tm-qpr-dev is now the preferred branch for doc fixes
until the U dev branch is open. Since this CL hasn't been reviewed yet,
I'm CPing it over here and abandoning the original CL.

Docs-only change, no change to code.

Change-Id: Id8de0d371e1290a7e8ed1831f2fbca063f9ff835
Test: [go/abtd docs build]
Bug: 263824202
      062f767d
  45. Jan 19, 2023
    • Neil Fuller's avatar
      Refactoring: Support alt. network time source · 8ad07e27
      Neil Fuller authored 
      Refactoring to support an alternative source of network time for passing
to the GNSS component. The new implementation will be submitted in a
follow-up.

NtpTimeHelper has been replaced by NetworkTimeHelper in
GnssLocationProvider. NetworkTimeHelper provides the stable interface
between GnssLocationProvider and the original / alternative impl for
what was NtpTimeHelper.

NtpTimeHelper has been renamed NtpNetworkTimeHelper.

These changes are not intended to change any behavior. There are some
minor changes between the interaction between GnssLocationProvider and
the NetworkTimeHelper class, but these are not expected to alter the
runtime behavior.

The NetworkTimeHelper.setPeriodicTimeInjectionMode() method touches
a pre-existing bug: The method name reflected the effect of the method,
which is the near-opposite of what the capability name would suggest.
This appears to be due to an accidental logic inversion, not by intent.
As can be seen in the changes for GnssLocationProvider: the
enablePeriodicTimeInjection() method was called when
mGnssNative.getCapabilities().hasOnDemandTime() was true. The existence
of bug 73893222 supports the fact that there is a long-standing bug
here. The intent with this commit is not to fix it or alter behavior,
just to make it more obvious, as it is unclear if the current behavior
is relied upon somewhere. Comments and field names have been improved to
try to clarify the actual behavior.

Bug: 73893222
Bug: 222295093
Test: atest services/robotests/src/com/android/server/location/gnss/NtpNetworkTimeHelperTest.java
Change-Id: I0b1ba43a55ff531df343c022650e3f5721dda7f1
      8ad07e27
  47. Jan 18, 2023
  49. Dec 22, 2022
  51. Dec 19, 2022
  53. Dec 14, 2022
  55. Dec 07, 2022
  57. Dec 06, 2022
  59. Dec 02, 2022
  61. Dec 01, 2022
    • Nagendra Prasad Nagarle Basavaraju's avatar
      API Enhancement CountryDetector · 576862f5
      Nagendra Prasad Nagarle Basavaraju authored 
      -Replace CountryListener with a Consumer<Country>
-Add registerCountryDetectorCallback to take an Executor Vs addCountryListener taking Looper
-Add unregisterCountryDetectorCallback to remove Consumer<Country> callback interface
-Adding getSource to return an IntDef
-Expose Country constructor
-Adding alternative API with new naming for getCountryIso
-Refactoring addCountryListener() & removeCountryListener API's

Bug: 252989268, 258197470
CTS-Coverage-Bug: 255511190
Test: manual test && make update-api
Change-Id: I5a2f253a87d1037837bc161a80cb873a6471c229
      576862f5
  63. Nov 30, 2022
  65. Nov 22, 2022
    • Yu-Han Yang's avatar
      Clarify javadoc of Full Tracking · 6c109ef8
      Yu-Han Yang authored 
      Bug: 257549183
Test: doc update only
Change-Id: Ia66235c20a527c4355b1ce9fae7c157dd90d2c84
      6c109ef8
    • Nagendra Prasad Nagarle Basavaraju's avatar
      Revert CountryDetector changes · e655f11c
      Nagendra Prasad Nagarle Basavaraju authored 
      -Revert detectCountry() to UnsupportedAppUsage
-Revert addCountryListener & removeCountryListener to UnsupportedAppUsage
-Revert countryListener to UnsupportedAppUsage
-Revert getCountryIso() to UnsupportedAppUsage to support api with new naming convention

Bug: 252989268
Test: manual test && make update-api
Change-Id: I5c5978f4460eb6bce8d3ed97458b5cc6ac6d788d
      e655f11c
  67. Nov 15, 2022