Skip to content
Snippets Groups Projects
  1. Jan 07, 2021
    • Ryan Mitchell's avatar
      Accept --overlay-name flag in idmap2 · 30dc2e01
      Ryan Mitchell authored
      To support allowing for multiple <overlay> tags in one package, idmap2
      must be able to generate an idmap for an individual <overlay> tag.
      
      `idmap2 create` now accepts a --overlay-name flag that specifies which
      tag to use to generate the idmap. The value of --overlay-name should be
      set to the value of the android:name attribute on the <overlay> tag to
      use.
      
      If the flag is not present, idmap2 will look for an <overlay> tag with
      no value for android:name.
      
      Bug: 162841629
      Test: libandroidfw_tests
      Test: libidmap2_tests
      Change-Id: I02316d0b88773f02c04a5d462be9825016fa496d
      30dc2e01
    • Ryan Mitchell's avatar
      Remove idmap path 256 length limit · 0699f1de
      Ryan Mitchell authored
      Overlay and target package paths can be longer than 256 characters.
      Currently, the idmap will fail to be generated if either path
      is longer than 256 characters.
      
      This change removes the 256 character limit and makes parsing variable
      length strings easier in libandroidfw.
      
      Bug: 174676094
      Test: idmap2_tests && libandroidfw_tests
      Change-Id: Ic240cdb8700566b2ac2ade08da58bea852e4ae0c
      0699f1de
  2. Dec 21, 2020
    • Bernie Innocenti's avatar
      Add explicit Result::ok() checks where needed · 58cf8e3f
      Bernie Innocenti authored
      Test: m checkbuild continuous_instrumentation_tests continuous_instrumentation_tests_api_coverage continuous_native_tests device-tests platform_tests
      Exempt-From-Owner-Approval: mechanical mass refactoring
      Change-Id: I3117833c51cdb333cccdfd159d1582f2adef77db
      58cf8e3f
  3. Dec 09, 2020
    • Robert Luo's avatar
      Migrate media output switcher metrics - 1/n · 23ccad79
      Robert Luo authored
      Bug: 172181610
      Test: (1) run statsd_testdrive 277, and check the
      metric output correctness after content switching.
      (2) run statsd_testdrive 90, and check the metric
      output correctness after launching the output dialog
      via Sound Setting / Volume Rocker / Media Object Chip.
      (3) atest MediaOutputControllerTest
      (4) atest MediaOutputDialogTest
      (5) atest MediaOutputBaseDialogTest
      
      Change-Id: I4094a510b5483a456522da9d0d8a6eee1526f687
      Merged-In: I0fea0c59afcb44fc1d22920036107524f221a7be
      23ccad79
  4. Dec 08, 2020
    • Ryan Mitchell's avatar
      Revert^2 "libandroidfw hardening for IncFs" · 80094e39
      Ryan Mitchell authored
      55ef6167
      
      Change-Id: I02d4890d181655dfd0a14c188468db512559d27b
      Merged-In: I02d4890d181655dfd0a14c188468db512559d27b
      80094e39
    • Mårten Kongstad's avatar
      idmap2: remove call to obsolete 'idmap2 verify' from valgrind.sh · ec7e7f56
      Mårten Kongstad authored
      The 'verify' command was removed as part of a707013b. Update
      valgrind.sh accordingly.
      
      Test: frameworks/base/cmds/idmap2/valgrind.sh
      Change-Id: I571cb46bb2ca09a244dc7b609a8bb0ffe01a6e2a
      Merged-In: I571cb46bb2ca09a244dc7b609a8bb0ffe01a6e2a
      ec7e7f56
    • Mårten Kongstad's avatar
      idmap2: remove the 'scan' command · 65324839
      Mårten Kongstad authored
      The 'scan' command has been replaced by 'create-multiple'. Remove the
      unused code.
      
      Also remove unused functions and #includes from FileUtils, and the
      obsolete JNI plumbing.
      
      Test: atest idmap2_tests OverlayDeviceTests OverlayHostTests
      Change-Id: Iae073c13ce64b5db48f22f7e723bc8c0c5fcd2c9
      Merged-In: Iae073c13ce64b5db48f22f7e723bc8c0c5fcd2c9
      65324839
    • Jeff Sharkey's avatar
      Improve OWNERS coverage across frameworks/base/. · 52b9862f
      Jeff Sharkey authored
      As general background, OWNERS files expedite code reviews by helping
      code authors quickly find relevant reviewers, and they also ensure
      that stakeholders are involved in code changes in their areas.
      
      Some teams under frameworks/base/ have been using OWNERS files
      successfully for many years, and we're ready to expand them to cover
      more areas.  Here's the historical coverage statistics for the last
      two years of changes before these new OWNERS changes land:
      
      -- 56% of changes are fully covered by OWNERS
      -- 17% of changes are partially covered by OWNERS
      -- 25% of changes have no OWNERS coverage
      
      Working closely with team leads, we've now identified clear OWNERS on
      a per-package basis, and we're using "include" directives whenever
      possible to to simplify future maintenance.  With this extensive
      effort, we've now improved our coverage as follows:
      
      -- 98% of changes are fully covered by OWNERS
      -- 1% of changes are partially covered by OWNERS
      -- 1% of changes have no OWNERS coverage
      
      This specific change is automatically generated by a script that
      identifies relevant "include" directives.
      
      Bug: 174932174
      Test: manual
      Exempt-From-Owner-Approval: refactoring with team leads buy-in
      Merged-In: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813
      Change-Id: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813
      52b9862f
  5. Dec 04, 2020
  6. Dec 03, 2020
  7. Dec 02, 2020
  8. Dec 01, 2020
    • Philip Junker's avatar
      Send shutdown callback only during animation destruction · f1291ba7
      Philip Junker authored
      The shutdown callback is currently used only by audioplay.cpp to destroy the audio player.
      Sending shutdown when the animation is destructed makes sure the audio
      player is not being destroyed before its boot animation part is being displayed.
      
      Test: Modified bootanimation, sound in second last part of bootanimation
      plays
      Bug: 157407957
      Bug: 127254055
      Merged-In: I47f57643791e73e4a4fa1597309dccb1f52f2316
      
      Change-Id: I47f57643791e73e4a4fa1597309dccb1f52f2316
      f1291ba7
    • Tej Singh's avatar
      Init duration metric if condition existed · 933b6e35
      Tej Singh authored
      Initialize a duration metric with the dimensions that are true if the
      "what" predicate previously existed.
      
      Assumes that the internal dimensions are a superset of the
      dimensions_in_what, the condition links, and the state links
      
      Test: atest statsd_test
      Bug: 167491517
      Change-Id: I8dd984fb9cb575d6d541f80cb3b1e626ce4e5f27
      933b6e35
    • Baligh Uddin's avatar
      Revert "Add OWNERS block to facilitate in migration" · bdbdc207
      Baligh Uddin authored
      This reverts commit 9e569671.
      
      Reason for revert: atoms and associated protos have been migrated.  Removing migration block.
      
      Merged-In: Ia1e4a73001ebc9509b8550c7957135172ce8938d
      BUG: 167962588
      Test: TH
      Change-Id: I7a451021461a24c2788411f2028e8ffed73667e9
      Exempt-From-Owner-Approval: Cleanup CL
      bdbdc207
  9. Nov 30, 2020
  10. Nov 27, 2020
    • Zim's avatar
      Remove dead isolated storage code from StorageManagerService · 7ac598f2
      Zim authored
      Isolated storage was added in Q (and enabled by default) and has been
      replaced by FUSE in R
      
      Additionally, we can remove the ExternalStorageMountPolicy concept
      which is only required if isolated storage is false
      
      Cleanup in preparation to introduce DeviceConfig changes for
      transcoding
      
      Bug: 169327180
      Test: Builds
      Change-Id: Ie2686d8efa6654ea6c4b4ca8c121c0c1841a6356
      7ac598f2
  11. Nov 26, 2020
    • Philip Junker's avatar
      Send shutdown callback only during animation destruction · 60600569
      Philip Junker authored
      The shutdown callback is currently used only by audioplay.cpp to destroy the audio player.
      Sending shutdown when the animation is destructed makes sure the audio
      player is not being destroyed before its boot animation part is being displayed.
      
      Test: Modified bootanimation, sound in second last part of bootanimation
      plays
      Bug: 157407957
      
      Change-Id: I47f57643791e73e4a4fa1597309dccb1f52f2316
      60600569
    • Jeffrey Huang's avatar
      Move enums file to new directory · 17df403e
      Jeffrey Huang authored
      Bug: 167962588
      Test: m -j
      Change-Id: I29b21fdc98c6c795902d23f21ef3dfd11d3f3216
      Merged-In: I29b21fdc98c6c795902d23f21ef3dfd11d3f3216
      17df403e
  12. Nov 25, 2020
    • Jeffrey Huang's avatar
      Move enums file to new directory · 71ae4fc7
      Jeffrey Huang authored
      Bug: 167962588
      Test: m -j
      Change-Id: I29b21fdc98c6c795902d23f21ef3dfd11d3f3216
      Merged-In: I29b21fdc98c6c795902d23f21ef3dfd11d3f3216
      71ae4fc7
    • Jeffrey Huang's avatar
      Delete atoms.proto from statsd · 15b86108
      Jeffrey Huang authored
      Use the atoms.proto in proto_logging as the source of truth. Also
      migrates statsd log api gen to use the new atoms.proto
      
      Bug: 167962588
      Test: m -j && m CtsStatsdAtomHostTestCases
      
      Change-Id: I36ec354d273dceace5245d7634c68ac63dc5a8cd
      Merged-In: I36ec354d273dceace5245d7634c68ac63dc5a8cd
      15b86108
    • Jeffrey Huang's avatar
      Move enums file to new directory · d16df80f
      Jeffrey Huang authored
      Bug: 167962588
      Test: m -j
      Change-Id: I29b21fdc98c6c795902d23f21ef3dfd11d3f3216
      Merged-In: I29b21fdc98c6c795902d23f21ef3dfd11d3f3216
      d16df80f
    • Jeffrey Huang's avatar
      Move enums file to new directory · 677a0df0
      Jeffrey Huang authored
      Bug: 167962588
      Test: m -j
      Change-Id: I29b21fdc98c6c795902d23f21ef3dfd11d3f3216
      677a0df0
  13. Nov 24, 2020
    • Jeffrey Huang's avatar
      Revert^2 "Delete atoms.proto from statsd" · 05e50cc9
      Jeffrey Huang authored
      e8552cd2
      
      Change-Id: I202a31ab654ca31ba9e5b73b23c5aa3d22a3e8b2
      Merged-In: I81a8287ed5b055e7b6547794d01e7ac897f0f022
      05e50cc9
    • Jeffrey Huang's avatar
      Revert^2 "Delete atoms.proto from statsd" · 91224ea8
      Jeffrey Huang authored
      217301c3
      
      Change-Id: I81a8287ed5b055e7b6547794d01e7ac897f0f022
      91224ea8
    • Jeffrey Huang's avatar
      Revert "Delete atoms.proto from statsd" · e8552cd2
      Jeffrey Huang authored
      Revert "Add android bp to proto_logging"
      
      Revert submission 1508746-delete_atoms
      
      Reason for revert: Build Failure
      Reverted Changes:
      I184cf8bf8:Add android bp to proto_logging
      I36ec354d2:Delete atoms.proto from statsd
      
      Change-Id: Ifec6a57d66cbd9c37503ca47847c3ae492f3d343
      e8552cd2
    • Alex Light's avatar
      Revert "Delete atoms.proto from statsd" · 217301c3
      Alex Light authored
      Revert "Add android bp to proto_logging"
      
      Revert submission 13070789-atomsproto
      
      Reason for revert: Breaks multiple git_master-without-vendor targets
      
      ```
      out/soong/.bootstrap/bin/soong_build -t -l out/.module_paths/Android.bp.list -b out/soong -n out -d out/soong/build.ninja.d -globFile out/soong/.bootstrap/build-globs.ninja -o out/soong/build.ninja Android.bp
      error: frameworks/base/tools/stats_log_api_gen/Android.bp:49:1: "stats-log-api-gen-test" depends on undefined module "libstats_proto_host"
      ninja: build stopped: subcommand failed.
      ```
      
      Reverted Changes:
      I184cf8bf8:Add android bp to proto_logging
      I36ec354d2:Delete atoms.proto from statsd
      
      Bug: 167962588
      
      Change-Id: Idce97c5cf020473744eb7f96dcfbdc7677c094da
      217301c3
    • Jeffrey Huang's avatar
      Delete atoms.proto from statsd · 5d230a2d
      Jeffrey Huang authored
      Use the atoms.proto in proto_logging as the source of truth. Also
      migrates statsd log api gen to use the new atoms.proto
      
      Bug: 167962588
      Test: m -j && m CtsStatsdAtomHostTestCases
      
      Change-Id: I36ec354d273dceace5245d7634c68ac63dc5a8cd
      Merged-In: I36ec354d273dceace5245d7634c68ac63dc5a8cd
      5d230a2d
    • Jeffrey Huang's avatar
      Delete atoms.proto from statsd · 4e671568
      Jeffrey Huang authored
      Use the atoms.proto in proto_logging as the source of truth. Also
      migrates statsd log api gen to use the new atoms.proto
      
      Bug: 167962588
      Test: m -j && m CtsStatsdAtomHostTestCases
      
      Change-Id: I36ec354d273dceace5245d7634c68ac63dc5a8cd
      4e671568
  14. Nov 23, 2020
  15. Nov 22, 2020
  16. Nov 19, 2020
  17. Nov 18, 2020
    • Nick Chalko's avatar
      Add TifTuneStateChanged atom. · 1fd8b567
      Nick Chalko authored
      This is the base atom for all TIF metrics
      
      Test: ./out/host/linux-x86/bin/statsd_testdrive
      Bug: 165369586
      Change-Id: I2e5c3e7f51abd2700611fcc0eaef91ec029513c8
      1fd8b567
    • Shuzhen Wang's avatar
      Camera: Enhance camera atoms for system health · b2443990
      Shuzhen Wang authored
      Introduce camera system health atoms, including:
      - Camera open, close, and session creation time
      - Camera session and stream combination information,
      - Stream statistics:
        - stream width, height, format, dataspace, usage flag,
        - max buffer count
        - buffer loss
        - first frame latency.
      
      Test: ./out/host/linux-x86/bin/statsd_testdrive 227
      Test: CTS PerformanceTest
      Bug: 154159000
      Change-Id: I858d64f3324bb9652a59e5857f2730c92c616a8e
      b2443990
    • Riddle Hsu's avatar
      Add a new launch type for hot start with relaunched activity · 59c2e7cf
      Riddle Hsu authored
      An existing activity may be relaunched when moving from background
      to front if the current configuration is changed and the activity
      cannot handle the change.
      
      The relaunch type was reported as a hot start because its process
      is alive and the original activity exists. But the relaunch needs to
      destroy the original activity and create a new instance, which may
      even take longer time than a warm start. So the case should be
      separated from hot start.
      
      Also:
      - Make WaitResult#launchState is always populated by
        ActivityMetricsLogger, so "am start -W" can get consistent
        launch type.
      - Remove dead code in ActivityRecord#ensureActivityConfiguration
        that it already early returns if !attachedToProcess.
      
      Bug: 172528316
      Test: atest ActivityMetricsLaunchObserverTests#testLaunchState
      Change-Id: I3ef64ce1e23b2f13d42fa2b12bc31c0cdb4652fc
      59c2e7cf
  18. Nov 17, 2020
Loading