Skip to content
Snippets Groups Projects
  1. Oct 20, 2023
    • Anushree Ganjam's avatar
      Include flag_check hook for "packages/SystemUI" · da9c624a
      Anushree Ganjam authored
      Parse arguments in flag_check.py.
      
      - msg = commit message
      - files = modified files paths
      - project = repo_path
      
      Using project we can filter further for "frameworks/base" and see if
      files starts with "packages/SystemUI" and then apply Flags check.
      
      Bug: 306262821
      Test: Manual
      Flag: NA
      Change-Id: I9b678344512527ec8b79aa458dae9f54fb4c61ba
      da9c624a
  2. Oct 11, 2023
  3. Oct 12, 2022
  4. Oct 07, 2022
  5. Aug 30, 2022
    • Jordan Demeulenaere's avatar
      Generate SystemUI ktfmt inclusion file · 5e3a34aa
      Jordan Demeulenaere authored
      This CL updates the ktfmt_includes.txt file used by SystemUI. Starting
      from this CL, all new Kotlin files in SystemUI/ will be checked using
      ktfmt.
      
      This file was generated using the following commands:
      $ cd $ANDROID_BUILD_TOP/frameworks/base
      $ $ANDROID_BUILD_TOP/external/ktfmt/generate_includes_file.py --output=packages/SystemUI/ktfmt_includes.txt packages/SystemUI
      
      Bug: 235461679
      Test: Manual
      Change-Id: I332abccd542796f72f4f89a7a4e1052611d955d8
      5e3a34aa
  6. Aug 12, 2022
    • Jordan Demeulenaere's avatar
      Add a ktfmt hook for some SystemUI files · e261526d
      Jordan Demeulenaere authored
      This CL enables a ktfmt hook to check that Kotlin files are properly
      formatted.
      
      The set of files or directories that should be included is specified in
      a simple ktfmt_includes.txt file. That way, existing files that are not
      properly formatted yet won't be checked and uploaders won't be bothered
      by this check. In the future, we will check all files created after some
      baseline.
      
      At the moment, only Kotlin files that I know are already formatted with
      ktfmt were included in that list.
      
      Test: Manual
      Bug: 235461679
      Change-Id: Idaed15c39f6af413c305f4c74f142a2895b5a753
      e261526d
  7. Aug 03, 2022
    • Jeff Sharkey's avatar
      Migrate stringslint.py to AyeAye. · 6e2c5663
      Jeff Sharkey authored
      This script has been deprecated and replaced by AyeAye checks
      directly in Gerrit.
      
      Bug: 164530987
      Test: none
      Change-Id: I6a36c0a7ac10cbec0667780c30ba4a20124edee4
      6e2c5663
  8. Apr 15, 2021
  9. Apr 12, 2021
  10. Mar 04, 2021
  11. Mar 02, 2021
  12. Feb 27, 2021
    • Songchun Fan's avatar
      [incremental] change build rules to not to use aidl_interface · e2c109d7
      Songchun Fan authored
      This will allow the usage of PersistableBundle in the aidl interfaces.
      The modules do not need to be stable so it is okay to just use the old
      aidl to build both c++ and Java backend.
      
      + use bpfmt to check Android.bp format before upload
      
      BUG: 181266844
      Test: builds (with aosp/1607482)
      Change-Id: I3340129ae6d12f33ade38d7a2b0eb23e7c37e996
      e2c109d7
  13. Jan 29, 2021
    • Siarhei Vishniakou's avatar
      Send input event id to SurfaceFlinger · d11f38f6
      Siarhei Vishniakou authored
      The application receives input events and produces graphic buffers in
      response. We are interested in measuring the total time that the input
      event takes to process, from the moment it's received on the device, to
      the moment that the image is displayed on the screen.
      
      To do this, we need to understand which input event produced a specific
      buffer. In this CL, we are sending the input event id from FrameInfo to
      SurfaceFlinger. This event id will later be used to identify a specific
      frame, and provide the frame timing information to inputflinger.
      
      Inputflinger will be able to use this information to reconstruct the
      complete event timeline, and record metrics on the duration of each
      input / graphics processing stage. This will allow us to optimize
      end-to-end touch latency.
      
      In the current CL, we are using 'NewestInputEvent' as the inputEventId.
      That's not quite correct. Today, this field contains the timestamp of
      the input event. Therefore, we will simply pass the truncated
      timestamp instead of proper input event id. We will fix this in a
      separate CL by providing input event id to FrameInfo.
      
      Design doc: https://docs.google.com/document/d/1G3bLaZYSmbe6AKcL-6ZChvrw_B_LXEz29Z6Ed9QoYXY/edit#
      Bug: 169866723
      Test: printed input event id at the site of SurfaceFrame creation in
      FrameTimeline.cpp
      
      Change-Id: Ia90337bb2f000e9c93a4db04d9dd6ea9ea153520
      d11f38f6
  14. Jan 26, 2021
    • Siarhei Vishniakou's avatar
      Send input event id to SurfaceFlinger · 60137079
      Siarhei Vishniakou authored
      The application receives input events and produces graphic buffers in
      response. We are interested in measuring the total time that the input
      event takes to process, from the moment it's received on the device, to
      the moment that the image is displayed on the screen.
      
      To do this, we need to understand which input event produced a specific
      buffer. In this CL, we are sending the input event id from FrameInfo to
      SurfaceFlinger. This event id will later be used to identify a specific
      frame, and provide the frame timing information to inputflinger.
      
      Inputflinger will be able to use this information to reconstruct the
      complete event timeline, and record metrics on the duration of each
      input / graphics processing stage. This will allow us to optimize
      end-to-end touch latency.
      
      In the current CL, we are using 'NewestInputEvent' as the inputEventId.
      That's not quite correct. Today, this field contains the timestamp of
      the input event. Therefore, we will simply pass the truncated
      timestamp instead of proper input event id. We will fix this in a
      separate CL by providing input event id to FrameInfo.
      
      Design doc: https://docs.google.com/document/d/1G3bLaZYSmbe6AKcL-6ZChvrw_B_LXEz29Z6Ed9QoYXY/edit#
      Bug: 169866723
      Test: printed input event id at the site of SurfaceFrame creation in
      FrameTimeline.cpp
      
      Change-Id: Ia90337bb2f000e9c93a4db04d9dd6ea9ea153520
      60137079
  15. Oct 23, 2020
    • Vishnu Nair's avatar
      Allow creating child surfaces from BlastBufferQueue · ce1a6484
      Vishnu Nair authored
      App such as Chrome create child surfaces and parent them to
      surfaces provided by SurfaceView. When we enable the blast
      adapter for SurfaceView, the IGBP returned to the app is
      created in the client and SurfaceFlinger does not know about it.
      When the app creates a child surface and provides the IGBP as the
      parent surface identifier, SF fails to validate the IGBP and the
      surface is not created. This can be avoid if the client creates the
      child surface from the SV SurfaceControl but we still need to
      support existing APIs.
      
      To fix this, when we create a Surface from the adapter, pass in
      the handle of the Blast SurfaceControl. When calling
      ASurfaceControl_createFromWindow, use this handle to identify
      the parent.
      
      Bug: 168917217
      Test: adb shell settings put global use_blast_adapter_sv 1 & launch chrome
      Change-Id: I879b411c47e8558397516bd7b7278813e79e005f
      ce1a6484
  16. Sep 25, 2020
    • Vishnu Nair's avatar
      Verify SurfaceView BlastBufferQueue behavior · 57928e6a
      Vishnu Nair authored
      Initial code to easily configure buffer producers to generate buffers
      with different properties inorder exercise and validate
      BlastBufferQueue adapter.
      
      The test captures surface flinger traces and verifies properties of a
      single buffer. This will allow us to verify buffer presentation order,
      buffer rejection, buffer properties and so on.
      
      Test: atest SurfaceViewBufferTests
      Bug: 168504870
      Change-Id: I9714d7b6f5ffbe5fecca5d93e8184f0e6ac2b4c1
      57928e6a
  17. Sep 18, 2020
    • Siarhei Vishniakou's avatar
      Update usage of PropertyMap::load · 2da17761
      Siarhei Vishniakou authored
      Now that PropertyMap returns an owned object, update the usage in
      validatekeymaps.
      
      Bug: 163171599
      Test: presubmit
      Change-Id: I75b9abe3fa1d418951a8c23a624771046a89b3f8
      2da17761
  18. Aug 19, 2020
    • Chris Ye's avatar
      Add "uinput" command to support uinput device. · 3c5b8093
      Chris Ye authored
      Add support of uinput device with "uinput" shell command, allows user to
      create a virtual uinput device and inject events to it, for input
      framework testing.
      
      Bug: 160360195
      Bug: 163217897
      
      Test: run uinput command from adb shell.
      Change-Id: Ic885ae510d98fa282722f7a17d66778c15a893b6
      3c5b8093
  19. Jul 18, 2020
    • Garfield Tan's avatar
      Enable clang-format for frameworks/base · 4c2d3daf
      Garfield Tan authored
      Copy and paste internal setup to AOSP. Not include folders not in AOSP
      yet.
      
      Bug: None
      Test: repo upload
      Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
      Merged-In: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
      4c2d3daf
  20. Jul 10, 2020
  21. Jul 09, 2020
  22. Apr 06, 2020
    • Alex Buynytskyy's avatar
      Appops permission monitoring for GET_USAGE_STATS. · 1d89216e
      Alex Buynytskyy authored
      This makes sure DataLoader won't be able to obtain read logs once user
      denies access.
      
      Bug: b/152633648
      Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
      Test: adb shell appops set 1000 GET_USAGE_STATS deny
      Change-Id: Ibbb74933b4ef0dd8f5fe27732743e5820b8ee4dc
      1d89216e
  23. Jan 27, 2020
    • Siarhei Vishniakou's avatar
      Enable clang-format for f/b/services/core/jni · 44d50fea
      Siarhei Vishniakou authored
      To avoid code review comments about code style, line length, and
      spacing, enable clang-format for frameworks/base/services/core/jni
      
      Bug: none
      Test: repo upload
      Change-Id: Ie38ecca2d5face78367d3eab450e497120ce12b1
      44d50fea
  24. Jan 03, 2020
    • Siarhei Vishniakou's avatar
      Enable clang-format for core/jni · cd2fe535
      Siarhei Vishniakou authored
      To have consistent code style and avoid format-related comments in code
      review, enable clang-format in frameworks/base/core/jni.
      
      Bug: none
      Test: repo upload
      Change-Id: Ie9e5408d85036dfabae3a9c60b238b4a190da5fc
      cd2fe535
  25. Dec 10, 2019
    • Siarhei Vishniakou's avatar
      Enable clang-format for input code · a3117ca4
      Siarhei Vishniakou authored
      Currently, there is no format enforcement for hid command. Add
      clang-format hook for all input-related code in frameworks/base.
      
      Bug: None
      Test: repo upload
      Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
      a3117ca4
  26. Nov 01, 2019
  27. Jul 24, 2019
    • Remi NGUYEN VAN's avatar
      Add ktlint to preupload hooks · ba47bae7
      Remi NGUYEN VAN authored
      The kotlin linter is particularly useful for tests written in Kotlin in
      frameworks/base.
      
      This is already merged in internal master.
      
      Test: Tried uploading change with/without kotlin style problems.
      Merged-In: Ie8659765b674ac7b2d82ed3d343f387195c07d83
      Change-Id: I420366c49d071e022b8988c3d6293dbc8e9a283a
      ba47bae7
  28. Dec 10, 2018
    • Lorenzo Colitti's avatar
      Enable checkstyle everywhere in frameworks/base. · 6bfffd68
      Lorenzo Colitti authored
      This was done in internal master in ag/5397886. Do it in AOSP as
      well so we can benefit from checkstyle in AOSP as well.
      
      Test: None
      Change-Id: Ib00fc8d318e8127224846e0a69cb542178631437
      Merged-In: I7d350c2bbb9fcd1019abd1addb035ce5e9e05acc
      6bfffd68
  29. Nov 29, 2018
    • Paul Duffin's avatar
      Prevent hiddenapi entries being added for libcore related projects · 00537c15
      Paul Duffin authored
      The libcore related projects (see below) have been (mostly) switched
      over to use UnsupportedAppUsage annotations, This change will prevent
      entries for those projects being added to a config/hiddenapi-* file.
      
      * libcore
      * external/bouncycastle
      * external/conscrypt
      * external/icu
      * external/okhttp
      * external/libphonenumber - still has a couple of entries in
            config/hiddenapi-light-greylist.txt due to limitations in
            UnsupportedAppUsage/class2greylist.
      
      Tested by attempting to upload the file with entries for libcore
      projects and without those entries and checking that the behavior
      is expected.
      
      Test: see above
      Bug: 117818301
      Change-Id: I67a30b307e12e842b28cfb2160fab0029868fa06
      00537c15
  30. Nov 21, 2018
  31. Oct 30, 2018
    • Aurimas Liutikas's avatar
      Enable checkstyle for all frameworks/base projects. · 2c5aa790
      Aurimas Liutikas authored
      We've been slowly rolling out checkstyle to frameworks/base by 
      whitelisting new directories, at this point we have most active directories, so let's make it enabled for everyone.
      
      Change-Id: I7d350c2bbb9fcd1019abd1addb035ce5e9e05acc
      Test: None
      2c5aa790
  32. Oct 18, 2018
  33. Sep 24, 2018
  34. Sep 11, 2018
    • Jeff Sharkey's avatar
      Upload hook that guides people towards AOSP. · 0a9c7319
      Jeff Sharkey authored
      The canonical location of certain parts of the source tree live in
      AOSP, and should not be changed internally to avoid merge conflicts.
      
      This initially starts with "OWNERS" files, but the hook can easily
      be repeated to match any files based on file path regexes.
      
      Bug: 113136846
      Test: manual
      Change-Id: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
      Merged-In: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
      0a9c7319
  35. Aug 24, 2018
    • Jeff Sharkey's avatar
      Upload hook that guides people towards AOSP. · fb7b3732
      Jeff Sharkey authored
      The canonical location of certain parts of the source tree live in
      AOSP, and should not be changed internally to avoid merge conflicts.
      
      This initially starts with "OWNERS" files, but the hook can easily
      be repeated to match any files based on file path regexes.
      
      Bug: 113136846
      Test: manual
      Change-Id: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
      fb7b3732
  36. Aug 23, 2018
    • Jason Monk's avatar
      First kotlin · ae7ced2f
      Jason Monk authored
      Convert one class to kotlin and provide a slight amount of guidance.
      
      Test: existing tests
      Change-Id: Ie8659765b674ac7b2d82ed3d343f387195c07d83
      ae7ced2f
  37. Aug 03, 2018
  38. Jul 30, 2018
    • Philip P. Moltmann's avatar
      Split PackageInstaller app into installation and permissions management · 8943ad63
      Philip P. Moltmann authored
      The two components were mostly independant for a long time. Since
      I1e80a3f5e63d02b3859ecf74af21ca4c61f96874 the installation flow does
      not grant any permissions anymore and the last connection between these
      parts was broken.
      
      The new app "com.android.packageinstaller" in
      frameworks/base/packages/PackageInstaller will only handle (side load)
      package installtion and uninstallation.
      
      The exisiting app will be renamed to "com.android.permissioncontroller"
      and only handle permission granting and permission management.
      
      This change does only minimal cleanup cleanup. In particularly it does
      not move any files in the old permissions controller. This is to not
      disturb other features currently in development.
      
      This change set also updates the make files to install the two apps on
      the appropriate devices.
      
      Further the permisson policy xmls need to be updated to point to the
      right packages.
      
      Test: Installed + uninstalled packages
            Granted permissions + managed permissions
      
            GtsPackageInstallTestCases
            GtsNoPermissionTestCases
            GtsNoPermissionTestCases25
            GtsPackageInstallerTapjackingTestCases
            GtsPackageUninstallTestCases
      Change-Id: I2d3796b837fc0049e712c82a990907f305c8febf
      8943ad63
  39. Jul 20, 2018
Loading