Test: Manual
Change-Id: Ia72b2cd3a3b50acad0139bad929ea5c57491851e

Fix areBundleEqual in Call.

Currently the sentence in areBundleEqual arranged in a wrong order.
Fixed this by moving the check sentence before the actual query
sentence.

Bug: b/312604549
Test: cts call tests
Change-Id: Id8caa5719b4df724cbe03edd75b99a2b2e3882b5

Bug: b/295530944
Test: Unit tests pass.
Defer-CP-To-Master: 297157687

Change-Id: I70197f1393bc77dfbf29056192fde6c8be8d1009
(cherry picked from commit c92465b603f5d294473308f85c9cfc441665037a)

This causes issues, for instance, when we have a MO and MT call
ongoing. The associated users for both calls would be different
based on the logic that was added for work profiles (MT calls
associated with target phone account handle user while MO calls
are associated with the profile user). As a result, resetting
the adapter puts Telecom in a state where it is unable to update
the existing calls.

The framework changes ensure that the phone instance (which provides
the in-call information to the user) is not being reset when it's
already instantiated.

Bug: 308856446
Bug: 294699269
Test: Manual
Test: New unit test to verify that call updates are persevered when
MO/MT call are placed from the secondary/guest user.
Test: v2/android-platinum/telephony-platinum-tests-ATT

Change-Id: I4976c0ec67d515e96f6d4df53c79ac500eb6a06e

Revert submission 24838577-cherrypick-MT-MO-secondaryUserCallUpdateFix-udc-qpr-dev-70l1hzdwrmf

Reason for revert: Probable culprit for b/311270644.

Reverted changes: /q/submissionid:24838577-cherrypick-MT-MO-secondaryUserCallUpdateFix-udc-qpr-dev-70l1hzdwrmf

Change-Id: Ic0a30f091de2bdf06f6c4ffc8c1a2725b64ac871

The default retention is CLASS, but the correct retention is SOURCE.
There is a metalava check for typedef annotations correctly, but that
check is currently disabled. This is part of the work required to
re-enable that check.

Bug: 309971481
Test: m checkapi
Change-Id: I386efea9321bd2adb2722710056b1d57dd5401f5

The key is used for dialer apps to mark missed calls as read when it
gets the notification on reboot.

Test: N/A
Bug: 292597423

Change-Id: I8a84778434891eca78dbce3d5a1c25cc1eb86228

Clarify in the docs that only the system/default dialer can
directly place call forwarding MMI codes. For other applications,
placing a call using these mmi codes will cause the dialer to
pop up with the MMI code populated so that the user can manually
confirm  before the call is placed.

Bug: 306380262
Test: docs only change
Flag: DOCS_ONLY
Change-Id: Id486304020b12e01785c5d98a1496d3bd9cfac43

This change guards CallDetails#getId and StreamingCall#EXTRA_CALL_ID with the newly added telecom flag FLAG_CALL_DETAILS_ID_CHANGES.

Bug: 301713560
Test: Updated CallDetailsTest#testCallId and CallStreamingTest
Change-Id: I3819fa9eda5995d7ef354e71d2b4c7d5a4423e66

Due to a bug in the build system, broken @see/@link references have not
failed to build for a while, so many errors have accumulated.

This is an attempt to patch up the telephony and telecomm docs. The
most common errors and fixes were:
- @link-ing IntDef constants from javadoc. IntDefs are not present
  in the docs, so rewrite those to natural english, or point to the
  constant prefixes
- Javadoc for public symbols referencing SystemApi symbols. Change those
  to @code instead of @link

There were various other fixes too, and I'm not sure they're all
perfect, but certainly an improvement over the brokenness we have
currently.

Bug: 303184203
Test: m docs
Change-Id: I5cefc72074ced29c0b046cf59deb7ee371e74bf0

This causes issues, for instance, when we have a MO and MT call ongoing. The associated users for both calls would be different based on the logic that was added for work profiles (MT calls associated with target phone account handle user while MO calls are associated with the profile user). As a result, resetting the adapter puts Telecom in a
state where it is unable to update the existing calls. This is being fixed in packages to ensure that MT calls adhere to the profile association as well, so Telecom would not try to set the adapter again in InCallController.

Bug: 294699269
Test: Manual
Test: New unit test to verify that call updates are persevered when
MO/MT call are placed from the secondary/guest user.

Change-Id: Ic771acab949f2ee6b47a5a32ffb02c0cddf0a8dc

This CL cleans up the equals method that i sused for string comparison by the CallEndpoint class. This change updates that method to rely on the standard .equals method provided by the java.utils.Objects class.

Test: this method is widely used so PS should provide coverage of this change
Bug: 288897277
Change-Id: I5863f323f921f146e46513a0f1b29631779f76af

This CL tags the PROPERTY_IS_TRANSACTIONAL API with the "voip_app_actions_support" flag.

Test: manual
Bug: 297436628
Change-Id: I393e8620962d4490205be41c7cdcc958aee64a12

Defined the new PROPERTY_IS_TRANSACTIONAL in Call#Details for tracking when a call is transactional or not.

Test: manually using the transactional VoIP app and added new CTS tests in TransactionalApisTest
Bug: 296934278
Change-Id: I50707a4026a93064e9f0763ed180bc8e7bd91184

Moved EVENT_DISPLAY_SOS_MESSAGE from Call.java to TelephonyManager.java

Bug: 285607031
Test: Flashed build on raven-userdebug and performed basic functionality
tests,
atest CtsTelephonyTestCases

Change-Id: Ib426ecab848313040b1fc426fd2fb31ceb0a0c88

Test: Owners only change.
Bug: 296459098
Change-Id: Ib97b6c3c155e0eee0529089f08ac87ebdd27e95a

Use Map.computeIfAbsent or the result of get() calls to interact with
the map via a single access, avoiding duplicate lookups.

Test: atest cts/tests/tests/telecom/src/android/telecom/cts/RemoteConnectionTest.java
Bug: 274764512
Change-Id: I1e6b10381f0c9b408c4a734384e550dfaefc1f40

The topic adds a transactional way to verify call state changes.
Connection#onHold can now lead to the call being disconnected if the
Connection#setOnHold is not called within the 2 second timeframe. The
docs should be updated to reflect this behavior change.

Test: build + existing Telecom test suite
Fixes: b/267234374
Change-Id: I910843d4e8adec8d38cd32915f223540cefb9ac6

The key is used for dialer apps to know when call is answered by user.

Test: N/A
Change-Id: Idfef41b88df21a9a39032fdbb4090a181b164f73
Skip-CP-To-Master: pending on telecom review
Bug: 242074284

If call is initially a DISCONNECTED call, the callback will be fire in wrong sequence where onCallRemoved is fired before onCallAdded.
Bug: 203563157
Test: manual test


Change-Id: I4b13dc13b34a1547f0c68ced01b3c1177dfa9eb3
(cherry picked from commit 5495c83fb5dbf833082ce4c9c21c415580420a7f)
(cherry picked from commit fb9aec0c1175618759f5d7328fc42ec3c152cbe2)

This CL unhides StreamingCall#EXTRA_CALL_ID and adds an API to Call Details to get the telecom call ID. Updated CTS tests accordingly to account for these changes.

Fixes: 286457948
Test: atest CallDetailsTest && atest CallStreamingTest
Change-Id: Ibf9dbe38224b9710eb79aa68812f3a185f7e297d

This CL is a postmortem action which is detailed in the linked bug.
In short, an OEM had the telecom stack outside of the system process
and had a non-ui InCallService it wanted to bind.  However, the
InCallService set the Exported property to false.  This combo caused
a calling outage that prevented users from making/receiving calls.

To prevent the above scenaro from occuring again, this new CTS test
was created. It tests the Telecom stack of the OEM against a
non-ui InCallService that has it's exported property set to false.

Bug: 198715680

Test: 1 new CTS test,
      NonUiInCallServiceWoExportTest
      #testTelecomCanBindToNonUiInCallServiceThatIsNotExported

Change-Id: I5b99aa9c7e989a1c20a7b086f65782286a8be575

bug: 282997779
Test: build
Change-Id: I9c1a3d0ca6e24a5cc6090d7e659329bf19391d1b

Throws an IllegalArgumentException when the endpoint name passed into
the constructor is null. This will help prevent the error from being
invoked later down the line and instead throws it at the first sign
of detection.

Fixes: 286310499
Test: atest TelecomUnitTests
Change-Id: Ic128d0e3577591d54cf9c4309844e4580af220c1

Because of the INTERACT_ACROSS_USERS permission, an app that implements
a ConnectionService can upload an image icon belonging to another user
by setting it in the StatusHints. Validating the construction of the
StatusHints on the calling user would prevent a malicious app from
registering a connection service with the embedded image icon from a
different user.

From additional feedback, this CL also addresses potential
vulnerabilities in an app being able to directly invoke the binder for a
means to manipulate the contents of the bundle that are passed with it.
The targeted points of entry are in ConnectionServiceWrapper for the
following APIs: handleCreateConnectionComplete, setStatusHints,
addConferenceCall, and addExistingConnection.

Fixes: 280797684
Test: Manual (verified that original exploit is no longer an issue).
Test: Unit test for validating image in StatusHints constructor.
Test: Unit tests to address vulnerabilities via the binder.
Change-Id: I6e70e238b3a5ace1cab41ec5796a6bb4d79769f2
Merged-In: I6e70e238b3a5ace1cab41ec5796a6bb4d79769f2

Because of the INTERACT_ACROSS_USERS permission, an app that implements
a ConnectionService can upload an image icon belonging to another user
by setting it in the StatusHints. Validating the construction of the
StatusHints on the calling user would prevent a malicious app from
registering a connection service with the embedded image icon from a
different user.

From additional feedback, this CL also addresses potential
vulnerabilities in an app being able to directly invoke the binder for a
means to manipulate the contents of the bundle that are passed with it.
The targeted points of entry are in ConnectionServiceWrapper for the
following APIs: handleCreateConnectionComplete, setStatusHints,
addConferenceCall, and addExistingConnection.

Fixes: 280797684
Test: Manual (verified that original exploit is no longer an issue).
Test: Unit test for validating image in StatusHints constructor.
Test: Unit tests to address vulnerabilities via the binder.
Change-Id: I6e70e238b3a5ace1cab41ec5796a6bb4d79769f2
Merged-In: I6e70e238b3a5ace1cab41ec5796a6bb4d79769f2

Because of the INTERACT_ACROSS_USERS permission, an app that implements
a ConnectionService can upload an image icon belonging to another user
by setting it in the StatusHints. Validating the construction of the
StatusHints on the calling user would prevent a malicious app from
registering a connection service with the embedded image icon from a
different user.

From additional feedback, this CL also addresses potential
vulnerabilities in an app being able to directly invoke the binder for a
means to manipulate the contents of the bundle that are passed with it.
The targeted points of entry are in ConnectionServiceWrapper for the
following APIs: handleCreateConnectionComplete, setStatusHints,
addConferenceCall, and addExistingConnection.

Fixes: 280797684
Test: Manual (verified that original exploit is no longer an issue).
Test: Unit test for validating image in StatusHints constructor.
Test: Unit tests to address vulnerabilities via the binder.
Change-Id: I6e70e238b3a5ace1cab41ec5796a6bb4d79769f2
Merged-In: I6e70e238b3a5ace1cab41ec5796a6bb4d79769f2

Because of the INTERACT_ACROSS_USERS permission, an app that implements
a ConnectionService can upload an image icon belonging to another user
by setting it in the StatusHints. Validating the construction of the
StatusHints on the calling user would prevent a malicious app from
registering a connection service with the embedded image icon from a
different user.

From additional feedback, this CL also addresses potential
vulnerabilities in an app being able to directly invoke the binder for a
means to manipulate the contents of the bundle that are passed with it.
The targeted points of entry are in ConnectionServiceWrapper for the
following APIs: handleCreateConnectionComplete, setStatusHints,
addConferenceCall, and addExistingConnection.

Fixes: 280797684
Test: Manual (verified that original exploit is no longer an issue).
Test: Unit test for validating image in StatusHints constructor.
Test: Unit tests to address vulnerabilities via the binder.
Change-Id: I6e70e238b3a5ace1cab41ec5796a6bb4d79769f2
Merged-In: I6e70e238b3a5ace1cab41ec5796a6bb4d79769f2

Because of the INTERACT_ACROSS_USERS permission, an app that implements
a ConnectionService can upload an image icon belonging to another user
by setting it in the StatusHints. Validating the construction of the
StatusHints on the calling user would prevent a malicious app from
registering a connection service with the embedded image icon from a
different user.

From additional feedback, this CL also addresses potential
vulnerabilities in an app being able to directly invoke the binder for a
means to manipulate the contents of the bundle that are passed with it.
The targeted points of entry are in ConnectionServiceWrapper for the
following APIs: handleCreateConnectionComplete, setStatusHints,
addConferenceCall, and addExistingConnection.

Fixes: 280797684
Test: Manual (verified that original exploit is no longer an issue).
Test: Unit test for validating image in StatusHints constructor.
Test: Unit tests to address vulnerabilities via the binder.
Change-Id: I6e70e238b3a5ace1cab41ec5796a6bb4d79769f2

Add an extra key used internally with call attributes when setting up a
call.

Test: Manual testing.
Bug: 277232336
Merged-In: Ic8b5d57df88cf9c1d8a82a11ad4934ed4ef5fd78
Change-Id: Ic8b5d57df88cf9c1d8a82a11ad4934ed4ef5fd78

Add an extra key used internally with call attributes when setting up a
call.

Test: Manual testing.
Bug: 277232336
Change-Id: Ic8b5d57df88cf9c1d8a82a11ad4934ed4ef5fd78

TL;DR:
- docs update for CallControlCallback rejection cases
- CTS coverage for onAnswer#(wasCompleted(false)) case
- CTS coverage for onSetActive#(wasCompleted(false)) case
- TSW fix

In most of the Transactional tests, it's expected that the client
always completed the CallControlCallback. In adding these tests I
noticed that the current logic will answer or set the call active if the
client rejects the onAnswer or onSetActive. In order to prevent this two
active call scenario, I've adjusted the appropriate code.

Fixes: 279034589
Test: CTS coverage for changes
Change-Id: I97f6371d845e00e7708b8b65abd57591d7a01cb7

Update API docs for REMOTE to make it clear that this disconnect cause is
used both for user-initiated disconnection on behalf of the remote party,
and for cases where the remote party never answered the call.

Test: Docs only change
Fixes: 280505750
Change-Id: Id718c75e2b748d2b5d5778f89d3dd7a420845418

Also fix bug where CallStreamingService would never init the streaming
adapter.  This caused the CallStreamingService to NEVER get notified of
onCallStreamingstarted since the handleMessage method was checking to see
if the adapter was set.

Test: Added CTS test for this case.
Bug: 279650527
Change-Id: I389efacd7547439985caabc068be5413897cf128

Also update javadoc to remove outdated information about self-managed
calls.

Bug: 279209119
Test: n/a
Change-Id: I6dba56f7afb8b383904a28042ad6e2a10e0a84b8

The D2DI team hit an NPE while testing out the call transfer/streaming
stuff. The NPE arises in StreamingCall whenever a call streaming changed
msg comes in and the StreamingCallAdapter is null.

Ideally, we should be wrapping any adapter request with an NPE check and
ignoring messages if the adapter is destroyed or not set.

bug: 277119309
Test: manual
Change-Id: I90a5c1dc16dfda9f3c92316b2f4f1655166a59b9

API council had originally created a bug to add details on disconnecting
a call and not needing to create a foreground service. I decided to
completely redo the docs to improve the adpotion of the API surface.

bug: 274957450
Test: none
Change-Id: I47dd84f8673ee7b81f1bd99ee6f42743d1d54b37

While investigating how the VoipCallMonitor class treats transactional
calls, I noticed a security exception was being thrown whenever
startForegroundServiceDelegate was being called. Upon some further
digging, an incorrect UID was being given to the activity manager class.

The fix is to fetch the UID in TelecomServiceImpl#addCall and store it
in the extras. Then, when the call is created in CallsManager, those
values are stored in the Call object. VoipCallMonitor can then query the
value and there is no longer a security exception.

Fixes: 276802273
Test: manual (start T-call and grep VoipCallMonitor)
      + unit test (ensure the CallingPackageIdentity is being set)
Change-Id: I10a22df721d1c9c6f467a24fed2d1204e0db843f

Bug: 261877110
Test: Telecom unit test
Change-Id: I05258c0ce17de38fb220f97ddbdda75a6bab1a1f
Merged-In: I05258c0ce17de38fb220f97ddbdda75a6bab1a1f

- include disable accounts when looking up accounts for a package to
  check if the limit is reached (10)
- put a new limit of 10 supported schemes
- put a new limit of 256 characters per scheme
- put a new limit of 256 characters per address
- ensure the Icon can write to memory w/o throwing an exception

bug: 259064622
bug: 256819769
Test: cts + unit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b07326f1fb3d0e42a6bab902c271974c42d93c06)
Merged-In: Ia7d8d00d9de0fb6694ded6a80c40bd55d7fdf7a7
Change-Id: Ia7d8d00d9de0fb6694ded6a80c40bd55d7fdf7a7