Skip to content
Snippets Groups Projects
  1. Dec 15, 2023
  2. Dec 14, 2023
  3. Dec 13, 2023
    • Shaju Mathew's avatar
      6106318c
    • Roshan Pius's avatar
      nfc(api): Address API council feedback · 2633b202
      Roshan Pius authored
      Rename from `isOtherServiceEnabled` to `isCategoryOtherServiceEnabled`.
      
      Bug: 315130804
      Test: Compiles
      Change-Id: I7b97b6de0bd702e695557a4d55a1f80e612f92c8
      2633b202
    • Roshan Pius's avatar
      nfc(api): Address API council feedback · ead78c5c
      Roshan Pius authored
      Add @IntDef to return values of getAdapterState.
      
      Bug: 315228674
      Test: Compiles
      Change-Id: I8134a68c36950e89cd65c2b4ab9dd9cefb2cb7b4
      ead78c5c
    • Shaju Mathew's avatar
      Removing unused counters. · c94cf7d4
      Shaju Mathew authored
      Bug: N/A
      Test: Treehugger
      Change-Id: I058b0e550c7ed9197934f2bbda1146e776324934
      c94cf7d4
    • T.J. Mercier's avatar
      Throw exception for negative UIDs/GIDs · 30b2cd80
      T.J. Mercier authored
      UIDs and GIDs are unsigned on linux. Badly behaved callers are
      occasionally passing negative integers for UIDs through JNI to uid_t
      which is unsigned. Prevent this by throwing a JNI exception.
      
      12-08 23:15:34.542  1000  3354  3388 I ActivityManager: Force stopping com.android.cts.install.lib.testapp.A appid=10109 user=-1: deletePackageX
      12-08 23:15:34.543  1000  3354  3388 E libprocessgroup: No such cgroup attribute: /sys/fs/cgroup/uid_4294877405/cgroup.freeze
      12-08 23:15:34.543  1000  3354  3388 W libprocessgroup: Failed to apply Frozen process profile: No such file or directory
      
      Test: 12-11 18:43:23.145  3432  3466 I ActivityManager: Force stopping com.android.cts.install.lib.testapp.A appid=10109 user=-1: deletePackageX
      Test: 12-11 18:43:23.146  3432  3466 E ActivityManager: Unable to freeze cgroup uid: -89891: java.lang.IllegalArgumentException: uid is negative: -89891
      Test: 12-11 18:43:23.147  3432  3466 E ActivityManager: Unable to unfreeze cgroup uid: -89891: java.lang.IllegalArgumentException: uid is negative: -89891
      Bug: 316198981
      Change-Id: I24cb1e65e502ef6e09226538efe6ed54c8db7cdd
      30b2cd80
    • Devin Moore's avatar
      Revert "Revert "Create a HwNoService class that fakes hwservicem..." · 25cbbbc9
      Devin Moore authored
      Revert submission 2870060-revert-2866127-HwNoService-EIABNUAXKH
      
      Reason for revert: Fixed robolectric tests with aosp/2874076
      
      Reverted changes: /q/submissionid:2870060-revert-2866127-HwNoService-EIABNUAXKH
      
      Change-Id: I0228877982f55ed8f53f5770ee43de7fad14922f
      25cbbbc9
    • Devin Moore's avatar
      Revert^2 "Add isHidlSupported Java API" · b480dead
      Devin Moore authored
      109b1352
      
      Change-Id: If68af33e95c33f8f8d9c7d66416c40bc5536a7c1
      b480dead
    • Vova Sharaienko's avatar
      0b50679b
    • Eric Biggers's avatar
    • Eric Biggers's avatar
      Merge changes Ica472482,I32381136 into main · f4c7c30b
      Eric Biggers authored
      * changes:
        locksettings: clean up references to managed profiles
        Sync tieProfileLockIfNecessary() with internal main
      f4c7c30b
    • Eric Biggers's avatar
    • Jiakai Zhang's avatar
      ANR WatchDog += artd. · 6cf321c5
      Jiakai Zhang authored
      ----- pid 4128 at 2023-12-13 15:25:30.811962769+0000 -----
      Cmd line: /apex/com.android.art/bin/artd
      ABI: 'x86_64'
      
      "binder:4128_2" sysTid=4128
          #00 pc 00000000000b9cb7  /apex/com.android.runtime/lib64/bionic/libc.so (__ioctl+7) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #01 pc 000000000006da28  /apex/com.android.runtime/lib64/bionic/libc.so (ioctl+216) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #02 pc 0000000000052ca3  /system/lib64/libbinder.so (android::IPCThreadState::joinThreadPool(bool)+387) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #03 pc 000000000002f50a  /apex/com.android.art/bin/artd (main+298) (BuildId: 43c560d33acb3337b302cd319cebe97d)
          #04 pc 0000000000054849  /apex/com.android.runtime/lib64/bionic/libc.so (__libc_init+89) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
      
      "binder:4128_1" sysTid=4129
          #00 pc 00000000000b9cb7  /apex/com.android.runtime/lib64/bionic/libc.so (__ioctl+7) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #01 pc 000000000006da28  /apex/com.android.runtime/lib64/bionic/libc.so (ioctl+216) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #02 pc 0000000000052ca3  /system/lib64/libbinder.so (android::IPCThreadState::joinThreadPool(bool)+387) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #03 pc 0000000000052b17  /system/lib64/libbinder.so (android::PoolThread::threadLoop()+23) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #04 pc 000000000001203c  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+172) (BuildId: b8bf1426d779a8f2a60ce8204bece8a6)
          #05 pc 00000000000cd10d  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+61) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #06 pc 0000000000065908  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+56) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
      
      "binder:4128_3" sysTid=4130
          #00 pc 00000000000bad9a  /apex/com.android.runtime/lib64/bionic/libc.so (__ppoll+10) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #01 pc 00000000000700aa  /apex/com.android.runtime/lib64/bionic/libc.so (poll+74) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #02 pc 00000000007cd03f  /apex/com.android.art/lib64/libart.so (art::ExecUtils::ExecAndReturnResult(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, int, art::ExecCallbacks const&, art::ProcessStat*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) const+1023) (BuildId: 39776b6cc45d1261149d0c2ad9d710fb)
          #03 pc 0000000000011f46  /apex/com.android.art/bin/artd (art::artd::Artd::ExecAndReturnCode(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, int, art::ExecCallbacks const&, art::ProcessStat*) const+86) (BuildId: 43c560d33acb3337b302cd319cebe97d)
          #04 pc 000000000001a3aa  /apex/com.android.art/bin/artd (art::artd::Artd::dexopt(aidl::com::android::server::art::OutputArtifacts const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::optional<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::optional<aidl::com::android::server::art::ProfilePath> const&, std::__1::optional<aidl::com::android::server::art::VdexPath> const&, std::__1::optional<aidl::com::android::server::art::DexMetadataPath> const&, aidl::com::android::server::art::PriorityClass, aidl::com::android::server::art::DexoptOptions const&, std::__1::shared_ptr<aidl::com::android::server::art::IArtdCancellationSignal> const&, aidl::com::android::server::art::ArtdDexoptResult*)+10170) (BuildId: 43c560d33acb3337b302cd319cebe97d)
          #05 pc 0000000000031b51  /apex/com.android.art/bin/artd (aidl::com::android::server::art::_aidl_com_android_server_art_IArtd_onTransact(AIBinder*, unsigned int, AParcel const*, AParcel*)+8177) (BuildId: 43c560d33acb3337b302cd319cebe97d)
          #06 pc 000000000000f599  /system/lib64/libbinder_ndk.so (ABBinder::onTransact(unsigned int, android::Parcel const&, android::Parcel*, unsigned int)+153) (BuildId: 2ebbee0172e872576631eb65e2b6c181)
          #07 pc 00000000000544d5  /system/lib64/libbinder.so (android::IPCThreadState::executeCommand(int)+2101) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #08 pc 0000000000052df3  /system/lib64/libbinder.so (android::IPCThreadState::joinThreadPool(bool)+723) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #09 pc 0000000000052b17  /system/lib64/libbinder.so (android::PoolThread::threadLoop()+23) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #10 pc 000000000001203c  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+172) (BuildId: b8bf1426d779a8f2a60ce8204bece8a6)
          #11 pc 00000000000cd10d  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+61) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #12 pc 0000000000065908  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+56) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
      
      "binder:4128_4" sysTid=4131
          #00 pc 00000000000b9cb7  /apex/com.android.runtime/lib64/bionic/libc.so (__ioctl+7) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #01 pc 000000000006da28  /apex/com.android.runtime/lib64/bionic/libc.so (ioctl+216) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #02 pc 0000000000052ca3  /system/lib64/libbinder.so (android::IPCThreadState::joinThreadPool(bool)+387) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #03 pc 0000000000052b17  /system/lib64/libbinder.so (android::PoolThread::threadLoop()+23) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #04 pc 000000000001203c  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+172) (BuildId: b8bf1426d779a8f2a60ce8204bece8a6)
          #05 pc 00000000000cd10d  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+61) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #06 pc 0000000000065908  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+56) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
      
      "binder:4128_5" sysTid=4138
          #00 pc 00000000000b9cb7  /apex/com.android.runtime/lib64/bionic/libc.so (__ioctl+7) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #01 pc 000000000006da28  /apex/com.android.runtime/lib64/bionic/libc.so (ioctl+216) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #02 pc 0000000000052ca3  /system/lib64/libbinder.so (android::IPCThreadState::joinThreadPool(bool)+387) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #03 pc 0000000000052b17  /system/lib64/libbinder.so (android::PoolThread::threadLoop()+23) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #04 pc 000000000001203c  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+172) (BuildId: b8bf1426d779a8f2a60ce8204bece8a6)
          #05 pc 00000000000cd10d  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+61) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #06 pc 0000000000065908  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+56) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
      
      "binder:4128_6" sysTid=4805
          #00 pc 00000000000b9cb7  /apex/com.android.runtime/lib64/bionic/libc.so (__ioctl+7) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #01 pc 000000000006da28  /apex/com.android.runtime/lib64/bionic/libc.so (ioctl+216) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #02 pc 0000000000052ca3  /system/lib64/libbinder.so (android::IPCThreadState::joinThreadPool(bool)+387) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #03 pc 0000000000052b17  /system/lib64/libbinder.so (android::PoolThread::threadLoop()+23) (BuildId: 9f6a60ab11b30ccf6f5da556bd220e83)
          #04 pc 000000000001203c  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+172) (BuildId: b8bf1426d779a8f2a60ce8204bece8a6)
          #05 pc 00000000000cd10d  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+61) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
          #06 pc 0000000000065908  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+56) (BuildId: 08fd2ddc7d888694af44cabfe6deb067)
      
      ----- end 4128 -----
      
      ----- Waiting Channels: pid 4128 at 2023-12-13 15:25:30.707452768+0000 -----
      Cmd line: /apex/com.android.art/bin/artd
      
      sysTid=4128      binder_ioctl_write_read
      sysTid=4129      binder_ioctl_write_read
      sysTid=4130      do_sys_poll
      sysTid=4131      binder_ioctl_write_read
      sysTid=4138      binder_ioctl_write_read
      
      ----- end 4128 -----
      
      Bug: 314171605
      Change-Id: Ic6976b825faa383620ae045503f2137d1151fdcd
      Test: -
        1. Trigger artd and keep it running
        2. adb shell am hang
        3. check the file in /data/anr
      6cf321c5
    • Dmitrii Ishcheikin's avatar
      Update dirty-image-objects · e5646daf
      Dmitrii Ishcheikin authored
      Use new format which allows to specify dirty objects (as opposed to only
      dirty classes) and supports object sorting.
      
      Test: m
      Bug: 314961378
      Change-Id: Ie06539054387f3541fd7cbd63247443fba1d1ca4
      e5646daf
    • beiyifb's avatar
      Do not kill ANR-ed debugged application · f1e3a6d6
      beiyifb authored
      Test: adb shell am set-debug-app --persistent <package> Observe that debugged app is not killed during stepping.
      Change-Id: I7a16a38cecbdf386bac04a4eda1680dd0dca6221
      f1e3a6d6
    • liuran5's avatar
      Update dumpsys info. · 94008dd7
      liuran5 authored
      
      Bug:316102422
      
      Change-Id: I6d9094d79729f079e31a0a1bcd8033d7473ccef2
      Signed-off-by: default avatarliuran5 <liuran5@xiaomi.corp-partner.google.com>
      94008dd7
    • Treehugger Robot's avatar
      75e8f4f9
    • Eric Biggers's avatar
      Don't show "unified challenge" for profile with non-shareable credential · f58dbdaa
      Eric Biggers authored
      The terms "unified challenge" and "separate challenge" apply only in the
      context of a profile whose credential is shareable with its parent.  It
      is possible for a profile's credential to not be shareable with its
      parent.  Update TrustManagerService's dump method to not show "profile
      with unified challenge" for such profiles.  To make this possible, also
      add a new method LockPatternUtils#isProfileWithUnifiedChallenge().
      
      Bug: 296464083
      Test: dumpsys trust
      Flag: exempt, just changes dumpsys
      Change-Id: I52a5c68633b3be969863c10cd1740f700af9cc07
      f58dbdaa
    • Hans Boehm's avatar
    • Shaju Mathew's avatar
      Removed unused counter. · 829141cd
      Shaju Mathew authored
      Test: Treehugger
      Change-Id: I432ad0335f97604b9ca01a7fbbea541534badc27
      829141cd
  4. Dec 12, 2023
    • Eric Biggers's avatar
      locksettings: clean up references to managed profiles · 6a2770b9
      Eric Biggers authored
      Clean up some code (comments, method names, class names) in
      LockSettingsService that referred to managed profiles (or work profiles,
      which are the same thing as managed profiles), when they really meant
      any profile with unified challenge.  Originally only managed profiles
      supported unified challenge, so this code was fine originally.  But now
      "clone profiles" support unified challenge too.  There's also a plan to
      add another profile type that supports unified challenge.
      
      Bug: 214355283
      Test: atest com.android.server.locksettings
      Flag: exempt, mechanical refactoring
      Change-Id: Ica472482983de13a19fcd9da966273e8d2e974ad
      6a2770b9
    • Eric Biggers's avatar
      Sync tieProfileLockIfNecessary() with internal main · ada6ce94
      Eric Biggers authored
      The internal-first commit ab75d2ce (http://ag/23150174) modified
      tieProfileLockIfNecessary(), which is now causing conflicts.  As the
      modification to tieProfileLockIfNecessary() (which simply made it not
      crash when called with a profile that does not have a parent) does not
      depend on the rest of the change, cherry-pick it separately.
      
      Test: atest com.android.server.locksettings
      Merged-In: Ib0e4e52c10f0e95913ddfde606d6995de3538f27
      Change-Id: I323811363d8801d4f0bc84f241ad042f45bb3358
      ada6ce94
Loading