Skip to content
Snippets Groups Projects
  1. Jun 05, 2024
  2. Jun 04, 2024
    • Pawan Wagh's avatar
      Combine ZipFileRO::getEntryInfo · fbe2bd37
      Pawan Wagh authored
      Removing getEntryInfo which doesn't contain extra field size
      and fixing the usage.
      
      Test: mma libandroidfw
      Bug: 334109171
      Change-Id: Id5c8a5405265e6964f5b56b253430eb7c49cdc02
      fbe2bd37
  3. May 30, 2024
    • Zhenhua Deng's avatar
      Fix register homeTransitionListener with empty Transitions · 2b164e1d
      Zhenhua Deng authored
      Sometimes Luancher frequently register homeTransitionListener
      while OverviewProxyService connect/desconnect, if Sysui also slow
      response it may cause setHomeTransitionListener delayed with invalidate
      Transitions.
      
      Bug: 343098476
      Test: auto monkey test
      
      Change-Id: I750d25f81f210373662b05fa9468585e47c4ed44
      2b164e1d
  4. May 21, 2024
  5. May 03, 2024
    • Oriol Prieto Gasco's avatar
      RESTRICT AUTOMERGE · 7b816129
      Oriol Prieto Gasco authored
      Set the container field of aconfig flags
      
      Test: printflags --format='{package}:{container}:' | grep "::"
      Bug: 312769710
      Flag: NONE
      Change-Id: I84fda0d5e9813940609436d825738ff786908ff0
      7b816129
  6. Apr 29, 2024
    • Akshata Kadam's avatar
      Updated fuzz_config in Android.bp file · a79348a4
      Akshata Kadam authored
      Added new fields in fuzz_config like - componentid,
      description, vector, service_privilege, users, fuzzed_code_usage, etc.
      
      Bug: 306435930
      Test: Build resourcefile_fuzzer
      
      Change-Id: I8ba363d214ab0b2e663ded2a2d24745faf5b909f
      a79348a4
  7. Apr 26, 2024
  8. Apr 23, 2024
    • Ryan Prichard's avatar
      hwui: add missing <mutex> include · bc3bf5b0
      Ryan Prichard authored
      Upgrading to clang-r522817's new libc++ requires that <mutex> be
      included here.
      
      Bug: 333165689
      Test: treehugger
      Flag: EXEMPT, fix build error
      Change-Id: I14ff396b21feb4b569a3c8d967c8295a04005beb
      bc3bf5b0
  9. Apr 14, 2024
  10. Apr 12, 2024
    • Pawan Wagh's avatar
      Add Extra field info in ZipFileRO · cb47bdac
      Pawan Wagh authored
      Adding extra field size info in ZipFileRO.
      Adding a new method for backward compatability.
      
      Test: m libandroidfw
      Bug: 301631861
      Change-Id: I55992c50f7db212fdf78a8708ac5dee6af66d83c
      cb47bdac
  11. Apr 11, 2024
  12. Apr 04, 2024
  13. Apr 03, 2024
  14. Mar 13, 2024
    • Aditya Kumar's avatar
      Provide a complete definition of FileBlobCache · 9feca01f
      Aditya Kumar authored
      ```
      In file included from external/libcxx/include/algorithm:644:
      external/libcxx/include/memory:2335:19: error: invalid application of 'sizeof' to an incomplete type 'android::FileBlobCache'
       2335 |     static_assert(sizeof(_Tp) > 0,
            |                   ^~~~~~~~~~~
      external/libcxx/include/memory:2652:7: note: in instantiation of member function 'std::default_delete<android::FileBlobCache>::operator()' requested here
       2652 |       __ptr_.second()(__tmp);
            |       ^
      external/libcxx/include/memory:2606:19: note: in instantiation of member function 'std::unique_ptr<android::FileBlobCache>::reset' requested here
       2606 |   ~unique_ptr() { reset(); }
            |                   ^
      frameworks/base/libs/hwui/pipeline/skia/ShaderCache.h:40:7: note: in instantiation of member function 'std::unique_ptr<android::FileBlobCache>::~unique_ptr' requested here
         40 | class ShaderCache : public GrContextOptions::PersistentCache {
            |       ^
      frameworks/base/libs/hwui/pipeline/skia/ShaderCache.h:35:7: note: forward declaration of 'android::FileBlobCache'
         35 | class FileBlobCache;
            |       ^
      1 error generated.
      ```
      
      Test: Build
      Fixes: b/328705924
      Change-Id: I6396f5fafef1941201c05d0b107f48e6d28a6631
      9feca01f
  15. Mar 06, 2024
    • Hamzeh Zawawy's avatar
      Adding fuzzer ResXMLTree · 1532fa75
      Hamzeh Zawawy authored
      Bug: 328272470
      Test: m resxmlparser_fuzzer and then run binary
      Change-Id: I389abf4f8cfb534c354b9846293c5b583987f4e2
      1532fa75
  16. Mar 04, 2024
    • Isak Lilja's avatar
      Don't add StageChangeRecord when stage task moves to back · 03c1e23c
      Isak Lilja authored
      We would add a StageChangeRecord for a closing task even when the task
      transition change was TRANSIT_TO_BACK. When both of the split stages had
      one child task each nothing would happen, but if one of the stages had
      two child tasks we would enter logic that assumed that one of stages was
      closed. This change adds a StageChangeRecord for a closing task only
      when the transition mode is TRANSIT_CLOSE.
      
      Bug: 314688953
      Test: atest WMShellUnitTests
      Test: Open Gmail and Chrome in split, go to the compose-email screen in
            Gmail, receive call, answer and hang up the call, observe that
            Gmail and Chrome are still paired.
      Change-Id: I8ee6c078bd8a1816a96a9515b1a50e652de70d1c
      03c1e23c
  17. Feb 05, 2024
    • Liangliang Sui's avatar
      Reduce some redundant steps · 6a74777a
      Liangliang Sui authored
      
      1. When |frame->pendingDirty.isEmpty()| is executed there, it must not be empty. Because the judgment has been made at the beginning of the applyRenderNodeTransform method.
      
      2. When |dirty->isEmpty()|, |dirty->setIWH(frame.width(), frame.height());| can be returned directly after execution. There is no need to judge bufferAge, and subsequent steps are redundant. Because the maximum range of dirty is [0, 0, frame.width(), frame.height()]
      
      Change-Id: Iccb3d39e4139c26ed5e7e24c39d1e141cb380dab
      Signed-off-by: default avatarLiangliang Sui <coolsui.coding@gmail.com>
      6a74777a
  18. Jan 25, 2024
    • Jihoon Kang's avatar
      Remove java_api_contribution modules from .bp files · 6aadcb64
      Jihoon Kang authored
      java_api_contribution modules are dynamically generated from droidstubs
      modules or java_sdk_library_import, and is not a user-facing module.
      Defining this module is a .bp file is a no-op.
      
      Test: m nothing
      Bug: 322242515
      Change-Id: I5a6c925f94017f4f92b6abb0c93079d8c85c3eeb
      6aadcb64
  19. Jan 22, 2024
  20. Jan 18, 2024
    • Jiang Tian's avatar
      Fix crash from asynchronous GPU metrics · 8e6a8468
      Jiang Tian authored
      Making the scope more accurate that only acquire the lock when trying
      to access frame info in FrameInfoVisualizer, then make it irrelevant
      to the real draw operation.
      
      Bug: 317995179
      Test: 1.going to developer options
            2. swapping the "profile hwui" option from "none" to "bars"
                and back a couple times, no crash
      
      Change-Id: I069a28a7e847c0c3fca94fd9c43e95382f501b80
      Merged-In: I069a28a7e847c0c3fca94fd9c43e95382f501b80
      8e6a8468
  21. Dec 28, 2023
  22. Dec 22, 2023
  23. Dec 14, 2023
    • Nick Chameyev's avatar
      [Unfold transition] Take over only physical display changes · d35959f0
      Nick Chameyev authored
      Updates UnfoldTransitionHandler to start unfold
      animation only if physical display has changed.
      We should not start unfold transition when display
      resizes without underlying display change.
      
      Bug: 314252763
      Test: manual unfolds => check that unfold animation plays
      Test: atest UnfoldTransitionHandlerTest
      Test: atest CompatChangeTests
      Change-Id: I46c7859ff042ee7aa9193757e5df8269f4892362
      d35959f0
    • Winson Chung's avatar
      Skip evicting children in certain non-drop cases as well · 4ec08f85
      Winson Chung authored
      - When splitting with an existing split pair task from an app icon
        menu we also need to avoid evicting the children to prevent the same
        race between start activity and eviction in ag/25565608
      
      Fixes: 309905087
      Test: Launch a split pair, Open a new fullscreen app, Use the taskbar
            to split with one of the previously paired tasks
      Change-Id: I76808dfad48951d443593c6d3d284827ba7f2e00
      4ec08f85
    • Winson Chung's avatar
      Hide both pausing and closing tasks when finishing the recents transition · f7921eec
      Winson Chung authored
      - If we try to merge a transition that closes a pausing task, the task
        will be removed from the pausing set, but not actually handled during
        cleanup and may result in the task being visible momentarily between
        reparenting of the task out of the transition leash (applied in the
        shell) and WM committing the visibility of the task
      - When handling a task view transition for a task that going TO_BACK,
        also update the surface visibility if the pending transition is also
        TO_BACK since that is only created when the taskview container's
        surface is destroyed.
      
      Fixes: 310567149
      Test: Repro on the bug
      Change-Id: I1ba72a2f1b2bcd2b56f55d4c288e86ebf3e53d8c
      f7921eec
  24. Dec 12, 2023
    • Vinit Nayak's avatar
      Fix a few split rotation issues when the IME showing · 2de74827
      Vinit Nayak authored
      
      - Fix an issue with the split bounds being wrong upon rotation. The target
        offset is relative to the actual task bounds and not the last y offset,
        so multiple changing IME insets changes in a row when rotating would
        set the window bounds of each task to be wrong, which affects the
        positionInParent of the task (relative to the single split root), which
        then results in the DefaultTransitionHandler positioning the task
        surfaces at the wrong position when the display rotation transition is
        actually played
      - Fix an issue with the divider position being wrong upon rotation. The
        divider position is based on the IME state, but during rotation we can
        get numerous insets changes before the display rotation animation is
        played, so we should not reset the IME state.  In addition, due to races
        between the app/WM and the Shell, there may be no insets changes after
        the display transition is played, so we need to manually update the
        surface position after recreating the divider surface
      - Restore handle view visibility & interactive state after recreating the
        divider view upon rotation
      
      Flag: None
      Test: Repeatedly rotate the device with the IME showing
      Test: atest WMShellUnitTests
      Bug: 299581029
      Change-Id: Id43c388a27ae3be117857688f1ffd73a86bdea30
      Signed-off-by: default avatarWinson Chung <winsonc@google.com>
      2de74827
    • Prabir Pradhan's avatar
      Pointer Icon Refactor: Update PointerController tests · 6c7aa6f2
      Prabir Pradhan authored
      When PointerChoreographer is enabled, the PointerControllers are used in
      a different way, where the presentation mode is set once and never
      changed. This should be reflected in the tests.
      
      When the flag is enabled, ensure that the tests call the APIs in the
      expected manner.
      
      Bug: 293587049
      Bug: 315538661
      Test: atest libinputservice_test
      Change-Id: I24205c4c02484c4a28946c152a2c507bfc371b8e
      6c7aa6f2
    • Ivan Tkachenko's avatar
      Add code owners for desktop · 5b1cdf39
      Ivan Tkachenko authored
      Bug: 315483862
      Change-Id: I501547e1b78ac6e95bb058ea83e33004738f0fc9
      5b1cdf39
  25. Dec 11, 2023
  26. Dec 09, 2023
  27. Dec 08, 2023
    • Ikram Gabiyev's avatar
      Reset the pip icon overlay scale and offset · 9ce08994
      Ikram Gabiyev authored
      Make sure we properly reset the scale and offset
      of the content overlay for PiP, as we reset the task scale
      and set a new crop.
      
      We also need to use different bounds to make overlay
      calulations if in fixed rotation.
      
      Test: swipe up to enter PiP with srcRectHint=null
      Bug: 314010733
      
      Change-Id: I38a465009497a60685f7bab73ddae2f389c4451f
      9ce08994
    • Mateusz Cicheński's avatar
      Hold the reference to overlay in PipTaskOrganizer. · 164e18bc
      Mateusz Cicheński authored
      The animator can finish before the overlay is being removed, so we need
      to keep a reference in PipTaskOrganizer and use it there for fade out.
      
      Previously the overlay leash was removed at animation end, causing it
      to be removed abruptly without smooth animation.
      
      Note that the animation progress from transition is used to update the
      state of the overlay, the fractional fade in is synchronized with it.
      
      Bug: 308003114
      Test: before http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/bxJIJ3g282Hl5wriD3HE6F
      Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/hG1H7edsQoUGkrq3WoLhsN
      Flag: none
      
      Change-Id: I12589c9699d2e2b6af17875f9bc32ba7f47c6365
      164e18bc
    • Ats Jenk's avatar
      Null safe BubbleBarAnimationHelper · 61bc09ac
      Ats Jenk authored
      Refactor bubble bar expanded view access in BubbleBarAnimationHelper.
      Unify the null checks for the expanded bubble and expanded view. So we
      don't have to keep checking for both.
      
      Bug: 283991264
      Test: open/close bubble bar bubble
      Change-Id: I8d8bb16729dd2175d31b621ff1b7e2a6730db6ec
      61bc09ac
    • Winson Chung's avatar
      Add home task container overlay · e268f3fb
      Winson Chung authored
      Test: Verified the flow in Launcher
      Bug: 273828110
      Change-Id: Idba36284b6030070d2f650fdb50a93215b5d9dbf
      e268f3fb
    • Graciela Wissen Putri's avatar
      Revert^2 "Disable user aspect ratio button if app not launchable" · 51c48c55
      Graciela Wissen Putri authored
      We exclude apps that do not have launchable activities in Settings >
      Apps > Aspect ratio (experimental), so we should not show user aspect
      ratio button in apps that do not have a launcher category.
      
      This will remove button from showing in DeviceAsWebcam and Android Auto
      transparent activity pop-up.
      
      Bug: 308391262
      Test: atest UserAspectRatioSettingsWindowManagerTest
            Steps in b/309377965 & b/309370256
      Change-Id: I620bd2c7c8154dff42ce59fba81b109fcba447ac
      51c48c55
    • Pascal Muetschard's avatar
      Some code cleanup of InteractionJankMonitor. · 6c8bd65c
      Pascal Muetschard authored
      - Move the CUJ constant related stuff to its own class
      - Remove the Session class
      - Separation of IJM and FT via event listener, breaking the dep loop
      - Fix (unlikely) race problems in begin/cancel/end
      - Trim out some unused stuff
      - Remove some duplicated stuff (like config validation)
      - Remove checks ensured by tests
      - Fix a bunch of warnings
      - Fix missing locks in debug overlay
      - Remove the outdated DEBUG mechanism
      
      Test: atest com.android.internal.jank
      Flag: NA
      Change-Id: I29b9da107313d4c07777ce50ce907c7516258807
      6c8bd65c
    • Shan Huang's avatar
      Delay onBackStarted() until the pointer is pilfered. · b0980cb3
      Shan Huang authored
      This only delays the dispatching of the start event. We still start back navigation as early as the first MOVE, to allow more time to receive back navigation info and avoid jank.
      
      Bug: 308550613
      Bug: 301195601
      Test: atest OnBackInvokedCallbackGestureTest
      Test: atest BackAnimationControllerTest
      Flag: NONE
      
      Change-Id: I0802fd716dc5dbce7071e083bd373df5c5ddcc4c
      b0980cb3
Loading