- May 30, 2024
-
-
Zhenhua Deng authored
Sometimes Luancher frequently register homeTransitionListener while OverviewProxyService connect/desconnect, if Sysui also slow response it may cause setHomeTransitionListener delayed with invalidate Transitions. Bug: 343098476 Test: auto monkey test Change-Id: I750d25f81f210373662b05fa9468585e47c4ed44
-
- May 21, 2024
-
-
Julien Desprez authored
This will allow to build them more effectively. This has no impact on the test execution itself. Change-Id: Iac18defcb13e7c3d4ad9845bffcda04766dd06a8 Test: presubmit Bug: 341947105
-
- May 03, 2024
-
-
Oriol Prieto Gasco authored
Set the container field of aconfig flags Test: printflags --format='{package}:{container}:' | grep "::" Bug: 312769710 Flag: NONE Change-Id: I84fda0d5e9813940609436d825738ff786908ff0
-
- Apr 29, 2024
-
-
Akshata Kadam authored
Added new fields in fuzz_config like - componentid, description, vector, service_privilege, users, fuzzed_code_usage, etc. Bug: 306435930 Test: Build resourcefile_fuzzer Change-Id: I8ba363d214ab0b2e663ded2a2d24745faf5b909f
-
- Apr 26, 2024
-
-
Mykola Podolian authored
Change-Id: If2297ae7402a2eefee6ab0b5051dbf18e51af91f
-
- Apr 23, 2024
-
-
Ryan Prichard authored
Upgrading to clang-r522817's new libc++ requires that <mutex> be included here. Bug: 333165689 Test: treehugger Flag: EXEMPT, fix build error Change-Id: I14ff396b21feb4b569a3c8d967c8295a04005beb
-
- Apr 14, 2024
-
-
Owner Cleanup Bot authored
This suggested change is automatically generated based on group memberships and affiliations. If this change is unnecessary or in error, vote CR -1 and the bot will abandon it. Vote CR +1/2 to approve this change. See the owner's recent activity for context: https://android-review.googlesource.com/q/mateuszc@google.com To report an issue, file a bug in the Infra>Codereview component. Change-Id: Ib26a249322046e0f01f0dc52530b1b3055c5ad00
-
Owner Cleanup Bot authored
This suggested change is automatically generated based on group memberships and affiliations. If this change is unnecessary or in error, vote CR -1 and the bot will abandon it. Vote CR +1/2 to approve this change. See the owner's recent activity for context: https://android-review.googlesource.com/q/mateuszc@google.com To report an issue, file a bug in the Infra>Codereview component. Change-Id: I8fabcabc95d18c52507f28fb103ea6ab262a088d
-
- Apr 12, 2024
-
-
Pawan Wagh authored
Adding extra field size info in ZipFileRO. Adding a new method for backward compatability. Test: m libandroidfw Bug: 301631861 Change-Id: I55992c50f7db212fdf78a8708ac5dee6af66d83c
-
- Apr 11, 2024
-
-
Pawan Wagh authored
Test: m libandroidfw Bug: 301631861 Change-Id: If6d0ddf6e3465f984209325406cfeaffc44f9d6a
-
- Apr 04, 2024
-
-
Mykola Podolian authored
Change-Id: I9b5bcf0d9971ea26eeb2858cf2102d622a506c81
-
- Apr 03, 2024
-
-
Elliott Hughes authored
I couldn't understand on https://issuetracker.google.com/273841150 why we saw a file truncation failure error message followed by a claim that ExtractToMemory() had failed, when only ExtractToFile() should be doing anything with files... Change-Id: Ic3b2c8b390a7b9f7a2e5c8b229b55c46acf6638e
-
- Mar 13, 2024
-
-
Aditya Kumar authored
``` In file included from external/libcxx/include/algorithm:644: external/libcxx/include/memory:2335:19: error: invalid application of 'sizeof' to an incomplete type 'android::FileBlobCache' 2335 | static_assert(sizeof(_Tp) > 0, | ^~~~~~~~~~~ external/libcxx/include/memory:2652:7: note: in instantiation of member function 'std::default_delete<android::FileBlobCache>::operator()' requested here 2652 | __ptr_.second()(__tmp); | ^ external/libcxx/include/memory:2606:19: note: in instantiation of member function 'std::unique_ptr<android::FileBlobCache>::reset' requested here 2606 | ~unique_ptr() { reset(); } | ^ frameworks/base/libs/hwui/pipeline/skia/ShaderCache.h:40:7: note: in instantiation of member function 'std::unique_ptr<android::FileBlobCache>::~unique_ptr' requested here 40 | class ShaderCache : public GrContextOptions::PersistentCache { | ^ frameworks/base/libs/hwui/pipeline/skia/ShaderCache.h:35:7: note: forward declaration of 'android::FileBlobCache' 35 | class FileBlobCache; | ^ 1 error generated. ``` Test: Build Fixes: b/328705924 Change-Id: I6396f5fafef1941201c05d0b107f48e6d28a6631
-
- Mar 06, 2024
-
-
Hamzeh Zawawy authored
Bug: 328272470 Test: m resxmlparser_fuzzer and then run binary Change-Id: I389abf4f8cfb534c354b9846293c5b583987f4e2
-
- Mar 04, 2024
-
-
Vinit Nayak authored
Change-Id: I6ff04ec54eab7789bf46a360e8d587ff51ef6d62
-
Jerome Gaillard authored
Bug: 322360037 Test: host build of libhwui Change-Id: Ic4d3c35180a188d460cd7006d02e725794324d69
-
Jerome Gaillard authored
This requires creating a host version of nativedisplay/ADisplay.cpp and putting it in libhostgraphics. Bug: 322360037 Test: host build of libhwui Change-Id: I75a14ce4dd417ef7ff5983beb0c1397f14c279e5
-
Isak Lilja authored
We would add a StageChangeRecord for a closing task even when the task transition change was TRANSIT_TO_BACK. When both of the split stages had one child task each nothing would happen, but if one of the stages had two child tasks we would enter logic that assumed that one of stages was closed. This change adds a StageChangeRecord for a closing task only when the transition mode is TRANSIT_CLOSE. Bug: 314688953 Test: atest WMShellUnitTests Test: Open Gmail and Chrome in split, go to the compose-email screen in Gmail, receive call, answer and hang up the call, observe that Gmail and Chrome are still paired. Change-Id: I8ee6c078bd8a1816a96a9515b1a50e652de70d1c
-
Louis Chang authored
by API review feedbacks Bug: 324092846 Test: wm presubmit Change-Id: Ifff698ef6c09823b36aedfc298e5bf8d040a1de7
-
- Mar 01, 2024
-
-
Winson Chung authored
- One possible flow for this: 1) play a pending split resize animation with a transition that includes a snapshot -> this creates a SplitDecorManager animation which directly animates the snapshot leash 2) have another resize which triggers setup of a new pending resize animation -> this cancels the current animation which cleans up/ releases the existing transition's surfaces, but nothing notifies SplitDecorManager, so that animation continues to play 3) Next frame comes in, SplitDecorManager's animation tries to update the surface that has already been released -> crash - This change just cancels any existing animations (which will remove the decor) before creating a new pending resize animation and finishing the previous transition Fixes: 325306101 Test: Presubmit (not reproducible) Change-Id: Id77f02871bfd684e8dd814b3a38a94e06049e210
-
Jorge Gil authored
1) Remove app name when app is using custom headers 2) Adjust padding/margins to support hiding the app name 3) Add empty drag zone on right-aligned bounding rect 4) Update close button vector, size and padding 5) Update app chip app icon size to 24x24dp Bug: 316387515 Test: enable/disable APPEARANCE_TRANSPARENT_CAPTION_BAR_BACKGROUND flag and observe window header UI updating to allow more custom space and a drag-only area. Change-Id: Ic27b98861521dbcf1253ff7618e8e773bb763988
-
Vinit Nayak authored
* If the split breaks in the background when split is not visible, we don't put any stage on top Test: Tested w/ Camera + Messages, toast and app don't show up if you swipe to home before folding the device Fixes: 323461567 Change-Id: I4ebce1ce795976a1ec61b8e1f35c8840863e4f92
-
Mateusz Cicheński authored
This change simply adds a warning for the app developers and mentions that this behavior might change in future releases. Bug: 298529550 Bug: 326989052 Test: both log messages show for wide aspect ratio videos Test: example of why animation is bad in those cases http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/haMvMxYpHcxiNt9gkAbGbP Flag: none Change-Id: I5193a1d19d86e2ec4456d1366433e7316b469e22
-
- Feb 29, 2024
-
-
Maryam Dehaini authored
Updates onHover maximize menu logic so that the menu only closes if the maximize menu or the maximize window button are completely exited. Bug: 327677202 Test: Manual Testing Change-Id: I95485a3bd9579539765cde274a324404bafd8e13
-
Jeremy Sim authored
This CL makes it so that DividerSnapAlgorithm.setDivideRatio() sets the middle position as a fallback when trying to fetch a non-existent snap target, instead of crashing. The issue arose because it is possible to have a 30-70 split in Overview, then rotate to landscape, where 30-70 splits are not supported. Trying to launch the pair then resulted in a crash. This change matches the behavior we already have when rotating a fullscreen 30-70 split to landscape, which is that the 30-70 split automatically converts to a 50-50 split. Fixes: 326336840 Flag: N/A Test: Does not crash anymore. Change-Id: I68072c2816d5f6cf3a178b0f8def27cdc564d5d7
-
Yurii Zubrytskyi authored
The most common operation when getting a new Resources object is checking if all apks and overlays are still up to date to reuse the cached object. It makes sense to optimize it by excluding the file by path lookups and instead keeping an open FD to the file in the cache + Make IsFabricatedOverlay() more efficient via a name check and string_view where possible Bug: 282215580 Test: build + boot + presubmit Change-Id: Ib1ab20cba359c2195a72dd2e10096883d95b4453
-
Liran Binyamin authored
Test: atest WMShellMultivalentTestsOnDevice Test: atest WMShellRobolectricTests Bug: 308004028 Change-Id: I384ae5afd57c020f098046a0b204fd2bb4123ef8
-
Jerome Gaillard authored
Host builds now support RenderThread. Bug: 322360037 Test: host build of libhwui Change-Id: Idfc96eb2dc36b7c267fbce0a06d9f82dc7d66031
-
Jerome Gaillard authored
This adds to the host build of layoutlib files that straightforwardly compile. Bug: 322360037 Test: host build of libhwui Change-Id: Idc1dc36b21c256dc35173287967c9b4b44a6bd8d
-
- Feb 28, 2024
-
-
Jorge Gil authored
Make the caption window in Desktop Mode a spy window when the transparent caption flag is requested. Then, when MotionEvents on the caption bar, issue cancellations if the gesture did not start within the bounds of the customizable space and the gesture exclusion bounds reported by the window. This allows input to fall through uncancelled to customizable app content as long as they've placed it in non-occluding caption regions and they requested to take over input in that region. Otherwise, the system will handle the events as a caption gesture (drag, double-tap, etc). Other window decoration types (app handle, non-desktop freeform caption) do not support this feature, so their caption window is not spy. Bug: 316387515 Test: atest WMShellUnitTests Change-Id: Ibb966a15fa3befe1f1dec802e448a973671ac645
-
Winson Chung authored
- This gives slightly more detailed info about what's happening w/ split Bug: 280494204 Test: Presubmit Change-Id: I5bf1f478946522e4844010715287e71cb2cbec2d Signed-off-by:
Winson Chung <winsonc@google.com>
-
Cosmin Băieș authored
Created an empty ImeTracker.Token instance for testing, and added more reasons to handle IME flows previously missed from tracking. Test: atest InputMethodStatsTest ImeInsetsSourceConsumerTest InputMethodManagerServiceWindowGainedFocusTest DefaultImeVisibilityApplierTest ImeVisibilityStateComputerTest#testOnApplyImeVisibilityFromComputer Bug: 271426908 Change-Id: Idfa8dabf16d0bcd43ff0c0d64affb2e5f923f44b
-
Pablo Gamito authored
Needed to create a new flag because we can't set flag to readonly once created Bug: 276432490 Test: mp droid Change-Id: I45598a8e91d8959fd957dc23af20c7817ebc31fe
-
Orhan Uysal authored
Create necessary hooks for desktop to fullscreen keyboard shortcut. Since both desktop to fullscreen and split to fullscreen will be using the same keyboard shortcut combine both on the StatusBarManager side as moveFocusedTasktoFullscreen. Test: atest DesktopTasksController Test: Manually trigger the shortcut to move from desktop to fullscreen Test: Manually trigger the shortcut to move from split to fullscreen Bug: 326061209 Flag: ACONFIG com.android.wm.shell.enable_desktop_windowing DEVELOPMENT Change-Id: Ic5f8af23f55e30c971c115a20960f7336beb8629
-
Winson Chung authored
- Extend support for launching intent drags into splitscreen in addition to crafted app drags sourced from SystemUI - Unlike app drag drags which are consumed for the whole display, intent drags only invoke split from the side edges of the screen, so we need to manipulate the touchable region of the shell drop target based on the drag data in the current drag session This reverts commit 41dc803ab1e79305304b3ad67e0ef8e35c33332e. Bug: 320797628 Test: atest WMShellUnitTests Test: https://recall.googleplex.com/projects/e3f080d7-2818-43f0-a087-405000b8fdf5/sessions/e88a0470-6850-43a0-abfa-3366b7c7c6a4 Change-Id: I3c0946ae06ae03c21c189c1df1dba3d47db77eb9
-
Surajit Chandra authored
This reverts commit 89848002. Reason for revert: Test revert b/327296571 Change-Id: I9c0dd0c333cb4b3f67d27aa78cd0d02d61af79b7
-
- Feb 27, 2024
-
-
Mateusz Cicheński authored
This is done by asserting on the center point of the PiP window, since in the fixed rotation case the full PiP bounds can temporarily go outside of screen bounds, as it is resizing from landscape fullscreen to final PiP size. The transition also involves rotating the display, which is why we have to first assert against starting bounds in landscape, and then check against the portrait bounds at the end of the transition. At that point we are asserting full PiP bounds though, as it is expected to be fully inside the display bounds. Test: atest EnterPipToOtherOrientation Bug: 275092905 Flag: none Change-Id: I87f42c9c96e5a01c8aff44c6c44a06fb9d29c2de
-
mattsziklay authored
The desktop mode touch handler would consume ACTION_DOWN input events if they occur in app pill / maximize / close buttons, preventing them from displaying ripple effects. This CL changes the touch handler and buttons themselves to prevent these events from being consumed while leaving other functionality (double tap, drag, long press) in tact. Because there are less input events being consumed, this CL removes variables mShouldClick and shouldLongClick as we can now allow the listener itself to determine these events. Bug: 316194617 Test: Manual Change-Id: I07a80d7952bfcc7e01d18449282e4339b0fcd6bb
-
Winson Chung authored
- Extend support for launching intent drags into splitscreen in addition to crafted app drags sourced from SystemUI - Unlike app drag drags which are consumed for the whole display, intent drags only invoke split from the side edges of the screen, so we need to manipulate the touchable region of the shell drop target based on the drag data in the current drag session Bug: 320797628 Test: atest WMShellUnitTests Test: https://recall.googleplex.com/projects/e3f080d7-2818-43f0-a087-405000b8fdf5/sessions/e88a0470-6850-43a0-abfa-3366b7c7c6a4 Change-Id: I04ddf3b463b446d2c688abed44e75fbd7f2110e1
-
Orhan Uysal authored
On split to desktop transition, we remove the leftover split screen task. This shouldn't be done for 2 reasons: 1) StageCoordinater already reparents the task on exit, so we shouldn't need to close it. 2) removeTask() removes the task from recents as well. Expected behaviour is that the leftover split task is moved to recents. Test: Move from split to desktop using the handle/menu/keyboard shortcut. Leftover split app is still in recents. Bug: 326043729 Change-Id: Ie0414f7672f244260c975120ce27f473d0676527
-