Skip to content
Snippets Groups Projects
  1. Oct 27, 2023
    • Prashanth Swaminathan's avatar
      Set child process name with child zygote args · 4651c3f8
      Prashanth Swaminathan authored
      When forking zygote processes, 'forkSimpleApps' may process multiple
      simple apps in the command buffer at once. However, the parsed zygote
      arguments are computed based on the first app in the command buffer,
      which can lead to all launched processes being assigned the same name.
      
      Move the setting of the child process name into childMain and use the
      arguments from it's local ZygoteArguments for the appropriate name.
      
      Bug: 305970538
      Test: Verified aosp_cf_riscv64_phone correctly uses unique process names
      and PIDs match intended name.
      Change-Id: I0febc49649b0ede4c07898b47b0ebe6ac37e7057
      
      Change-Id: I64b2644ffb8ee75043623222b48fba8f2cfc5f08
      4651c3f8
  2. Oct 24, 2023
  3. Oct 23, 2023
  4. Oct 21, 2023
  5. Oct 20, 2023
    • Sumedh Sen's avatar
      Recycle the original bitmap after scaling down · 99396a46
      Sumedh Sen authored
      This will free the memory used by the original bitmap
      
      Bug: 290862169
      Bug: 304567418
      Test: Manual. Install the APK attached in b/290862169#comment18
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:74d9576bec1fd0f0ef25936eb672b9e733b0e3e7)
      Merged-In: I94f5a9a4313c13375062fdade0e672d51eb5dc55
      Change-Id: I94f5a9a4313c13375062fdade0e672d51eb5dc55
      
      NOTE FOR REVIEWERS - errors occurred while applying the patch.
      PLEASE REVIEW CAREFULLY.
      Errors:
      Error applying patch in packages/PackageInstaller/src/com/android/packageinstaller/PackageUtil.java, hunk HunkHeader[172,7->172,7]: Hunk cannot be applied
      
      Original patch:
       From 74d9576b Mon Sep 17 00:00:00 2001
      From: Sumedh Sen <sumedhsen@google.com>
      Date: Thu, 12 Oct 2023 10:13:35 -0700
      Subject: [PATCH] Recycle the original bitmap after scaling down
      
      This will free the memory used by the original bitmap
      
      Bug: 290862169
      Bug: 304567418
      Test: Manual. Install the APK attached in b/290862169#comment18
      Change-Id: I94f5a9a4313c13375062fdade0e672d51eb5dc55
      ---
      99396a46
    • Sumedh Sen's avatar
      Resize large app icons before adding them in a parcel · df3af7fd
      Sumedh Sen authored
      If an app icon is too large, scale the icon down so that it can be
      parcelled and sent in an intent.
      
      Bug: 290862169
      Bug: 304567418
      Test: Manual. Install the APK attached in b/290862169#comment18
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2fc482f6fd8ba4217a4f9c956dfdb45c6494974e)
      Merged-In: I5feafea491208c8fd6bbdc6b2b655d46b6964d95
      Change-Id: I5feafea491208c8fd6bbdc6b2b655d46b6964d95
      
      
      Original patch:
       From 2fc482f6 Mon Sep 17 00:00:00 2001
      From: Sumedh Sen <sumedhsen@google.com>
      Date: Wed, 11 Oct 2023 12:19:50 -0700
      Subject: [PATCH] Resize large app icons before adding them in a parcel
      
      If an app icon is too large, scale the icon down so that it can be
      parcelled and sent in an intent.
      
      Bug: 290862169
      Bug: 304567418
      Test: Manual. Install the APK attached in b/290862169#comment18
      Change-Id: I5feafea491208c8fd6bbdc6b2b655d46b6964d95
      ---
      df3af7fd
    • Roshan Pius's avatar
    • Sumedh Sen's avatar
      Make AppSnippet parcelable · c1647930
      Sumedh Sen authored
      AppSnippet is used in Pia in 4 activities. Each time, it is expensive to
      parse the app's logo and label from PackageManager and the APK file of
      the app being installed. Thus, lets compute the AppSnippet once and pass
      it as an intent extra to whichever activity needs it.
      
      This also solves the bug where InstallSuccess showed an activity's name
      in place of the app label since the temporary directory used to create
      AppSnippet is already destroyed after app installation.
      
      Bug: 290862169
      Test: Manually install an APK and observe the app install / update
      dialog
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:719d00a979005e1b5919694305b015e1970992d9)
      Merged-In: I2095b092e1a7b3186ff4cdc4c81effce51377b19
      Change-Id: I2095b092e1a7b3186ff4cdc4c81effce51377b19
      
      Original patch:
       From 719d00a9 Mon Sep 17 00:00:00 2001
      From: Sumedh Sen <sumedhsen@google.com>
      Date: Tue, 18 Jul 2023 15:00:59 -0700
      Subject: [PATCH] Make AppSnippet parcelable
      
      AppSnippet is used in Pia in 4 activities. Each time, it is expensive to
      parse the app's logo and label from PackageManager and the APK file of
      the app being installed. Thus, lets compute the AppSnippet once and pass
      it as an intent extra to whichever activity needs it.
      
      This also solves the bug where InstallSuccess showed an activity's name
      in place of the app label since the temporary directory used to create
      AppSnippet is already destroyed after app installation.
      
      Bug: 290862169
      Test: Manually install an APK and observe the app install / update
      dialog
      
      Change-Id: I2095b092e1a7b3186ff4cdc4c81effce51377b19
      ---
      c1647930
    • Eric Biggers's avatar
      Make fix_unlocked_device_required_keys a build-time flag · 747eb019
      Eric Biggers authored
      This flag will need to be accessed from keystore2, which is started
      before the DeviceConfig-based flag infrastructure is available.  Also,
      LockSettingsService in system_server will need to vary its start-up
      behavior depending on this flag, so toggling this flag at runtime won't
      work properly anyway (unless the device is immediately rebooted).
      
      Bug: 296464083
      Test: build
      Change-Id: I22327798e0fe804144bbedb3e57f57b60b85e72a
      747eb019
Loading