- Jan 23, 2024
-
-
Haining Chen authored
Report authentication attempts with PIN/pattern/password from LockSettingsService as the source of truth. Also add a new listener to allow other system components to response to primary auth results Bug: 285053096 Test: m -j Test: atest LockSettingsServiceTests Change-Id: I9115b70742cb724b373c028d8e00d178aa1a8096
-
Haining Chen authored
Bug: 285053096 Test: builds Change-Id: I1912b8ada49aa22f1bcad4dd252368a3f95bbed1
-
- Jan 22, 2024
-
-
Kangping Dong authored
Add this permission for Thread user restrictions control. See go/ae-v-thread-admin-control Bug: 319198393 Merged-In: Ie8393cf876435a3ffb77a4b27bcf419b529fd785 Change-Id: Ie8393cf876435a3ffb77a4b27bcf419b529fd785
-
- Jan 19, 2024
-
-
Arun Johnson authored
Bug: 298052174 Change-Id: I369affbb103cbf860a2fabfc1b85f0c44750ed82
-
Paul Duffin authored
Previously, the `core/api/current.txt` erroneously and unnecessarily listed `drawMesh(...)` as the only method in the `android.graphics.RecordingCanvas` class. That was because there was an bug in Metalava that meant it ignored a super method if that method came from a hidden/inaccessible class. The accompanying change in this topic fixes the bug and so it can be removed. Listing `drawMesh(...)` method in `RecordingCanvas` was unnecessary because `RecordingCanvas` extends `Canvas` which defines and provides a concrete implement of `drawMesh(...)`. The `RecordingCanvas` does not add any new methods, it simply overrides the methods from `Canvas` and records their parameters. Bug: 319826204 Test: m checkapi (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:cf7ff527cf5fa7deb086cb61c5ec3400d45838db) Merged-In: I7e23b93659a87f13606ca2d6c4c3ceebee23901f Change-Id: I7e23b93659a87f13606ca2d6c4c3ceebee23901f
-
Suprabh Shukla authored
This needs to be used in a cts test and so it is good to have it annotated as such. Test: Manually verify that its stubs are generated in the correct txt. Bug: 304347838 Merged-In: I5a6f30cdb76a37f5ff412339a0d78e98991fe86e Change-Id: I5a6f30cdb76a37f5ff412339a0d78e98991fe86e
-
- Jan 18, 2024
-
-
Jooyung Han authored
We'd like to limit the usage of libvintf because of its performance/memory impact. By removing VintfObject and VintfRuntimeInfo classes from preloaded-classes list, we can avoid loading libvintf from libandroid_runtime. A new JNI library (libvintf_jni) is loaded only when it's actually used. Bug: 270169217 Test: atest VintfObjectTest Change-Id: I469f368ee04863374988359c28bcd1a5fb4ead9e
-
linkai authored
Bug:319498513 When gallery app opens Ultra HDR photo on default display, ViewRootImpl#updateColorModeIfNeeded is executed and mHdrSdrRatioChangedListener is not null. At this point, we move the gallery app to the virtual display, ViewRootImpl#updateInternalDisplay is executed and mDisplay is updated as the virtual display. The virtual display is ready to register hdr/sdr ratio listener due to non-null mHdrSdrRatioChangedListener and mDisplay. However, the virtual display is not available for hdr/sdr ratio, the gallery app in the virtual display will crash. Change-Id: I34f03dfe5a00841131784dc3abbe1c11fd07d4b2 Merged-In: Ic69b633d6042145a537c7d39e713f804faff6600 Signed-off-by:
linkai <linkai@xiaomi.com>
-
Yohei Yukawa authored
Historically RemoteInputConnectionImpl has been calling on InputMethodManager#isActive() to see if the InputConnection is considered to be active or inactive when actually handling each incoming InputConnection operation. However, InputMethodManager#isActive() is also known to be tricky because it internally calls InputMethodManager#checkFocus(), which can have non-trivial side effects. With this CL, RemoteInputConnectionImpl keeps maintains its own boolean state on whether #deactivate() is already called or not so that it does not need to rely on IMM#isActive() any more. For 99% cases there must be no observable behavior change, and for the remaining 1% cases the new behavior should be more easily understandable. Bug: 291826769 Test: atest CtsInputMethodTestCases:InputConnectionHandlerTest#testInputConnectionSideEffect Merged-In: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8 Change-Id: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8
-
Yohei Yukawa authored
With my previous CLs [1][2], we can generally assume the following things. - InputConnection#closeConnection() always gets called when it becomes invalidated, including the case when the IME has switched to another IME client. - Each implementation of InputConnection#closeConnection() is expected to do appropriate clean up including finishing composing text. {Base,Editable}InputConnection actually do this correctly. With that it should be safe for #finishComposingText*() to follow the same pattern about isActive(). [1]: I234309c5880c9fe0b299b8bd0f8862796d4dda0d 9f9afe52 [2]: If2a03bc84d318775fd4a197fa43acde086eda442 aaa38c9f Bug: 35301295 Bug: 291826769 Test: presubmit Merged-In: If913701bf8555f5d76fceb272e38a99f5e243bbe Change-Id: If913701bf8555f5d76fceb272e38a99f5e243bbe
-
Yohei Yukawa authored
It is guaranteed that the following two boolean expressions have always the same value observed outside from RemoteInputConnectionImpl#mLock. A. RemoteInputConnectionImpl#mFinished B. RemoteInputConnectionImpl#mInputConnection != null With that we should be able to simply merge them into an atomic reference object AtomicReference<InputConnection> without requiring RemoteInputConnectionImpl#mLock as a lock object. This CL does so as a preparation to clean up RemoteInputConnectionImpl for Bug 291826769. There should be no observable behavior change, except for the fact that RemoteInputConnectionImpl#dumpDebug() no longer blocks other operations that required mLock, which is kind of out of our original intention. Bug: 291826769 Test: presubmit Merged-In: I69fa2c81670f84be3dd4a808262758a803f69dfc Change-Id: I69fa2c81670f84be3dd4a808262758a803f69dfc
-
- Jan 17, 2024
-
-
Shawn Willden authored
Bug: 290312729 Test: N/A Change-Id: I65e7ce4b7113639523aec1e08682a334056cbb69
-
Girish authored
Bug: 289097671 Test: atest android.media.misc.cts.ResourceManagerTest atest android.media.misc.cts.ResourceManagerMultiTest Merged-In: I750ef5a7585b7bba94f0dfb7bb8e70ec12bf70f5 Change-Id: I750ef5a7585b7bba94f0dfb7bb8e70ec12bf70f5
-
- Jan 16, 2024
-
-
Sihua Ma authored
This helps fix issues with improper layouts of adapter child views in case RemoteCollecionItemsAdapter is used. Test: Manual Bug: 245950570 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dc464d6e522eebec5221a934ec3ff5f52a4fb90e) Merged-In: I0eedf4574975bfae88801e0153816135fc1c8181 Change-Id: I0eedf4574975bfae88801e0153816135fc1c8181
-
- Jan 15, 2024
-
-
wilsonshih authored
To make the embedded window of SplashScreenView non-focusable, needs to add the window flag separately from SurfaceControlViewHost#setView Bug: 319369153 Test: verify the embedded window of splash screen won't grant focus Change-Id: Ic9b48dcc4de25e681405b3dd78468597a8a7c627
-
- Jan 13, 2024
-
-
Aaron Vaage authored
Change-Id: Ib79857aa0c6bdf76d0ab65cd66e044aac4e4084e
-
- Jan 12, 2024
-
-
lizhigang authored
Splice can be used to speed up file copy operations by avoiding moving any memory between kernel/user space. But splice copy can not support from socket file to regular/socket file directly. So use pipe file as proxy, socket/regular --> pipe --> socket/regular. Even it needs 2 times splice syscall, it is still much faster than user space copy. Please refer to the comparison data below for the time consumption of executing FileUtils.copy in FileUtilsTest:testCopy_SocketToFile_FileToSocket file-->socket(unit ms): 32KB: user_cp:0.604, splice_cp:0.113, reduce 80% 32MB: user_cp:236, splice_cp:68, reduce 71% socket-->file(unit ms): 32KB: user_cp:0.611, splice_cp:0.240, reduce 61% 32MB: user_cp:284, splice_cp:88, reduce 69% The network environment for this test is localhost, and the data in real scenarios depends more on the actual network environment. Test: atest FrameworksCoreTests:android.os.FileUtilsTest Change-Id: I0636647934a889ce95bdf4df0db428cb370148fd Signed-off-by:
lizhigang <lizhigang.1220@bytedance.com>
-
- Jan 11, 2024
-
-
Yan Yan authored
This CL integrates the IpSecPacketLossDetector into VCN route selection. With this change, when a data stall is reported, the network candidate will be penalized and then deprioritized during network selection. A network candidate will stop being penalized until it hitting a timeout or passing the validation. Bug: 282996138 Test: atest FrameworksVcnTests(new tests), CtsVcnTestCases Change-Id: Ifabd6fdea1d5a4fea40cf929dbab7c26d37274ac
-
William Loh authored
Bug: 307556883 Test: n/a Change-Id: I5001247c342f23b07e1355db7e50ad90cce66b07
-
Tom Chan authored
syntax from go/android-codereviews#include-an-owners-file-from-a-sub-directory-within-the-same-git-project Change-Id: Ia02a5efdda1c2dea65753a63cbd2e78e56bac6eb
-
- Jan 10, 2024
-
-
Yan Yan authored
This CL creates an abstract class NetworkMetricMonitor and a subclass IpSecPacketLossDetector. IpSecPacketLossDetector is responsible for continuously monitoring IPsec packet loss and reporting to the caller when the data loss rate surpass a threshold. This detector allows the VCN to switch from the underlying network that has bad quality. This CL also defines new carrier configs that specify the data loss threshold and detecting frequency Bug: 282996138 Test: atest FrameworksVcnTests(new tests), CtsVcnTestCases Change-Id: I5f4b8e1821bdbb37f0a6de6e1584f8e3c87273f3
-
William Loh authored
Bug: 307556883 Test: n/a Change-Id: I2836908a00981d54e884a495a662bc293219c0e4
-
- Jan 09, 2024
-
-
Alisher Alikhodjaev authored
(Discovery tech and Change Routing) Bug: 300351519 Bug: 319156577 Test: n/a Merged-In: If664910d00fc673c0329e0cd4489174260eb4f1e Merged-In: I3035f8b4fac331d827afa8e7bda6109d91ee510a Change-Id: If664910d00fc673c0329e0cd4489174260eb4f1e
-
Sudheer Shanka authored
Bug: 317897994 Test: manual Change-Id: I806df54dd1f82d37998a37113faafbecd04adc10
-
- Jan 08, 2024
-
-
Yifan Hong authored
After compatibility check at boot time, the VintfObject is usually no longer needed. Hence, at boot time, we actively release the VintfObject object after compatibility check by not using the shared instance in the first place. Test: TH Bug: 270169217 Change-Id: I9b3383cd52fa67eb18dd5837f96caf2b0eab2ce5
-
Yifan Hong authored
Before this change, if the kernel has a set of CONFIGs that is not compatible with the system image, a dialog is displayed for user / userdebug builds at boot time. This check has been doing more harm than good because: - This check is already enforced at build time and during VTS tests (See vts_treble_vintf_framework_test). - The dialog blocks UI automation for tests. For these UI automation tests, they need to respond to the dialog. - GKI has been enforced ecosystem-wide except for a few low-end devices of other verticals. For these non-GKI devices, the check enforced by VTS should guard this. Hence, the check does not give us any signal. - During development, a kernel that corresponds to the latest release (android15 as of now) might not have valid kernel config requirements in userspace. Kernel development schedule is usually ahead of the userspace development schedule. It does not always carry the string "-mainline-", because it is not a mainline kernel. To unblock test automation on these latest, bleeding-edge kernels, this kernel check should go away. - This is a small steps towards dropping the dependency on libvintf on libandroid_runtime. libvintf links to libselinux, which is huge. libandroid_runtime loads this, and the memory stays there forever. Ideally, we should disable the whole VINTF check at boot time, but let's do this one step at a time. Bug: 272479887 Bug: 270169217 Test: TH Change-Id: If24cdca9fb535b8f443c0d21f9a46c7ea25c1f9f
-
Yifan Hong authored
It is not used anywhere. Test: TH Bug: 270169217 Change-Id: Ifcc8412ed3629d2447908513faf1d6f5ed3f483c
-
- Jan 06, 2024
-
-
Yifan Hong authored
Non-A/B has been deprecated for long. During non-A/B updates, compatibility.zip is checked with VintfObject.verify(), which is another deprecated function that always returns compatible if a list of package VINTF XMLs are supplied. (see below.) Hence, the private RecoverySystem.verifyPackageCompatibility was just useless code that unconditionally returns true except for invalid ZIP file. Remove it. Replace the public RecoverySystem.verifyPackageCompatibility and make it return true unconditonally. VintfObject.verify() with OTA XMLs are deprecated per http://b/139300422 [VINTF] Delete OTA vintf checking code in http://r.android.com/1194233 ("Delete VINTF compatibility checks during OTA."), in 2019. We had decided that compatibility checks during OTA should be removed, and moved to OTA generation time instead. Using an old libvintf on the device to check against new libvintf metadata required forward compatibility of libvintf, which cannot be achieved. Instead, the device should verify the signature of the OTA to verify its source. Test: TH Bug: 270169217 Bug: 139300422 Change-Id: I775d29e4cd1d165233e07cfb820d1fe343fa4757
-
- Jan 05, 2024
-
-
Eric Biggers authored
Remove the serialNumber parameter from IStorageManager#prepareUserStorage, StorageManager#prepareUserStorage, and StorageManagerService#prepareUserStorageInternal, as it is not used. Bug: 316035110 Test: atest UserDataPreparerTest Flag: N/A, mechanical refactoring Change-Id: I4bb716a502fec267fbe0d93e423c7d713c78feaa
-
Eric Biggers authored
Remove the serialNumber parameter from IStorageManager#createUserStorageKeys and StorageManager#createUserStorageKeys, as it is not used. Bug: 316035110 Test: presubmit Flag: N/A, mechanical refactoring Change-Id: I11f2507fefb374bea7c8de857424c67108fcb97e
-
Eric Biggers authored
Remove the serialNumber parameter from IStorageManager#unlockCeStorage, as it is not used. Bug: 316035110 Test: atest UserControllerTest Test: atest com.android.server.locksettings Flag: N/A, mechanical refactoring Change-Id: Idfb46e625f0ab6915c980e4a39420fe712cb5fb5
-
Edward Savage-Jones authored
Add/update owners for SystemConfig related files (See comment in: https://r.android.com/2775452) c/j/c/a/s/SystemConfig.java has also moved so update the OWNERS file for that too. Change-Id: Ia773c7851d6aad4223ce5845d0993d527a5fd140
-
Edward Savage-Jones authored
Prevent the disabling of specified apps, avoiding cases where disabling the app may result in an unusable system. Bug: 200043113 Change-Id: I5b0ed8c34a40428e8d18072582e46854737c000a
-
- Jan 04, 2024
-
-
Pawan Wagh authored
Test: m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk Test: atest SettingsProviderTest Bug: 295035851 Bug: 294614538 Change-Id: I7bba46c39d609f314e17eb861341bd599b192612
-
Pawan Wagh authored
Test: m framework-all Test: Compiled and applied OTA using settings app using stable interface m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk Bug: 317914533 Change-Id: I393df5218c60303dbea60386c680b75b553ddac2
-
Alexei Nicoara authored
Change-Id: Icc8a7b899ccb54196ece9cccbfe3658547f0603c
-
- Jan 03, 2024
-
-
Yan Yan authored
Bug: 317406085 Test: atest FrameworksVcnTests(new tests), CtsVcnTestCases Change-Id: I8f5b6cb4e8286331626d4d39b864f0298657cab6
-
Peiyong Lin authored
Toast message should have a target package that receives and resolves the intent, otherwise it will be sent to all components in all packages which could result in crashes. Bug: b/318460567 Test: manual Change-Id: I9918ae7d273aa0bda6a39294bba878d9b58cf1b5
-
Sooraj Sasindran authored
Bugs: 307559608 Change-Id: I0c600c1a8c96fef4d820e41a6188862672f535af
-