- Jun 06, 2024
-
-
Owner Cleanup Bot authored
This suggested change is automatically generated based on group memberships and affiliations. If this change is unnecessary or in error, vote CR -1 and the bot will abandon it. Vote CR +1/2 to approve this change. See the owner's recent activity for context: https://android-review.googlesource.com/q/wessam@google.com To report an issue, file a bug in the Infra>Codereview component. Change-Id: I0d418b0ba6596867c4e787329798395fd93a784e
-
Ellen Arteca authored
-
Treehugger Robot authored
-
Adrian Roos authored
Change-Id: Iec8b8243cec8fbc14af945280c30d89a15b16d19
-
David Drysdale authored
-
- Jun 05, 2024
-
-
Pawan Wagh authored
* changes: Fix usage of ZipFileRO::getEntryInfo Fix usage of ZipFileRO::getEntryInfo Combine ZipFileRO::getEntryInfo
-
David Drysdale authored
Test: TreeHugger Change-Id: Ibe48e5aac817fbc3ec651a315611d7bd73dad4ee
-
Pablo Gamito authored
-
Pablo Gamito authored
Change-Id: I465731f45e663dbe699eca64c04061c6167c1813
-
- Jun 04, 2024
-
-
Pawan Wagh authored
Extra field size has been added to getEntryInfo. Adding parameter to call. Test: mma libandroidfw Bug: 334109171 Change-Id: I63232ab7c9c1db9c4dadc2c457c587900899e305
-
Pawan Wagh authored
Extra field size has been added to getEntryInfo. Adding parameter to call. Test: mma libandroidfw Bug: 334109171 Change-Id: I38f0884c69c7b3b2871f264e41971a86c61bda65
-
Jared Duke authored
-
Ang Li authored
-
Ang Li authored
Bug: 344870230 Test: Not required. Add owner only. Change-Id: I5ef64a9604f7453a1704e5a7b8f49acce3bf37c3
-
Ang Li authored
-
Treehugger Robot authored
-
Sanal Buvaev authored
-
Pawan Wagh authored
Removing getEntryInfo which doesn't contain extra field size and fixing the usage. Test: mma libandroidfw Bug: 334109171 Change-Id: Id5c8a5405265e6964f5b56b253430eb7c49cdc02
-
Alan Viverette authored
-
Sanal Buvaev authored
This reverts commit c996b909. Reason for revert: Fixed CTS tests Change-Id: I4ebb7d1a05eec41e8c5f603c42972c2e16d60b3d
-
Ang Li authored
The remote color resources (under `remote_color_resources_res`) were authored and checked in three years ago by pbdr@, and these resource files are well isolated from other frameworks resources. It will make sense to add Pierre as an owner. Bug: 344870230 Test: Not required. Add owner only. Change-Id: I338a40fe7118dd04f168e83e85bf03912da45842
-
Alan Viverette authored
No longer an appropriate reviewer for platform code. Change-Id: I051251f7baee476dd95c4a85b1a6e2e51e9a00fd
-
Jeff DeCew authored
-
Siim Sammul authored
-
Siim Sammul authored
Processing the large proto tombstones can cause OOM and there is no point adding tombstones larger than dropbox max capacity as they will not get uploaded. Bug: 343135528 Change-Id: Ib308e48dcfc3282ae7ab0e9fa0827cc8fae97078
-
Mitch Phillips authored
-
Parth Sane authored
-
Yi Kong authored
We have enough logging now, they have become excessive. Change-Id: Ia26dbbf7d771554e29087527bea97d6e6d5887bb Test: presubmit
-
Treehugger Robot authored
-
Treehugger Robot authored
-
- Jun 03, 2024
-
-
Ioannis Ilkos authored
-
Mark Fasheh authored
-
Ioannis Ilkos authored
TracingServiceProxy depends on external system services to forward its requests to. There is an edge case where reportTrace was called before the encrypted storage was unlocked and before external services can be bound (e.g. occurs when reportTrace is concurrent to system_server starting up). This change defers the registration of the service until we are ready to accept requests. As a side-effect this also means that the device needs to be unlocked before the service is published. Bug: 333846370 Test: atest PerfettoReporterTest Test: boot device without lock and invoke perfetto reporting (verify the report is accepted immediately) Test: boot device with lock and invoke perfetto reporting (verify the report is accepted after unlocking) Test: invoke perfetto reporting concurrent to kill -9 `pidof system_server` Change-Id: Ibb75c3e314d30b18cdc32e3774be1ee8022960b1
-
Mark Fasheh authored
We've been profiling and making improvements to MessageQueue for some time now and also have OWNERS for MessageQueueTest.java. Would like to be able to review future changes to the core MessageQueue class. I also added Message.java for good measure. Test: presubmit Change-Id: I961a2468c7b9a451d3b33d78a67f17cccf22cd60
-
Treehugger Robot authored
-
Treehugger Robot authored
Merge "Increase the dropbox disk quota to 20Mb for user debug builds as we add more debug to dropbox for user debug. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ea261f6a2a9d1034abfaf2ebdaae72c9869c8c90) Merged-In: Ib758fa6fa47cfd26e895bf8d7b9d5bde98c99461 Change-Id: Ib758fa6fa47cfd26e895bf8d7b9d5bde98c99461" into main
-
Jared Duke authored
While this offers minimal savings, there's no real reason to opt out of optimization (the default for app targets). Test: m + check APK diff Bug: 203241149 Change-Id: Ib1bba31a95afa87f37aedb0251796bdb31ab65c0
-
Parth Sane authored
Bug: 333854840 Test: atest android.os.BinderTest Change-Id: Iaf1fd1e5daea7103a873bc8f8aa0b78377e57714
-
Olivier Gaillard authored
Increase the dropbox disk quota to 20Mb for user debug builds as we add more debug to dropbox for user debug. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ea261f6a2a9d1034abfaf2ebdaae72c9869c8c90) Merged-In: Ib758fa6fa47cfd26e895bf8d7b9d5bde98c99461 Change-Id: Ib758fa6fa47cfd26e895bf8d7b9d5bde98c99461
-
Mitch Phillips authored
There's some bad behaviour going on that's exclusive to WatchOS (discovered on the Pixel Watch 2). The TombstoneWatcher class is responsible for watching the /data/tombstones/ directory. It is a member of the NativeTombstoneManager class, which is created when ActivityManager starts, and lives until the device is powered off. Unfortunately, some bad behaviour (unclear exactly what at this stage) means that the TombstoneWatcher class is spuriously garbage collected, even though the parent NativeTombstoneMenager class is still alive and reachable. I chatted with hboehm@ from the ART team, and his hypothesis is that because the TombstoneWatcher member is initialized in the constructor and never used again, some optimiser is doing the wrong thing and thinking that it's unused and can be GC'd. The TombstoneWatcher uses inotify in native code to execute a callback when a file is added to a directory, so it's clearly in use, but unfortunately the bug allows this class to be GC'd anyway. What this means, in practice, is that app native crashes on WatchOS are not being handled correctly. This includes: - Apps cannot get their own crashes through the ApplicationExitInfo::getHistoricalProcessExitReasons API. - Crash reports are never sent to Google, with the exception of tombstones that last until the next reboot, where they're one-time scooped up and sent to Google. This has substantially increased latency (requires a reboot) and also probably drops quite a number of reports because there's a limit of tombstones on the device, and a rate limit of how many are sent by GMS. Bug: 339371242 Test: atest CtsGwpAsanTestCases on eos (Pixel Watch 2, WatchOS) Change-Id: I9226e4368b03bd4742fccdafde6018f145da63e6
-