Skip to content
Snippets Groups Projects
  1. May 07, 2024
    • Inseob Kim's avatar
      Use no_full_install: true instead of installable: false · 8541b878
      Inseob Kim authored
      So far, we have used `instalable: false` to avoid collision with the
      other modules that are installed to the same path. A typical example was
      <foo> and <foo>.microdroid. The latter is a modified version of the
      former for the inclusion of the microdroid image. They however both have
      the same instalation path (ex: system/bin) and stem (ex: foo) so that we
      can reference them using the same path regardless of whether we are in
      Android or microdroid.
      
      However, the use of `installable: false` for the purpose is actually
      incorrect, because `installable: false` also means, obviously, "this
      module shouldn't be installed". The only reason this incorrect way has
      worked is simply because packaging modules (ex: android_filesystem)
      didn't respect the property when gathering the modules.
      
      As packaging modules are now fixed to respect `installable: false`, we
      need a correct way of avoiding the collision. `no_full_install: true` is
      it.
      
      If a module has this property set to true, it is never installed to the
      full instal path like out/target/product/<partition>/... It can be
      installed only via packaging modules.
      
      Bug: 335369205
      Bug: 337993945
      Test: m droid aosp_cf_system_x86_64
      Change-Id: If9c053968bde39c3eb3b852f1df1d475161bd846
      8541b878
  2. May 03, 2024
    • yangbill's avatar
      Convert keyboards artifacts to soong · deee1119
      yangbill authored
      This CL still keep PRODUCT_COPY_FILE for the original system image
      packaging for Make, but create 3 soong's modules which could be used for
      soong generated system images.
      
      Bug: 337993945
      Test: lunch aosp_cf_x86_64_only_phone-trunk_staging-userdebug ;\
            m aosp_cf_system_x86_64 ; m
      Test: lunch yukawa-trunk_staging-userdebug ; m
      Change-Id: Ie749de99273f85623861a001e69a9c4187cc8067
      deee1119
    • Ray Chin's avatar
      Revert "Convert keyboards artifacts to soong" · 01596715
      Ray Chin authored
      This reverts commit fd803f55.
      
      Reason for revert: This change break most of the tv targets. Please test building cf_x86_tv_gtv
      
      Bug: 338497361
      Change-Id: I5e9063f3099315de4ec6bde966bf8563f5faac56
      01596715
  3. May 02, 2024
  4. Apr 22, 2024
  5. Mar 25, 2024
  6. Mar 12, 2024
  7. Feb 06, 2024
  8. Jan 30, 2024
  9. Jan 23, 2024
    • Nelson Li's avatar
      Move fontchain_lint to build/core/tasks · c784e9e9
      Nelson Li authored
      Because `system.img` is a dependency of `fontchain_lint`, and
      `system.img` is currently not generated inside `Soong`, it is not
      possible to directly convert `fontchain_lint` to `Android.bp`.
      Move it to build/core/task first.
      
      Bug: 319050958
      Test: m fontchain_lint
      Change-Id: Iad483117a609786ecfb885b13015f18dda113155
      c784e9e9
  10. Jan 08, 2024
    • Nelson Li's avatar
      Convert validate_framework_keymaps to Android.bp · bedfe383
      Nelson Li authored
      The primary purpose of validate_framework_keymaps is to perform checks
      on all *.kl, *.kcm, and *.idc files using the "validatekeymaps -q"
      command. This action can be replaced by using a genrule.
      
      Bug: 318785074
      Test: m validate_framework_keymaps
      Change-Id: I657466d7ee2cec29900beeb0610cb0d30f34f92e
      bedfe383
  11. Jan 04, 2024
    • Pawan Wagh's avatar
      Add recovery permission to Settings app · 22a847e7
      Pawan Wagh authored
      Settings app needs to retrieve and publish update info from
      SystemUpdateManager. This is needed to install 16k developer option
      update which enables users to use 16K kernel from local OTAs.
      
      Test: m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk
      Bug: 302391134
      Bug: 295035851
      Change-Id: I89e30a8fc7e753f41c70e3ddbf759fb63ea97bd5
      22a847e7
  12. Jan 03, 2024
  13. Dec 28, 2023
  14. Dec 08, 2023
    • Vishnu Nair's avatar
      Reland Use WindowInfosListener for TPL · 06ebddac
      Vishnu Nair authored
      Move TPL logic from surfaceflinger to system server. When a TPL is
      registered, start listening to window info updates and start checking
      for whether thresholds will be crossed. This allows us to move the logic
      away from the composition hot path and optimize to handle multiple
      listeners. This change also consolidates all the TPL logic into its own
      thread.
      
      Bug: 290795410
      Change-Id: Ib4ab68d7f116ace168bf994c0fd5c0c08c4496a6
      Test: atest TrustedPresentationCallbackTest
      06ebddac
  15. Dec 06, 2023
  16. Dec 01, 2023
    • Joshua Trask's avatar
      Grant SHOW_CUSTOMIZED_RESOLVER permission to Shell · f08b6c69
      Joshua Trask authored
      (This is needed to be able to exercise the new API in a CTS test.)
      
      Test: (see other CLs in this topic)
      Bug: 268089816
      Change-Id: I63de51fbb837071fbf99b8bdc9135bcfb3b12b52
      f08b6c69
    • Vishnu Nair's avatar
      Use WindowInfosListener for TPL · ae3a5365
      Vishnu Nair authored
      Move TPL logic from surfaceflinger to system server. When a TPL is
      registered, start listening to window info updates and start checking
      for whether thresholds will be crossed. This allows us to move the logic
      away from the composition hot path and optimize to handle multiple
      listeners. This change also consolidates all the TPL logic into its own
      thread.
      
      Bug: 290795410
      Test: atest TrustedPresentationCallbackTest
      
      Change-Id: Ib649f157ddbb6b5a952cedeb235f6ace6f5e43ae
      ae3a5365
    • Nick Chameyev's avatar
      Defer display switch update if transition is running · 6233caf0
      Nick Chameyev authored
      WindowManager receives updates from DisplayManager through
      onDisplayChanged() callback by reading the DisplayInfo
      objects after receiving this callback.  This CL makes
      WindowManager to defer the updates if there is a collecting
      Shell transition. This is needed to allow starting physical
      display change transition if there is another transition
      running.
      
      Previously this was silently failing without starting
      a display switch transition.  It also changes the behavior
      of PhysicalDisplayTransitionLauncher: now it starts the
      display change transition even if it's not an 'unfold' transition.
      UnfoldTransitionHandler will decide if it wants to handle
      'unfold' display change and default transition handler will be used otherwise.
      
      Bug: 259220649
      Bug: 277866717
      Test: atest PhysicalDisplaySwitchTransitionLauncherTest
      Test: atest DisplayContentTests
      Test: manual fold/unfold with apps/split screen/
        split screen + PIP
      Change-Id: Ib0d0624bf141ff16578d7902bec98272d17ee36f
      6233caf0
  17. Nov 29, 2023
    • Josep del Rio's avatar
      Replace Action+Grave with Action+Escape · 5d858ee5
      Josep del Rio authored
      At the moment Action+Grave will go back, but not Action+Escape;
      Escape is the top-left key, not grave.
      
      Bug: 313612728
      Test: Flashed build, confirmed Action+Escape goes back
      Change-Id: Ieb83fb0373f62e39e2debed72cdbc1b6761760ff
      Flag: NONE
      5d858ee5
  18. Nov 27, 2023
    • Marzia Favaro's avatar
      Improve readability and add protections against use after release NPE · 5496dfa0
      Marzia Favaro authored
      Preventively ensure the dimLayer has not been released before trying to access it.
      
      Fix: 308448047
      Test: atest CtsWindowManagerDeviceOther:android.server.wm.other.MinimalPostProcessingTests#testTwoVisibleWindowsSecondOnePrefersMinimalPostProcessing --iteration 100
      Test: atest DimmerTests
      Change-Id: Id08838e0a98ba949382442b8fac8e81156d1aa40
      5496dfa0
  19. Nov 22, 2023
    • Chavi Weingarten's avatar
      Move LayoutParam secure flag so it's set on the WS level · ac76ed94
      Chavi Weingarten authored
      The LayoutParam secure flag set by the client is set on the WSA level.
      
      This causes a few issues:
      1. Child windows don't inherit this flag since child windows are added
         beneath WS
      2. Prevents moving the WSA's SC to the client since the secure flag
         needs to be set in WMS.
      
      Test: FlagSecureTest
      Bug: 308662081
      Change-Id: I724ab0d834b0d74b33ccbb6bbd2c6f9c622c2a15
      ac76ed94
  20. Nov 15, 2023
    • Ajay Gopi's avatar
      Add android.permission.RECEIVE_SANDBOX_TRIGGER_AUDIO in Shell manifest. · c32fa5f3
      Ajay Gopi authored
      This is required for CtsVoiceInteractionTestCases.
      
      Test: presubmit
      Bug: 291656263
      Change-Id: I0fa57a0ec0d337f5bf2970a536e20bdc94d4f312
      c32fa5f3
    • Vladimir Komsiyski's avatar
      API for home support on virtual displays. · 410361a9
      Vladimir Komsiyski authored
      Instead of adding yet another virtual display flag, the API is in
      VirtualDisplayConfig and uses WM's DisplayWindowSettings to store the
      bit whether home is supported.
      
      The difference with the existing FLAG_SHOULD_SHOW_SYSTEM_DECORATIONS
      is that it also adds navigation bar and the new API doesn't. The flag
      is hidden but there are existing clients of it.
      
      Several caveats:
       - Need to use displayUniqueId instead of displayId because we should
         tell WM about the home support before the display is actually
         created and the display listeners notified.
       - Interacting with the DisplayWindowSettings requires the WM lock,
         which must not be acquired while DisplayManagerService is holding
         its own lock because this may and will sometimes cause deadlock.
       - So extracting the displayUniqueId generation logic before the DMS
         locked region of actually creating the virtual display and passing
         it to WM to store the settings.
       - Change in the virtual display uniqueId generation: reusing ids per
         package/uid causes problems in when displays with the same name
         are created and released quickly (CTS). When there are no display
         devices, the same unique id is used, but the DisplayWindowSettings
         may not have yet received the previous onDisplayRemoved callback,
         so the setting for that uniqueId is removed. Making the uniqueIds
         truly unique fixes this and there's no realistic danger of an
         overflow.
      
      Fix: 291749213
      Fix: 297167917
      Test: see CTS in topic
      Test: atest VirtualDisplayAdapterTest
      Test: atest DisplayWindowSettingsTests
      Test: atest DisplayAreaPolicyTests
      Change-Id: If72696a793a9c4d63d4f8b72de7433b0dd440909
      410361a9
  21. Nov 14, 2023
  22. Nov 10, 2023
    • wilsonshih's avatar
      Refine back navigation search method. · 7c64d687
      wilsonshih authored
      - Remove embedded window check, EmbeddedWindowController#getByFocusToken
        should search with input token instead of window token, so it always
        return null nowaday.
      - Skip search if the closing target isn't visibleRequested, usually that
        means the closing transition is collecting or playing, either case the
        window shouldn't receive another back invoked event. Inject the back
        key then next focus app will handle it.
      - Use TYPE_CALLBACK if we cannot find any task below current task, this
        could also happen on some specific device.(e.g. No home)
      
      Bug: 303266152
      Bug: 309683765
      Test: atest BackNavigationControllerTests
      Change-Id: Ia1f5ec664ea7154d9c8ac59cbc247a51226dfdf1
      7c64d687
  23. Nov 08, 2023
    • Kangping Dong's avatar
      [Thread] add Thread network permissions · fa35b426
      Kangping Dong authored
      Defines permissions for guarding access to Thread network API.
      
      The permissions are also granted to shell for CTS tests, see the
      instructions here: go/ctswrite#write-a-test-to-test-an-api-that-requires-system-permission
      
      Design doc: go/thread-android-api
      
      Bug: 262683651
      Merged-In: Ib15d5589bbd304d68840ee52a193676d12110512
      Change-Id: Ifc6c1d55cc170a5a200dfb5d531f5e0f86a9507a
      fa35b426
  24. Nov 07, 2023
    • Kangping Dong's avatar
      [Thread] add Thread network permissions · ad6d6b6c
      Kangping Dong authored
      Defines permissions for guarding access to Thread network API.
      
      The permissions are also granted to shell for CTS tests, see the
      instructions here: go/ctswrite#write-a-test-to-test-an-api-that-requires-system-permission
      
      Design doc: go/thread-android-api
      
      (cherry picked from commit 03aa71cd4b5eabe9310d3c4d4db10038b80853d1)
      
      Bug: 262683651
      Change-Id: Ib15d5589bbd304d68840ee52a193676d12110512
      ad6d6b6c
  25. Nov 06, 2023
    • Makoto Onuki's avatar
      New Importance API for Rb · 0162f2a1
      Makoto Onuki authored
      Bug: 292533010
      Test: atest CtsGetBindingUidImportanceTest
          ... with and without android.app.get_binding_uid_importance set.
      
      Change-Id: Iee6f0e08ba499f2f51d8173e45168c69933cd451
      0162f2a1
  26. Nov 01, 2023
    • dakinola's avatar
      Report MediaProjectionTargetChanged Atom · a582dde3
      dakinola authored
      Update ContentRecorder & MediaProjectionManagerService to log a MediaProjectionTargetChanged atom upon recording starting and further updates to windowing mode.
      
      Bug: 304728422
      Test: atest WmTests:ContentRecorderTests
      Test: atest FrameworksServicesTests:MediaProjectionManagerServiceTest
      Test: atest FrameworksServicesTests:MediaProjectionMetricsLoggerTest
      Change-Id: I5120ba2571fb2e6e084e72c4fd079767530ccdeb
      a582dde3
  27. Oct 30, 2023
  28. Oct 25, 2023
    • Nick Chameyev's avatar
      Take over animating of unfold Shell transitions · 4fe9c2c3
      Nick Chameyev authored
      Adds logic to UnfoldTransitionHandler that
      takes over animating a transition if it contains
      changes related to unfold.
      
      Bug: 259220649
      Test: atest PhysicalDisplaySwitchTransitionLauncherMixedTest
      Test: manual unfold 20 times =>
        verify that there is no black screen delay
      Test: artificially increase collecting of rotation transition
        => rotate and unfold device, check that animation works
      Flag: handle_mixed_unfold_transitions
      Change-Id: I3285c1b6a45da63ac7846e9d5929db9426b069ae
      4fe9c2c3
  29. Oct 24, 2023
    • Prabir Pradhan's avatar
      Remove HID usage mapping for stylus buttons in Generic.kl · 2c42929c
      Prabir Pradhan authored
      ... until we figure out a way to determine if a device supports a
      specific HID usage code. Right now, having a usage code mapping means we
      automatically assume the device can report the key code. Assuming a
      device can support a stylus keycode makes the device get classified as a
      stylus, leading to widespread misclassifications.
      
      Bug: 291529805
      Test: atest inputflinger_tests
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5fb192aaec7a1d4ebb1384d96b3f79d4b2ca2f2c)
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:55930e07d69fbd8ffd27d677a06fd0ba71a30bf8)
      Merged-In: I580514bdcbbfbe93df83fa3faa6262077e881243
      Change-Id: I580514bdcbbfbe93df83fa3faa6262077e881243
      2c42929c
    • Evan Rosky's avatar
      Add base impl of new ready tracker · fcbcaade
      Evan Rosky authored
      This introduces a new ReadyTracker class based around tracking
      explicit conditions instead of an arbitrary set of heuristics
      mixed with legacy.
      
      Usage involves constructing a ReadyCondition and adding it to
      a transition's tracker. Once the condition is met, call `meet()`
      on the condition.
      
      The new ReadyTracker considers the transition ready if there
      was at-least one condition added and all the added conditions
      have been met.
      
      This is just the base implementation so it isn't really
      functional yet. This does add ready-conditions in most of
      the places where the old method's defer/continue were used.
      
      Bug: 294925498
      Test: atest TransitionTests
      Change-Id: I6cbd9152d03e707e0e7134fa8ada2902e5af847e
      fcbcaade
  30. Oct 20, 2023
    • Pierre Barbier de Reuille's avatar
      Adapt recorded scaling in X and Y · 910509a5
      Pierre Barbier de Reuille authored
      The new scaling takes into account the asymmetry in pixel size on the
      external display for better rendering.
      
      Bug: 304248677
      Test: atest WmTests:ContentRecorderTests
      Change-Id: I7502538c5423343da93c20bfb7c6c8bea33dd7d2
      910509a5
  31. Oct 06, 2023
    • Marzia Favaro's avatar
      Apply dim changes only at the end of traversal · 6321bda5
      Marzia Favaro authored
      Collect the changes on a dim layer and assign only the last requested to
      a transaction
      - Avoids issues with transaction ending up in the wrong order
      - Allows smooth transactions between different alpha values
      - Does not treat the entering animation as a special animation case
      
      Test: DimmerTests
      Bug: 281632483
      Bug: 295291019
      
      Change-Id: Ic3e6ce1f107bfc3ac925eb167b8bc89a5df478c8
      6321bda5
  32. Oct 04, 2023
  33. Oct 03, 2023
Loading