Skip to content
Snippets Groups Projects
  1. May 30, 2024
  2. May 28, 2024
    • Yunfan Chen's avatar
      Apply stable config compat override after other compats · 1255c85e
      Yunfan Chen authored
      Moving the size override after other compat overrides to make sure the
      letterbox overrides can be applied correctly. The fields overridden by
      letterbox doesn't need extra override regarding the stable configuration
      as all insets are already in consideration.
      
      Besides, check shouldCreateCompatDisplayInsets() before applying the
      override to avoid inconsistency when the compat display insets is not
      yet created.
      
      This is a partial cherry-pick contains the critical part of the change.
      
      Bug: 332468995
      Bug: 340970172
      Bug: 336687188
      Test: See reproduce steps in b/332468995
      Test: CtsWindowManagerDeviceWindow:WindowMetricsActivityTests
      Test: CtsWindowManagerSdk25TestCases:AspectRatioSdk25Tests
      Test: v2/android-crystalball-eng/health/microbench/startup/hscapps/compile-speed-profile/open-maps
      Merged-In: Iee7ae3ea7e483e6f80fa6ef4659627d620653081
      Change-Id: If2e2e7f0eb504f2468f262b195f3a1cd28820423
      1255c85e
    • Seigo Nonaka's avatar
      Fix update failure if font family was installed and upgraded to 14 · 54792987
      Seigo Nonaka authored
      Bug: 331717791
      Test: atest UpdatableFontDirTest
      Test: Step 1: Build AOSP image and install
      Test: Step 2: Install font family.
      Test: Step 3: Remove certificate manually by adb shell.
      Test: Step 4: Reboot the device
      Test: Step 5: Install font family.
      Change-Id: I0373a2e66b7a6a51168094772afb36d8905b6979
      Merged-In: I0373a2e66b7a6a51168094772afb36d8905b6979
      (cherry picked from commit c273a7e8)
      54792987
  3. May 27, 2024
    • Oleg Blinnikov's avatar
      Prevent double updateLogicalDisplaysLocked · 987eeb85
      Oleg Blinnikov authored
      Bug: 332711269
      Bug: 338927759
      Test: atest ExternalDisplayPolicyTest DisplayManagerServiceTest
      LogicalDisplayMapperTest
      Change-Id: Iad0c5b0ea19a8f1f14642109639fd435b0e43bc4
      (cherry picked from commit ab71a6c1)
      987eeb85
    • Riddle Hsu's avatar
      Add mixed entering pip transition with display change · e76e2239
      Riddle Hsu authored
      The case happens when a pip is entering in previous rotation and then
      display updates. The transition type can be either TRANSIT_CHANGE or
      TRANSIT_PIP:
       PipTask CHANGE
         sb=Rect(0, 0 - 1080, 2340)
         eb=Rect(0, 0 - 2340, 1080) r=0->3
       Display CHANGE
         sb=Rect(0, 0 - 1080, 2340)
         eb=Rect(0, 0 - 2340, 1080) r=0->3
      
      The destination pip bounds should be calculated from (2340, 1080).
      Because a display snapshot should have covered the screen, the pip
      should go to the end state immediately and only animate the display
      rotation animation.
      
      This also merges [1] and [2].
      [1]: I110d1c11f3d3fdcfb83698e5cf1ec4efb062bd10
      [2]: Ia9c78105f4a9782c156744e6cb38681f265955a0
      
      Bug: 340367710
      Test: Enable auto rotation and home rotation.
            Swipe up (do not release touch) an auto pip activity in portrait.
            Rotate the device to landscape.
            Continue the swipe up to enter pip.
            The display should show a rotation animation and
            the pip can show on correct landscape position,
      
      Merged-In: Ia1e5e8c7edb8c2a078a66b587d5d26a495166de2
      Change-Id: Ia1e5e8c7edb8c2a078a66b587d5d26a495166de2
      (cherry picked from commit 6373912c)
      e76e2239
  4. May 26, 2024
  5. May 24, 2024
    • Riddle Hsu's avatar
      Pause insets position for seamless rotation · b6ce9a4b
      Riddle Hsu authored
      The enhances the concept [1] to sync insets leash position.
      Because after [2], the position will be applied with insets
      control change.
      
      [1]: I51ebd9f2c90b2b4d12f77d1361acc66ab7777b38
      [2]: I5ba0c33ca4542d27bb4dee4ce849f34721f20b14
      
      This also merges I2a886a6a04891a7bf09c1152e52a431326a80d03.
      
      Bug: 337018949
      Test: Enable auto rotation. Rotate camera app. The navigation
            bar can won't show on screen center.
      Merged-In: Ibb25dc5735674e6618b5c639c4e2e61ffa678f52
      Change-Id: Ibb25dc5735674e6618b5c639c4e2e61ffa678f52
      b6ce9a4b
  6. May 23, 2024
    • Ikram Gabiyev's avatar
      Disallow userLeaving when split drag drop · 0f7d92bd
      Ikram Gabiyev authored
      We should avoid setting mUserLeaving=true when
      bringing task to front that disallow entering PiP
      due to the launching task coming to front.
      
      Bug: 336477473
      Test: repro the steps in the bug report
      Change-Id: I94377538ab922b2ca03f295a847a8b8e4d1904df
      (cherry picked from commit 86860b8e)
      0f7d92bd
  7. May 22, 2024
    • Riddle Hsu's avatar
      Do not hide new adding window for rotated transient launch · fdfc1787
      Riddle Hsu authored
      The hide operation is mainly used to avoid showing navigation bar
      with inconsistent rotation after recents activity switches to next
      app. So if the state stays at running recents, let the adding
      windows show normally.
      
      Bug: 302249163
      Bug: 340979786
      Test: Disable home rotation. Launch landscape app.
            Enter recents. Long press power key.
            The power menu should be visible.
      Test: atest TransitionTests#testAppTransitionWithRotationChange
      Merged-In: I692df7227773ff4ca49ff50a02a2eb300dfcd241
      Change-Id: I692df7227773ff4ca49ff50a02a2eb300dfcd241
      (cherry picked from commit 7970e4f9)
      fdfc1787
  8. May 21, 2024
    • Riddle Hsu's avatar
      Narrow down the condition of wallpaper target for occluded keyguard · 9d48942c
      Riddle Hsu authored
      Previously, keyguard will be selected as the backup wallpaper target
      if there keyguard is locked and there is an active transition. That
      is to avoid wallpaper from being show/hide in a short time when
      running recents transition to close app on keyguard.
      
      The condition was a bit broad so the regular transition will also
      keep wallpaper target on keyguard. Which could make the transition
      change mode of wallpaper become CHANGE rather than TO_BACK when
      launching an occlude-keyguard app and then display rotates. Which
      could make the condition of seamless rotation rejects the seamless
      effect because it found wallpaper is a changing operation.
      
      To avoid such case, only enable the condition if there is a transient
      (recents) transition.
      
      Bug: 333557024
      Test: Enable auto rotation. Set a secured lock. Turn off screen.
            Double click power key to launch camera when holding the
            device in landscape. There should not have a rotation animation.
      Test: On a secured keyguard. Double click power key to launch camera.
            Swipe from bottom to dismiss camera. The wallpaper target
            should only change to notification shade once.
      Test: atest WallpaperControllerTests#testShowWhenLockedWallpaperTarge
      
      Merged-In: I43a29e828798f36f39d38af130f98de7c5859ec6
      Change-Id: I43a29e828798f36f39d38af130f98de7c5859ec6
      (cherry picked from commit 275e2758)
      9d48942c
  9. May 18, 2024
    • Mina Granic's avatar
      Do not apply fullscreen override for camera activities. · 996ce09e
      Mina Granic authored
      Fixed-orientation activities are rarely tested in other orientations, and it often results in sideways or stretched previews. As the camera compat treatment targets fixed-orientation activities, overriding the orientation disables the treatment.
      
      Fixes: 340818342
      Test: atest WmTests:LetterboxUiControllerTest
      Change-Id: I23cc542158e8fe53b1b210409dfb96c45ff7462f
      996ce09e
  10. May 17, 2024
    • Shawn Lin's avatar
      Refine biometric dangling notification · a8f6500d
      Shawn Lin authored
      - Update string resources
      - Make the notification not able to be cleared by "clear all" button
      
      Bug: 331804186
      Test: atest FaceInternalEnumerateClientTest
                  FingerprintInternalEnumerateClientTest
                  BiometricDanglingReceiverTest
      Test: Manual trigger dangling force re-enroll
      Flag: NONE
      Change-Id: I25c1e621f9464c7f0f7a895cf7294c752950b262
      a8f6500d
  11. May 16, 2024
  12. May 15, 2024
  13. May 14, 2024
    • Evan Rosky's avatar
      Make sure an isolated removeTask becomes ready · 60386b82
      Evan Rosky authored
      If this removeTask happens without any consequent actions
      (eg. removing a pip task and nothing starts as a result), the
      transition system needs to interpret it as ready immediately.
      
      Bug: 339135761
      Test: Open netflix video in pip, go to recents and restore netflix
      Change-Id: I14bed6164e12bd4d36c24870738188f5e89a4eb1
      Merged-In: I14bed6164e12bd4d36c24870738188f5e89a4eb1
      (cherry picked from commit 31a9c1f4)
      60386b82
    • Massimo Carli's avatar
      Handle letterbox education when disabled · 65f334df
      Massimo Carli authored
      When the letterbox education is disabled we should exclude it
      from the initial education flow.
      
      Bug: 335272191
      Test: atest WMShellUnitTests:CompatUIControllerTest
      Test: atest WmTests:LetterboxUiControllerTest
      
      Change-Id: Iec500496045c9dd324f4a6d8dd1f35712bb0c582
      65f334df
    • Evan Severson's avatar
      Clear historical record on all package uninstall broadcasts · f4b1bce7
      Evan Severson authored
      When the last package is removed the uid removed signal can arrive
      before which removes the UidState object from the data structure. This
      caused the historical appops clearing call to never be made so the
      registry is only correct during the first install.
      
      Test: atests AppOpsTest --iterations 5, without then with the change.
      Fixes: 333797941
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7a23d1f7fa42026c5b3b15bc282851bf497d97b7)
      Merged-In: If7cc71bec2c609aed501fc06c875f87c167cf521
      Change-Id: If7cc71bec2c609aed501fc06c875f87c167cf521
      f4b1bce7
  14. May 10, 2024
  15. May 09, 2024
    • Shawn Lin's avatar
      [DO NOT MERGE] Support biometric re-enrollment for dangling · 5b515d8b
      Shawn Lin authored
      Add a re-enroll notification with "set up" and "not now" action buttons.
      "set up" : bring users to enroll process.
      "not now" : do nothing and cancel notification.
      
      Bug: 331804186
      Test: atest FaceInternalEnumerateClientTest
                  FingerprintInternalEnumerateClientTest
      	    BiometricDanglingReceiverTest
      Flag: NONE
      Change-Id: Ic2401ae588ae5e2d404dd67d7de67491548fdfa2
      Merged-In: Ic2401ae588ae5e2d404dd67d7de67491548fdfa2
      5b515d8b
    • Yi-an Chen's avatar
      Fix error handling for non-dynamic permissions · f3cf6deb
      Yi-an Chen authored
      We only allow removing dynamic permissions. When removePermission() is
      called for a non-dynamic permission, in addition to logging it, we
      should also return early to avoid the removePermission() call.
      
      Test: manual
      Bug: 321555066
      Fixes: 321711213
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:528a87e90ff9354581d54fd37fbe9f95cccbcdb1)
      Merged-In: Ie2f43663bc71a06ffadb868d2d0eea5ee78f76e5
      Change-Id: Ie2f43663bc71a06ffadb868d2d0eea5ee78f76e5
      24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
      f3cf6deb
    • Riddle Hsu's avatar
      Make tf organizer process have visible state with visibile activity · b1e39972
      Riddle Hsu authored
      This is similar to [1]. But even if the activity is not embedded, the
      organizer process will still need to response for task fragment info
      change. So if there is any visible activity on a task which is
      associated with tf organizer, the organizer process also need to be
      visible state to handle the event.
      
      [1]: I57ef9ebe95e05842e7f325c1a4775e98c7eb57bd
      
      Fix: 337784723
      Test: atest TaskFragmentOrganizerControllerTest# \
                  testOnActivityReparentedToTask_ \
                  activityNotInOrganizerProcess_useTemporaryToken
      
      Merged-In: I42c9cb2b95c5517370ef2d26b948b3f4e0db8ec4
      Change-Id: I42c9cb2b95c5517370ef2d26b948b3f4e0db8ec4
      (cherry picked from commit 65b9bff7)
      b1e39972
    • wilsonshih's avatar
      Correct predictive condition about companion TaskFragment. · a92f6987
      wilsonshih authored
      There should only close two task fragments together when another task
      fragment sets companion to current one. If the bottom tf set it's companion
      to top tf, that means the bottom tf will be close while top activity
      be finished.
      Ref JetpackTaskFragmentOrganizer#setCompanionTaskFragment
      
      Bug: 325504342
      Test: atest BackNavigationControllerTests
      Change-Id: I1dfb9ed8b27a520db0a240e2645910656d1894df
      Merged-In: I1dfb9ed8b27a520db0a240e2645910656d1894df
      a92f6987
    • pajacechen's avatar
      Update the string and action for battery saver notification · 645675a3
      pajacechen authored
      Update the strings and tapped action for the battery saver auto-turn-on
      notification to make it clearer
      
      Bug: 336960905
      Flag: com.android.server.power.batterysaver.update_auto_turn_on_notification_string_and_action
      Test: Manual Test
      
      Change-Id: I38964a16a689ef0b887759c359d0412e5be9d306
      Merged-In: I38964a16a689ef0b887759c359d0412e5be9d306
      (cherry picked from commit aa4ccbfd)
      645675a3
  16. May 08, 2024
  17. May 06, 2024
    • Eric Laurent's avatar
      AudioService: do not mute music systematically in setBluetoothA2dpOn · 2f9fac7b
      Eric Laurent authored
      Only mute music if an actual change in Bluetooth A2DP state happens
      when setBluetoothA2dpOn() is called.
      
      Bug: 334182057
      Test: repro steps in bug.
      Change-Id: If2494dc9db1252cf1afb6ffcd600553b8140a191
      Merged-In: If2494dc9db1252cf1afb6ffcd600553b8140a191
      2f9fac7b
    • Chaitanya Cheemala's avatar
      Revert^3 "Fix for a11yManagerService broadcastReceiver ANR" · 3fc49810
      Chaitanya Cheemala authored
      This reverts commit 552f6eab.
      
      Reason for revert: Likely culprit for b/338952107  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
      
      Change-Id: I2eb76c951e3395417c75a55e537f1eeb54e48047
      3fc49810
    • Riddle Hsu's avatar
      Update insets position after rotation change is done · 22a770af
      Riddle Hsu authored
      Otherwise because getWindowFrameSurfacePosition returns old position
      before the display rotation transform is applied, if the position
      doesn't update after the transform is done, it will show old position
      in new rotation around a few frames. Such as the handle of navigation
      bar may be flickering at screen center.
      
      Bug: 338091119
      Test: atest TransitionTests#testAppTransitionWithRotationChange
      
      Merged-In: I21a0f10d4c83b6e7137ea0b389f2bbe1a4c82c2f
      Change-Id: I21a0f10d4c83b6e7137ea0b389f2bbe1a4c82c2f
      (cherry picked from commit a1d5520a)
      22a770af
Loading