Skip to content
Snippets Groups Projects
  1. Apr 03, 2024
    • Pablo Gamito's avatar
      Improve performance of ProtoLog · 7de1d5a2
      Pablo Gamito authored
      Wrap all protolog calls in an if condition using a cached state variable to make sure we don't have any overhead if the protolog message is disbaled
      
      Bug: 327341670
      
      Test: android.platform.test.scenario.calculator.OpenAppMicrobenchmark#testOpen v2/android-crystalball-eng/health/microbench/startup/hscapps/compile-speed-profile/hotlaunch/open-calculator
      Change-Id: Ic031fe076c0897d168b1e7982ad27824b2db999c
      7de1d5a2
  2. Apr 01, 2024
  3. Mar 28, 2024
    • Priyanka Advani's avatar
      Revert "Aslgen tests" · 9d5ad5cf
      Priyanka Advani authored
      Revert submission 26719621
      
      Reason for revert: Culprit for test breakages in b/331778845
      
      Reverted changes: /q/submissionid:26719621
      
      Change-Id: I16025e4a452b55017cb2717a12fdab05ccc01931
      9d5ad5cf
    • Priyanka Advani's avatar
      Revert "Adding more supported fields/logic to aslgen." · 45bd8e28
      Priyanka Advani authored
      Revert submission 26719621
      
      Reason for revert: Culprit for test breakages in b/331778845
      
      Reverted changes: /q/submissionid:26719621
      
      Change-Id: I3e69645c070d5aca4825e2b233513c7790a15239
      45bd8e28
    • Max Loh's avatar
      Adding more supported fields/logic to aslgen. · d4c7fa82
      Max Loh authored
      Includes top-level version number, transparency_info. Refactored non-Marshallable conversion logic from AndroidSafetyLabel to AslConverter. Added logic to support some more non-required fields without throwing an error.
      
      Bug: 329902686
      Test: A future CL will add a lot of unit tests, after which unit tests can be written in tandem with implementation.
      Change-Id: If4fb73cdcc40abac77ec82e436ca11ebe4feb48d
      d4c7fa82
    • Max Loh's avatar
      Aslgen tests · 5b444b94
      Max Loh authored
      Contains logic for testing as well as a couple of initial tests for HR to OD conversion. More tests will be added later. Also fixed a bug with data type parsing.
      
      Bug: 329902686
      Test: JUnit unit tests, verified by running atest
      Change-Id: I6103f5f93169f25a430cab16c2d1cb1fc4b89d44
      5b444b94
  4. Mar 20, 2024
    • Max Loh's avatar
      ASL validation logic · bd237be4
      Max Loh authored
      Adds validation logic for isSharingOptional, isCollectionOptional, and various expected elements in the input XML file.
      
      Bug: 287487923
      Test: TODO in future CLs
      Change-Id: I0a2261ec3c71a1d2df977810d065dfc5a4dda5e3
      bd237be4
    • Max Loh's avatar
      Refactor with interface pattern, and throw exception for unsupported formats · 9dd4e469
      Max Loh authored
      Revised methods allow marshalling/unmarshalling from a list of XML nodes, allowing DataCategory to be incorporated seamlessly.
      Factory pattern makes it easier to maintain createFromHrElements.
      go/asl-tc-aosp
      
      Bug: 287487923
      Test: TODO in future CLs
      Change-Id: I9fff3c1e28df74ef934da6355632c91e0ec91e79
      9dd4e469
  5. Mar 19, 2024
    • Max Loh's avatar
      ASL command-line tool initial implementation · a59f6567
      Max Loh authored
      Includes logic for converting data types from HR to OD XML format, as well as storing them in an internal Java representation. Future CLs will implement more fields, make error checking more robust, and add tests.
      
      Bug: 287487923
      Test: TODO in future CLs
      Change-Id: I6170feec9df0ce709b912d46356204badacfbe5b
      a59f6567
    • Wenhao Wang's avatar
      Init the App metadata bundles · e3a07533
      Wenhao Wang authored
      Bug: 287487923
      Test: N/A
      Change-Id: I27dd83fe44b947dbfb2742fd3a208f9a25bbe0d0
      e3a07533
  6. Mar 14, 2024
  7. Mar 13, 2024
    • Pablo Gamito's avatar
      Inject log group mapping into ProtoLogImpl generated classes · 79a6d187
      Pablo Gamito authored
      We then keep track of the logging state of each group that way and in
      particular use this to toggle groups to logcat on and off.
      
      Test: adb shell wm logging enable-text WM_DEBUG_WINDOW_TRANSITIONS
      Bug: 327491675
      Change-Id: I2a2e4cfdc51113a5aaf2adc51aa10f5df47a5051
      Merged-In: I2a2e4cfdc51113a5aaf2adc51aa10f5df47a5051
      (cherry picked from commit 869ebffa)
      79a6d187
  8. Mar 11, 2024
  9. Mar 08, 2024
    • Sorin Basca's avatar
      Update the golden image after building with JDK 21 · 833fa691
      Sorin Basca authored
      This was generated by running:
      
      m droid && $ANDROID_BUILD_TOP/frameworks/base/tools/hoststubgen/hoststubgen/test-tiny-framework/diff-and-update-golden.sh -u
      
      Bug: 313924276
      Fixes: 328674570
      Test: TH
      Merged-In: Ia238ca246c4607984beaaa229ec21f2181f6f6a8
      Change-Id: Ia238ca246c4607984beaaa229ec21f2181f6f6a8
      833fa691
  10. Mar 06, 2024
    • Pablo Gamito's avatar
      Inject log group mapping into ProtoLogImpl generated classes · 869ebffa
      Pablo Gamito authored
      We then keep track of the logging state of each group that way and in
      particular use this to toggle groups to logcat on and off.
      
      Test: adb shell wm logging enable-text WM_DEBUG_WINDOW_TRANSITIONS
      Bug: 327491675
      Change-Id: I2a2e4cfdc51113a5aaf2adc51aa10f5df47a5051
      869ebffa
    • Pablo Gamito's avatar
      Use deterministic hash for generate ProtoLogImpl postfix · 32b1b355
      Pablo Gamito authored
      This is to make sure build artifacts are more deterministic to improve developer build time, RBE cache rate, and testing infrastructure load.
      
      Bug: 327529918
      Test: none
      Change-Id: I47f47bf657eed853c683995b47f48943ab0ed9e0
      32b1b355
  11. Mar 05, 2024
    • Pablo Gamito's avatar
      Add option to only compile certain Proto messages · 6ca20ea9
      Pablo Gamito authored
      Used to save space in the framework.jar which isn't r8 optimized to
      remove unused constants.
      
      Bug: 321668269
      Test: abtd running v2/android-crystalball-eng/health/microbench/bootup/idle/aosp/system-processes-memory and checking pinner_system_/system/framework/framework.jar_bytes metric value
      Change-Id: I32d16f80364e3446799498318e40844bc8adfc5a
      6ca20ea9
  12. Feb 28, 2024
    • Makoto Onuki's avatar
      Fix typo, etc · f96aa34f
      Makoto Onuki authored
      Bug: 292141694
      Test: TH
      
      Change-Id: I96c5999679e52cb6db8a47c029291702ed4832a8
      f96aa34f
    • Makoto Onuki's avatar
      Temporarily disable test_compare_to_golden · 2fef277d
      Makoto Onuki authored
      Bug: 326897452
      Test: atest tiny-framework-dump-test # make sure the test won't run
      Change-Id: I8d674d0819a03e95a9e2400c6d4284588edc8794
      2fef277d
    • Pablo Gamito's avatar
      Increment protolog version · 9abac8a7
      Pablo Gamito authored
      Because we now dump 64 bit integers instead of 32 bit integers we need to have a different protolog version so we know which viewer config to use in Winscope
      
      Bug: 327002914
      
      Test: collected protolog trace in Winscope
      Change-Id: Iab3071952ff7957a11a0f01f09cfaa4306a7f7ae
      9abac8a7
    • Wei Li's avatar
      Change the default package license to Apache-2.0 and remove the Android.mk. · 1a20c12e
      Wei Li authored
      The Android.mk contains license declaration for aapt2_result only, and with this change that declares the license of the package precisely the
      Android.mk is not needed any more.
      
      Bug: 322285259
      Test: CIs
      Change-Id: Ie4b82686cc72d07b1c75016ede6f3c7c53816e83
      1a20c12e
  13. Feb 26, 2024
  14. Feb 22, 2024
    • Pablo Gamito's avatar
      Update ProtoLog build rules · 5fe2c80e
      Pablo Gamito authored
      ProtoLogTool now has additional parameters to support Perfetto tracing. We also need to generate and include a proto version of the viewer configuration.
      
      Flag: ACONFIG android.tracing.Flags.perfettoProtolog DEVELOPMENT
      Test: mp droid && atest FrameworksServicesTests
      Bug: 276432490
      Change-Id: I26929eed96faae04bec65ae5eaf86afda75cb83c
      5fe2c80e
    • Pablo Gamito's avatar
      Refactor ProtoLogImpl to support Perfetto tracing with flag better · 0ce7d7ce
      Pablo Gamito authored
      Flag: ACONFIG android.tracing.Flags.perfettoProtolog DEVELOPMENT
      Bug: 276432490
      Test: atest FrameworksServicesTests
      Change-Id: If95bfeeaff491ce51b61e34d2f8c22d8b635912d
      0ce7d7ce
    • Pablo Gamito's avatar
      Update ProtoLogTool · 44fe3a9a
      Pablo Gamito authored
      Generate the impl classes and support writing the viewer config to a proto file
      
      Flag: ACONFIG android.tracing.Flags.perfettoProtolog DEVELOPMENT
      Bug: 276432490
      Test: atest FrameworksServicesTests
      Change-Id: I69956b5ef2b8b48a98860aa3b8579521480d7bc0
      44fe3a9a
    • Pablo Gamito's avatar
      Update ProtoLogTool commands args · 329813a9
      Pablo Gamito authored
      We need these new parameters to inject those values into the generated classes so we don't have to manually create an impl of these class and passing those values manually.
      
      Flag: ACONFIG android.tracing.Flags.perfettoProtolog DEVELOPMENT
      Bug: 276432490
      Test: atest FrameworksServicesTests
      Change-Id: I32906cbe37c7c3899d7c487d5ed341381a05fdf1
      329813a9
    • Pablo Gamito's avatar
      Update ProtoLog hash function to 64 bit · 01e08016
      Pablo Gamito authored
      To avoid hash collisions now that we have more messages.
      
      Flag: ACONFIG android.tracing.Flags.perfettoProtolog DEVELOPMENT
      Bug: 276432490
      Test: atest FrameworksServicesTests
      Change-Id: Ia252f1fc60deb2beaf177b0782a8723e39f90a7e
      01e08016
    • Pablo Gamito's avatar
      Extract LogLevel to common package · f44daf99
      Pablo Gamito authored
      Since we now use it in a few different places including in the ProtoLogTool.
      
      Flag: ACONFIG android.tracing.Flags.perfettoProtolog DEVELOPMENT
      Bug: 276432490
      Test: atest FrameworksServicesTests
      Change-Id: Iba3a4904ea0b5e27afb1486c765e627fb343f6af
      f44daf99
  15. Feb 16, 2024
    • Sorin Basca's avatar
      Update the golden image after building with JDK 21 · e43430ac
      Sorin Basca authored
      This was generated by running:
      
      m droid && $ANDROID_BUILD_TOP/frameworks/base/tools/hoststubgen/hoststubgen/test-tiny-framework/diff-and-update-golden.sh -u
      
      Bug: 313924276
      Test: TH
      Change-Id: Ia238ca246c4607984beaaa229ec21f2181f6f6a8
      e43430ac
  16. Feb 15, 2024
    • Makoto Onuki's avatar
      [Hoststubgen] Allow to apply policy based on inheritance · 3e12731d
      Makoto Onuki authored
      Use "*" + base class/interface name in the policy file to define
      an inheritance based policy.
      
      Wrote it to investigate classpath conflicting problem.
      
      It's not actually used on ravenwood. (at least yet)
      
      Test: ./ravenwood/run-ravenwood-tests.sh
      Bug: 292141694
      Change-Id: I173e2545a1ad9e0bc374d6798e1558dacc3569bd
      3e12731d
  17. Feb 14, 2024
    • Makoto Onuki's avatar
      Include hoststubgen tests in run-ravenwood-tests.sh · d347a616
      Makoto Onuki authored
      And remove the stale run-all-tests.sh.
      
      Bug: 315031371
      Test: ./ravenwood/run-ravenwood-tests.sh
      Change-Id: I2ac6457b1f60017c6e4e506ca11dbd7fc18dfa59
      d347a616
    • Dan Willemsen's avatar
      Set static timestamps in protologtool output · d0473319
      Dan Willemsen authored
      When build outputs are deterministic, that helps improve the RBE cache
      hit rate.
      
      Bug: 325124724
      Test: m out/soong/.intermediates/frameworks/base/libs/WindowManager/Shell/wm_shell_protolog_src/6c826b466f2421b82c3ec7d86f8481e7/gen/wm_shell_protolog.srcjar; zipinfo $!
      Change-Id: I838eb379531ae5434d576828e6be43663122187b
      d0473319
  18. Feb 13, 2024
    • Makoto Onuki's avatar
      Move "runtime helpers" to f/b/ravenwood · 053eac85
      Makoto Onuki authored
      - Also make sure framework-minus-apex is prioritized
      - Also some build rule cleanup
      
      Bug: 315031371
      Test: ./ravenwood/run-ravenwood-tests.sh
      
      Change-Id: I2d0eb822517abfc17f351810a53176ad9904f908
      053eac85
  19. Feb 12, 2024
    • Jeff Sharkey's avatar
      hoststubgen: Slightly refined stats. · fae66ea5
      Jeff Sharkey authored
      To give more accurate statistics, focus only on public non-abstract
      methods.  Shift measurement back to `BaseAdapter`, but only collect
      stats when operating in the `impl` mode; this ensures we're early
      enough to accurately count `substitute-from` methods.
      
      Also ignore common generated code like Protos, StatsLog, and
      LogTags, as we'll eventually be handling them all in a more
      consistent way.
      
      Bug: 324417456
      Test: atest FrameworksCoreTestsRavenwood
      Change-Id: I07e0ea4107b27dbfa241c48c9f05def445b78cfe
      fae66ea5
    • Jeff Sharkey's avatar
      Human-readable XML on Ravenwood. · 1e92835f
      Jeff Sharkey authored
      We had temporarily been using the binary XML implementation in all
      situations, but this change brings in the existing `kxml2-android`
      library to offer reading/writing of human-readable XML.  We also
      use the upstream SAX parser to offer an event-based parser.
      
      In all cases we carefully keep the existing XML libraries in place
      untouched on physical devices to avoid regressions.
      
      Bug: 324417456
      Test: atest CtsUtilTestCasesRavenwood
      Test: atest FrameworksCoreTestsRavenwood
      Test: atest FrameworksUtilTestsRavenwood
      Change-Id: I2effc7fca5c586968658073f9652d13cf50a2c66
      1e92835f
    • Pablo Gamito's avatar
      Add ProtoLog owners files · 2605a438
      Pablo Gamito authored
      Test: n/a
      Change-Id: I6e8a3f288a231f44e0df20b52f0bbf6a0ca08460
      2605a438
  20. Feb 09, 2024
    • Jeff Sharkey's avatar
      hoststubgen: Emit stats for dashboarding. · d2cc1917
      Jeff Sharkey authored
      As we expand our audience, developers will be interested in knowing
      what APIs are supported through a top-down dashboard view that we
      can continually update over time.
      
      This change emits a statistics CSV that can be easily bulk-imported
      to generate a dashboard.
      
      Bug: 322895594
      Test: TH
      Change-Id: Idea55b64cdb79e9a49f63340f83a1b395f8e5ec7
      d2cc1917
Loading