Skip to content
Snippets Groups Projects
  1. Mar 09, 2024
    • Pranav Madapurmath's avatar
      Improve DisconnectCause API for mainline. · dd438af8
      Pranav Madapurmath authored
      As part of API feedback, improve the DisconnectCause API that was
      formalized as part of Telecom mainline. This CL has some minor cleanup
      around those suggestions (refer to the associated bug for more details).
      
      Bug: 327030432
      Bug: 311773409
      Test: atest TelecomUnitTests, atest DataObjectUnitTests
      Change-Id: Ic1dd1ae2221be21207474950f307ba72fe8b35af
      dd438af8
  2. Mar 05, 2024
    • Pranav Madapurmath's avatar
      Set telecomCallId in Remote ConnectionRequest · d8bb7781
      Pranav Madapurmath authored
      Ensure that the telecom call id generated when creating a remote
      connection or conference in RemoteConnectionService is saved into the
      ConnectionRequest. This was causing the call id to show up as null in
      Telephony.
      
      Bug: 323358714
      Test: atest RemoteConnectionTest
      Change-Id: I6a65c81af302da5071c5f24f728cf4a94415836e
      d8bb7781
  3. Mar 04, 2024
    • Thomas Stuart's avatar
      update TM#getRegisteredPhoneAccounts docs · 920b387d
      Thomas Stuart authored
      API review noted that I should mention that the API will only return
      accounts registered by the same app.
      
      Fixes: 327333100
      Test: existing CTS coverage + javadoc comment check (renders properly)
      Change-Id: I355ae4d09e857568c5d5198a3d69838e8df0daff
      920b387d
    • Pranav Madapurmath's avatar
      TelecomManager consolidate isInSelfManagedCall. · dbb2887d
      Pranav Madapurmath authored
      As per API feedback, consolidate TelecomManager#isInSelfManagedCall into
      a single API which only takes a UserHandle and disregard the
      hasCrossUserAccess parameter. Instead, the caller can specify
      UserHandle.ALL in order to indicate that self managed calls across all
      users should be checked.
      
      Bug: 327029478
      Bug: 311773409
      Test: atest SelfManagedConnectionServiceTest
      Change-Id: Icbffaf8d2a507f519eb2fda34106a359f1bddaf4
      dbb2887d
  4. Feb 16, 2024
    • Thomas Stuart's avatar
      add API for getRegisteredPhoneAccounts · 1a9c30a4
      Thomas Stuart authored
      currently there is no way for VoIP applications to fetch their
      registered PhoneAccounts with Telecom. TelecomManager#getPhoneAccount
      is gated by the READ_PHONE_STATE permission which is a highly privileged
      permission that VoIP apps will not be granted. This API will not only allow
      VoIP apps to get all registered PhoneAccounts with Telecom but Managed apps
      (like system Dialers) can use it.  This is helpful to know what calling
      capabilities are currently registered and know the state of Telecom.
      
      Bug: 307609763
      Test: CTS coverage
      Change-Id: I73ace8cd766369f877c7fc0ef985f6a0c575e097
      1a9c30a4
  5. Feb 14, 2024
    • Pranav Madapurmath's avatar
      Separate TelecomManager#isInSelfManagedCall APIs · 4d509e0a
      Pranav Madapurmath authored
      Instead of consolidating the TelecomManager#isInSelfManagedCall APIs
      which combine the cross user logic with the ability to also specifiy a
      user handle, create two separate APIs to handle this. One will allow the
      caller to specify a user handle while the other will allow them to
      specify if calls should be verified across all users.
      
      Ensure that if the user handle specified isn't the caller or that
      interacting across users is defined in the parameter, that the
      permission check is enforced properly. Otherwise, ensure that the user
      handle being verified is always the caller.
      
      Bug: 323958718
      Bug: 311773409
      Test: atest SelfManagedConnectionServiceTest
      Change-Id: Ie7096c0a876cca2cf8e1e70cd3ae102127f60197
      4d509e0a
    • Ronish Kalia's avatar
      [DON'T BLOCK] Test ownership migration rules · f891397b
      Ronish Kalia authored
      This CL is created as a best effort to migrate test targets
      to the new android ownership model. If you find incorrect or unnecessary
      attribution in this CL, please create a separate CL to fix that.
      
      For more details please refer to the link below,
      <add g3 doc link>
      
      Bug: 304529413
      Test: N/A
      Change-Id: I6b6cf0abdd1fdb8fefa4184b3698f6951c192ac0
      f891397b
  6. Feb 11, 2024
    • Pranav Madapurmath's avatar
      Formalize EXTRA_SKIP_CALL_FILTERING as system API · 9ad3039d
      Pranav Madapurmath authored
      As part of telecom mainline prep, resolve the hidden reference from wear
      services to EXTRA_SKIP_CALL_FILTERING by promoting it to a system API.
      
      Bug: 322518197
      Bug: 311773409
      Test: m Telecom
      Test m wear-services-calling-bluetooth & atest
      WearServicesRoboTests:HfpClientConnectionServiceTest & atest
      WearServicesRobotTests:HfpClientConnectionTest
      
      Change-Id: I47b3f2d6146309157c18246e0e131bab1021c726
      9ad3039d
  7. Feb 08, 2024
    • Thomas Stuart's avatar
      add new APIs for Enriched Calling · 4fab083a
      Thomas Stuart authored
      This feature lets users know if a verified business is calling and the
      name of the business calling.
      
      Bug: 324325516
      Bug: 226518586 (root)
      Test: CTS
      Change-Id: Ie25ef3d4952f7a21655015b8a1234a9ca22b5493
      4fab083a
    • Pranav Madapurmath's avatar
      Include DisconnectCause Builder · 8c5695ce
      Pranav Madapurmath authored
      As part of telecom mainline prep, the previously hidden DisconnectCause
      constructor (which includes the Telephony debug info) was promoted to a
      system API. From API feedback, a request was put forward to add a
      Builder to consolidate the construction of the DisconnectCause instance.
      
      This CL adds the Builder and reverts the previous changes to make the
      constructor an API. Instead, the Telephony reference has been resolved
      to use the builder pattern instead. The other constructors have been
      untouched sincce there are many references within Telecom, which would
      make the changes unnecessarily noisy. Those can be cleaned up for a
      separate refactor but they shouldn't block mainline prep work.
      
      Bug: 324414185
      Bug: 311773409
      Test: atest TelecomUnitTests, atest DataObjectUnitTests
      Change-Id: I784915cac286322c50f9e605ef457969f5a8cda4
      8c5695ce
  8. Feb 07, 2024
    • Pranav Madapurmath's avatar
      Resolve API feedback TelecomManager#isInSelfManagedCall · 63490381
      Pranav Madapurmath authored
      As part of the mainline work, feedback has given to change the
      hasCrossUserAccess param to better match the description. The
      INTERACT_ACROSS_USERS permission has also been made an optional
      parameter which is enforced when the user handle passed in doesn't match
      the calling user or when the detectForAllUsers parameter is set to true.
      
      Bug: 323958718
      Bug: 311773409
      Test: atest SelfManagedConnectionServiceTest
      Change-Id: I96c04249e6320bde355a1efeddf0374048b84198
      63490381
    • Pranav Madapurmath's avatar
      Formalize DisconnectCause API · 4aaf2a23
      Pranav Madapurmath authored
      As part of telecom mainline, formalize the hidden DisconnectCause
      constructor (used by Telephony) into a system API. Additionally, the
      telephony related debug info getters also need to be formalized:
      getTelephonyDisconnectCause, getTelephonyPreciseDisconnectCause,
      getImsReasonInfo.
      
      Bug: 322518612
      Bug: 311773409
      Test: atest DataObjectUnitTests
      Change-Id: Idb0c502bde5391012349a58358515c59fc3cb893
      4aaf2a23
  9. Feb 06, 2024
  10. Feb 02, 2024
    • Tyler Gunn's avatar
      Formalize ConnectionService#onCreateXComplete hidden APIs. · da266f20
      Tyler Gunn authored
      These were added a long time ago for the Telephony stack so that it could
      know when Telecom has finished adding a new connection or conference.
      The original design of ConnectionService#onCreateConnectionComplete and
      ConnectionService#onCreateConferenceComplete assumes that the developer
      returns their instance of Connection or Conference, respectively, from
      those APIs and the platform then adds those to Telecom.
      
      The original API design there has a small timing issue in that if you
      want to signal on the Connection/Conference, you need to wait until it has
      been added to Telecom first.  In practice this is not often a problem,
      well, until it is.  We've had a few 3p VOIP apps running into similar
      issues so making these public gives them the same benefit we've seen
      in the Telephony stack.
      
      Test: Added new CTS test coverage for these APIs.
      Fixes: 317391843
      Change-Id: I46b00e468873bc7f880f6a4bd2416adfa0a4c161
      da266f20
    • Hui Wang's avatar
      Update the java doc of getCallCapablePhoneAccountsAcrossProfiles · 22747ecc
      Hui Wang authored
      Bug: 318471441
      Test: make
      Change-Id: I6539835f6de9d196170683097967507e3e74d1cd
      22747ecc
  11. Jan 30, 2024
    • Pranav Madapurmath's avatar
      Formalize TelecomManager#isInSelfManagedCall · f6e8b18f
      Pranav Madapurmath authored
      Make TelecomManager#isInSelfManagedCall a proper system API as per
      mainline prep. Note that this is only used by the system UI.
      
      Bug: 322516073
      Bug: 311773409
      Test: atest SelfManagedConnectionServiceTest
      Change-Id: I364eab0aab66290dd96e5f23ee4dc52febaba384
      f6e8b18f
  12. Jan 26, 2024
    • Pranav Madapurmath's avatar
      Formalize CallDirection APIs · e045e66a
      Pranav Madapurmath authored
      Promote Connection#getCallDirection into a proper system API as part of
      Telecom internal mainline prep (used by Telephony to get call direction
      of the connection).
      
      Bug: 322514233
      Bug: 311773409
      Test: atest ConnectionServiceTest
      Change-Id: I36acd83503148a7919518dd26f06d5aca0b49b86
      e045e66a
    • Pranav Madapurmath's avatar
      Formalize Connection CallQuality report APIs · 106df3bc
      Pranav Madapurmath authored
      Promote Connection#EVENT_CALL_QUALITY_REPORT as well as
      Connection#EXTRA_CALL_QUALITY_REPORT into proper system APIs. These are
      used by Telephony to send the call quality report from Telephony over to
      Telecom which is retreived by CallDiagnosticService.
      
      Bug: 322513691
      Bug: 311773409
      Test: atest CtsCallDiagnosticService
      Change-Id: I06c0cd021d1de3ff54ead59fb7483547599193e3
      106df3bc
    • Hui Wang's avatar
      Update OWNERS file · 1c888b45
      Hui Wang authored
      Test: Manual
      Change-Id: Ia72b2cd3a3b50acad0139bad929ea5c57491851e
      1c888b45
    • Brad Ebinger's avatar
      Add Simultaneous Calling restrictions to PhoneAccount toString · 5365cc32
      Brad Ebinger authored
      Bug: 319904227
      Test: Inspection of toString via adb shell dumpsys telecom
      Change-Id: I061f492e8cbb16b6504f668846690fa4d7b3ff31
      5365cc32
  13. Jan 25, 2024
  14. Jan 22, 2024
  15. Jan 20, 2024
    • Thomas Stuart's avatar
      CallControl#setMuteState API changes · 0bc7c58a
      Thomas Stuart authored
      These changes are in response to an API review on the recent addition of the CallControl#setMuteState API.
      
      API changes:
      - change setMuteState to requestMuteState
      - change @Nullable CallControl to @NonNull
      
      Impl changes:
      - remove ClientTransactionalWrapper from the hidden contructor
      - remove PhoneAccountHandle from the hidden constructor
      - remove the if serviceInterface != null clause
      
      Fixes: 320507724
      Test: adjusted CallControlTest class
      Change-Id: I7c2352ca2038c2d3d175f7ca7167d4b3b4ff340e
      0bc7c58a
    • Brad Ebinger's avatar
      Docs fix for simultaneous calling API · 516e7ab6
      Brad Ebinger authored
      Bug: 319904227
      Test: docs only fix
      Flag: DOCS ONLY CHANGE
      Change-Id: I950ebf552269df560ffd873a0d75ffc6519234ff
      516e7ab6
  16. Jan 18, 2024
  17. Jan 17, 2024
  18. Jan 16, 2024
  19. Jan 12, 2024
    • Thomas Stuart's avatar
      add setMuteState framework changes · fc93e93c
      Thomas Stuart authored
      previously, there was no way to mute a Transactional call via the
      CallControl object.  In order to mute the call, the AudioService
      was needed.
      
      Now, clients can use CallControl#setMuteState to mute the call.
      
      Fixes: 310669304
      Test: 1 new CTS test
      Change-Id: I7b5d834b8073dd8fbae07d31722aa8f54a88b26e
      fc93e93c
  20. Jan 05, 2024
  21. Dec 19, 2023
    • Tyler Gunn's avatar
      Delete unused AuthenticatorService Telecom code. · 5b59252e
      Tyler Gunn authored
      This is not used anywhere and is not an API.
      
      Bug: 308003610
      Flag: Removing unused code, no flag required.
      Test: Compile to verify no build errors.
      Change-Id: I27f9efd5991bb53b9f1260da625684039ca8dbbc
      5b59252e
    • Tyler Gunn's avatar
      Remove unused hidden handover code. · 59195e5e
      Tyler Gunn authored
      These extras are not used anywhere.  Removing them and the associated
      code.
      
      Flag: Code cleanup only; no functional impact since this is orphaned code.
      Test: Compile code to verify no build errors.
      Bug: 308003610
      Change-Id: I598707edc70b23eab3b6cbd39e20321305056237
      59195e5e
    • Tyler Gunn's avatar
      Remove orphaned code. · cedc19a7
      Tyler Gunn authored
      Remove orphaned code that is not called by anything.
      
      Bug: 308003610
      Test: Compile to verify no uses.
      Flag: Not required; unreachable code path.
      Change-Id: I4750c22ae0bd58e24a7e4b939a36be0064b8a7cd
      cedc19a7
  22. Dec 11, 2023
  23. Dec 07, 2023
  24. Nov 22, 2023
    • xiaotonj's avatar
      DO NOT MERGE · 8d552499
      xiaotonj authored
      Fix areBundleEqual in Call.
      
      Currently the sentence in areBundleEqual arranged in a wrong order.
      Fixed this by moving the check sentence before the actual query
      sentence.
      
      Bug: b/312604549
      Test: cts call tests
      Change-Id: Id8caa5719b4df724cbe03edd75b99a2b2e3882b5
      8d552499
    • Rana Mouawi's avatar
      Add DO_NOT_LOG_CALL extra definition for omitting a call from the call log. · ce746778
      Rana Mouawi authored
      Bug: b/295530944
      Test: Unit tests pass.
      Defer-CP-To-Master: 297157687
      
      Change-Id: I70197f1393bc77dfbf29056192fde6c8be8d1009
      (cherry picked from commit c92465b603f5d294473308f85c9cfc441665037a)
      ce746778
  25. Nov 17, 2023
    • Pranav Madapurmath's avatar
      Avoid resetting InCallAdapter when set. · 74319651
      Pranav Madapurmath authored
      This causes issues, for instance, when we have a MO and MT call
      ongoing. The associated users for both calls would be different
      based on the logic that was added for work profiles (MT calls
      associated with target phone account handle user while MO calls
      are associated with the profile user). As a result, resetting
      the adapter puts Telecom in a state where it is unable to update
      the existing calls.
      
      The framework changes ensure that the phone instance (which provides
      the in-call information to the user) is not being reset when it's
      already instantiated.
      
      Bug: 308856446
      Bug: 294699269
      Test: Manual
      Test: New unit test to verify that call updates are persevered when
      MO/MT call are placed from the secondary/guest user.
      Test: v2/android-platinum/telephony-platinum-tests-ATT
      
      Change-Id: I4976c0ec67d515e96f6d4df53c79ac500eb6a06e
      74319651
  26. Nov 16, 2023
    • Priyanka Advani's avatar
      Revert "Avoid resetting InCallAdapter when set." · fd53c96b
      Priyanka Advani authored
      Revert submission 24838577-cherrypick-MT-MO-secondaryUserCallUpdateFix-udc-qpr-dev-70l1hzdwrmf
      
      Reason for revert: Probable culprit for b/311270644.
      
      Reverted changes: /q/submissionid:24838577-cherrypick-MT-MO-secondaryUserCallUpdateFix-udc-qpr-dev-70l1hzdwrmf
      
      Change-Id: Ic0a30f091de2bdf06f6c4ffc8c1a2725b64ac871
      fd53c96b
  27. Nov 10, 2023
    • Anton Hansson's avatar
      Make all typedefs SOURCE retention · faf2ba91
      Anton Hansson authored
      The default retention is CLASS, but the correct retention is SOURCE.
      There is a metalava check for typedef annotations correctly, but that
      check is currently disabled. This is part of the work required to
      re-enable that check.
      
      Bug: 309971481
      Test: m checkapi
      Change-Id: I386efea9321bd2adb2722710056b1d57dd5401f5
      faf2ba91
Loading