Skip to content
Snippets Groups Projects
  1. Dec 08, 2020
    • Jeff Sharkey's avatar
      Improve OWNERS coverage across frameworks/base/. · fab0ab3c
      Jeff Sharkey authored
      As general background, OWNERS files expedite code reviews by helping
      code authors quickly find relevant reviewers, and they also ensure
      that stakeholders are involved in code changes in their areas.
      
      Some teams under frameworks/base/ have been using OWNERS files
      successfully for many years, and we're ready to expand them to cover
      more areas.  Here's the historical coverage statistics for the last
      two years of changes before these new OWNERS changes land:
      
      -- 56% of changes are fully covered by OWNERS
      -- 17% of changes are partially covered by OWNERS
      -- 25% of changes have no OWNERS coverage
      
      Working closely with team leads, we've now identified clear OWNERS on
      a per-package basis, and we're using "include" directives whenever
      possible to to simplify future maintenance.  With this extensive
      effort, we've now improved our coverage as follows:
      
      -- 98% of changes are fully covered by OWNERS
      -- 1% of changes are partially covered by OWNERS
      -- 1% of changes have no OWNERS coverage
      
      This specific change is automatically generated by a script from
      detailed ownership information confirmed by team leads.
      
      Bug: 174932174
      Test: manual
      Exempt-From-Owner-Approval: refactoring with team leads buy-in
      Merged-In: I9789c97c1de8e5d962b48c29c57d82fe83729eba
      Change-Id: I9789c97c1de8e5d962b48c29c57d82fe83729eba
      fab0ab3c
  2. Nov 04, 2020
    • Mathew Inwood's avatar
      Add maxTargetSdk restriction to unused APIs. · 5d123b67
      Mathew Inwood authored
      These are APIs that have @UnsupportedAppUsage but for which we don't
      have any evidence of them currently being used, so should be safe to
      remove from the unsupported list.
      
      Bug: 170729553
      Test: Treehugger
      Merged-In: I626caf7c1fe46c5ab1f39c2895b42a34319f771a
      Change-Id: I54e5ecd11e76ca1de3c5893e3a98b0108e735413
      5d123b67
  3. Nov 02, 2020
    • Mathew Inwood's avatar
      Add maxTargetSdk restriction to unused APIs. · 5f0edaaa
      Mathew Inwood authored
      These are APIs that have @UnsupportedAppUsage but for which we don't
      have any evidence of them currently being used, so should be safe to
      remove from the unsupported list.
      
      Bug: 170729553
      Test: Treehugger
      Merged-In: I8285daa8530260251ecad6f3f38f98e263629ca7
      Change-Id: I626caf7c1fe46c5ab1f39c2895b42a34319f771a
      5f0edaaa
  4. Oct 29, 2020
    • Mathew Inwood's avatar
      Add maxTargetSdk restriction to unused APIs. · 8e742f92
      Mathew Inwood authored
      These are APIs that have @UnsupportedAppUsage but for which we don't
      have any evidence of them currently being used, so should be safe to
      remove from the unsupported list.
      
      This is a resubmit of ag/12929664 with some APIs excluded that caused
      test failures; see bugs 171886397, 171888296, 171864568.
      
      APIs excluded:
      Landroid/bluetooth/le/ScanRecord;->parseFromBytes([B)Landroid/bluetooth/le/ScanRecord;
      Landroid/os/Process;->myPpid()I
      Landroid/os/SharedMemory;->getFd()I
      Landroid/hardware/input/InputManager;->INJECT_INPUT_EVENT_MODE_WAIT_FOR_FINISH:I
      
      Bug: 170729553
      Test: Treehugger
      Change-Id: I8285daa8530260251ecad6f3f38f98e263629ca7
      8e742f92
  5. Oct 28, 2020
  6. Oct 27, 2020
    • Mathew Inwood's avatar
      Add maxTargetSdk restriction to unused APIs. · 72f07d6a
      Mathew Inwood authored
      These are APIs that have @UnsupportedAppUsage but for which we don't
      have any evidence of them currently being used, so should be safe to
      remove from the unsupported list.
      
      Bug: 170729553
      Test: Treehugger
      Change-Id: I4c8fd0006f950de9955242e93968fb0996ceb372
      72f07d6a
  7. Jan 23, 2020
    • Artur Satayev's avatar
      Replace dalvik..UnsupportedAppUsage annotation. · 9a5c3105
      Artur Satayev authored
      The new annotation to be used is android.compat.annotation.UnsupportedAppUsage.
      
      Test: m
      Bug: 145132366
      Change-Id: Ib2101605fb385b4f778893e5181a954dccbea037
      Exempt-From-Owner-Approval: roll-forward previously approved change
      9a5c3105
  8. Jan 14, 2020
    • Artur Satayev's avatar
      Use new UnsupportedAppUsage annotation. · 53ada2ab
      Artur Satayev authored
      Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.
      
      Bug: 145132366
      Test: m && diff unsupportedappusage_index.csv \
            git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import'
      Merged-In: I853372f3c6fef905553bb31be4f1bb48df735f7a
      Change-Id: I853372f3c6fef905553bb31be4f1bb48df735f7a
      53ada2ab
  9. Jan 08, 2020
    • Artur Satayev's avatar
      Use new UnsupportedAppUsage annotation. · 2ebb31c0
      Artur Satayev authored
      Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.
      
      Bug: 145132366
      Test: m && diff unsupportedappusage_index.csv \
            git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import'
      
      Change-Id: I853372f3c6fef905553bb31be4f1bb48df735f7a
      2ebb31c0
  10. Dec 19, 2019
  11. Dec 18, 2019
    • Artur Satayev's avatar
      Use new UnsupportedAppUsage annotation. · a5264903
      Artur Satayev authored
      Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.
      
      Bug: 145132366
      Test: m && diff unsupportedappusage_index.csv \
            git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import'
      Change-Id: I087bb1cecbe59f1cf0c2e770c735d7a433722c6f
      a5264903
  12. Nov 19, 2019
    • Artur Satayev's avatar
      Add @UnsupportedAppUsage annotations for greylist. · 751e5511
      Artur Satayev authored
      go/cleanup-greylist-txt
      
      These have already been greylisted, however due to bugs/omissions in the tooling have been kept in go/greylist-txt instead of being annotated in the code.
      
      This is partial merge of aosp/Id6c1f5e403a0e66edb1102ee45f3bf19f244fb09. Telephony greylist cleanup has been done separately. Note that annotations outside of frameworks/base/ have been merged from AOSP.
      
      Bug: 137350495
      Test: m
      Exempt-From-Owner-Approval: merge
      Change-Id: I015c466e8b69cc0fed5e9d394ba865aad11d8ba6
      751e5511
  13. Nov 08, 2019
    • Artur Satayev's avatar
      Add @UnsupportedAppUsage annotations for greylist. · fc46be7d
      Artur Satayev authored
      go/cleanup-greylist-txt
      
      These have already been greylisted, however due to bugs/omissions in the tooling have been kept in go/greylist-txt instead of being annotated in the code.
      
      Bug: 137350495
      Test: m
      
      Change-Id: Id6c1f5e403a0e66edb1102ee45f3bf19f244fb09
      Merged-In: Id6c1f5e403a0e66edb1102ee45f3bf19f244fb09
      fc46be7d
  14. Sep 10, 2019
  15. Apr 04, 2019
    • Courtney Goeltzenleuchter's avatar
      EGLAttrib requires special handling in JNI · 43ef0c3d
      Courtney Goeltzenleuchter authored
      EGLAttrib is defined for a C / C++ interface and is
      intended to be the size of a pointer. That can change
      depending on which abi the code is built for but Java doesn't
      have a way of dealing with such types. Java defines EGLAttrib
      as a jlong, so need to convert jlong to 32bit when running on
      a 32bit device.
      
      Bug: 124382141
      Test: atest --all-abi CtsGraphicsTestCases:EGL15Test
      Change-Id: I966f6a3716b2710e17d10e0d0cb58314853675e0
      43ef0c3d
  16. Mar 27, 2019
    • Leon Scroggins III's avatar
      Pass Bitmap's native instance to JNI where feasible · 71fae62f
      Leon Scroggins III authored
      Test: CtsGraphicsTestCases, CtsUiRenderingTestCases,
            CtsRenderscriptTestCases
      
      This is significantly faster than passing the Java object down and then
      calling a JNI method to retrieve the pointer. See
      https://buganizer.corp.google.com/issues/16656908#comment19
      
      In some cases this changes what used to be native crashes (due to
      android::BitmapWrapper:assertValid's LOG_ALWAYS_FATAL_IF) into
      NullPointerExceptions (if a caller used a null Bitmap).
      
      In addition:
      - Remove unnecessary JNIEnv param from toBitmap(jlong)
      - Change instances of toBitmap(JNIEnv*, jobject) to the above
      - Replace calls to GraphicsJNI::getSkBitmap() to inline calls to
        toBitmap/getSkBitmap
      - make Canvas#nInitRaster @FastNative (FIXME: Could these be
        @CriticalNative?)
      
      Change-Id: I6194097be1b6e6952eba70e1e7052a5a250eed93
      71fae62f
  17. Oct 24, 2018
  18. Oct 23, 2018
    • Courtney Goeltzenleuchter's avatar
      Add EGL15: eglCreateImage, eglDestroyImage · 6e8c60cc
      Courtney Goeltzenleuchter authored
      Also change eglCreatePlatformPixmapSurface to throw an
      unsupported extension rather than call the native function
      which will return an error indicating it's unsupported.
      
      Bug: 80297325
      Test: atest CtsGraphicsTestCases:EGL15Test
      Change-Id: I94f2d39678515fdacf9b2fccd1c531365930ad1b
      6e8c60cc
  19. Oct 16, 2018
    • Courtney Goeltzenleuchter's avatar
      Update to EGL 1.5 · 367ed8b1
      Courtney Goeltzenleuchter authored
      Test: compile
      Bug: 80239516
      Change-Id: I1c00ac5e55900260b724e1c298edca15f87f3a01
      (cherry picked from commit 63584195b9d15daa9973d280381fd619cd7a0f89)
      367ed8b1
  20. Aug 17, 2018
    • Mathew Inwood's avatar
      Add @UnsupportedAppUsage annotations · 585f2716
      Mathew Inwood authored
      For packages:
        javax.microedition.khronos.opengles
        javax.microedition.khronos.egl
      
      This is an automatically generated CL. See go/UnsupportedAppUsage
      for more details.
      
      Exempted-From-Owner-Approval: Mechanical changes to the codebase
      which have been approved by Android API council and announced on
      android-eng@
      
      Bug: 110868826
      Test: m
      Change-Id: I0af80d46c5810dab9f7002cc33537e9356ae55d1
      Merged-In: I3615f60789c14c44284c896c3a9ea291100dff8e
      585f2716
    • Mathew Inwood's avatar
      Add @UnsupportedAppUsage annotations · b6c9782f
      Mathew Inwood authored
      For packages:
        javax.microedition.khronos.opengles
        javax.microedition.khronos.egl
      
      This is an automatically generated CL. See go/UnsupportedAppUsage
      for more details.
      
      Exempted-From-Owner-Approval: Mechanical changes to the codebase
      which have been approved by Android API council and announced on
      android-eng@
      
      Bug: 110868826
      Test: m
      Change-Id: I3615f60789c14c44284c896c3a9ea291100dff8e
      b6c9782f
  21. Aug 09, 2018
    • Mathew Inwood's avatar
      Add @UnsupportedAppUsage annotations · 6e80c54e
      Mathew Inwood authored
      For packages:
        android.opengl
      
      This is an automatically generated CL. See go/UnsupportedAppUsage
      for more details.
      
      Exempted-From-Owner-Approval: Mechanical changes to the codebase
      which have been approved by Android API council and announced on
      android-eng@
      
      Bug: 110868826
      Test: m
      Change-Id: Iac5bb97445d3f0e3383df0223e2d18fbdc336839
      Merged-In: I747cf5d5e6e211dc368545472fee65fd20cdae74
      6e80c54e
    • Mathew Inwood's avatar
      Add @UnsupportedAppUsage annotations · c04326d7
      Mathew Inwood authored
      For packages:
        android.opengl
      
      This is an automatically generated CL. See go/UnsupportedAppUsage
      for more details.
      
      Exempted-From-Owner-Approval: Mechanical changes to the codebase
      which have been approved by Android API council and announced on
      android-eng@
      
      Bug: 110868826
      Test: m
      Change-Id: I747cf5d5e6e211dc368545472fee65fd20cdae74
      c04326d7
  22. May 01, 2017
  23. Apr 22, 2017
    • John Reck's avatar
      Workaround apps that override surfaceCreated · e7f4286c
      John Reck authored
      Fixes: 34512969
      Test: manual, tested repro in bug and verified
      basic GLSurfaceView usage in ApiDemos works
      without warnings
      
      Change-Id: I0ce9128874af681e9cfbd3b0b2ef5e2df7080154
      e7f4286c
  24. Feb 04, 2017
  25. Jan 12, 2017
  26. Jan 09, 2017
    • Robert Carr's avatar
      Provide non-blocking SurfaceView draw notification path. · 25cfa134
      Robert Carr authored
      SurfaceView needs to notify the window manager that
      drawing has been completed, so that animations and such
      can begin. Currently this is implemented through
      having the SurfaceView user block in surfaceRedrawNeeded
      (called from  UI thread) until a frame has been completed.
      This blocking can be unnecessary serialization during startup, and
      also clumsy to implement for some users.
      
      Test: GLSurfaceView and takeSurface API Demos, android.server.cts.SurfaceViewTests
      Bug: 31850030
      Change-Id: Idda02098a635f25cf392f2d59a3abbe54a1d64d4
      25cfa134
  27. Dec 01, 2016
  28. Nov 30, 2016
    • Romain Guy's avatar
      Deprecate eglCreatePixmapSurface · 1f071dd8
      Romain Guy authored
      This function was never properly supported. It had partial support in our JNI
      layer in EGL10 but not implementation in EGL14. It has never been tested and
      it is unlikely that drivers support pixmap rendering.
      
      Bug: 11257511
      Test: CtsGraphicsTestCases
      Change-Id: I209fff470c715cd97148a32b2f41ecf7e5283bab
      1f071dd8
  29. Jun 29, 2016
  30. Jun 07, 2016
  31. Apr 18, 2016
    • John Reck's avatar
      Make surfaceRedrawNeeded forgiving · fd3cee13
      John Reck authored
      Fixes: 27071678
      
      It's semi-common for apps to not realize surfaceRedrawNeeded
      is a callback they can (and should) be handling, so have it be
      more tolerant in lifecycle handling.
      
      Specifically allow a renderer to have not yet been set on
      GLSurfaceView, even though it was supposed to have been set already.
      Apps are overriding the other lifecycle methods that require this
      (created, changed, an destroyed) but not noticing this method.
      
      Change-Id: I6cebca541eeec6e9949bdb55f687b095768a17b2
      fd3cee13
  32. Feb 22, 2016
  33. Feb 10, 2016
    • Pablo Ceballos's avatar
      Fix glGetTransformFeedbackVarying JNI · 59fb43e7
      Pablo Ceballos authored
      - Deprecate the broken version that takes a byte argument.
      - Implement a new version that takes a byte buffer argument.
      
      Bug 19478262
      
      Change-Id: I5ea4f11940e93b5964b66dbf5700b7ff8b80339e
      59fb43e7
  34. Jan 26, 2016
    • Robert Carr's avatar
      Fix reentrant deadlock in GLSurfaceView. · d4393b28
      Robert Carr authored
      It is possible for clients to call SurfaceView
      methods e.g. setFormat from the GLSurfaceView#Renderer
      drawFrame callback. In this case, SurfaceView#updatewindow
      will understand that a redraw is required, and will request
      it back to GLSurfaceView. Remember, we are still on the GLThread
      though (from the drawFrame callback). So these methods
      (requestRenderAndWait, windowSizeChanged), need to be reentrant.
      Also fix a data race around mWantRenderNotification, which was
      accessed out of lock.
      
      Bug: 26770615
      Change-Id: Ic66a36c886ae0b085dd456a4220f0d4f270fb016
      d4393b28
  35. Jan 08, 2016
    • Robert Carr's avatar
      Implement surfaceRedrawNeeded for GLSurfaceView · 2b3bf720
      Robert Carr authored
      GLSurfaceView was not supporting the surfaceRedrawNeeded protocol
      which leads to issues with report draw. Thus far this has mostly
      been fine as the main surface will not render
      a transparent hole until the SurfaceView has finished drawing. However
      in the case of SurfaceView replacement the hole in the parent surface
      will be preexisting and we must be able to tell that our new SurfaceView
      has actually drawn before removing the replacee. This is part of a
      series of fixes to 26070641.
      
      Bug: 26070641
      Change-Id: Iecc16647f9979aa057449e8bafa540885881ed64
      2b3bf720
  36. Dec 18, 2015
  37. Oct 06, 2015
    • Pablo Ceballos's avatar
      Remove GLTrace support · a4d4e829
      Pablo Ceballos authored
      GLTrace is defunct, it does not support newer GL features, breaks
      security requirements, and has no supported tooling now that Eclipse
      is at end of life.
      
      Bug 22329852
      
      Change-Id: I64c58464f8c2c7ae6125f5d5c7884e3fd34d68ea
      a4d4e829
  38. Sep 29, 2015
Loading