- Dec 08, 2020
-
-
Jeff Sharkey authored
As general background, OWNERS files expedite code reviews by helping code authors quickly find relevant reviewers, and they also ensure that stakeholders are involved in code changes in their areas. Some teams under frameworks/base/ have been using OWNERS files successfully for many years, and we're ready to expand them to cover more areas. Here's the historical coverage statistics for the last two years of changes before these new OWNERS changes land: -- 56% of changes are fully covered by OWNERS -- 17% of changes are partially covered by OWNERS -- 25% of changes have no OWNERS coverage Working closely with team leads, we've now identified clear OWNERS on a per-package basis, and we're using "include" directives whenever possible to to simplify future maintenance. With this extensive effort, we've now improved our coverage as follows: -- 98% of changes are fully covered by OWNERS -- 1% of changes are partially covered by OWNERS -- 1% of changes have no OWNERS coverage This specific change is automatically generated by a script from detailed ownership information confirmed by team leads. Bug: 174932174 Test: manual Exempt-From-Owner-Approval: refactoring with team leads buy-in Merged-In: I9789c97c1de8e5d962b48c29c57d82fe83729eba Change-Id: I9789c97c1de8e5d962b48c29c57d82fe83729eba
-
- Nov 04, 2020
-
-
Mathew Inwood authored
These are APIs that have @UnsupportedAppUsage but for which we don't have any evidence of them currently being used, so should be safe to remove from the unsupported list. Bug: 170729553 Test: Treehugger Merged-In: I626caf7c1fe46c5ab1f39c2895b42a34319f771a Change-Id: I54e5ecd11e76ca1de3c5893e3a98b0108e735413
-
- Nov 02, 2020
-
-
Mathew Inwood authored
These are APIs that have @UnsupportedAppUsage but for which we don't have any evidence of them currently being used, so should be safe to remove from the unsupported list. Bug: 170729553 Test: Treehugger Merged-In: I8285daa8530260251ecad6f3f38f98e263629ca7 Change-Id: I626caf7c1fe46c5ab1f39c2895b42a34319f771a
-
- Oct 29, 2020
-
-
Mathew Inwood authored
These are APIs that have @UnsupportedAppUsage but for which we don't have any evidence of them currently being used, so should be safe to remove from the unsupported list. This is a resubmit of ag/12929664 with some APIs excluded that caused test failures; see bugs 171886397, 171888296, 171864568. APIs excluded: Landroid/bluetooth/le/ScanRecord;->parseFromBytes([B)Landroid/bluetooth/le/ScanRecord; Landroid/os/Process;->myPpid()I Landroid/os/SharedMemory;->getFd()I Landroid/hardware/input/InputManager;->INJECT_INPUT_EVENT_MODE_WAIT_FOR_FINISH:I Bug: 170729553 Test: Treehugger Change-Id: I8285daa8530260251ecad6f3f38f98e263629ca7
-
- Oct 28, 2020
-
-
Hongwei Wang authored
This reverts commit 72f07d6a. Reason for revert: Droidcop-triggered revert due to breakage https://android-build.googleplex.com/builds/quarterdeck?testMethod=testAppZygotePreload&testClass=android.app.cts.ServiceTest&atpConfigName=suite%2Ftest-mapping-presubmit-retry_cloud-tf&testModule=CtsAppTestCases&fkbb=6936597&lkbb=6936969&lkgb=6936551&testResults=true&branch=git_master&target=cf_x86_phone-userdebug>, bug b/171886397 Bug: 171886397 Change-Id: Ibe0f0430a3451477c1ee8ef56a596e91ea1e7672
-
- Oct 27, 2020
-
-
Mathew Inwood authored
These are APIs that have @UnsupportedAppUsage but for which we don't have any evidence of them currently being used, so should be safe to remove from the unsupported list. Bug: 170729553 Test: Treehugger Change-Id: I4c8fd0006f950de9955242e93968fb0996ceb372
-
- Jan 23, 2020
-
-
Artur Satayev authored
The new annotation to be used is android.compat.annotation.UnsupportedAppUsage. Test: m Bug: 145132366 Change-Id: Ib2101605fb385b4f778893e5181a954dccbea037 Exempt-From-Owner-Approval: roll-forward previously approved change
-
- Jan 14, 2020
-
-
Artur Satayev authored
Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library. Bug: 145132366 Test: m && diff unsupportedappusage_index.csv \ git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import' Merged-In: I853372f3c6fef905553bb31be4f1bb48df735f7a Change-Id: I853372f3c6fef905553bb31be4f1bb48df735f7a
-
- Jan 08, 2020
-
-
Artur Satayev authored
Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library. Bug: 145132366 Test: m && diff unsupportedappusage_index.csv \ git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import' Change-Id: I853372f3c6fef905553bb31be4f1bb48df735f7a
-
- Dec 19, 2019
-
-
Austin Wang authored
This reverts commit a5264903. Reason for revert: Droidcop-triggered revert due to breakage https://android-build.googleplex.com/builds/quarterdeck?branch=git_master&target=sdk_phone_armv7-sdk&lkgb=6083299&lkbb=6085371&fkbb=6083313, bug b/146533269 Change-Id: Ie5b031d7b277cf0e09b0a9776b26bf74f5f69e70
-
- Dec 18, 2019
-
-
Artur Satayev authored
Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library. Bug: 145132366 Test: m && diff unsupportedappusage_index.csv \ git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import' Change-Id: I087bb1cecbe59f1cf0c2e770c735d7a433722c6f
-
- Nov 19, 2019
-
-
Artur Satayev authored
go/cleanup-greylist-txt These have already been greylisted, however due to bugs/omissions in the tooling have been kept in go/greylist-txt instead of being annotated in the code. This is partial merge of aosp/Id6c1f5e403a0e66edb1102ee45f3bf19f244fb09. Telephony greylist cleanup has been done separately. Note that annotations outside of frameworks/base/ have been merged from AOSP. Bug: 137350495 Test: m Exempt-From-Owner-Approval: merge Change-Id: I015c466e8b69cc0fed5e9d394ba865aad11d8ba6
-
- Nov 08, 2019
-
-
Artur Satayev authored
go/cleanup-greylist-txt These have already been greylisted, however due to bugs/omissions in the tooling have been kept in go/greylist-txt instead of being annotated in the code. Bug: 137350495 Test: m Change-Id: Id6c1f5e403a0e66edb1102ee45f3bf19f244fb09 Merged-In: Id6c1f5e403a0e66edb1102ee45f3bf19f244fb09
-
- Sep 10, 2019
-
-
Derek Sollenberger authored
Restrict access to SkBitmap for libandroid_runtime.so to be only within the boundaries of the graphics module. Test: CtsUiRenderingTestCases Bug: 137655431 Change-Id: I4d0ea227e91d22068966513c4e3a55021b9e924f
-
- Apr 04, 2019
-
-
Courtney Goeltzenleuchter authored
EGLAttrib is defined for a C / C++ interface and is intended to be the size of a pointer. That can change depending on which abi the code is built for but Java doesn't have a way of dealing with such types. Java defines EGLAttrib as a jlong, so need to convert jlong to 32bit when running on a 32bit device. Bug: 124382141 Test: atest --all-abi CtsGraphicsTestCases:EGL15Test Change-Id: I966f6a3716b2710e17d10e0d0cb58314853675e0
-
- Mar 27, 2019
-
-
Leon Scroggins III authored
Test: CtsGraphicsTestCases, CtsUiRenderingTestCases, CtsRenderscriptTestCases This is significantly faster than passing the Java object down and then calling a JNI method to retrieve the pointer. See https://buganizer.corp.google.com/issues/16656908#comment19 In some cases this changes what used to be native crashes (due to android::BitmapWrapper:assertValid's LOG_ALWAYS_FATAL_IF) into NullPointerExceptions (if a caller used a null Bitmap). In addition: - Remove unnecessary JNIEnv param from toBitmap(jlong) - Change instances of toBitmap(JNIEnv*, jobject) to the above - Replace calls to GraphicsJNI::getSkBitmap() to inline calls to toBitmap/getSkBitmap - make Canvas#nInitRaster @FastNative (FIXME: Could these be @CriticalNative?) Change-Id: I6194097be1b6e6952eba70e1e7052a5a250eed93
-
- Oct 24, 2018
-
-
Courtney Goeltzenleuchter authored
Updates from API review feedback. Bug: 118296391 Test: manually inspect code Change-Id: If79f03497e77dfce65909a734bafbb6e08c39155
-
- Oct 23, 2018
-
-
Courtney Goeltzenleuchter authored
Also change eglCreatePlatformPixmapSurface to throw an unsupported extension rather than call the native function which will return an error indicating it's unsupported. Bug: 80297325 Test: atest CtsGraphicsTestCases:EGL15Test Change-Id: I94f2d39678515fdacf9b2fccd1c531365930ad1b
-
- Oct 16, 2018
-
-
Courtney Goeltzenleuchter authored
Test: compile Bug: 80239516 Change-Id: I1c00ac5e55900260b724e1c298edca15f87f3a01 (cherry picked from commit 63584195b9d15daa9973d280381fd619cd7a0f89)
-
- Aug 17, 2018
-
-
Mathew Inwood authored
For packages: javax.microedition.khronos.opengles javax.microedition.khronos.egl This is an automatically generated CL. See go/UnsupportedAppUsage for more details. Exempted-From-Owner-Approval: Mechanical changes to the codebase which have been approved by Android API council and announced on android-eng@ Bug: 110868826 Test: m Change-Id: I0af80d46c5810dab9f7002cc33537e9356ae55d1 Merged-In: I3615f60789c14c44284c896c3a9ea291100dff8e
-
Mathew Inwood authored
For packages: javax.microedition.khronos.opengles javax.microedition.khronos.egl This is an automatically generated CL. See go/UnsupportedAppUsage for more details. Exempted-From-Owner-Approval: Mechanical changes to the codebase which have been approved by Android API council and announced on android-eng@ Bug: 110868826 Test: m Change-Id: I3615f60789c14c44284c896c3a9ea291100dff8e
-
- Aug 09, 2018
-
-
Mathew Inwood authored
For packages: android.opengl This is an automatically generated CL. See go/UnsupportedAppUsage for more details. Exempted-From-Owner-Approval: Mechanical changes to the codebase which have been approved by Android API council and announced on android-eng@ Bug: 110868826 Test: m Change-Id: Iac5bb97445d3f0e3383df0223e2d18fbdc336839 Merged-In: I747cf5d5e6e211dc368545472fee65fd20cdae74
-
Mathew Inwood authored
For packages: android.opengl This is an automatically generated CL. See go/UnsupportedAppUsage for more details. Exempted-From-Owner-Approval: Mechanical changes to the codebase which have been approved by Android API council and announced on android-eng@ Bug: 110868826 Test: m Change-Id: I747cf5d5e6e211dc368545472fee65fd20cdae74
-
- May 01, 2017
-
-
Mike Reed authored
Test: CtsGraphicsTests Change-Id: I611f5dc127636f67dc219ef15adc0a591a72a95e
-
- Apr 22, 2017
-
-
John Reck authored
Fixes: 34512969 Test: manual, tested repro in bug and verified basic GLSurfaceView usage in ApiDemos works without warnings Change-Id: I0ce9128874af681e9cfbd3b0b2ef5e2df7080154
-
- Feb 04, 2017
-
-
Ricardo Loo authored
Adding missing variable in the output vector. Originally reported in http://code.google.com/p/android/issues/detail?id=25143 Change-Id: I91d9ce7e53a9d9cdd890899a0edd49830d533b9b Bug: 5991013
-
- Jan 12, 2017
-
-
Kalle Raita authored
Test: CtsMediaTestCases on N5X Bug: 29402583 Change-Id: I2520fdc51d363998d4404b033722fabf0d839113
-
- Jan 09, 2017
-
-
Robert Carr authored
SurfaceView needs to notify the window manager that drawing has been completed, so that animations and such can begin. Currently this is implemented through having the SurfaceView user block in surfaceRedrawNeeded (called from UI thread) until a frame has been completed. This blocking can be unnecessary serialization during startup, and also clumsy to implement for some users. Test: GLSurfaceView and takeSurface API Demos, android.server.cts.SurfaceViewTests Bug: 31850030 Change-Id: Idda02098a635f25cf392f2d59a3abbe54a1d64d4
-
- Dec 01, 2016
-
-
Romain Guy authored
Bug: 24950082 Test: CtsGraphicsTestCases Change-Id: I2835128bbd5d1b8a234324323c74eca6e55d8726
-
- Nov 30, 2016
-
-
Romain Guy authored
This function was never properly supported. It had partial support in our JNI layer in EGL10 but not implementation in EGL14. It has never been tested and it is unlikely that drivers support pixmap rendering. Bug: 11257511 Test: CtsGraphicsTestCases Change-Id: I209fff470c715cd97148a32b2f41ecf7e5283bab
-
- Jun 29, 2016
-
-
John Reck authored
fixes: 22448595 Also delete some epically outdated code to match the documented behavior Change-Id: I2bb5b475433ebff8ca82db385e228fef11e32e20
-
- Jun 07, 2016
-
-
Aurimas Liutikas authored
Bug: https://code.google.com/p/android/issues/detail?id=56762 Change-Id: I55f8000a6f29172dadd99221ad5ffe3789a3500a
-
- Apr 18, 2016
-
-
John Reck authored
Fixes: 27071678 It's semi-common for apps to not realize surfaceRedrawNeeded is a callback they can (and should) be handling, so have it be more tolerant in lifecycle handling. Specifically allow a renderer to have not yet been set on GLSurfaceView, even though it was supposed to have been set already. Apps are overriding the other lifecycle methods that require this (created, changed, an destroyed) but not noticing this method. Change-Id: I6cebca541eeec6e9949bdb55f687b095768a17b2
-
- Feb 22, 2016
-
-
Pablo Ceballos authored
- For reading into PBOs on GLES3, add an overloaded version of glReadPixels that takes an offset argument. Bug 18878609 Change-Id: I744483deab6358a66b0dc5e87be1ae2b96560ac1
-
- Feb 10, 2016
-
-
Pablo Ceballos authored
- Deprecate the broken version that takes a byte argument. - Implement a new version that takes a byte buffer argument. Bug 19478262 Change-Id: I5ea4f11940e93b5964b66dbf5700b7ff8b80339e
-
- Jan 26, 2016
-
-
Robert Carr authored
It is possible for clients to call SurfaceView methods e.g. setFormat from the GLSurfaceView#Renderer drawFrame callback. In this case, SurfaceView#updatewindow will understand that a redraw is required, and will request it back to GLSurfaceView. Remember, we are still on the GLThread though (from the drawFrame callback). So these methods (requestRenderAndWait, windowSizeChanged), need to be reentrant. Also fix a data race around mWantRenderNotification, which was accessed out of lock. Bug: 26770615 Change-Id: Ic66a36c886ae0b085dd456a4220f0d4f270fb016
-
- Jan 08, 2016
-
-
Robert Carr authored
GLSurfaceView was not supporting the surfaceRedrawNeeded protocol which leads to issues with report draw. Thus far this has mostly been fine as the main surface will not render a transparent hole until the SurfaceView has finished drawing. However in the case of SurfaceView replacement the hole in the parent surface will be preexisting and we must be able to tell that our new SurfaceView has actually drawn before removing the replacee. This is part of a series of fixes to 26070641. Bug: 26070641 Change-Id: Iecc16647f9979aa057449e8bafa540885881ed64
-
- Dec 18, 2015
-
-
Pablo Ceballos authored
Change-Id: I05ff0c14a35f51c2015edbd762dc9e6fe43347b9
-
- Oct 06, 2015
-
-
Pablo Ceballos authored
GLTrace is defunct, it does not support newer GL features, breaks security requirements, and has no supported tooling now that Eclipse is at end of life. Bug 22329852 Change-Id: I64c58464f8c2c7ae6125f5d5c7884e3fd34d68ea
-
- Sep 29, 2015
-
-
Pablo Ceballos authored
Bug 23892570 Change-Id: I92c7bb9bafb84259bdc42927193e989a6a95d4df
-