Test: none
Change-Id: I122b44261ac892ebab2c0867c27b9b9badc2f0bc

I don't know why I didn't clean these up when I learned about this
trick.

Test: treehugger
Change-Id: Iec74cab28c782a61ef3e48210f3a48043e981212

* changes:
  Fix refreshDeviceLockedForUser() to use correct trust state
  Improve LockStateTrackingRule
  Add flag fix_unlocked_device_required_keys
  Fix kotlin nullable errors in TrustTests
  Include TrustState in TrustManagerService dumpUser

TrustManagerService#refreshDeviceLockedForUser() incorrectly considers
the device to be unlocked by a trust agent whenever a trust agent has
granted trust.  This ignores the conditions that
TrustManagerService#updateTrust() has for recognizing trust grants.
This code used to be correct, but it became incorrect in Android 10 when
trust agents were made to extend unlock rather than actively unlock.

The correct state is sent to Keyguard, while the incorrect state is sent
to Keystore.  This would cause UnlockedDeviceRequired keys to sometimes
be usable when the device is locked, though since Android 12 this bug is
hidden by other bugs with UnlockedDeviceRequired keys that make them
unusable in many cases.  However, these bugs are planned to be fixed.

Therefore, fix this bug by making refreshDeviceLockedForUser() use
mUserTrustState, which holds the user's authoritative trust state.

Bug: 296464083
Bug: 298249081
Flag: 296464083
Test: adb shell device_config put hardware_backed_security android.security.fix_unlocked_device_required_keys true
      atest TrustTests
      adb shell device_config put hardware_backed_security android.security.fix_unlocked_device_required_keys false
      atest TrustTests
Change-Id: I0880685c23ebe71a799671fa611fafb42642fa83

- Make assertLocked and assertUnlocked check
  KeyguardManager#isDeviceLocked, in addition to what they were checking
  before.  This is important, as this verifies what TrustManagerService
  (and thus also Keystore) considers the device locked state to be.

- Rename assertUnlocked to assertUnlockedAndTrusted.  This makes it
  clear that it checks for trusted (which implies unlocked), not just
  unlocked (which does not necessarily imply trusted).

- Rename the inner class LockState to TrustState.  This makes it clear
  what it actually is.

- Improve the class comment.

Bug: 296464083
Bug: 298249081
Flag: TEST_ONLY
Test: atest TrustTests
Change-Id: I865ec19dff7ebe00ff083da29154e3c9cb846574

Bug: 296464083
Change-Id: Id3a1e34bfc2d4fbc3ea1c6bfb8fa55d3c28d1687

Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
Change-Id: I31c4f4d256ff8dd2b6ed1f6ed74844ccaf7a4814
Merged-In: I31c4f4d256ff8dd2b6ed1f6ed74844ccaf7a4814
(cherry picked from commit c5a0cfdd)

TrustManagerService dumps the raw aggregated trustable value for each
user, which is not useful because it is not the authoritative trust
state for the user, and it's a computed value (i.e., not real state)
that is computed from other state already dumped.  Therefore, dump the
TrustState instead which is real state that is much more useful.

Test: adb shell dumpsys trust
Flag: exempt, straightforward fix that only affects bugreports
Change-Id: I17103be4d0cc2545e3bdcb1656b35f2d287b01d5

* changes:
  Support multiple modules for lint_fix
  Add utility lint for metrics on @EnforcePermission
  Move AidlImplementationDetector from global to common

* changes:
  Add a java host flag library for testing
  Add API flag fsverity_api

This CL adds support for 2 new features flag meant for keyboard
features: layout preview and accessibility.

Bug: 294546335
Bug: 293579375
Test: `atest FrameworksCoreTests:InputFlagsTest`
Change-Id: Id716a4d8e9d0d081f093fde67883fc4a4b266aa3

Bug: N/A
Change-Id: Ifea6c3681f6499a4e3188a51fe2512e0bf260345
Test: N/A

Test: lint_fix --print --no-fix --check AnnotatedAidlCounter --lint-module AndroidUtilsLintChecker services.autofill services.usage
Change-Id: I08f5aa3e74db8ff24544bbdd3edb0635a0d2fb52

Bug: 298285238
Test: lint_fix --print --no-fix --check AnnotatedAidlCounter --lint-module AndroidUtilsLintChecker services.autofill
Test: atest --host AndroidUtilsLintCheckerTest
Change-Id: I7876e44cabc006de9b996f84477e15071cb95203

After upgrading libc++, Clang fails to compile DumpManifest.cpp.

prebuilts/clang/host/linux-x86/clang-r498229/include/c++/v1/__memory/unique_ptr.h:63:19: error: invalid application of 'sizeof' to an incomplete type 'aapt::CommonFeatureGroup'
    static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
                  ^~~~~~~~~~~

Fix the problem by deferring the instantiation of ~unique_ptr, by
making the ManifestExtractor constructor out-of-line and moving it and
the initialization of commonFeatureGroup_ to a point after
CommonFeatureGroup has been defined.

Bug: b/175635923
Test: treehugger
Change-Id: I9ab51f29724fded24773344aa36763ffeea02d00
Merged-In: I9ab51f29724fded24773344aa36763ffeea02d00

Bug: 298285238
Test: m AndroidGlobalLintChecker
Change-Id: I4e90a0452caaf69ec5da680b7955b16eb1387871

Bug: b/175635923
Test: treehugger
Change-Id: I241c8b2b48bb4c616fbc5b4ae1285e274182144b
Merged-In: I241c8b2b48bb4c616fbc5b4ae1285e274182144b

Merge "Revert "Move @ViewDebug.ExportedProperty annotations from private fields to public methods"" into main

Onboarding new clients to the flagging infrastructure will require updating this file frequently.

Test: updating OWNERS file
Bug: 298653405
Change-Id: I3c752a1b7785f1443572516119cf8090f30e3946

This reverts commit 7f2a6227.

Reason for revert: Verifying if it is culprit for 299257121

Change-Id: I854221ccc99ecb43628b03f06d6365937c703c83

Merge "Move @ViewDebug.ExportedProperty annotations from private fields to public methods" into main

Bug: 295394788
Test: make checkbuild
Change-Id: I370f66c469de73064dec2e42c539dc236dd69d1e

Bug: 291751402
Test: N/A
Change-Id: Ibfd0f41bc49c7c72e31a9c45f760edba93fbfe32

Today, the top-level DecorView is missing some useful pieces of data in its dump, for example the "V"isible and "E"nabled and "I"nvalidated and "D"irty flags. Add these back in.

Today it looks like:

```
    View Hierarchy:
      DecorView@41b7f45[MapsActivity]
        android.widget.LinearLayout{a1c3dbb V.E...... ......ID 208,0-1920,1080}
          android.view.ViewStub{c5878e4 G.E...... ......I. 0,0-0,0 #1020194 android:id/action_mode_bar_stub}
```

Note how the DecorView doesn't have the deep debug info the other views do.

This change updates toString to work the same as the other views, but including the extra title suffix information.

This is a new version of aosp/2276228, but on the main branch.

Change-Id: I35415f7625dc99a80412f6656800504eea876d91

Add the extra info of a VPN network to provide helpful
debugging info.

The validation logs in the dumpsys of NetworkStack refer to
the extra info from NetworkInfo of the given network.
But the extra info in a VPN NetworkInfo is empty so the name
will be null. It's hard to tell the exact name information
from only dumpsys of NetworkStack.

Bug: 297790570
Test: atest FrameworksNetTests
Change-Id: I7cf5f30db9a9bbc0361e5dc6bf4d8f533e12f5c8