Skip to content
Snippets Groups Projects
  1. Jan 18, 2024
    • Yohei Yukawa's avatar
      RemoteInputConnectionImpl should not call on IMM#isActive() · 2b5fbda5
      Yohei Yukawa authored
      Historically RemoteInputConnectionImpl has been calling on
      
        InputMethodManager#isActive()
      
      to see if the InputConnection is considered to be active or inactive
      when actually handling each incoming InputConnection operation.
      
      However, InputMethodManager#isActive() is also known to be tricky
      because it internally calls InputMethodManager#checkFocus(), which can
      have non-trivial side effects.
      
      With this CL, RemoteInputConnectionImpl keeps maintains its own
      boolean state on whether #deactivate() is already called or not so
      that it does not need to rely on IMM#isActive() any more.
      
      For 99% cases there must be no observable behavior change, and for the
      remaining 1% cases the new behavior should be more easily
      understandable.
      
      Bug: 291826769
      Test: atest CtsInputMethodTestCases:InputConnectionHandlerTest#testInputConnectionSideEffect
      Merged-In: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8
      Change-Id: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8
      2b5fbda5
    • Yohei Yukawa's avatar
      Simplify RemoteInputConnectionImpl#finishComposingText*() · a9156d61
      Yohei Yukawa authored
      With my previous CLs [1][2], we can generally assume the following
      things.
      
       - InputConnection#closeConnection() always gets called when it
         becomes invalidated, including the case when the IME has switched
         to another IME client.
      
       - Each implementation of InputConnection#closeConnection() is
         expected to do appropriate clean up including finishing composing
         text. {Base,Editable}InputConnection actually do this correctly.
      
      With that it should be safe for #finishComposingText*() to follow the
      same pattern about isActive().
      
       [1]: I234309c5880c9fe0b299b8bd0f8862796d4dda0d
            9f9afe52
       [2]: If2a03bc84d318775fd4a197fa43acde086eda442
            aaa38c9f
      
      Bug: 35301295
      Bug: 291826769
      Test: presubmit
      Merged-In: If913701bf8555f5d76fceb272e38a99f5e243bbe
      Change-Id: If913701bf8555f5d76fceb272e38a99f5e243bbe
      a9156d61
    • Yohei Yukawa's avatar
      Remove RemoteInputConnectionImpl#mLock, which is redudant · e47a2e5c
      Yohei Yukawa authored
      It is guaranteed that the following two boolean expressions have
      always the same value observed outside from
      RemoteInputConnectionImpl#mLock.
      
        A. RemoteInputConnectionImpl#mFinished
        B. RemoteInputConnectionImpl#mInputConnection != null
      
      With that we should be able to simply merge them into an atomic
      reference object
      
        AtomicReference<InputConnection>
      
      without requiring RemoteInputConnectionImpl#mLock as a lock object.
      
      This CL does so as a preparation to clean up RemoteInputConnectionImpl
      for Bug 291826769.
      
      There should be no observable behavior change, except for the fact
      that
      
        RemoteInputConnectionImpl#dumpDebug()
      
      no longer blocks other operations that required mLock, which is kind
      of out of our original intention.
      
      Bug: 291826769
      Test: presubmit
      Merged-In: I69fa2c81670f84be3dd4a808262758a803f69dfc
      Change-Id: I69fa2c81670f84be3dd4a808262758a803f69dfc
      e47a2e5c
    • Sihua Ma's avatar
      Revert "Making adapter child views in RemoteCollectionItemsAdapter size-aware" · 3f45bdad
      Sihua Ma authored
      This reverts commit 28dcae49.
      
      Reason for revert: Revert framework changes on test platform, will follow up with a CL that makes the CTS test permissive
      
      Change-Id: I825b4978270720c3693e718f007040c033ccf58f
      3f45bdad
  2. Jan 17, 2024
  3. Jan 16, 2024
  4. Jan 15, 2024
    • wilsonshih's avatar
      Make the icon of SplashScreenView non-focusable · d12f56e7
      wilsonshih authored
      To make the embedded window of SplashScreenView non-focusable, needs
      to add the window flag separately from SurfaceControlViewHost#setView
      
      Bug: 319369153
      Test: verify the embedded window of splash screen won't grant focus
      Change-Id: Ic9b48dcc4de25e681405b3dd78468597a8a7c627
      d12f56e7
  5. Jan 13, 2024
  6. Jan 11, 2024
    • Yan Yan's avatar
      Enable NetworkMetricMonitor and support penalizing networks · ce1468a2
      Yan Yan authored
      This CL integrates the IpSecPacketLossDetector into VCN
      route selection. With this change, when a data stall is
      reported, the network candidate will be penalized and
      then deprioritized during network selection. A network
      candidate will stop being penalized until it hitting a timeout
      or passing the validation.
      
      Bug: 282996138
      Test: atest FrameworksVcnTests(new tests), CtsVcnTestCases
      Change-Id: Ifabd6fdea1d5a4fea40cf929dbab7c26d37274ac
      ce1468a2
    • William Loh's avatar
      Update OWNERS for intent.proto · ec2616b7
      William Loh authored
      Bug: 307556883
      Test: n/a
      Change-Id: I5001247c342f23b07e1355db7e50ad90cce66b07
      ec2616b7
    • Tom Chan's avatar
      Consolidate OWNERS files and add hackz@ and myself · e20a03bf
      Tom Chan authored
      syntax from go/android-codereviews#include-an-owners-file-from-a-sub-directory-within-the-same-git-project
      
      Change-Id: Ia02a5efdda1c2dea65753a63cbd2e78e56bac6eb
      e20a03bf
  7. Jan 10, 2024
    • Yan Yan's avatar
      Support IPsec packet loss detector · 4d8d4462
      Yan Yan authored
      This CL creates an abstract class NetworkMetricMonitor and a
      subclass IpSecPacketLossDetector. IpSecPacketLossDetector
      is responsible for continuously monitoring IPsec packet loss
      and reporting to the caller when the data loss rate surpass
      a threshold. This detector allows the VCN to switch from
      the underlying network that has bad quality.
      
      This CL also defines new carrier configs that specify the
      data loss threshold and detecting frequency
      
      Bug: 282996138
      Test: atest FrameworksVcnTests(new tests), CtsVcnTestCases
      Change-Id: I5f4b8e1821bdbb37f0a6de6e1584f8e3c87273f3
      4d8d4462
    • William Loh's avatar
      Add owners for new UriRelativeFilter* files. · a642dd22
      William Loh authored
      Bug: 307556883
      Test: n/a
      Change-Id: I2836908a00981d54e884a495a662bc293219c0e4
      a642dd22
  8. Jan 09, 2024
  9. Jan 08, 2024
    • Yifan Hong's avatar
      Release VintfObject memory after compat check at boot time. · acb46e4c
      Yifan Hong authored
      After compatibility check at boot time, the VintfObject is
      usually no longer needed. Hence, at boot time, we actively
      release the VintfObject object after compatibility check
      by not using the shared instance in the first place.
      
      Test: TH
      Bug: 270169217
      Change-Id: I9b3383cd52fa67eb18dd5837f96caf2b0eab2ce5
      acb46e4c
    • Yifan Hong's avatar
      vintf: Disable kernel compat check at boot time. · 052b036b
      Yifan Hong authored
      Before this change, if the kernel has a set of CONFIGs
      that is not compatible with the system image, a dialog
      is displayed for user / userdebug builds at boot time.
      
      This check has been doing more harm than good because:
      
      - This check is already enforced at build time and during
        VTS tests (See vts_treble_vintf_framework_test).
      - The dialog blocks UI automation for tests. For these UI
        automation tests, they need to respond to the dialog.
      - GKI has been enforced ecosystem-wide except for a few
        low-end devices of other verticals. For these non-GKI
        devices, the check enforced by VTS should guard this.
        Hence, the check does not give us any signal.
      - During development, a kernel that corresponds to the latest
        release (android15 as of now) might not have valid kernel
        config requirements in userspace. Kernel development schedule
        is usually ahead of the userspace development schedule.
        It does not always carry the string "-mainline-", because
        it is not a mainline kernel. To unblock test automation on
        these latest, bleeding-edge kernels, this kernel check should
        go away.
      - This is a small steps towards dropping the dependency on libvintf
        on libandroid_runtime. libvintf links to libselinux, which is
        huge. libandroid_runtime loads this, and the memory stays there
        forever. Ideally, we should disable the whole VINTF check at
        boot time, but let's do this one step at a time.
      
      Bug: 272479887
      Bug: 270169217
      Test: TH
      Change-Id: If24cdca9fb535b8f443c0d21f9a46c7ea25c1f9f
      052b036b
    • Yifan Hong's avatar
      vintf: delete deprecated VintfObject.verify. · 27022ac8
      Yifan Hong authored
      It is not used anywhere.
      
      Test: TH
      Bug: 270169217
      Change-Id: Ifcc8412ed3629d2447908513faf1d6f5ed3f483c
      27022ac8
  10. Jan 06, 2024
    • Yifan Hong's avatar
      recovery: Delete internal verifyPackageCompatibility. · 16da32b0
      Yifan Hong authored
      Non-A/B has been deprecated for long. During non-A/B updates,
      compatibility.zip is checked with VintfObject.verify(), which
      is another deprecated function that always returns compatible
      if a list of package VINTF XMLs are supplied. (see below.) Hence, the private
      RecoverySystem.verifyPackageCompatibility was just useless code
      that unconditionally returns true except for invalid ZIP file.
      Remove it. Replace the public RecoverySystem.verifyPackageCompatibility
      and make it return true unconditonally.
      
      VintfObject.verify() with OTA XMLs are deprecated per
      http://b/139300422 [VINTF] Delete OTA vintf checking code
      in http://r.android.com/1194233 ("Delete VINTF compatibility checks
      during OTA."), in 2019. We had decided that compatibility checks
      during OTA should be removed, and moved to OTA generation time instead.
      Using an old libvintf on the device to check against new libvintf
      metadata required forward compatibility of libvintf, which cannot be
      achieved. Instead, the device should verify the signature of the OTA to
      verify its source.
      
      Test: TH
      Bug: 270169217
      Bug: 139300422
      Change-Id: I775d29e4cd1d165233e07cfb820d1fe343fa4757
      16da32b0
  11. Jan 05, 2024
    • Eric Biggers's avatar
      Remove serialNumber parameter from prepareUserStorage · 47a9d404
      Eric Biggers authored
      Remove the serialNumber parameter from
      IStorageManager#prepareUserStorage, StorageManager#prepareUserStorage,
      and StorageManagerService#prepareUserStorageInternal, as it is not used.
      
      Bug: 316035110
      Test: atest UserDataPreparerTest
      Flag: N/A, mechanical refactoring
      Change-Id: I4bb716a502fec267fbe0d93e423c7d713c78feaa
      47a9d404
    • Eric Biggers's avatar
      Remove serialNumber parameter from createUserStorageKeys · 383e31cb
      Eric Biggers authored
      Remove the serialNumber parameter from
      IStorageManager#createUserStorageKeys and
      StorageManager#createUserStorageKeys, as it is not used.
      
      Bug: 316035110
      Test: presubmit
      Flag: N/A, mechanical refactoring
      Change-Id: I11f2507fefb374bea7c8de857424c67108fcb97e
      383e31cb
    • Eric Biggers's avatar
      Remove serialNumber parameter from unlockCeStorage · 41749ebb
      Eric Biggers authored
      Remove the serialNumber parameter from IStorageManager#unlockCeStorage,
      as it is not used.
      
      Bug: 316035110
      Test: atest UserControllerTest
      Test: atest com.android.server.locksettings
      Flag: N/A, mechanical refactoring
      Change-Id: Idfb46e625f0ab6915c980e4a39420fe712cb5fb5
      41749ebb
    • Edward Savage-Jones's avatar
      Add/update owners for SystemConfig related files · 84ebe666
      Edward Savage-Jones authored
      Add/update owners for SystemConfig related files
      (See comment in: https://r.android.com/2775452)
      
      c/j/c/a/s/SystemConfig.java has also moved so update the OWNERS
      file for that too.
      
      Change-Id: Ia773c7851d6aad4223ce5845d0993d527a5fd140
      84ebe666
    • Edward Savage-Jones's avatar
      Prevent the disabling of specified apps · 12b06820
      Edward Savage-Jones authored
      Prevent the disabling of specified apps, avoiding cases
      where disabling the app may result in an unusable system.
      
      Bug: 200043113
      Change-Id: I5b0ed8c34a40428e8d18072582e46854737c000a
      12b06820
  12. Jan 04, 2024
    • Pawan Wagh's avatar
      Add 16k option key in settings · 3e5012c5
      Pawan Wagh authored
      Test: m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk
      Test: atest SettingsProviderTest
      Bug: 295035851
      Bug: 294614538
      Change-Id: I7bba46c39d609f314e17eb861341bd599b192612
      3e5012c5
    • Pawan Wagh's avatar
      Added java wrapper for update engine stable · a1a72609
      Pawan Wagh authored
      Test: m framework-all
      Test: Compiled and applied OTA using settings app using stable interface
      m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk
      Bug: 317914533
      
      Change-Id: I393df5218c60303dbea60386c680b75b553ddac2
      a1a72609
    • Alexei Nicoara's avatar
      Updating OWNERS file · 2b0323eb
      Alexei Nicoara authored
      Change-Id: Icc8a7b899ccb54196ece9cccbfe3658547f0603c
      2b0323eb
  13. Jan 03, 2024
  14. Jan 02, 2024
  15. Dec 23, 2023
  16. Dec 21, 2023
  17. Dec 20, 2023
    • John Johnson's avatar
      Add flag for nfc card detection · 8f0ec40a
      John Johnson authored
      Test: repo still builds
      Bug: 306203494
      Change-Id: I3983801865a6b8cd9aba04c24a52f9bb2b1d7577
      8f0ec40a
    • Nelson Li's avatar
      Convert helper_apps of OverlayHostTests to Android.bp · a3bee88c
      Nelson Li authored
      Bug: 317159909
      Test: atest OverlayHostTests
            m OverlayHostTests
            m OverlayHostTests_PlatformSignatureStaticOverlay
            m OverlayHostTests_PlatformSignatureOverlay
            m OverlayHostTests_UpdateOverlaya
            m OverlayHostTests_FrameworkOverlayV1
            m OverlayHostTests_FrameworkOverlayV2
            m OverlayHostTests_AppOverlayV1
            m OverlayHostTests_AppOverlayV2
      Change-Id: I14491d2cbaa98ec72de1eb149e1a82a7f061d5d0
      a3bee88c
  18. Dec 19, 2023
    • Paul Duffin's avatar
      Remove erroneous duplicate baseline entry · 4a6e5cca
      Paul Duffin authored
      Due to a bug in Metalava the `VisiblySynchronized` check would report
      an erroneous duplicate baseline entry that referenced some internal
      implementation detail, e.g. `PsiThisExpression` instead of an actual
      API element. Another entry with the same message and correct API
      element was also written.
      
      The Metalava bug has been fixed so this change removes the erroneous
      entry.
      
      Bug: 311690008
      Test: m checkapi
      Merged-In: If5550b8cc0a97f02fb7fb1bd949f8e5517007d4c
      Change-Id: I79b3c9802e40e74ba7f0c9b102dc201d01ddeab5
      4a6e5cca
  19. Dec 18, 2023
Loading