Skip to content
Snippets Groups Projects
  1. Jul 18, 2020
    • Garfield Tan's avatar
      Enable clang-format for frameworks/base · 4c2d3daf
      Garfield Tan authored
      Copy and paste internal setup to AOSP. Not include folders not in AOSP
      yet.
      
      Bug: None
      Test: repo upload
      Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
      Merged-In: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
      4c2d3daf
  2. Jul 10, 2020
  3. Jul 09, 2020
  4. Apr 06, 2020
    • Alex Buynytskyy's avatar
      Appops permission monitoring for GET_USAGE_STATS. · 1d89216e
      Alex Buynytskyy authored
      This makes sure DataLoader won't be able to obtain read logs once user
      denies access.
      
      Bug: b/152633648
      Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
      Test: adb shell appops set 1000 GET_USAGE_STATS deny
      Change-Id: Ibbb74933b4ef0dd8f5fe27732743e5820b8ee4dc
      1d89216e
  5. Jan 27, 2020
    • Siarhei Vishniakou's avatar
      Enable clang-format for f/b/services/core/jni · 44d50fea
      Siarhei Vishniakou authored
      To avoid code review comments about code style, line length, and
      spacing, enable clang-format for frameworks/base/services/core/jni
      
      Bug: none
      Test: repo upload
      Change-Id: Ie38ecca2d5face78367d3eab450e497120ce12b1
      44d50fea
  6. Jan 03, 2020
    • Siarhei Vishniakou's avatar
      Enable clang-format for core/jni · cd2fe535
      Siarhei Vishniakou authored
      To have consistent code style and avoid format-related comments in code
      review, enable clang-format in frameworks/base/core/jni.
      
      Bug: none
      Test: repo upload
      Change-Id: Ie9e5408d85036dfabae3a9c60b238b4a190da5fc
      cd2fe535
  7. Dec 10, 2019
    • Siarhei Vishniakou's avatar
      Enable clang-format for input code · a3117ca4
      Siarhei Vishniakou authored
      Currently, there is no format enforcement for hid command. Add
      clang-format hook for all input-related code in frameworks/base.
      
      Bug: None
      Test: repo upload
      Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
      a3117ca4
  8. Nov 01, 2019
  9. Jul 24, 2019
    • Remi NGUYEN VAN's avatar
      Add ktlint to preupload hooks · ba47bae7
      Remi NGUYEN VAN authored
      The kotlin linter is particularly useful for tests written in Kotlin in
      frameworks/base.
      
      This is already merged in internal master.
      
      Test: Tried uploading change with/without kotlin style problems.
      Merged-In: Ie8659765b674ac7b2d82ed3d343f387195c07d83
      Change-Id: I420366c49d071e022b8988c3d6293dbc8e9a283a
      ba47bae7
  10. Dec 10, 2018
    • Lorenzo Colitti's avatar
      Enable checkstyle everywhere in frameworks/base. · 6bfffd68
      Lorenzo Colitti authored
      This was done in internal master in ag/5397886. Do it in AOSP as
      well so we can benefit from checkstyle in AOSP as well.
      
      Test: None
      Change-Id: Ib00fc8d318e8127224846e0a69cb542178631437
      Merged-In: I7d350c2bbb9fcd1019abd1addb035ce5e9e05acc
      6bfffd68
  11. Nov 29, 2018
    • Paul Duffin's avatar
      Prevent hiddenapi entries being added for libcore related projects · 00537c15
      Paul Duffin authored
      The libcore related projects (see below) have been (mostly) switched
      over to use UnsupportedAppUsage annotations, This change will prevent
      entries for those projects being added to a config/hiddenapi-* file.
      
      * libcore
      * external/bouncycastle
      * external/conscrypt
      * external/icu
      * external/okhttp
      * external/libphonenumber - still has a couple of entries in
            config/hiddenapi-light-greylist.txt due to limitations in
            UnsupportedAppUsage/class2greylist.
      
      Tested by attempting to upload the file with entries for libcore
      projects and without those entries and checking that the behavior
      is expected.
      
      Test: see above
      Bug: 117818301
      Change-Id: I67a30b307e12e842b28cfb2160fab0029868fa06
      00537c15
  12. Nov 21, 2018
  13. Oct 30, 2018
    • Aurimas Liutikas's avatar
      Enable checkstyle for all frameworks/base projects. · 2c5aa790
      Aurimas Liutikas authored
      We've been slowly rolling out checkstyle to frameworks/base by 
      whitelisting new directories, at this point we have most active directories, so let's make it enabled for everyone.
      
      Change-Id: I7d350c2bbb9fcd1019abd1addb035ce5e9e05acc
      Test: None
      2c5aa790
  14. Oct 18, 2018
  15. Sep 24, 2018
  16. Sep 11, 2018
    • Jeff Sharkey's avatar
      Upload hook that guides people towards AOSP. · 0a9c7319
      Jeff Sharkey authored
      The canonical location of certain parts of the source tree live in
      AOSP, and should not be changed internally to avoid merge conflicts.
      
      This initially starts with "OWNERS" files, but the hook can easily
      be repeated to match any files based on file path regexes.
      
      Bug: 113136846
      Test: manual
      Change-Id: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
      Merged-In: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
      0a9c7319
  17. Aug 24, 2018
    • Jeff Sharkey's avatar
      Upload hook that guides people towards AOSP. · fb7b3732
      Jeff Sharkey authored
      The canonical location of certain parts of the source tree live in
      AOSP, and should not be changed internally to avoid merge conflicts.
      
      This initially starts with "OWNERS" files, but the hook can easily
      be repeated to match any files based on file path regexes.
      
      Bug: 113136846
      Test: manual
      Change-Id: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
      fb7b3732
  18. Aug 23, 2018
    • Jason Monk's avatar
      First kotlin · ae7ced2f
      Jason Monk authored
      Convert one class to kotlin and provide a slight amount of guidance.
      
      Test: existing tests
      Change-Id: Ie8659765b674ac7b2d82ed3d343f387195c07d83
      ae7ced2f
  19. Aug 03, 2018
  20. Jul 30, 2018
    • Philip P. Moltmann's avatar
      Split PackageInstaller app into installation and permissions management · 8943ad63
      Philip P. Moltmann authored
      The two components were mostly independant for a long time. Since
      I1e80a3f5e63d02b3859ecf74af21ca4c61f96874 the installation flow does
      not grant any permissions anymore and the last connection between these
      parts was broken.
      
      The new app "com.android.packageinstaller" in
      frameworks/base/packages/PackageInstaller will only handle (side load)
      package installtion and uninstallation.
      
      The exisiting app will be renamed to "com.android.permissioncontroller"
      and only handle permission granting and permission management.
      
      This change does only minimal cleanup cleanup. In particularly it does
      not move any files in the old permissions controller. This is to not
      disturb other features currently in development.
      
      This change set also updates the make files to install the two apps on
      the appropriate devices.
      
      Further the permisson policy xmls need to be updated to point to the
      right packages.
      
      Test: Installed + uninstalled packages
            Granted permissions + managed permissions
      
            GtsPackageInstallTestCases
            GtsNoPermissionTestCases
            GtsNoPermissionTestCases25
            GtsPackageInstallerTapjackingTestCases
            GtsPackageUninstallTestCases
      Change-Id: I2d3796b837fc0049e712c82a990907f305c8febf
      8943ad63
  21. Jul 20, 2018
  22. May 08, 2018
    • David Brazdil's avatar
      Add presubmit hook for hidden API lists. · 2200a1b8
      David Brazdil authored
      Check that they're sorted as expected and contain no duplicates.
      The sort order now uses:
      $ LC_COLLATE=C sort -f
      
      So that non-alphanumeric characters are not ignored, giving a more
      intuitive sort order. the '-f' means ignore case.
      
      Also sort the existing lists accordingly.
      
      Test: repo upload
      Bug: 64382372
      Merged-In: I52b884da33a9a46455df6747a215683d9d3c3218
      Change-Id: Icc124fd8ceb3f001a9c11bbf40e0a111910c6b39
      (cherry picked from commit e5dc64d4)
      2200a1b8
  23. Apr 24, 2018
    • Mathew Inwood's avatar
      Add presubmit hook for hidden API lists. · e5dc64d4
      Mathew Inwood authored
      Check that they're sorted as expected and contain no duplicates.
      The sort order now uses:
      $ LC_COLLATE=C sort -f
      
      So that non-alphanumeric characters are not ignored, giving a more
      intuitive sort order. the '-f' means ignore case.
      
      Also sort the existing lists accordingly.
      
      Test: repo upload
      Bug: 64382372
      Merged-In: I52b884da33a9a46455df6747a215683d9d3c3218
      Change-Id: I4cdd3bc5c11be91a9a3f678580af49ac67f3c968
      e5dc64d4
    • Mathew Inwood's avatar
      Add presubmit hook for hidden API lists. · a10f2e24
      Mathew Inwood authored
      Check that they're sorted as expected and contain no duplicates.
      The sort order now uses:
      $ LC_COLLATE=C sort -f
      
      So that non-alphanumeric characters are not ignored, giving a more
      intuitive sort order. the '-f' means ignore case.
      
      Also sort the existing lists accordingly.
      
      Test: repo upload
      Bug: 64382372
      Change-Id: I52b884da33a9a46455df6747a215683d9d3c3218
      a10f2e24
  24. Mar 26, 2018
    • Jeff Sharkey's avatar
      Add linter for strings.xml. · abe058c0
      Jeff Sharkey authored
      Strings are tedious to get right, so write a lint script that catches
      common errors to warn developers before they're uploaded.
      
      Test: builds, boots
      Bug: 76097999
      Change-Id: I9826ca796c17cd93a100951d56214653de63a379
      abe058c0
  25. Mar 22, 2018
  26. Feb 09, 2018
  27. Nov 13, 2017
    • Jason Monk's avatar
      Add api lint to upload checks · 53b2a73c
      Jason Monk authored
      Currently will never block upload, only considered a warning, but
      will print out any lint issues discovered.
      
      Test: do an upload
      Bug: 69115822
      Change-Id: I69b8e5a3f92ac28ee3c954408e88a1056c33af65
      53b2a73c
  28. Aug 22, 2017
  29. Apr 28, 2017
  30. Dec 15, 2016
  31. Oct 21, 2016
  32. Oct 12, 2016
    • Aurimas Liutikas's avatar
      Enable Checkstyle preupload hook for certain frameworks/base directories. · 5c19b542
      Aurimas Liutikas authored
      Enables Checkstyle preupload hook for the following directories:
      - core/java/android/animation/
      - core/java/android/text/
      - core/java/android/view/
      - core/java/android/transition/
      - core/java/android/widget/
      
      Test: tested manually uploading a CL that contained many changes
            to directories outside of the listed ones and checkstyle did
            not complain about those.
      
      Change-Id: I795ba478fad7af124c43ca1e18d51b33d7800976
      5c19b542
Loading