- Jul 18, 2020
-
-
Garfield Tan authored
Copy and paste internal setup to AOSP. Not include folders not in AOSP yet. Bug: None Test: repo upload Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05 Merged-In: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
-
- Jul 10, 2020
-
-
Aurimas Liutikas authored
This reverts commit 8497789b. Reason for revert: This was fixed, see b/160796554 Bug: 160796554 Change-Id: I42f8d6b76c7319522239517ac3aff6eee7d9084b
-
- Jul 09, 2020
-
-
Aurimas Liutikas authored
checkstyle uses inefficient git calls that make it really slow for --partial-clone Bug: 160796554 Change-Id: I3bb2ac1bebdb6f778b2d2ff159eefb27664aa177
-
- Apr 06, 2020
-
-
Alex Buynytskyy authored
This makes sure DataLoader won't be able to obtain read logs once user denies access. Bug: b/152633648 Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest Test: adb shell appops set 1000 GET_USAGE_STATS deny Change-Id: Ibbb74933b4ef0dd8f5fe27732743e5820b8ee4dc
-
- Jan 27, 2020
-
-
Siarhei Vishniakou authored
To avoid code review comments about code style, line length, and spacing, enable clang-format for frameworks/base/services/core/jni Bug: none Test: repo upload Change-Id: Ie38ecca2d5face78367d3eab450e497120ce12b1
-
- Jan 03, 2020
-
-
Siarhei Vishniakou authored
To have consistent code style and avoid format-related comments in code review, enable clang-format in frameworks/base/core/jni. Bug: none Test: repo upload Change-Id: Ie9e5408d85036dfabae3a9c60b238b4a190da5fc
-
- Dec 10, 2019
-
-
Siarhei Vishniakou authored
Currently, there is no format enforcement for hid command. Add clang-format hook for all input-related code in frameworks/base. Bug: None Test: repo upload Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
-
- Nov 01, 2019
-
-
Adrian Roos authored
Linting is performed by metalava as part of the build now. Test: n/a Change-Id: I6223549657912fdf305a17f66f55b97561f7f7ac
-
- Jul 24, 2019
-
-
Remi NGUYEN VAN authored
The kotlin linter is particularly useful for tests written in Kotlin in frameworks/base. This is already merged in internal master. Test: Tried uploading change with/without kotlin style problems. Merged-In: Ie8659765b674ac7b2d82ed3d343f387195c07d83 Change-Id: I420366c49d071e022b8988c3d6293dbc8e9a283a
-
- Dec 10, 2018
-
-
Lorenzo Colitti authored
This was done in internal master in ag/5397886. Do it in AOSP as well so we can benefit from checkstyle in AOSP as well. Test: None Change-Id: Ib00fc8d318e8127224846e0a69cb542178631437 Merged-In: I7d350c2bbb9fcd1019abd1addb035ce5e9e05acc
-
- Nov 29, 2018
-
-
Paul Duffin authored
The libcore related projects (see below) have been (mostly) switched over to use UnsupportedAppUsage annotations, This change will prevent entries for those projects being added to a config/hiddenapi-* file. * libcore * external/bouncycastle * external/conscrypt * external/icu * external/okhttp * external/libphonenumber - still has a couple of entries in config/hiddenapi-light-greylist.txt due to limitations in UnsupportedAppUsage/class2greylist. Tested by attempting to upload the file with entries for libcore projects and without those entries and checking that the behavior is expected. Test: see above Bug: 117818301 Change-Id: I67a30b307e12e842b28cfb2160fab0029868fa06
-
- Nov 21, 2018
-
-
Felipe Leme authored
Bug: none Test: none Change-Id: I1f6f554cf98c78d1ab8a1e820d485a37238230f5
-
- Oct 30, 2018
-
-
Aurimas Liutikas authored
We've been slowly rolling out checkstyle to frameworks/base by whitelisting new directories, at this point we have most active directories, so let's make it enabled for everyone. Change-Id: I7d350c2bbb9fcd1019abd1addb035ce5e9e05acc Test: None
-
- Oct 18, 2018
-
-
Fabian Kozynski authored
Test: Using bogus CL with changes to upload Fixes: 117599474 Change-Id: I1b69e04160dfee402622187991f5c58ead439754
-
- Sep 24, 2018
-
-
Ng Zhi An authored
Bug: 115719623 Test: import unused classes and try to repo upload, checkstyle will block it Change-Id: I063b9946df6c3d852506449221a7f04d6f9c656f
-
- Sep 11, 2018
-
-
Jeff Sharkey authored
The canonical location of certain parts of the source tree live in AOSP, and should not be changed internally to avoid merge conflicts. This initially starts with "OWNERS" files, but the hook can easily be repeated to match any files based on file path regexes. Bug: 113136846 Test: manual Change-Id: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38 Merged-In: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
-
- Aug 24, 2018
-
-
Jeff Sharkey authored
The canonical location of certain parts of the source tree live in AOSP, and should not be changed internally to avoid merge conflicts. This initially starts with "OWNERS" files, but the hook can easily be repeated to match any files based on file path regexes. Bug: 113136846 Test: manual Change-Id: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
-
- Aug 23, 2018
-
-
Jason Monk authored
Convert one class to kotlin and provide a slight amount of guidance. Test: existing tests Change-Id: Ie8659765b674ac7b2d82ed3d343f387195c07d83
-
- Aug 03, 2018
-
-
Aurimas Liutikas authored
This mostly means all of core/tests. Test: None Change-Id: Ibfa5d2b616f98d47ce4c1c484919518cb5d43f35
-
- Jul 30, 2018
-
-
Philip P. Moltmann authored
The two components were mostly independant for a long time. Since I1e80a3f5e63d02b3859ecf74af21ca4c61f96874 the installation flow does not grant any permissions anymore and the last connection between these parts was broken. The new app "com.android.packageinstaller" in frameworks/base/packages/PackageInstaller will only handle (side load) package installtion and uninstallation. The exisiting app will be renamed to "com.android.permissioncontroller" and only handle permission granting and permission management. This change does only minimal cleanup cleanup. In particularly it does not move any files in the old permissions controller. This is to not disturb other features currently in development. This change set also updates the make files to install the two apps on the appropriate devices. Further the permisson policy xmls need to be updated to point to the right packages. Test: Installed + uninstalled packages Granted permissions + managed permissions GtsPackageInstallTestCases GtsNoPermissionTestCases GtsNoPermissionTestCases25 GtsPackageInstallerTapjackingTestCases GtsPackageUninstallTestCases Change-Id: I2d3796b837fc0049e712c82a990907f305c8febf
-
- Jul 20, 2018
-
-
Roshan Pius authored
This CL enables Checkstyle for the following directories: - wifi/ Bug: 28291425 Test: Compilation Change-Id: Iefdabcc3c5867f392c0bf9925d10ddeb3b334c9f
-
- May 08, 2018
-
-
David Brazdil authored
Check that they're sorted as expected and contain no duplicates. The sort order now uses: $ LC_COLLATE=C sort -f So that non-alphanumeric characters are not ignored, giving a more intuitive sort order. the '-f' means ignore case. Also sort the existing lists accordingly. Test: repo upload Bug: 64382372 Merged-In: I52b884da33a9a46455df6747a215683d9d3c3218 Change-Id: Icc124fd8ceb3f001a9c11bbf40e0a111910c6b39 (cherry picked from commit e5dc64d4)
-
- Apr 24, 2018
-
-
Mathew Inwood authored
Check that they're sorted as expected and contain no duplicates. The sort order now uses: $ LC_COLLATE=C sort -f So that non-alphanumeric characters are not ignored, giving a more intuitive sort order. the '-f' means ignore case. Also sort the existing lists accordingly. Test: repo upload Bug: 64382372 Merged-In: I52b884da33a9a46455df6747a215683d9d3c3218 Change-Id: I4cdd3bc5c11be91a9a3f678580af49ac67f3c968
-
Mathew Inwood authored
Check that they're sorted as expected and contain no duplicates. The sort order now uses: $ LC_COLLATE=C sort -f So that non-alphanumeric characters are not ignored, giving a more intuitive sort order. the '-f' means ignore case. Also sort the existing lists accordingly. Test: repo upload Bug: 64382372 Change-Id: I52b884da33a9a46455df6747a215683d9d3c3218
-
- Mar 26, 2018
-
-
Jeff Sharkey authored
Strings are tedious to get right, so write a lint script that catches common errors to warn developers before they're uploaded. Test: builds, boots Bug: 76097999 Change-Id: I9826ca796c17cd93a100951d56214653de63a379
-
- Mar 22, 2018
-
-
Jack Yu authored
This CL enables Checkstyle for the following directories: - telephony/ Bug: 34746646, 32954735 Test: Compilation Change-Id: Ia67eaf5b871e6b74f21344fef1572835801843a5
-
- Feb 09, 2018
-
-
Siyamed Sinir authored
Test: None Change-Id: I1c8342dda2678917e245e48ab141b2953a522197
-
- Nov 13, 2017
-
-
Jason Monk authored
Currently will never block upload, only considered a warning, but will print out any lint issues discovered. Test: do an upload Bug: 69115822 Change-Id: I69b8e5a3f92ac28ee3c954408e88a1056c33af65
-
- Aug 22, 2017
-
-
Aurimas Liutikas authored
This CL enables Checkstyle for the following directories: - core/java/android/ - core/tests/coretests/src/android/ Bug: 34746646 Test: None Change-Id: Ib8b3f198000be19e9a7a61aa5abd61d827454eba (cherry picked from commit e5abb866)
-
- Apr 28, 2017
-
-
Aurimas Liutikas authored
This CL enables Checkstyle for the following directories: - core/java/android/ - core/tests/coretests/src/android/ Bug: 34746646 Test: None Change-Id: Ib8b3f198000be19e9a7a61aa5abd61d827454eba
-
- Dec 15, 2016
-
-
Aurimas Liutikas authored
This change depends on r.android.com/314437 Bug: 33666900 Test: None Change-Id: I301723d516803146943f0866ea35b68cc36af6af
-
- Oct 21, 2016
-
-
Philip P. Moltmann authored
Test: Uploaded Change-Id: Ib103a4fdc1dea0efc3a1a1be8c864541d283343a
-
- Oct 12, 2016
-
-
Aurimas Liutikas authored
Enables Checkstyle preupload hook for the following directories: - core/java/android/animation/ - core/java/android/text/ - core/java/android/view/ - core/java/android/transition/ - core/java/android/widget/ Test: tested manually uploading a CL that contained many changes to directories outside of the listed ones and checkstyle did not complain about those. Change-Id: I795ba478fad7af124c43ca1e18d51b33d7800976
-