Skip to content
Snippets Groups Projects
Select Git revision
  • test
  • fifteen-qpr0-new
  • fifteen default
3 results
Search by author
  • Any Author
  • Farzin Kazemzadeh Farzin Kazemzadeh itisFarzin
1 author
  1. Feb 13, 2021
    • Jean-Luc Brouillet's avatar
      Fix bug in Blend that did not use options. · a2c6eb2f
      Jean-Luc Brouillet authored 
      For one of the many variants of Blend, a cut&paste error made
that the options were not passed.

This was not caught because no test exercised this.

I've added the test (in a related CL) and fixed the bug.

Bug: 178718752
Test: Ran the RS Java tests
Change-Id: Ide2fef96137ffd89e4431cf15be5df398036d909
      a2c6eb2f
  3. Jan 14, 2020
    • Artur Satayev's avatar
      Use new UnsupportedAppUsage annotation. · 53ada2ab
      Artur Satayev authored 
      Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.

Bug: 145132366
Test: m && diff unsupportedappusage_index.csv \
      git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import'
Merged-In: I853372f3c6fef905553bb31be4f1bb48df735f7a
Change-Id: I853372f3c6fef905553bb31be4f1bb48df735f7a
      53ada2ab
  5. Jan 08, 2020
    • Derek Sollenberger's avatar
      Update renderscript to use stable graphics APIs · db98b528
      Derek Sollenberger authored 
      This change removes usage of skia data structures and replaces
them with stable C APIs. It also removes two unused java APIs
that were missing their native components.

Test: CTS presubmit tests
Bug: 137655431
Change-Id: I18cbe0cf9dc731c4c6c1f645be0df2f462764118
      db98b528
    • Artur Satayev's avatar
      Use new UnsupportedAppUsage annotation. · 2ebb31c0
      Artur Satayev authored 
      Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.

Bug: 145132366
Test: m && diff unsupportedappusage_index.csv \
      git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import'

Change-Id: I853372f3c6fef905553bb31be4f1bb48df735f7a
      2ebb31c0
  7. Dec 19, 2019
  9. Dec 18, 2019
    • Artur Satayev's avatar
      Use new UnsupportedAppUsage annotation. · a5264903
      Artur Satayev authored 
      Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.

Bug: 145132366
Test: m && diff unsupportedappusage_index.csv \
      git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import'
Change-Id: I087bb1cecbe59f1cf0c2e770c735d7a433722c6f
      a5264903
  11. Mar 27, 2019
    • Leon Scroggins III's avatar
      Pass Bitmap's native instance to JNI where feasible · 71fae62f
      Leon Scroggins III authored 
      Test: CtsGraphicsTestCases, CtsUiRenderingTestCases,
      CtsRenderscriptTestCases

This is significantly faster than passing the Java object down and then
calling a JNI method to retrieve the pointer. See
https://buganizer.corp.google.com/issues/16656908#comment19

In some cases this changes what used to be native crashes (due to
android::BitmapWrapper:assertValid's LOG_ALWAYS_FATAL_IF) into
NullPointerExceptions (if a caller used a null Bitmap).

In addition:
- Remove unnecessary JNIEnv param from toBitmap(jlong)
- Change instances of toBitmap(JNIEnv*, jobject) to the above
- Replace calls to GraphicsJNI::getSkBitmap() to inline calls to
  toBitmap/getSkBitmap
- make Canvas#nInitRaster @FastNative (FIXME: Could these be
  @CriticalNative?)

Change-Id: I6194097be1b6e6952eba70e1e7052a5a250eed93
      71fae62f
  13. Mar 06, 2019
  15. Feb 11, 2019
    • Hans Boehm's avatar
      Correct registerNativeAllocation type · da3cee60
      Hans Boehm authored 
      We're changing the argument type to long, since it should be roughly
large enough to hold a size_t everywhere.

Make style checker happy by reordering imports.

Test: Treehugger
Change-Id: Iccdc5fa592f56d448817f7762af1cff27b4fc2a8
      da3cee60
  17. Aug 06, 2018
    • Mathew Inwood's avatar
      Add @UnsupportedAppUsage annotations · 1532447a
      Mathew Inwood authored 
      For packages:
  android.renderscript

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Change-Id: I016f6e720e79c48afe44f4690b5dd99fc81ae780
Merged-In: I1aa8ebca448547031b426a7b305c5c3d6fcf2652
      1532447a
  19. Aug 02, 2018
    • Mathew Inwood's avatar
      Add @UnsupportedAppUsage annotations · f0c90b1f
      Mathew Inwood authored 
      For packages:
  android.renderscript

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Change-Id: I1aa8ebca448547031b426a7b305c5c3d6fcf2652
      f0c90b1f
  21. Mar 21, 2018
  23. Jun 13, 2017
    • Yang Ni's avatar
      Do not CloseGuard KernelID or FieldID · 3a84a23f
      Yang Ni authored 
      Bug: 28053584

Stop CloseGuarding for two reasons:

1) KernelID and FieldID objects are constructed in auto-generated
(RenderScript reflected) Java code. It would be impossible for a user to
explicitly call destroy() on them. Guarding them would leave a lot of
noisy warnings in logcat.

2) These KernelID and FieldID objects are not big compared to other
RenderScript objects, e.g. Allocations. They occupy almost no native
resources except for a native pointer. Leaving their destruction to Java
GC would be completely acceptable, since any delay in reclaiming them is
unlikely to cause memory pressure.

Test: CTS on x86_64 emulator
Change-Id: I587b5561a0b2bdbf0b2e95bf2995c20d5f5faf9d
      3a84a23f
  25. May 05, 2017
  27. May 04, 2017
    • Yang Ni's avatar
      Destroy Allocation with ScriptIntrinsicLut · 8b8f75a7
      Yang Ni authored 
      Bug: 28053584

On destroying the intrinsic, destroy its contained Allocation right away.

Test: CTS on x86_64 emulator
Change-Id: I5ca0da33b620c3291b7cafda31a6cc83eb7461a0
      8b8f75a7
  29. Apr 20, 2017
  31. Apr 18, 2017
  33. Mar 03, 2017
    • Yang Ni's avatar
      Removed close guards for Element and Type objects · 45438c94
      Yang Ni authored 
      Bug: 28053769

These objects are tiny and unlikely to cause memory issues.

In addition, llvm-rs-cc auto-generated code contains such objects, which are
not visibible to developers and impossible to manually destroy, leaving
distracting warnings in Strict Mode.

Test: RsTest with StrictMode on and CTS tests

Change-Id: Iec68cca4f1259124b9f503a230c1a28b97ede1f3
      45438c94
  35. Jan 26, 2017
  37. Jun 14, 2016
  39. Jun 02, 2016
  41. May 25, 2016
  43. May 18, 2016
  45. May 10, 2016
  47. Apr 22, 2016
    • Yang Ni's avatar
      Fixed BaseObj finalizer and destroy() · 1b4df169
      Yang Ni authored 
      Bug: 28242626
Bug: 27972184
Bug: 27973681

This is resolving issues in ScriptGroup (V1) again.
In ScriptGroup.destroy(), we also need to consider the old API where
mClosures is not initialized.

Also cleaned up the finalizer for ScriptGroup and Allocation:
Since BaseObj.finalize() calls BaseObj.helpDestroy(), instead of
BaseObj.destroy(), there is no possibility that the finalizers of
child objects may race their parents finalizers. Note that
helpDestroy() does not try to recurse on child objects.

Change-Id: I9dbb2b60f8478f656f8a418c2b5fc8d6848aeef0
      1b4df169
  49. Apr 20, 2016
  51. Apr 19, 2016
    • Yang Ni's avatar
      Fixed ScriptGroup finalizer for old API · e04e5d7c
      Yang Ni authored 
      Bug: 28242626

ScriptGroup finalizer clears out the list of closures, which is
uninitialized for the old API.

Need to check null first, before accessing the list.

Change-Id: Ibf914e17a0878c8c561f823c5f6f6f6619594de1
(cherry picked from commit 07837d6d)
      e04e5d7c
    • Yang Ni's avatar
      Made Element accessors thread-safe · 33703f0c
      Yang Ni authored 
      Bug: 28177082
Change-Id: I8f3f2d8ce559e93cba29f8eedd5b95d1389deb23
      33703f0c
  53. Apr 18, 2016
    • Yang Ni's avatar
      Fixed ScriptGroup finalizer for old API · 07837d6d
      Yang Ni authored 
      Bug: 28242626

ScriptGroup finalizer clears out the list of closures, which is
uninitialized for the old API.

Need to check null first, before accessing the list.

Change-Id: Ibf914e17a0878c8c561f823c5f6f6f6619594de1
      07837d6d
  55. Apr 12, 2016
  57. Apr 11, 2016
  59. Apr 07, 2016
    • Yang Ni's avatar
      Destroy Closures in ScriptGroup · 44e2f45f
      Yang Ni authored 
      Bug: 27973681

Implemented correct destruction in ScriptGroup.destroy() and
Clsoure.destroy(), which properly destroys child BaseObj's.

Change-Id: I946f62c2979d6a338b8883514cacad472a213c5c
      44e2f45f
  61. Apr 05, 2016
    • Yang Ni's avatar
      Avoid destroying Device separately · cb939dc4
      Yang Ni authored 
      Bug: 27983025

Device should be destroyed inside the destructor of the associated
Context.

Change-Id: I921a89974e1174f837349a89aef9b03efa4882f5
(cherry picked from commit 4a70df58)
      cb939dc4
  63. Apr 04, 2016
    • Yang Ni's avatar
      Avoid destroying Device separately · 4a70df58
      Yang Ni authored 
      Bug: 27983025

Device should be destroyed inside the destructor of the associated
Context.

Change-Id: I921a89974e1174f837349a89aef9b03efa4882f5
      4a70df58