Skip to content
Snippets Groups Projects
  1. Jun 03, 2024
  2. Jun 02, 2024
    • Faye Yan's avatar
      Security fix for VPN app killable via lockscreen. · 0fddfa03
      Faye Yan authored
      Do not show the active apps dialog when the screen is locked.
      Instead prompt the user to unlock directly if clicked and only open the dialog on
      successsful unlock.
      
      Merged-In: I384699d478e5abcee3a165afc45211b9ed96334a
      Change-Id: I071cd9b7d0e779a156795d6af481231c5347101d
      Flag: NONE
      Bug: 304772709
      Test: manually, locked and unlocked
      Test: atest com.android.systemui.qs.FooterActionsControllerTest
      0fddfa03
  3. Jun 01, 2024
  4. May 31, 2024
    • Bryce Lee's avatar
      Allow navigating to keyguard from dreaming with Glanceable Hub. · 1d1ac020
      Bryce Lee authored
      This changelist allows reaching the keyguard when exiting a dream.
      
      Test: manual
      Fixes: 343505271
      Flag: com.android.systemui.glanceable_hub_allow_keyguard_when_dreamin
      Change-Id: I87107366dd75b1d41576ef2f3442bf5da7878599
      1d1ac020
    • William Xiao's avatar
      Fix hub shortcut not showing up on left of dream · 59ccff6c
      William Xiao authored
      Using the home controls category ties the visibility of the open hub
      complication to the home controls category, which seems to get turned
      off if the home lock screen shortcut is not part of the default set
      when the open_hub_chip_replace_home_controls setting is on.
      
      Bug: 339667383
      Flag: com.android.systemui.glanceable_hub_shortcut_button
      Test: N/A, manually verified
      Change-Id: If69367758998eb84c81478fd844fcb1346d73a1e
      59ccff6c
    • burakov's avatar
      [bc25] Adjust OverlayShade padding to account for insets and cutout. · 1329ce7d
      burakov authored
      Test: Manually tested by opening and closing the notifications shade on
      a foldable device both in a folded and unfolded configuration.
      Test: Unit tests build and pass.
      Bug: 337849926
      Flag: com.android.systemui.dual_shade
      
      Change-Id: I2c3baa781ba687c867f2d96054e3dfd3d58cc3f5
      1329ce7d
    • Sumedh Sen's avatar
      Catch exceptions thrown inside the Handler · f3a6be3b
      Sumedh Sen authored
      Bug: 343803187
      Test: Manual. Perform CUJ9 from go/pia_manual_testing_plan
      Change-Id: I50b945c5d7042eedd2cd0203df5e915b74a1d710
      f3a6be3b
    • Zhi Dou's avatar
      Revert "Revert "Compare aconfig flag value in SetttingsState and..." · b7593b40
      Zhi Dou authored
      Revert submission 27606956-revert-27466096-aconfigd_compare-INBWUZZENO
      
      Reason for revert: the fix is submitted
      
      Reverted changes: /q/submissionid:27606956-revert-27466096-aconfigd_compare-INBWUZZENO
      
      Change-Id: I2aef5b8a637b903c2c230d4794cd9a4e6b88864a
      b7593b40
    • Hawkwood Glazier's avatar
      Prevent smartspace from disconnecting during rebuilds · eb1ccf0d
      Hawkwood Glazier authored
      Bug: 343477676
      Test: Reran some ContentObserver tests
      Flag: com.android.systemui.migrate_clocks_to_blueprint
      Change-Id: Ib2076a5567d71ea3f04c34f5b460745d0d8a6027
      eb1ccf0d
    • Liam, Lee Pong Lam's avatar
      [smartspace] Fixes unit test threading · 9b436547
      Liam, Lee Pong Lam authored
      When rolling out the flag to staging, the test failed on threading so
      making the test running on main looper.
      
      Details: ag/27422442
      
      Flag: com.android.systemui.smartspace_lockscreen_viewmodel
      Test: Unit tests
      Bug: 331451011
      Change-Id: Iaecb0996d36418202ec33f794d791eb1576da552
      9b436547
    • Juan Sebastian Martinez's avatar
      Letting View handle click and longclick detection · 0f7badbe
      Juan Sebastian Martinez authored
      The touch listener for long-press effects in QS tiles is removed. An
      investgation showed that this was the cause of the regression that this
      CL aims to fix. With the listener removed, the tile view is left to
      handle its own touch events and call the onTouchEvent method of the View
      to allow the click and long-click detection logic to run. The
      QSLongPressEffect class is now modified to act according to the
      detection of clicks by the View, the triggering of long-clicks, and the
      necessary tap timeout wait (as a new action in the Flow of actions).
      
      Test: atest SystemUITests:QSTileViewImplTest
      Test: atest SystemUiRobotTests:QSLongPressEffectTest
      Bug: 341890266
      Flag: com.android.systemui.quick_settings_visual_haptics_longpress
      
      Change-Id: Iac48d6563be4e7442deb891c0be61551ac125670
      0f7badbe
    • Evan Laird's avatar
      Revert^2 "[Sat] Add satellite supported changed callback" · cdb64722
      Evan Laird authored
      This reverts commit aa0f68b0.
      
      Reason for revert: Added a a try/catch to handle the exception
      
      Original commit message:
      
      Per the linked bug, there is a new API on `SatelliteManager` that
      implements a callback for satellite support. This is in addition to the
      existing query API that happens when the repository starts up.
      
      This CL adds the listener after the initial query, and makes sure that
      if satellite support shows up later it is caught. The state change
      listener runs regardless of the initial supported state.
      
      Test: DeviceBasedSatelliteRepositoryImplTest
      Bug: 342278770
      Flag: NONE bugfix
      Change-Id: I2ddf754b60ca71427754c3940f593e851c9c28da
      Merged-In: I2ddf754b60ca71427754c3940f593e851c9c28da
      cdb64722
    • Sherry Zhou's avatar
      Fix glitchy animation when going from LS to AOD with media · b79e27a3
      Sherry Zhou authored
      We get continuous topPadding in
      requestScrollerTopPaddingUpdate without flag, and only get start and end
      value with flag. The fix is to interpolate between start and end notif
      bounds with AOD progress.
      
      Test: manual test with media player in notification stack and
      smartspace, observing that there's no jump fading out notification stack
      when entering AOD from LS
      Bug: 340312485
      Flag: com.android.systemui.migrate_clocks_to_blueprint
      
      Change-Id: Ib53b917a1f002100a55b004207a216473017351c
      b79e27a3
    • Shreerag Jayakrishnan's avatar
      Use the right packagename for Wear SystemUI in FlagsManager · 2563aa55
      Shreerag Jayakrishnan authored
      Bug: 339104897
      Test: Flippin App doesn't crash on launch
      Flag: NONE trivial string fix for Wear
      Change-Id: I41a286aa4fd6c18836c5259eaa351a830ab9dc0e
      2563aa55
    • Julia Tuttle's avatar
      MobileConnectionsRepository: register KeyguardUpdateMonitor callback on main thread · e9cc8d16
      Julia Tuttle authored
      If we do this on the background thread, we trip an assert in
      KeyguardUpdateMonitor, so do it on the main thread instead.
      
      Bug: 342424366
      Test: manual: set lockscreen, post notif, go to lockscreen, expand notif
      Flag: com.android.systemui.scene_container
      Change-Id: I737559baeb587bb94497ab7cdb5f1dadfc951fed
      e9cc8d16
    • Julia Tuttle's avatar
      ShadeLockscreenInteractor: change scene on main thread · fc54ceaa
      Julia Tuttle authored
      If we do this on the background thread, we trip a new assert in
      SceneTransitionLayout, so do it on the main thread instead.
      
      Bug: 342424366
      Test: manual: set lockscreen, post notif, go to lockscreen, expand notif
      Flag: com.android.systemui.scene_container
      Change-Id: Ib118764d1ff21f46560dee9a7e914325d74eab96
      fc54ceaa
    • Michael Mikhail's avatar
      Move listener to lockscreen setting to application scope · 1c048583
      Michael Mikhail authored
      There is a binder call in the code checking lockscreen setting.
      Executing this code everytime screen transitions go to lockscreen is
      expensive. It is better to execute the binder call one time in the
      application scope.
      
      Flag: EXEMPT BUGFIX
      Bug: 331800609
      Bug: 330801389
      Test: atest MediaCarouselControllerTest
      
      Change-Id: Ia165e7fd63690403bfa6b61890d63b632c031d5e
      1c048583
    • Matt Pietal's avatar
      Add more error logging for DISMISS · df6c191d
      Matt Pietal authored
      Should help debug certain scenarios where requests to
      dismiss keyguard are being ignored.
      
      Bug: 340948081
      Test: manual - observe logs
      Flag: EXEMPT just adding logs
      Change-Id: I4df1842b4abe7b3d75d24f26f483e21b4e874628
      df6c191d
    • Evan Laird's avatar
      [Sat] Add retrySignal to the device-based satellite repository · 5bfec795
      Evan Laird authored
      In the event that a telephony process crashes, SystemUI needs to
      potentially re-register our callbacks with the SatelliteManager service.
      To achieve this, we define a new [retrySignal] option in the wrapper for
      flows that query [SatelliteManager] APIs.
      
      Test: DeviceBasedSatelliteRepositoryImplTest
      Bug: 337258696
      Flag: com.android.internal.telephony.flags.oem_enabled_satellite_flag
      Change-Id: I22176b104adfbfa5b9b792114d98a05d5e6ce75e
      Merged-In: I22176b104adfbfa5b9b792114d98a05d5e6ce75e
      5bfec795
    • Chris Göllner's avatar
      Shortcut Helper: fix wrong "open calendar" shortcut on the phone version · 089c9630
      Chris Göllner authored
      The shortcut is ACTION + K and not ACTION + L. This was already correct
      for the large screen version of the helper, but wrong for the small
      screen version.
      
      Fixes: 309569033
      Test: Manually
      Flag: NONE Trivial change
      Change-Id: I1efff8e4e66813e704a8d66cf699a0954a77af44
      089c9630
    • Arpan's avatar
      Align with Jetpack Changes (toBundle/FW Flag) · 66b370ef
      Arpan authored
      Recently, we added a change to Jetpack to bundle BPData properties
      within a bundle, rather than directly imbue it into the slice.
      This requires us to re-structure our slice parsing, to:
      
      1. Read the bundle from the slice.
      2. Parse the bundle after reading from the slice.
      
      Along this change, we also need to know, for a whole many use cases,
      when the framework prompt was the originator for the codes of the BP.
      This is also a Jetpack decision, so a small bit was added so it can be
      utilized in JP.
      
      Bug: 339650358
      Test: Build and device tests
      
      Change-Id: I6c3392fb96e6d5409310ba4b840f229444942803
      66b370ef
    • Winson Chung's avatar
      Update back-gesture-allowed state before calling state change callback · 0d4f3d72
      Winson Chung authored
      - When a device is first set up, isHandlingGestures() is false because
        we are in SUW, but when user setup completes, we need to update
        mIsBackGestureAllowed prior to calling the callback which will
        query that state, otherwise there is no other signal to trigger
        another relayout after the state is set.
      
      Bug: 331601358
      Test: atest Launcher3Tests
      Change-Id: I9b37df4b3e63c6fcdd91e166c613866f8f046554
      0d4f3d72
    • Coco Duan's avatar
      Prevent the hub from recomposing while opening a timer activity · 46a6de1c
      Coco Duan authored
      Create a flow `isCommunalContentFlowFrozen` to pause the emission of
      communalContent flow. The freeze only happens if we last transitioned
      to hub, keyguard is occluded and isAbleToDream is false as a new activity
      is about to show on top.
      
      Bug: b/338052219
      Flag: com.android.systemui.communal_hub
      Test: manually add a timer via voice and the grid doesn't re-flow
      Test: atest CommunalViewModelTest
      Change-Id: Ic0bea11e848da6820e44404005397b161bd88a7e
      46a6de1c
    • Chandru S's avatar
      Change var to val in SensorLocation object · b0adeb4f
      Chandru S authored
      Fixes: 342956711
      Test: manually, enroll fingerprint on a device with UDFPS
          1. Change resolution
          2. Go to lockscreen
          3. Verify the size and location of the fingerprint icon
      Flag: com.android.systemui.device_entry_udfps_refactor
      Change-Id: I0ec6b267b02fb5101299f3628275ec579133502e
      b0adeb4f
    • Peter Kalauskas's avatar
      Separate thread for back panel · a379689f
      Peter Kalauskas authored
      Create a new thread for showing the navigation back panel.
      
      Bug: 304583132
      Flag: com.android.systemui.edge_back_gesture_handler_thread
      Test: atest SystemUITests:com.android.systemui.navigationbar.gestural
      Change-Id: I97b8a67e4fbe07040a7113a83a57cc83dedb8f5c
      a379689f
  5. May 30, 2024
    • Daniel Chapin's avatar
      Revert "Update face authenticating asset" · 2faa5386
      Daniel Chapin authored
      This reverts commit 026cf425.
      
      Reason for revert: Droidfood blocking bug: b/331920634
      
      Change-Id: Ib2107e9275bee144270aaafdee3c59212868462e
      2faa5386
    • Caitlin Shkuratov's avatar
      [SB][Sat] Always show satellite carrier text in shade if available. · 91a8a43a
      Caitlin Shkuratov authored
      This isn't my favorite way to fix this, but it's what we can do given
      the state of the current code and what little time we have left.
      
      Fixes: 341841138
      Flag: com.android.internal.telephony.flags.oem_enabled_satellite_flag
      Test: In SysUI demo mode, enter satellite mode then open the shade
      -> verify the header has the satellite carrier text
      Test: atest CarrierTextManagerTest ShareCarrierGroupControllerTest
      
      Change-Id: I1bd7a67d7a2f0f9971ad5fab638adf2d78eac6be
      91a8a43a
    • Jeff DeCew's avatar
      Stop using NotificationContentInflater directly when the interface will work · 4594699b
      Jeff DeCew authored
      Flag: EXEMPT rename
      Test: presubmit
      Change-Id: Ie48d489a22da2a78e33fe8dc18a24e1f3f31915c
      4594699b
    • Michael Mikhail's avatar
      [flexiglass] Remove new media pipeline flag · 9bdf4830
      Michael Mikhail authored
      This CL merges new media pipeline code into flexiglass.
      
      Flag: com.android.systemui.scene_container
      Bug: 326408371
      Test: atest MediaViewControllerTest
      Test: atest MediaDataProcessorTest
      Change-Id: I0a264e52b4f3d64395dcdb43ccf093a53050ea3a
      9bdf4830
    • Matthew Reynolds's avatar
      Mass Robolectric migration directories systemui/[g-m] · ea1d7488
      Matthew Reynolds authored
      Bug: 337746260
      Flag: TEST_ONLY
      Test: tested manually with atest
      Change-Id: I9366d3f9fa42bbca9495507a32a77b332f2d7254
      ea1d7488
    • Hawkwood Glazier's avatar
      Eagerly update ClockSize & isLargeClockVisible flows · 6efc29f0
      Hawkwood Glazier authored
      This should fix an issue where both clocks would appear on mokey. It
      appears that the isLargeClockVisible may not be always subscribed on
      mokey/aosp.
      
      Bug: 327249281
      Test: Mostly presubmits, having a hard time reproducing
      Flag: com.android.systemui.migrate_clocks_to_blueprint
      Change-Id: I4c7edab90b11e8b7e3de1538413466d50f675779
      6efc29f0
    • Peter Kalauskas's avatar
      Apply new code formatting to back panel arrow · 89d11ad9
      Peter Kalauskas authored
      Apply ktfmt 0.49 formatting to
      com.android.systemui.navigationbar.gestural
      
      Test: atest SystemUITests:com.android.systemui.navigationbar.gestural
      Flag: NONE Code formatting
      Change-Id: I4e70d07d9d4a3c582e5602879903d8c463c98fa1
      89d11ad9
    • Shreerag Jayakrishnan's avatar
      Revert "Compare aconfig flag value in SetttingsState and new storage" · 1f955a21
      Shreerag Jayakrishnan authored
      Revert submission 27466096-aconfigd_compare
      
      Reason for revert: Testing fix of b/343628930
      
      Reverted changes: /q/submissionid:27466096-aconfigd_compare
      
      Change-Id: Iefa35231c8b922aee698a066d5a0a517e1b86333
      1f955a21
    • burakov's avatar
      [bc25] Add an overscroll animation for Dual Shade. · 8ebb9fb5
      burakov authored
      Test: Manually tested by opening and closing the notifications shade on
      a foldable device both in a folded and unfolded configuration.
      Test: Unit tests build and pass.
      Bug: 342463447
      Bug: 337849926
      Flag: com.android.systemui.dual_shade
      
      Change-Id: Ica5412464d3f6976518ddb4e307a5d838326dfd8
      8ebb9fb5
    • Lyn's avatar
      Log UiEvents for throttling decision · 8d53fb11
      Lyn authored
      Bug: 330610050
      Test: make statsd_testdrive && $ANDROID_HOST_OUT/bin/statsd_testdrive -terse 90
      Change-Id: I988ceefc516269d9d86d001a16cd4a02b46e7bb7
      8d53fb11
    • Zhi Dou's avatar
      add sdk_version for settingsLib flag · aa207568
      Zhi Dou authored
      This change adds sdk_verion for settingsLib flag. Before the
      sdk_version is missing, and by default the libraries will be built
      agaist the implementation of the framework jars.
      
      The right sdk_version is assigned to allow the libraries to use the
      right scope of apis.
      
      Test: presubmit
      Bug: 333003287
      Change-Id: Ia156ef01b4e2c16a7bb0a880f8d13c1727e98c11
      aa207568
    • Nate Myren's avatar
      Hide notifications with sensitive content on the lock screen · ea404e2f
      Nate Myren authored
      Bug: 343631648
      Test: atest NotificationLockscreenUserManagerTest
      Flag: android.app.redact_sensitive_content_notifications_on_lockscreen DISABLED
      
      Change-Id: Ibc613b0859531e16651645288bedbdcbef7e9824
      ea404e2f
Loading