- Sep 13, 2023
-
-
Gustavo Pagani authored
Merge "Add Wear project folder with OWNERS file. Also add folders for: - Shared: common code shared between phone and wear app; - Horologist: components provided from Horologist;" into main
-
Gustavo Pagani authored
- Shared: common code shared between phone and wear app; - Horologist: components provided from Horologist; Change-Id: I70186deed0d2a941e1959613a65c69edfff70265
-
- Sep 12, 2023
-
-
Eric Biggers authored
-
Roshan Pius authored
-
Sarp Misoglu authored
-
prateek rawal authored
Problem: { //frameworks/base/services/backup/backuplib/java/com/android/server/backup/TransportManager.java NullPointerException is occurring as a transport with null transportDirName is attempted to register, causing subsequent fatal in system server resulting in restart. Bug : https://partnerissuetracker.corp.google.com/issues/298000577 } Solution: { Null check transportName and transportDirName added to circumvent fatal in system } Bug: 298000577 Change-Id: I865dbc14768fb9be3e557261aab05b1dc3dc5839
-
Sam Delmerico authored
-
Treehugger Robot authored
-
- Sep 11, 2023
-
-
Treehugger Robot authored
-
Gil Cukierman authored
Adds a new aconfig file in android.os and creates the first flag there. Test: m Bug: 276752881 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5fc9dc6c0e9a121dd3556fd918088dbb14970af6) Merged-In: I81b8f4f42bafc1adee139b35cc111dc852c4d2a2 Change-Id: I81b8f4f42bafc1adee139b35cc111dc852c4d2a2
-
Suren Baghdasaryan authored
This reverts commit 26cc4077. Reason for revert: This change is not needed in the presence of aosp/2521297, which was the right fix for the problem. This change only introduces another problem (see b/297649601). Bug: 297649601 Change-Id: If1656c7393790327396a80431c9bb7cc4738988a Signed-off-by:
Suren Baghdasaryan <surenb@google.com>
-
Junyu Lai authored
-
- Sep 08, 2023
-
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Joe Onorato authored
Test: none Change-Id: I122b44261ac892ebab2c0867c27b9b9badc2f0bc
-
Elliott Hughes authored
-
Ryan Prichard authored
-
Roman Kiryanov authored
it is added to the vendor partition. Bug: 212639052 Test: press the assist button, check that keyboard Test: events are delivered to the guest (`adb shell getevent -lt`) Test: and the asistant window appears. Change-Id: I1b836b975df2fc46383b3f83a6276936874bfea9 Signed-off-by:
Roman Kiryanov <rkir@google.com>
-
Elliott Hughes authored
I don't know why I didn't clean these up when I learned about this trick. Test: treehugger Change-Id: Iec74cab28c782a61ef3e48210f3a48043e981212
-
Eric Biggers authored
* changes: Fix refreshDeviceLockedForUser() to use correct trust state Improve LockStateTrackingRule Add flag fix_unlocked_device_required_keys Fix kotlin nullable errors in TrustTests Include TrustState in TrustManagerService dumpUser
-
Eric Biggers authored
-
Vania Januar authored
-
Eric Biggers authored
TrustManagerService#refreshDeviceLockedForUser() incorrectly considers the device to be unlocked by a trust agent whenever a trust agent has granted trust. This ignores the conditions that TrustManagerService#updateTrust() has for recognizing trust grants. This code used to be correct, but it became incorrect in Android 10 when trust agents were made to extend unlock rather than actively unlock. The correct state is sent to Keyguard, while the incorrect state is sent to Keystore. This would cause UnlockedDeviceRequired keys to sometimes be usable when the device is locked, though since Android 12 this bug is hidden by other bugs with UnlockedDeviceRequired keys that make them unusable in many cases. However, these bugs are planned to be fixed. Therefore, fix this bug by making refreshDeviceLockedForUser() use mUserTrustState, which holds the user's authoritative trust state. Bug: 296464083 Bug: 298249081 Flag: 296464083 Test: adb shell device_config put hardware_backed_security android.security.fix_unlocked_device_required_keys true atest TrustTests adb shell device_config put hardware_backed_security android.security.fix_unlocked_device_required_keys false atest TrustTests Change-Id: I0880685c23ebe71a799671fa611fafb42642fa83
-
Eric Biggers authored
- Make assertLocked and assertUnlocked check KeyguardManager#isDeviceLocked, in addition to what they were checking before. This is important, as this verifies what TrustManagerService (and thus also Keystore) considers the device locked state to be. - Rename assertUnlocked to assertUnlockedAndTrusted. This makes it clear that it checks for trusted (which implies unlocked), not just unlocked (which does not necessarily imply trusted). - Rename the inner class LockState to TrustState. This makes it clear what it actually is. - Improve the class comment. Bug: 296464083 Bug: 298249081 Flag: TEST_ONLY Test: atest TrustTests Change-Id: I865ec19dff7ebe00ff083da29154e3c9cb846574
-
Eric Biggers authored
Bug: 296464083 Change-Id: Id3a1e34bfc2d4fbc3ea1c6bfb8fa55d3c28d1687
-
Colin Cross authored
Fix kotlin nullable errors that were exposed by setting the retention of android.annotation.NonNull and android.annotation.Nullable to class retention. Bug: 294110802 Test: builds Change-Id: I31c4f4d256ff8dd2b6ed1f6ed74844ccaf7a4814 Merged-In: I31c4f4d256ff8dd2b6ed1f6ed74844ccaf7a4814 (cherry picked from commit c5a0cfdd)
-
Eric Biggers authored
TrustManagerService dumps the raw aggregated trustable value for each user, which is not useful because it is not the authoritative trust state for the user, and it's a computed value (i.e., not real state) that is computed from other state already dumped. Therefore, dump the TrustState instead which is real state that is much more useful. Test: adb shell dumpsys trust Flag: exempt, straightforward fix that only affects bugreports Change-Id: I17103be4d0cc2545e3bdcb1656b35f2d287b01d5
-
Thiébaud Weksteen authored
* changes: Support multiple modules for lint_fix Add utility lint for metrics on @EnforcePermission Move AidlImplementationDetector from global to common
-
Ryan Prichard authored
-
- Sep 07, 2023
-
-
Ryan Prichard authored
-
Bryce Lee authored
This change adds a new callback from TrustManagerService when the enabled trust agents change. This addition enables TrustListeners to react when an authentication method has been enabled by the user. Test: atest KeyguardStateControllerTest#testOnEnabledTrustAgentsChangedCallback Test: atest KeyguardUpdateMonitorTest#testOnEnabledTrustAgentsChangedCallback Test: atest TrustManagerServiceTest#reportEnabledTrustAgentsChangedInformsListener Fixes: 277845892 Fixes: 279231562 Change-Id: Id6d4b65abb4de77f52f1d48499eed3ca26384663 (cherry picked from commit 3580317c) Fixes: 299529171 Merged-In: Id6d4b65abb4de77f52f1d48499eed3ca26384663
-
Josep del Río authored
-
Eric Biggers authored
-
Treehugger Robot authored
* changes: Add a java host flag library for testing Add API flag fsverity_api
-
Josep del Rio authored
This CL adds support for 2 new features flag meant for keyboard features: layout preview and accessibility. Bug: 294546335 Bug: 293579375 Test: `atest FrameworksCoreTests:InputFlagsTest` Change-Id: Id716a4d8e9d0d081f093fde67883fc4a4b266aa3
-
Vania Januar authored
Bug: N/A Change-Id: Ifea6c3681f6499a4e3188a51fe2512e0bf260345 Test: N/A
-
Victor Hsieh authored
-
Chiachang Wang authored
-
Ryan Prichard authored
It needs to be at least above this line: theme->entries_.reserve(kInitialReserveSize); Otherwise, after upgrading libc++, the compiler fails with errors about an incomplete type, e.g.: include/c++/v1/vector:839:62: error: arithmetic on a pointer to an incomplete type 'android::Theme::Entry' include/c++/v1/__memory/uninitialized_algorithms.h:609:5: error: cannot increment value of type 'std::reverse_iterator<android::Theme::Entry *>' Bug: b/175635923 Test: treehugger Change-Id: I6c231184c3a4c0e67dd29d43560b0c28778883db Merged-In: I6c231184c3a4c0e67dd29d43560b0c28778883db
-
Thiébaud Weksteen authored
Test: lint_fix --print --no-fix --check AnnotatedAidlCounter --lint-module AndroidUtilsLintChecker services.autofill services.usage Change-Id: I08f5aa3e74db8ff24544bbdd3edb0635a0d2fb52
-