Skip to content
Snippets Groups Projects
  1. Jan 19, 2024
    • Ian Baker's avatar
      Log exception when MediaPlayer.attemptDataSource fails · b01504da
      Ian Baker authored
      This gives more context when a subsequent fallback call to
      setDataSource(String, Map<String, String>, List<HttpCookie>) fails
      (which is often expected, especially for content:// URIs). These logs
      should help to see more detail of the unexpected failure from
      ContentResolver in this case.
      
      Bug: 313263440
      Test: Presubmit
      Change-Id: I77df208d796c92596a5c28d845aaaf71546173b5
      b01504da
  2. Jan 18, 2024
    • Siim Sammul's avatar
    • Siim Sammul's avatar
      Revert^3 "Change the way tombstones are added to dropbox." · 59082d54
      Siim Sammul authored
      This reverts commit 225bfb76.
      
      Reason for revert: We are possibly losing tombstones
      
      Change-Id: I8372ae3b7b5db63bc48155eca63eb3cae41239c8
      59082d54
    • Treehugger Robot's avatar
      Merge changes from topic "cherrypicker-L71800030001277565:N06200030020868453" into main · b7a04919
      Treehugger Robot authored
      * changes:
        RemoteInputConnectionImpl should not call on IMM#isActive()
        Simplify RemoteInputConnectionImpl#finishComposingText*()
        Remove RemoteInputConnectionImpl#mLock, which is redudant
      b7a04919
    • Yohei Yukawa's avatar
      RemoteInputConnectionImpl should not call on IMM#isActive() · 2b5fbda5
      Yohei Yukawa authored
      Historically RemoteInputConnectionImpl has been calling on
      
        InputMethodManager#isActive()
      
      to see if the InputConnection is considered to be active or inactive
      when actually handling each incoming InputConnection operation.
      
      However, InputMethodManager#isActive() is also known to be tricky
      because it internally calls InputMethodManager#checkFocus(), which can
      have non-trivial side effects.
      
      With this CL, RemoteInputConnectionImpl keeps maintains its own
      boolean state on whether #deactivate() is already called or not so
      that it does not need to rely on IMM#isActive() any more.
      
      For 99% cases there must be no observable behavior change, and for the
      remaining 1% cases the new behavior should be more easily
      understandable.
      
      Bug: 291826769
      Test: atest CtsInputMethodTestCases:InputConnectionHandlerTest#testInputConnectionSideEffect
      Merged-In: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8
      Change-Id: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8
      2b5fbda5
    • Yohei Yukawa's avatar
      Simplify RemoteInputConnectionImpl#finishComposingText*() · a9156d61
      Yohei Yukawa authored
      With my previous CLs [1][2], we can generally assume the following
      things.
      
       - InputConnection#closeConnection() always gets called when it
         becomes invalidated, including the case when the IME has switched
         to another IME client.
      
       - Each implementation of InputConnection#closeConnection() is
         expected to do appropriate clean up including finishing composing
         text. {Base,Editable}InputConnection actually do this correctly.
      
      With that it should be safe for #finishComposingText*() to follow the
      same pattern about isActive().
      
       [1]: I234309c5880c9fe0b299b8bd0f8862796d4dda0d
            9f9afe52
       [2]: If2a03bc84d318775fd4a197fa43acde086eda442
            aaa38c9f
      
      Bug: 35301295
      Bug: 291826769
      Test: presubmit
      Merged-In: If913701bf8555f5d76fceb272e38a99f5e243bbe
      Change-Id: If913701bf8555f5d76fceb272e38a99f5e243bbe
      a9156d61
    • Yohei Yukawa's avatar
      Remove RemoteInputConnectionImpl#mLock, which is redudant · e47a2e5c
      Yohei Yukawa authored
      It is guaranteed that the following two boolean expressions have
      always the same value observed outside from
      RemoteInputConnectionImpl#mLock.
      
        A. RemoteInputConnectionImpl#mFinished
        B. RemoteInputConnectionImpl#mInputConnection != null
      
      With that we should be able to simply merge them into an atomic
      reference object
      
        AtomicReference<InputConnection>
      
      without requiring RemoteInputConnectionImpl#mLock as a lock object.
      
      This CL does so as a preparation to clean up RemoteInputConnectionImpl
      for Bug 291826769.
      
      There should be no observable behavior change, except for the fact
      that
      
        RemoteInputConnectionImpl#dumpDebug()
      
      no longer blocks other operations that required mLock, which is kind
      of out of our original intention.
      
      Bug: 291826769
      Test: presubmit
      Merged-In: I69fa2c81670f84be3dd4a808262758a803f69dfc
      Change-Id: I69fa2c81670f84be3dd4a808262758a803f69dfc
      e47a2e5c
    • Treehugger Robot's avatar
    • Shawn Willden's avatar
  3. Jan 17, 2024
  4. Jan 16, 2024
  5. Jan 15, 2024
  6. Jan 13, 2024
  7. Jan 12, 2024
  8. Jan 11, 2024
Loading