- Jan 19, 2024
-
-
Ian Baker authored
This gives more context when a subsequent fallback call to setDataSource(String, Map<String, String>, List<HttpCookie>) fails (which is often expected, especially for content:// URIs). These logs should help to see more detail of the unexpected failure from ContentResolver in this case. Bug: 313263440 Test: Presubmit Change-Id: I77df208d796c92596a5c28d845aaaf71546173b5
-
- Jan 18, 2024
-
-
Siim Sammul authored
-
Siim Sammul authored
This reverts commit 225bfb76. Reason for revert: We are possibly losing tombstones Change-Id: I8372ae3b7b5db63bc48155eca63eb3cae41239c8
-
Treehugger Robot authored
* changes: RemoteInputConnectionImpl should not call on IMM#isActive() Simplify RemoteInputConnectionImpl#finishComposingText*() Remove RemoteInputConnectionImpl#mLock, which is redudant
-
Yohei Yukawa authored
Historically RemoteInputConnectionImpl has been calling on InputMethodManager#isActive() to see if the InputConnection is considered to be active or inactive when actually handling each incoming InputConnection operation. However, InputMethodManager#isActive() is also known to be tricky because it internally calls InputMethodManager#checkFocus(), which can have non-trivial side effects. With this CL, RemoteInputConnectionImpl keeps maintains its own boolean state on whether #deactivate() is already called or not so that it does not need to rely on IMM#isActive() any more. For 99% cases there must be no observable behavior change, and for the remaining 1% cases the new behavior should be more easily understandable. Bug: 291826769 Test: atest CtsInputMethodTestCases:InputConnectionHandlerTest#testInputConnectionSideEffect Merged-In: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8 Change-Id: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8
-
Yohei Yukawa authored
With my previous CLs [1][2], we can generally assume the following things. - InputConnection#closeConnection() always gets called when it becomes invalidated, including the case when the IME has switched to another IME client. - Each implementation of InputConnection#closeConnection() is expected to do appropriate clean up including finishing composing text. {Base,Editable}InputConnection actually do this correctly. With that it should be safe for #finishComposingText*() to follow the same pattern about isActive(). [1]: I234309c5880c9fe0b299b8bd0f8862796d4dda0d 9f9afe52 [2]: If2a03bc84d318775fd4a197fa43acde086eda442 aaa38c9f Bug: 35301295 Bug: 291826769 Test: presubmit Merged-In: If913701bf8555f5d76fceb272e38a99f5e243bbe Change-Id: If913701bf8555f5d76fceb272e38a99f5e243bbe
-
Yohei Yukawa authored
It is guaranteed that the following two boolean expressions have always the same value observed outside from RemoteInputConnectionImpl#mLock. A. RemoteInputConnectionImpl#mFinished B. RemoteInputConnectionImpl#mInputConnection != null With that we should be able to simply merge them into an atomic reference object AtomicReference<InputConnection> without requiring RemoteInputConnectionImpl#mLock as a lock object. This CL does so as a preparation to clean up RemoteInputConnectionImpl for Bug 291826769. There should be no observable behavior change, except for the fact that RemoteInputConnectionImpl#dumpDebug() no longer blocks other operations that required mLock, which is kind of out of our original intention. Bug: 291826769 Test: presubmit Merged-In: I69fa2c81670f84be3dd4a808262758a803f69dfc Change-Id: I69fa2c81670f84be3dd4a808262758a803f69dfc
-
Treehugger Robot authored
-
Shawn Willden authored
-
- Jan 17, 2024
-
-
Shawn Willden authored
Bug: 290312729 Test: N/A Change-Id: I65e7ce4b7113639523aec1e08682a334056cbb69
-
Girish Shetty authored
-
Sudheer Shanka authored
* changes: Pass in a new instance supplier for creating RingBuffer. Update RingBuffer to take Supplier<T> for creating new instances.
-
Nelson Li authored
Bug: 312324146 Test: Add android-test-base-current.txt to the Android.bp Change-Id: I4fe3565be918d7212334f4d36a8d80aa2adf4460
-
Girish authored
Bug: 289097671 Test: atest android.media.misc.cts.ResourceManagerTest atest android.media.misc.cts.ResourceManagerMultiTest Merged-In: I750ef5a7585b7bba94f0dfb7bb8e70ec12bf70f5 Change-Id: I750ef5a7585b7bba94f0dfb7bb8e70ec12bf70f5
-
- Jan 16, 2024
-
-
Automerger Merge Worker authored
Merge "Merge "Making adapter child views in RemoteCollectionItemsAdapter size-aware" into android14-tests-dev am: 83b74c07" into main
-
Sihua Ma authored
Merge "Making adapter child views in RemoteCollectionItemsAdapter size-aware" into android14-tests-dev am: 83b74c07 Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2912083 Change-Id: I93142f62b45124a1d25ea839b90927796c67c797 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Sihua Ma authored
Merge "Making adapter child views in RemoteCollectionItemsAdapter size-aware" into android14-tests-dev
-
Mikhail Naganov authored
-
Eric Biggers authored
-
T.J. Mercier authored
-
Sihua Ma authored
This helps fix issues with improper layouts of adapter child views in case RemoteCollecionItemsAdapter is used. Test: Manual Bug: 245950570 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dc464d6e522eebec5221a934ec3ff5f52a4fb90e) Merged-In: I0eedf4574975bfae88801e0153816135fc1c8181 Change-Id: I0eedf4574975bfae88801e0153816135fc1c8181
-
Aaron Vaage authored
-
Yi Kong authored
-
Yi Kong authored
This adds profcollect trigger for dex2oat invocations. This helps improving profile coverage for dex2oat. Bug: 319377405 Test: manual Change-Id: I6fa6f2b0538a87d4fbab7f220052e5be621159bb
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
- Jan 15, 2024
-
-
Wei Sheng Shih authored
-
wilsonshih authored
To make the embedded window of SplashScreenView non-focusable, needs to add the window flag separately from SurfaceControlViewHost#setView Bug: 319369153 Test: verify the embedded window of splash screen won't grant focus Change-Id: Ic9b48dcc4de25e681405b3dd78468597a8a7c627
-
- Jan 13, 2024
-
-
Aaron Vaage authored
Change-Id: Ib79857aa0c6bdf76d0ab65cd66e044aac4e4084e
-
- Jan 12, 2024
-
-
Jihoon Kang authored
-
Eric Biggers authored
UserDataPreparerTest#testPrepareUserData_forNewUser_destroysOnFailure and UserDataPreparerTest#testPrepareUserData_forExistingUser_doesNotDestroyOnFailure fail on eng builds because they exercise a code path in UserDataPreparer that uses Log.wtf, and on eng builds Log.wtf causes the process to abort. Fix this by changing the message to ERROR level instead. Bug: 316035110 Test: atest UserDataPreparerTest Change-Id: I4dce4db37bf650b7f97e46638c03a429a135a3b6
-
Pawan Wagh authored
* changes: Add recovery permission to Settings app Add 16k option key in settings
-
Yan Yan authored
-
Jaideep Sharma authored
Dump audio effect hal to get thread traces incase of watchdog. Bug: 319759668 Test: compile and induce a watchdog and check generated dumps Change-Id: Ie38876aedea597e6ff3fac3d861f3ab43c7c37a6
-
YK Hung authored
-
Sebastiano Barezzi authored
During development the Wi-Fi service might not work, let's handle this case so the Setting app doesn't crash when opening the about phone page Logic borrowed from the Bluetooth controller Change-Id: Id8f6ba5d7cbac5780363612b50848ecfea10bc04
-
- Jan 11, 2024
-
-
Yan Yan authored
This CL integrates the IpSecPacketLossDetector into VCN route selection. With this change, when a data stall is reported, the network candidate will be penalized and then deprioritized during network selection. A network candidate will stop being penalized until it hitting a timeout or passing the validation. Bug: 282996138 Test: atest FrameworksVcnTests(new tests), CtsVcnTestCases Change-Id: Ifabd6fdea1d5a4fea40cf929dbab7c26d37274ac
-
William Loh authored
-
William Loh authored
Bug: 307556883 Test: n/a Change-Id: I5001247c342f23b07e1355db7e50ad90cce66b07
-