- Nov 22, 2023
-
-
Harry Cutts authored
Bug: 302297266 Test: atest UinputTests Change-Id: I7b4c6fa87f6ba50147f3ddeb9b8e4ceaa238ffc1
-
- Nov 21, 2023
-
-
Harry Cutts authored
evemu [0] is a system used by the wider Linux community to record sequences of evdev events and descriptions of the device that created them. Together with the evemu-record implementation added to frameworks/native, implementing support for evemu recordings in uinput gives us a system for event recording and replay that's compatible with other Linux systems. Since the format looks quite different from the existing JSON-style one, we can automatically detect which type of data is being passed in, instead of having to change the command-line interface. As part of the implementation, the Event.Bus enum is replaced with plain integers. This allows the tool to support new bus IDs that are added to Linux's input.h without code changes, at least for evemu files. [0]: https://gitlab.freedesktop.org/libevdev/evemu Bug: 302297266 Test: replay recordings made using Android and FreeDesktop evemu-record implementations Change-Id: Ie2f969da24db9aa04037335d5b697cdc0db0b3ca
-
Pascal Muetschard authored
Although the binary looks for a vendor provided shared library, it is an otherwise vendor agnostic tool. Moving it off the vendor partition also has the added benefit of it not requiring root to be run. Bug: b/273907878 Test: manual Change-Id: I81726ffb7d96acef69b7b77c864be254be9a74c5
-
- Nov 16, 2023
-
-
Harry Cutts authored
Parsing strings into enum values should be done by the parser, not the builder, and this means that the evemu parser will be able to pass properly typed values to setCommand rather than "magic" strings. Bug: 302297266 Test: m uinput Change-Id: Icac5764a66025412c87c326280d1895f3da78cac
-
Harry Cutts authored
Previously the tool just carried on, with event injections being silently dropped, which isn't very obvious behaviour. Bug: 302297266 Test: cause device creation to fail somehow, check the tool exits Change-Id: I94e931729339bff0f6fc7ab5b591f062043a1d7a
-
Harry Cutts authored
This came in useful when debugging the evemu support, and seems like something we should be checking anyway. Bug: 302297266 Test: pass some invalid arguments (e.g. large numbers that aren't valid event codes) to the ioctls, check errors are logged Change-Id: Id3e32dad96c9db8819009b815ee2574ef63e96f7
-
- Nov 15, 2023
-
-
John Reck authored
Test: make && adb shell screencap Change-Id: I0141a9ea9b51a06bafdeac6c7848986906b8eacc
-
- Nov 14, 2023
-
-
Harry Cutts authored
Rename setDuration and associated identifiers to make the units clearer, fix a typo in setInputport, and add some JavaDoc to clarify the structure of configuration arrays. Bug: 302297266 Test: m uinput Change-Id: I9b9ae8970389da3cdfe06738883ef02ebf07ff77
-
Harry Cutts authored
This makes the Command and UinputControlCode enums and the code to look up their values a little tidier. Bug: 302297266 Test: atest CtsInputHostTestCases Change-Id: Iad98088b93dc1e1b72df1efbeb9010f78c6962e9
-
Harry Cutts authored
We'll shortly be adding a parser for a different file format (evemu), and having the different parsers in separate files will make the code nicer to navigate. In addition to moving it to a separate file, this CL renames Reader to JsonStyleParser to avoid confusion with Java's Reader classes, and replaces some switch statements with the new-style switch syntax to improve readability. Bug: 302297266 Test: atest CtsInputHostTestCases Change-Id: Id6c7536a2caea3b61fac615dce071129bf4dc1e4
-
- Nov 08, 2023
-
-
Dominik Laskowski authored
The underlying type of DisplayId is uint64_t, but screencap parsed the IDs as signed 64-bit, invoking undefined behavior for out-of-range IDs. In practice, out-of-range IDs were clamped, so SF failed to find them. Fixes: 302580952 Test: screencap works for virtual display on Felix Change-Id: I09a863d0c68dbb857b6f756b51159e5e3d853f5d
-
Pascal Muetschard authored
Test: tested locally Change-Id: I4971e1b422bf4b278e8c3153e2134956c8d35700
-
- Oct 24, 2023
-
-
Roshan Pius authored
This reverts commit 8140652e. Reason for revert: Added a fix for the failing code. Change-Id: I729672340d52a745dd43121e1dbedf9d6d5ec34a
-
- Oct 23, 2023
-
-
Roshan Pius authored
This reverts commit 12058cb9. Reason for revert: Fails telephony tests Bug: 303286040 Test: N/A Change-Id: I07c79f6d07ac8f7394698b8144e9310be2f3f1fe
-
Roshan Pius authored
Follow up CL for aosp/2798514 to add owners file. Bug: 303286040 Test: Compiles Change-Id: I18d8f617beb385c684c635ec2ec57d296be5e6f3
-
- Oct 20, 2023
-
-
Roshan Pius authored
Bug: 303286040 Test: adb shell svc nfc enable Change-Id: I678d01c7c86defb7eb071d66cb2aede4983ab506
-
- Sep 28, 2023
-
-
Harry Cutts authored
Bug: 245989146 Change-Id: I84dfce5d216a5065611bf63f61e803a93e76b58f Test: check gittiles rendering
-
- Sep 22, 2023
-
-
Pawan Wagh authored
readFileDescriptor doesn't provide ownership of the fds. fdopen needs ownership of the fds. Fds read from parcel should be duped in this scenario and readUniqueFileDescriptor dups fds internally. Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer Test: atest incidentd_test Bug: 286931110 Bug: 283699145 Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e (cherry picked from commit ba78ef27)
-
Pawan Wagh authored
readFileDescriptor doesn't provide ownership of the fds. fdopen needs ownership of the fds. Fds read from parcel should be duped in this scenario and readUniqueFileDescriptor dups fds internally. Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer Test: atest incidentd_test Bug: 286931110 Bug: 283699145 Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e (cherry picked from commit ba78ef27)
-
Pawan Wagh authored
readFileDescriptor doesn't provide ownership of the fds. fdopen needs ownership of the fds. Fds read from parcel should be duped in this scenario and readUniqueFileDescriptor dups fds internally. Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer Test: atest incidentd_test Bug: 286931110 Bug: 283699145 Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e (cherry picked from commit ba78ef27)
-
Pawan Wagh authored
readFileDescriptor doesn't provide ownership of the fds. fdopen needs ownership of the fds. Fds read from parcel should be duped in this scenario and readUniqueFileDescriptor dups fds internally. Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer Test: atest incidentd_test Bug: 286931110 Bug: 283699145 Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e (cherry picked from commit ba78ef27)
-
Pawan Wagh authored
readFileDescriptor doesn't provide ownership of the fds. fdopen needs ownership of the fds. Fds read from parcel should be duped in this scenario and readUniqueFileDescriptor dups fds internally. Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer Test: atest incidentd_test Bug: 286931110 Bug: 283699145 Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e (cherry picked from commit ba78ef27)
-
Pawan Wagh authored
readFileDescriptor doesn't provide ownership of the fds. fdopen needs ownership of the fds. Fds read from parcel should be duped in this scenario and readUniqueFileDescriptor dups fds internally. Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer Test: atest incidentd_test Bug: 286931110 Bug: 283699145 Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e (cherry picked from commit ba78ef27)
-
Pawan Wagh authored
readFileDescriptor doesn't provide ownership of the fds. fdopen needs ownership of the fds. Fds read from parcel should be duped in this scenario and readUniqueFileDescriptor dups fds internally. Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer Test: atest incidentd_test Bug: 286931110 Bug: 283699145 Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e (cherry picked from commit ba78ef27)
-
Pawan Wagh authored
readFileDescriptor doesn't provide ownership of the fds. fdopen needs ownership of the fds. Fds read from parcel should be duped in this scenario and readUniqueFileDescriptor dups fds internally. Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer Test: atest incidentd_test Bug: 286931110 Bug: 283699145 Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e (cherry picked from commit ba78ef27)
-
Pawan Wagh authored
readFileDescriptor doesn't provide ownership of the fds. fdopen needs ownership of the fds. Fds read from parcel should be duped in this scenario and readUniqueFileDescriptor dups fds internally. Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer Test: atest incidentd_test Bug: 286931110 Bug: 283699145 Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e (cherry picked from commit ba78ef27)
-
- Sep 21, 2023
-
-
beatricemarch authored
In particular add events to cover -If this is KV or Full restore -For each package, when the restore started and when it ended -When a restore operation starts, if it is system restore or restore at install -Any errors Test: manual testing. Run `adb shell bmgr restore 1` and verify that the new restore events are added to the dumpsys atest CtsBackupHostTestCases, GtsBackupHostTestCases atest BackupManagerMonitorDumpsysUtilsTest, BackupManagerMonitorEventSenderTest, UserBackupManagerServiceTest, PerformUnifiedRestoreTaskTest, BmgrTest Bug: 290747920 Change-Id: I0d221f10932fea3e8fb90a1827c7f1b5bf21d25d
-
- Sep 12, 2023
-
-
Tomasz Wasilczyk authored
Bug: 295394788 Test: m checkbuild Change-Id: I6aa039b6b2a4944e3537ef133f8785890d957edd
-
- Sep 07, 2023
-
-
Ryan Prichard authored
Bug: b/175635923 Test: treehugger Change-Id: I241c8b2b48bb4c616fbc5b4ae1285e274182144b Merged-In: I241c8b2b48bb4c616fbc5b4ae1285e274182144b
-
- Sep 06, 2023
-
-
Tomasz Wasilczyk authored
Bug: 295394788 Test: make checkbuild Change-Id: I95264e8bfc96a5adb7f7cc55a24dc0e8c126371d (cherry picked from commit a550a478)
-
- Sep 05, 2023
-
-
Tomasz Wasilczyk authored
Bug: 295394788 Test: make checkbuild Change-Id: I370f66c469de73064dec2e42c539dc236dd69d1e
-
- Sep 01, 2023
-
-
Tomasz Wasilczyk authored
Bug: 295394788 Test: make checkbuild Change-Id: I95264e8bfc96a5adb7f7cc55a24dc0e8c126371d
-
Ryan Prichard authored
Bug: b/175635923 Test: treehugger Change-Id: I241c8b2b48bb4c616fbc5b4ae1285e274182144b
-
- Aug 30, 2023
-
-
Yurii Zubrytskyi authored
Don't convert each attribute name but instead only do it once for the string they're compared to Bug: 282215580 Test: build + atest idmap2_tests Change-Id: I09f6d0f90f6c09632ceac8cdde7c20801f41524e
-
- Aug 28, 2023
-
-
Tomasz Wasilczyk authored
Bug: 295394788 Test: make checkbuild Change-Id: I538720d4de2dcc038b417048209782ff605b7e30
-
- Aug 24, 2023
-
-
Tomasz Wasilczyk authored
This empty method is different from the old one - it aligns with std::string definition. Bug: 295394788 Test: make checkbuild Change-Id: I1900997f36327af8c3d12b4f77971fdd96080616
-
Tomasz Wasilczyk authored
This empty method is different from the old one - it aligns with std::string definition. Bug: 295394788 Test: make checkbuild Change-Id: Ib80c839df7ff7e3fb0ed2df7a00393d843d44d9d
-
- Aug 23, 2023
-
-
Tomasz Wasilczyk authored
Bug: 295394788 Test: TH Change-Id: I8e87ed078797cc941a16d1b2a3f96e0d668bf4ec
-
Tomasz Wasilczyk authored
Bug: 295394788 Test: m checkbuild Change-Id: I2e3167aaf464132127d5838075c7f9a5257ed275
-
- Aug 22, 2023
-
-
Chan Kim authored
See https://source.android.com/setup/contribute/respectful-code for reference For this round, the fixes are only applied to the following to minimize breaking dependencies: * comments (excluding javaDoc annotations) * private constants * private functions * parameters within functions BYPASS_INCLUSIVE_LANGUAGE_REASON=Just updating a few select inclusive language violations. No-Typo-Check: Changes focused on inclusive language violations. BUG: 295342157 Change-Id: Iacc0ea9fc848b15048978637bdc25136582433ef
-