Some developers have been surprised by this limitation and had trouble
figuring out what the issue was. Add documentation to address this.

This also includes a drive-by removal of a duplicate check.

Bug: 149867479
Test: doc-only change
Change-Id: I5911d01984695550b6c9afe7a8eb535bf5e320a1

* changes:
  Add back missing `tidy_checks`, since `tidy_checks_as_errors` isn't enough
  Use `tidy_checks_as_errors` list instead of `-warnings-as-errors=*`

Change-Id: I5e541138c35cdf67d18ce5475221baeb3e7faef4
Test: emulator
Bug: 158151004

Bug: 157380700
Test: manual
Change-Id: Ia5e5a84e1b17887b440c2c83894f0a8cfc50faf4
Merged-In: Ia5e5a84e1b17887b440c2c83894f0a8cfc50faf4

Bug: 144284873
Test: make checkapi
Change-Id: I99ed93e96f7465f1f7c9a32c3715a874055dc809
Merged-In: I99ed93e96f7465f1f7c9a32c3715a874055dc809

The BPF tethering coordinator listens to the forwarding rule
changes for updating data limit which is applied in the following
conditions.
- After adding the first rule on a given upstream, add data limit.
- After removing the last rule on a given upstream, clear data limit.
- The service applies a new data limit on current upstream.

The reason for relying on rule changes is because the Tethering and
IpServer objects have multi-internal state machines. It is hard to
synchronize all of their states.

Note that the data limit cleanup for stopping or switching upstream
relies on offload rules are all removed as well.

Bug: 150736748
Test: manual
Change-Id: I829d36339973f9473fe6b616c48aa288f18d1c46

I unfortunately missed in the original testing that
`tidy_checks_as_errors` isn't sufficient by itself. Instead we need to
have both places with the same variables. A future change will make
Soong expand `tidy_checks_as_errors` into both locations appropriately.

Bug: 119328308
Test: WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=*,-readability-*,-google-readability-*,-google-runtime-references,-cppcoreguidelines-*,-modernize-*,-llvm-*,-bugprone-narrowing-conversions,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-hicpp-*,-fuchsia-* mm
Change-Id: If69f69bf7861ba3569756270381f3f737366f2f0
Merged-In: If69f69bf7861ba3569756270381f3f737366f2f0
(cherry picked from commit 56af5939)

This fixes a build break due to new code from
http://ag/I96f970e82b5243be01b205ac2cb6ab249c6100bc that inadvertently
triggers some false positives with other clang-tidy flags. Builds that
use a wider set of tidy flags (as specified in the test below) will
break since `-warnings-as-errors=*` turns all warnings into errors,
rather than just the ones that were specified as part of this
Android.bp. The preferred way of checking this is to use
`tidy_checks_as_errors`

Bug: 119328308
Test: WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=*,-readability-*,-google-readability-*,-google-runtime-references,-cppcoreguidelines-*,-modernize-*,-llvm-*,-bugprone-narrowing-conversions,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-hicpp-*,-fuchsia-* mm
Change-Id: I941b3c89402e2cfa290b3829e2ac8ff7ea67ca3d
Merged-In: I941b3c89402e2cfa290b3829e2ac8ff7ea67ca3d
(cherry picked from commit 0bc64543)

I8ea5421723a4a40d580956e5ceb51be70253f0eb has made the two APIs in the
class public (though as deprecated). We don't need to put them into the
greylist, which would make the hiddenapi tool uncomfortable.

Bug: 157007292
Test: m on qemu_trusty_arm64
Change-Id: Ibde3f44244fbe0e2c5da596eef05da57a6ee474a

Test: build
Bug: 146066107
Bug: 141631489
Bug: 122371089
Bug: 149880090
Bug: 127666858
Bug: 142026991
Bug: 155097675
Bug: 158014276

Merged-In: I124cf2da59ed4c5e92406081aac0df0f347ace74
Merged-In: I283483f2037d33225b18145c46effaed29825dbe
Merged-In: I320611ee871c7feae53e3e67fcdf8cbab0be241b
Change-Id: I121bc7a90425410c5b3d7b325ddd806aa4a040d1

When eng/userdebug load is with user build adbd, we
need to always new AdbDebuggingManager to let confirmation
dialog can appear.

Bug: 158156979
Test: "adb shell" can trigger confirmation dialog
Change-Id: Ia0830c78c8cc913985f41b93eeecf8bf57ec1b03

BUG=63112905

Change-Id: I0277737eb9e683073f27d2ddea30c93f78ec4b91

Restarts immediately, a future patch will ensure we restart
at a non-interruptive time.

Bug: 156757711
Test: atest BluetoothInstrumentationTests
Tag: #feature
Change-Id: I8aad97b8c21f28d4a18ae597f3838de9caee150a

Bug: 150736748
Test: atest BpfCoordinatorTest
Change-Id: Ic1f37de75b064d7c8717e1b496e13174bb8693ec

Invoke the existing polling thread to update data alert statistics.
Once the data alert limit has reached, trigger the notification.

Bug: 150736748
Test: BpfCoordinatorTest
Change-Id: Ibf25560ca2e9f003d8eba01361dc7d35ec1b1627

Currently tethering notification is sending a pending intent for
redirecting user to tether settings page. However, this intent
is implicit that only create with
Settings.ACTION_TETHER_SETTINGS. For security reasons, this
intetnt should specify an explicit component to be delivered to.
Thus, specify the settings package name to this intent.

Test: atest TetheringTests
Bug: 156353008
Change-Id: I49187aee8a004caa890e2a73c0a28d280215c7d4