Skip to content
Snippets Groups Projects
  1. Oct 31, 2019
  2. Oct 30, 2019
  3. Oct 29, 2019
    • Xiangyu/Malcolm Chen's avatar
      Merge changes from topic "getDeviceCapableModemCount" · 8ed3fb4b
      Xiangyu/Malcolm Chen authored
      * changes:
        Rename and publicize getMaxPhoneCount; and deprecate getPhoneCount.
        Add public intent ACTION_MULTI_SIM_CONFIG_CHANGED.
      8ed3fb4b
    • Treehugger Robot's avatar
      Merge "Add OWNERS for media/tv files" · c91c7ab3
      Treehugger Robot authored
      c91c7ab3
    • Kweku Adams's avatar
      Add yanmin@ and zhouwenjie@ to incident proto OWNERS list. · 03866d96
      Kweku Adams authored
      Bug: N/A
      Test: N/A
      Change-Id: I8c2fa55a348c8cb1622489ab07fea05a29391f0b
      03866d96
    • Kweku Adams's avatar
      Move heap dump sharing to SHELL. · 4d345d7a
      Kweku Adams authored
      The system shouldn't be granting read URI permissions as itself. This
      means that heap dumps aren't successfully shared. Moving the heap dump
      sharing mechanism to SHELL, which already has the permission to dump
      heaps so that dumps can be shared properly.
      
      The ActivityManagerService changes are submitted separately.
      
      Bug: 126885951
      Bug: 135150619
      Test: collect a heap dump and confirm it's successfully shared with an app
      Test: do manual test on a secondary user & confirm it's not available to
      other user
      
      Change-Id: I6fad69280b5124c8ec2d3b4bef0f7dddb6a9422c
      4d345d7a
    • Christian Wailes's avatar
    • Jack Yu's avatar
    • Treehugger Robot's avatar
    • Chris Wailes's avatar
      Fixes a system crash in VibratorService on x86 hosts · 7d716426
      Chris Wailes authored
      Original symptom: Cuttlefish devices would crash when the "recent apps"
      tray was swiped up from the bottom.
      
      Root cause: Raising the "recent apps" tray triggers a vibration.  Close
      to the bottom of the call stack responsible for this action in
      VibratorService is the native function vibratorPerformEffect().  The
      Java Language signature for this function has a long as the type of the
      second parameter, as does the JNI signature that is registered with the
      environment.  The native function, however, uses an int type for this
      parameter.  As a result, when the arguments are passed via the stack on
      x86 devices the high bits of the second long argument are read as the
      contents of the third argument, which is a jobject reference.  When the
      code attempts to convert this NULL local reference into a global
      reference the JNI code aborts the runtime for the process.  Because the
      VibratorService is part of the SystemServer, when it crashes the Zygote
      is notified and restarts the entire shell.
      
      Why this wasn't an issue on ARM devices: ARMs calling conventions pass
      many of a function's arguments via registers instead of via the stack.
      This means that the long argument is passed in a register, preventing it
      from stomping on any other arguments.  When the native function uses the
      argument it simply reads the lower bits from the register and ignores
      the higher bits.
      
      Why this wasn't previously an issue on X86 hosts: ag/9158254 introduced
      a new parameter to the vibratorPerformEffect() function.  This new
      parameter is located after the mis-typed parameter and will be aliased
      to the high bits of the mis-typed long argument.
      
      Fix: Correct the type signature of the native vibratorPerformEffect()
      function.
      
      Bug: 143082450
      Test: Build -> start cuttlefish -> raise recent apps tray -> no crash
      [adelva: port to AOSP to close potential ASAN issues]
      Change-Id: If50f68df9579f84bddc9d70a0a30cd73f4485e96
      Merged-In: If50f68df9579f84bddc9d70a0a30cd73f4485e96
      7d716426
    • Treehugger Robot's avatar
    • Malcolm Chen's avatar
      Have getSupportedModemCount always rely on system properties. · ee5bfb64
      Malcolm Chen authored
      Earlier we disabled the reboot free feature and always have
      getSupportedModemCount return the same value with getActiveModemCount.
      Now that we've enbaled reboot free switch, we will return correct value
      based on system property.
      
      Bug: 142514392
      Test: manual - change PROPERTY_REBOOT_REQUIRED_ON_MODEM_CHANGE and test
      what getSupportedModemCount returns.
      Change-Id: I34e172c747dd52aa498037e64b758393793fddba
      Merged-In: I34e172c747dd52aa498037e64b758393793fddba
      ee5bfb64
    • Malcolm Chen's avatar
      Rename and publicize getMaxPhoneCount; and deprecate getPhoneCount. · 387dc0ef
      Malcolm Chen authored
      To have better names reflecting what getPhoneCount / getMaxPhoneCount
      actually represent, we replace them with getActiveModemCount and
      getSupportedModemCount. As getPhoneCount is public API, we mark
      it as @Deprecated.
      
      Bug: 141388730
      Test: build
      Change-Id: If086c50ae803b384691f709057bceeac2fc1d9d5
      Merged-In: If086c50ae803b384691f709057bceeac2fc1d9d5
      387dc0ef
    • Malcolm Chen's avatar
      Add public intent ACTION_MULTI_SIM_CONFIG_CHANGED. · 64ff73fe
      Malcolm Chen authored
      ACTION_MULTI_SIM_CONFIG_CHANGED will be sent when multi-SIM
      variants change.
      
      Bug: 141388730
      Test: test app
      Change-Id: I717482ea05571afdfe6b04318d3f1fbda0c177ed
      Merged-In: I717482ea05571afdfe6b04318d3f1fbda0c177ed
      64ff73fe
    • Nicolas Geoffray's avatar
      Add checks to ensure only the ART memfd file is whitelisted. · abbd4a7a
      Nicolas Geoffray authored
      A memfd file can be created with any name, but to protect ourselves
      from unintended leakage, check that it's the name ART uses.
      
      Test: boots
      Bug: 119800099
      Change-Id: Ibc684d09dd05f38933c6808b72fb402fc9d5e4eb
      abbd4a7a
    • Steven Moreland's avatar
      2a6f6ed9
    • Nicolas Geoffray's avatar
    • Marco Nelissen's avatar
      00639037
Loading