Skip to content
Snippets Groups Projects
  1. May 03, 2024
    • Oriol Prieto Gasco's avatar
      RESTRICT AUTOMERGE · 7b816129
      Oriol Prieto Gasco authored
      Set the container field of aconfig flags
      
      Test: printflags --format='{package}:{container}:' | grep "::"
      Bug: 312769710
      Flag: NONE
      Change-Id: I84fda0d5e9813940609436d825738ff786908ff0
      7b816129
  2. Apr 23, 2024
    • Ryan Prichard's avatar
      hwui: add missing <mutex> include · bc3bf5b0
      Ryan Prichard authored
      Upgrading to clang-r522817's new libc++ requires that <mutex> be
      included here.
      
      Bug: 333165689
      Test: treehugger
      Flag: EXEMPT, fix build error
      Change-Id: I14ff396b21feb4b569a3c8d967c8295a04005beb
      bc3bf5b0
  3. Mar 13, 2024
    • Aditya Kumar's avatar
      Provide a complete definition of FileBlobCache · 9feca01f
      Aditya Kumar authored
      ```
      In file included from external/libcxx/include/algorithm:644:
      external/libcxx/include/memory:2335:19: error: invalid application of 'sizeof' to an incomplete type 'android::FileBlobCache'
       2335 |     static_assert(sizeof(_Tp) > 0,
            |                   ^~~~~~~~~~~
      external/libcxx/include/memory:2652:7: note: in instantiation of member function 'std::default_delete<android::FileBlobCache>::operator()' requested here
       2652 |       __ptr_.second()(__tmp);
            |       ^
      external/libcxx/include/memory:2606:19: note: in instantiation of member function 'std::unique_ptr<android::FileBlobCache>::reset' requested here
       2606 |   ~unique_ptr() { reset(); }
            |                   ^
      frameworks/base/libs/hwui/pipeline/skia/ShaderCache.h:40:7: note: in instantiation of member function 'std::unique_ptr<android::FileBlobCache>::~unique_ptr' requested here
         40 | class ShaderCache : public GrContextOptions::PersistentCache {
            |       ^
      frameworks/base/libs/hwui/pipeline/skia/ShaderCache.h:35:7: note: forward declaration of 'android::FileBlobCache'
         35 | class FileBlobCache;
            |       ^
      1 error generated.
      ```
      
      Test: Build
      Fixes: b/328705924
      Change-Id: I6396f5fafef1941201c05d0b107f48e6d28a6631
      9feca01f
  4. Feb 05, 2024
    • Liangliang Sui's avatar
      Reduce some redundant steps · 6a74777a
      Liangliang Sui authored
      
      1. When |frame->pendingDirty.isEmpty()| is executed there, it must not be empty. Because the judgment has been made at the beginning of the applyRenderNodeTransform method.
      
      2. When |dirty->isEmpty()|, |dirty->setIWH(frame.width(), frame.height());| can be returned directly after execution. There is no need to judge bufferAge, and subsequent steps are redundant. Because the maximum range of dirty is [0, 0, frame.width(), frame.height()]
      
      Change-Id: Iccb3d39e4139c26ed5e7e24c39d1e141cb380dab
      Signed-off-by: default avatarLiangliang Sui <coolsui.coding@gmail.com>
      6a74777a
  5. Jan 25, 2024
    • Jihoon Kang's avatar
      Remove java_api_contribution modules from .bp files · 6aadcb64
      Jihoon Kang authored
      java_api_contribution modules are dynamically generated from droidstubs
      modules or java_sdk_library_import, and is not a user-facing module.
      Defining this module is a .bp file is a no-op.
      
      Test: m nothing
      Bug: 322242515
      Change-Id: I5a6c925f94017f4f92b6abb0c93079d8c85c3eeb
      6aadcb64
  6. Jan 22, 2024
  7. Jan 18, 2024
    • Jiang Tian's avatar
      Fix crash from asynchronous GPU metrics · 8e6a8468
      Jiang Tian authored
      Making the scope more accurate that only acquire the lock when trying
      to access frame info in FrameInfoVisualizer, then make it irrelevant
      to the real draw operation.
      
      Bug: 317995179
      Test: 1.going to developer options
            2. swapping the "profile hwui" option from "none" to "bars"
                and back a couple times, no crash
      
      Change-Id: I069a28a7e847c0c3fca94fd9c43e95382f501b80
      Merged-In: I069a28a7e847c0c3fca94fd9c43e95382f501b80
      8e6a8468
  8. Dec 11, 2023
  9. Dec 07, 2023
  10. Dec 06, 2023
  11. Dec 05, 2023
  12. Nov 30, 2023
  13. Nov 29, 2023
    • Nader Jawad's avatar
      Fix null pointer reference. · 5970c3e8
      Nader Jawad authored
      Fixed issue where profile canvas always leverage
      the transform from the vulkan surface instead of
      leveraging the transform from the hardwarebuffer
      if one was provided.
      
      Fixes: 307978217
      Test: manual
      Change-Id: If27e24828f84977bde321a7635f1531550518491
      5970c3e8
  14. Nov 28, 2023
    • Zhao Qin's avatar
      Fix gpu resource not cleaned up · 6ccda761
      Zhao Qin authored
      Gpu resource is not purged as expected in new implementation when
      app stays in foreground.
      
      Test: manual, adb shell dumpsys gfxinfo
      Change-Id: I15deb71693e726661c8bae70c7ae30cff2dcfa6b
      6ccda761
  15. Nov 22, 2023
    • Tyler Freeman's avatar
      fix(force invert): fix white-on-white text when text is drawn against a fill... · e0faa69a
      Tyler Freeman authored
      fix(force invert): fix white-on-white text when text is drawn against a fill rect in the same RenderNode
      
      This fixes issues with custom Views that draw background and text in the
      same View/RenderNode. Instead of trying to force the individual paints
      to be dark, we simply invert the whole view.
      
      Adds a new hasFill() member to DisplayList and Canvas so that we record
      when the RenderNode has a call that fills the background.
      
      Also adds a new Container usage hint type, for this exact situation.
      
      Bug: 282821643
      Bug: 293883260
      Test: RenderNodeTests.cpp:
        mmm -j8 frameworks/base/libs/hwui && adb push $ANDROID_PRODUCT_OUT/data/nativetest/hwui_unit_tests/hwui_unit_tests     /data/nativetest/hwui_unit_tests/hwui_unit_tests && adb shell /data/nativetest/hwui_unit_tests/hwui_unit_tests
      
      Change-Id: Ia0fe9c739bf07c1f3a8508d3f295a1dc54ee48f9
      e0faa69a
  16. Nov 21, 2023
  17. Nov 17, 2023
    • Kevin Lubick's avatar
      [base] Replace SkFontMgr::RefDefault() with FreeTypeFontMgr · 04931014
      Kevin Lubick authored
      Android Renderengine doesn't draw any text, but hwui needs
      to turn bytes into SkTypefaces and it currently uses Skia's
      "Empty Custom" SkFontMgr, which is really just a wrapper around
      FreeType. This makes that connection explicit instead of relying
      on SkFontMgr::RefDefault(), which is going away soon.
      
      Change-Id: Ida96538c76e069ec86e8dc078ef329cfaeac5d78
      Bug: b/305780908
      04931014
  18. Nov 16, 2023
    • John Reck's avatar
      Only use the gainmap shader if we might need it · 6256c0f5
      John Reck authored
      Skip using the gainmap shader when drawing to a bitmap
      with a known SDR colorspace as it'll be a no-op in
      rendering results since W=1.0, but it'll be very expensive
      in runtime due to CPU evaluation of the SKSL shader.
      
      Before:
      createScaledBitmapWithGainmap_median (ns): 179,455,037
      
      After:
      createScaledBitmapWithGainmap_median (ns): 15,643,742
      
      Bug: 311085927
      Test: benchmark in CL
      Change-Id: I3f2506a2bd86bbe29c6e0837d31e4a231a7c182a
      6256c0f5
  19. Nov 15, 2023
    • John Reck's avatar
      Only use the gainmap shader if we might need it · 859af0d1
      John Reck authored
      Skip using the gainmap shader when drawing to a bitmap
      with a known SDR colorspace as it'll be a no-op in
      rendering results since W=1.0, but it'll be very expensive
      in runtime due to CPU evaluation of the SKSL shader.
      
      Before:
      createScaledBitmapWithGainmap_median (ns): 179,455,037
      
      After:
      createScaledBitmapWithGainmap_median (ns): 15,643,742
      
      Bug: 311085927
      Test: benchmark in CL
      Change-Id: I3f2506a2bd86bbe29c6e0837d31e4a231a7c182a
      859af0d1
  20. Nov 14, 2023
  21. Nov 13, 2023
  22. Nov 10, 2023
  23. Nov 09, 2023
    • John Reck's avatar
      Adjust how present semaphore is handled · 5d3fac14
      John Reck authored
      Avoids stashing a semaphore in a field
      use unique_fd to ensure an unused present fence isn't leaked
      
      Test: sample app ran in a loop for 3 hours, FD usage remained constant
      Fixes: 295332012
      Change-Id: Iee38e86587805ef3596e5f7efea3ca3b5c7758b3
      5d3fac14
  24. Nov 08, 2023
  25. Nov 07, 2023
  26. Nov 06, 2023
  27. Nov 01, 2023
  28. Oct 28, 2023
  29. Oct 27, 2023
  30. Oct 25, 2023
    • Seigo Nonaka's avatar
      Change default value of setElegantTextFlag · de05ca71
      Seigo Nonaka authored
      As a first step of deprecating UI fonts, make setElegantTextFlag as true
      by default if the target SDK is set to Android 15 or later..
      
      Bug: 279646685
      Test: atest PaintDefaultsTest
      Change-Id: If8e40c075122cafd2f89ae703bf6a5f07ebc7bd0
      de05ca71
Loading