Commits · d2a1d5aa5f2e6efc1e24d46281ae345262cb31e4 · Farzin Kazemzadeh / platform_frameworks_base-old

Jun 03, 2024

Update boot image and system server profiles [M82C37P58S0PP] · 3a157131

art-benchmark-service authored 9 months ago

Bug: 254051423

Test: go/art-benchmark?p=BootImageProfileId:39982&f=CandidateName:in:39985

= Perf stats =
(lower is better)

Regular update to the boot image profiles. Benchmark shows a code size reduction of 0.5MB and improvements in App-memory and system-memory with a tiny improvement in boot Time.

             Avg % [Confidence interval min-max %]
App Startup:            0.42 [-1.59, 2.42]
App RSS:               -0.49 [-1.15, 0.16]
App Anon RSS + Swap:   -0.75 [-2.04, 0.53]
Memory(PSS):           -0.25 [-1.1, 0.61]
Memory(RSS):           -0.49 [-1.09, 0.12]
Memory(Private-dirty): -2.6 [-4.54, -0.66]
Boot time:             -0.57 [-1.44, 0.3]
Code size:             -0.50MB (-0.607%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.82
image_class_threshold: 0.37
preloaded_classes_threshold: 0.58
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.026428571
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.058571428
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.026428571
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.058571428
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.026428571
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.058571428
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.026428571
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.058571428
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.026428571
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.058571428
}

=Profile stats=

Data info:
- total aggregations: 1873
- number of (device types, builds): 245

File boot-image-profile.txt
  - hot methods: 610 added, 615 removed
  - methods: 610 added, 615 removed
  - classes: 17 added, 15 removed
  - totals now: 32511 hot methods, 32511 methods, 17851 classes
  - totals before: 32516 hot methods, 32516 methods, 17849 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 575, 574, 8, 10, 20958, 10421
    com.android, 17, 23, 6, 4, 2320, 3538
    java, 9, 9, 2, 1, 7241, 2131
    android.view, 160, 164, 1, 0, 3394, 1148
    android.hardware, 3, 1, 0, 0, 471, 873
    android.animation, 46, 46, 0, 0, 413, 89
    android.app, 35, 35, 0, 2, 2923, 1183
    android.content, 74, 71, 0, 0, 1908, 635
    android.graphics, 76, 76, 3, 0, 1974, 374
    android.icu, 19, 19, 0, 0, 2043, 1497
    android.media, 0, 0, 2, 0, 792, 637
    android.net, 7, 7, 0, 0, 252, 222
    android.widget, 77, 77, 0, 0, 1403, 445

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 33 added, 24 removed
  - totals now: 0 hot methods, 0 methods, 17762 classes
  - totals before: 0 hot methods, 0 methods, 17753 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 21, 14, 0, 10372
    com.android, 0, 0, 6, 5, 0, 3515
    java, 0, 0, 5, 5, 0, 2118
    android.view, 0, 0, 2, 3, 0, 1142
    android.hardware, 0, 0, 2, 0, 0, 873
    android.app, 0, 0, 1, 2, 0, 1180
    android.content, 0, 0, 0, 1, 0, 632
    android.graphics, 0, 0, 0, 3, 0, 368
    android.icu, 0, 0, 11, 0, 0, 1497
    android.media, 0, 0, 2, 0, 0, 628

File boot-image-profile.txt
  - hot methods: 601 added, 606 removed
  - methods: 601 added, 606 removed
  - classes: 14 added, 14 removed
  - totals now: 22381 hot methods, 22381 methods, 14605 classes
  - totals before: 22386 hot methods, 22386 methods, 14605 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 575, 574, 8, 10, 20894, 10390
    com.android, 17, 23, 5, 4, 1390, 3125
    android.view, 160, 164, 1, 0, 3394, 1148
    android.hardware, 3, 1, 0, 0, 471, 873
    android.animation, 46, 46, 0, 0, 413, 89
    android.app, 35, 35, 0, 2, 2923, 1183
    android.content, 74, 71, 0, 0, 1908, 635
    android.graphics, 76, 76, 3, 0, 1974, 374
    android.icu, 19, 19, 0, 0, 2043, 1497
    android.media, 0, 0, 2, 0, 792, 637
    android.net, 7, 7, 0, 0, 252, 222
    android.widget, 77, 77, 0, 0, 1403, 445

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 26 added, 19 removed
  - totals now: 0 hot methods, 0 methods, 14530 classes
  - totals before: 0 hot methods, 0 methods, 14523 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 21, 14, 0, 10341
    com.android, 0, 0, 4, 5, 0, 3102
    android.view, 0, 0, 2, 3, 0, 1142
    android.hardware, 0, 0, 2, 0, 0, 873
    android.app, 0, 0, 1, 2, 0, 1180
    android.content, 0, 0, 0, 1, 0, 632
    android.graphics, 0, 0, 0, 3, 0, 368
    android.icu, 0, 0, 11, 0, 0, 1497
    android.media, 0, 0, 2, 0, 0, 628

File art-profile
  - hot methods: 1774 added, 2504 removed
  - methods: 1774 added, 2504 removed
  - classes: 7 added, 3 removed
  - totals now: 3950 hot methods, 3950 methods, 82 classes
  - totals before: 4680 hot methods, 4680 methods, 78 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 3, 4, 1, 1, 21, 1
    com.android, 1771, 2500, 6, 2, 3929, 81
    android.hardware, 3, 4, 0, 1, 18, 0

InternalReferenceRawProfileId: 39982
InternalReferenceCandidateProfileId: 39985

Test: build & benchmark

Change-Id: I984aa7fffa8d68fc315124699e64de1a8cba2993

3a157131

May 22, 2024

Update boot image and system server profiles [M84C39P60S0PP] · 64daec64

art-benchmark-service authored 10 months ago

Bug: 254051423

Test: go/art-benchmark?p=BootImageProfileId:39887&f=CandidateName:in:39896

= Perf stats =
(lower is better)

Regular update to the boot image profiles. Benchmark shows a great code size reduction of 3.3MB and improvement in App-memory and system-memory with almost no impact on startup time and boot Time.

             Avg % [Confidence interval min-max %]
App Startup:            0.31 [-2.42, 3.04]
App RSS:               -0.62 [-1.48, 0.25]
App Anon RSS + Swap:   -1.86 [-3.46, -0.27]
Memory(PSS):           -1.74 [-3.78, 0.29]
Memory(RSS):           -0.06 [-0.72, 0.6]
Memory(Private-dirty): -3.52 [-5.99, -1.05]
Boot time:              0.35 [-0.8, 1.5]
Code size:             -3.36 MB (-3.93%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.84
image_class_threshold: 0.39
preloaded_classes_threshold: 0.6
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.027857142
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.06
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.027857142
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.06
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.027857142
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.06
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.027857142
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.06
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.027857142
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.06
}

=Profile stats=

Data info:
- total aggregations: 1790
- number of (device types, builds): 234

File boot-image-profile.txt
  - hot methods: 1031 added, 1140 removed
  - methods: 1031 added, 1140 removed
  - classes: 153 added, 57 removed
  - totals now: 32516 hot methods, 32516 methods, 17849 classes
  - totals before: 32625 hot methods, 32625 methods, 17753 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 943, 1038, 79, 47, 20957, 10423
    com.android, 52, 68, 40, 8, 2326, 3536
    java, 31, 29, 19, 1, 7241, 2130
    android.view, 199, 216, 9, 2, 3398, 1147
    android.hardware, 1, 16, 4, 9, 469, 873
    android.animation, 63, 63, 0, 0, 413, 89
    android.app, 56, 69, 15, 8, 2923, 1185
    android.content, 71, 82, 2, 8, 1905, 635
    android.graphics, 88, 89, 0, 0, 1974, 371
    android.icu, 86, 91, 19, 7, 2043, 1497
    android.media, 12, 12, 4, 2, 792, 635
    android.net, 22, 22, 0, 0, 252, 222
    android.widget, 62, 63, 2, 0, 1403, 445

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 168 added, 70 removed
  - totals now: 0 hot methods, 0 methods, 17753 classes
  - totals before: 0 hot methods, 0 methods, 17655 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 80, 54, 0, 10365
    com.android, 0, 0, 49, 15, 0, 3514
    java, 0, 0, 20, 0, 0, 2118
    android.view, 0, 0, 16, 3, 0, 1143
    android.hardware, 0, 0, 4, 10, 0, 871
    android.app, 0, 0, 14, 6, 0, 1181
    android.content, 0, 0, 3, 7, 0, 633
    android.icu, 0, 0, 8, 7, 0, 1486
    android.media, 0, 0, 2, 3, 0, 626
    android.net, 0, 0, 0, 1, 0, 221
    android.widget, 0, 0, 3, 1, 0, 443

File boot-image-profile.txt
  - hot methods: 995 added, 1106 removed
  - methods: 995 added, 1106 removed
  - classes: 119 added, 56 removed
  - totals now: 22386 hot methods, 22386 methods, 14605 classes
  - totals before: 22497 hot methods, 22497 methods, 14542 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 943, 1038, 79, 47, 20893, 10392
    com.android, 52, 68, 37, 8, 1396, 3124
    java, 0, 0, 0, 1, 2, 114
    android.view, 199, 216, 9, 2, 3398, 1147
    android.hardware, 1, 16, 4, 9, 469, 873
    android.animation, 63, 63, 0, 0, 413, 89
    android.app, 56, 69, 15, 8, 2923, 1185
    android.content, 71, 82, 2, 8, 1905, 635
    android.graphics, 88, 89, 0, 0, 1974, 371
    android.icu, 86, 91, 19, 7, 2043, 1497
    android.media, 12, 12, 4, 2, 792, 635
    android.net, 22, 22, 0, 0, 252, 222
    android.widget, 62, 63, 2, 0, 1403, 445

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 128 added, 70 removed
  - totals now: 0 hot methods, 0 methods, 14523 classes
  - totals before: 0 hot methods, 0 methods, 14465 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 80, 54, 0, 10334
    com.android, 0, 0, 46, 15, 0, 3103
    java, 0, 0, 0, 1, 0, 114
    android.view, 0, 0, 16, 3, 0, 1143
    android.hardware, 0, 0, 4, 10, 0, 871
    android.app, 0, 0, 14, 6, 0, 1181
    android.content, 0, 0, 3, 7, 0, 633
    android.icu, 0, 0, 8, 7, 0, 1486
    android.media, 0, 0, 2, 3, 0, 626
    android.net, 0, 0, 0, 1, 0, 221
    android.widget, 0, 0, 3, 1, 0, 443

File art-profile
  - hot methods: 1362 added, 5742 removed
  - methods: 1362 added, 5742 removed
  - classes: 26 added, 5 removed
  - totals now: 4680 hot methods, 4680 methods, 78 classes
  - totals before: 9060 hot methods, 9060 methods, 57 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 4, 29, 1, 0, 22, 1
    com.android, 1358, 5713, 25, 4, 4658, 77
    java, 0, 0, 0, 1, 0, 0
    android.hardware, 3, 26, 1, 0, 19, 1
    android.net, 1, 3, 0, 0, 2, 0

InternalReferenceRawProfileId: 39887
InternalReferenceCandidateProfileId: 39896

Test: build & benchmark

Change-Id: If7d2699a79a04490dc1b82537456da5022edea2e

64daec64

Apr 25, 2024

Update boot image and system server profiles [M46C41P62S0PP] · 5cbc582b

art-benchmark-service authored 10 months ago

Bug: 254051423
Bug: 324079793

Test: go/art-benchmark?p=BootImageProfileId:38926&f=CandidateName:in:38933

= Perf stats =
(lower is better)

Regular update to the boot image profiles which considers the latest changes in the ART module code instead of depending on the released mainline trains only. Benchmark shows a tiny improvement in App's startup time and Anon RSS+Swap and good improvement in system memory PSS and Private-dirty and almost no impact on boot Time, with a good reduction in code size.

             Avg % [Confidence interval min-max %]
App Startup:           -0.44 [-2.79, 1.9]
App Anon RSS + Swap:   -0.83 [-1.92, 0.25]
Memory(PSS):           -1.4 [-4.28, 1.48]
Memory(Private-dirty): -4.48 [-13.31, 4.34]
Boot time:              0.47 [-0.68, 1.62]
Code size:             -0.79MB (-0.92%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.46
image_class_threshold: 0.41
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.032857142
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.032857142
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.032857142
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.032857142
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.032857142
}

=Profile stats=

Data info:
- total aggregations: 2263
- number of (device types, builds): 169

File boot-image-profile.txt
  - hot methods: 1427 added, 1398 removed
  - methods: 1427 added, 1398 removed
  - classes: 113 added, 215 removed
  - totals now: 32625 hot methods, 32625 methods, 17753 classes
  - totals before: 32596 hot methods, 32596 methods, 17855 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 684, 825, 2, 64, 21052, 10391
    com.android, 65, 89, 14, 21, 2342, 3504
    java, 590, 420, 86, 115, 7239, 2112
    android.view, 171, 223, 2, 8, 3415, 1140
    android.hardware, 2, 12, 0, 5, 484, 878
    android.animation, 59, 59, 0, 0, 413, 89
    android.app, 44, 85, 0, 15, 2936, 1178
    android.content, 56, 57, 0, 3, 1916, 641
    android.graphics, 65, 69, 0, 0, 1975, 371
    android.icu, 43, 43, 0, 0, 2048, 1485
    android.media, 3, 3, 0, 0, 792, 633
    android.net, 8, 8, 0, 6, 252, 222
    android.widget, 53, 53, 0, 0, 1404, 443

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 120 added, 214 removed
  - totals now: 0 hot methods, 0 methods, 17655 classes
  - totals before: 0 hot methods, 0 methods, 17749 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 14, 59, 0, 10339
    com.android, 0, 0, 15, 19, 0, 3480
    java, 0, 0, 80, 117, 0, 2098
    android.view, 0, 0, 1, 4, 0, 1130
    android.hardware, 0, 0, 3, 4, 0, 877
    android.app, 0, 0, 1, 17, 0, 1173
    android.content, 0, 0, 1, 3, 0, 637
    android.media, 0, 0, 0, 2, 0, 627
    android.net, 0, 0, 0, 6, 0, 222

File boot-image-profile.txt
  - hot methods: 723 added, 890 removed
  - methods: 723 added, 890 removed
  - classes: 2 added, 80 removed
  - totals now: 22497 hot methods, 22497 methods, 14542 classes
  - totals before: 22664 hot methods, 22664 methods, 14620 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 683, 824, 2, 64, 20988, 10360
    com.android, 40, 66, 0, 14, 1412, 3095
    java, 0, 0, 0, 1, 2, 115
    android.view, 171, 223, 2, 8, 3415, 1140
    android.hardware, 2, 12, 0, 5, 484, 878
    android.animation, 59, 59, 0, 0, 413, 89
    android.app, 44, 85, 0, 15, 2936, 1178
    android.content, 56, 57, 0, 3, 1916, 641
    android.graphics, 65, 69, 0, 0, 1975, 371
    android.icu, 43, 43, 0, 0, 2048, 1485
    android.media, 3, 3, 0, 0, 792, 633
    android.net, 8, 8, 0, 6, 252, 222
    android.widget, 53, 53, 0, 0, 1404, 443

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 15 added, 72 removed
  - totals now: 0 hot methods, 0 methods, 14465 classes
  - totals before: 0 hot methods, 0 methods, 14522 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 14, 59, 0, 10308
    com.android, 0, 0, 1, 11, 0, 3072
    java, 0, 0, 0, 1, 0, 115
    android.view, 0, 0, 1, 4, 0, 1130
    android.hardware, 0, 0, 3, 4, 0, 877
    android.app, 0, 0, 1, 17, 0, 1173
    android.content, 0, 0, 1, 3, 0, 637
    android.media, 0, 0, 0, 2, 0, 627
    android.net, 0, 0, 0, 6, 0, 222

File art-profile
  - hot methods: 2157 added, 4848 removed
  - methods: 2157 added, 4848 removed
  - classes: 0 added, 1547 removed
  - totals now: 9060 hot methods, 9060 methods, 57 classes
  - totals before: 11751 hot methods, 11751 methods, 1604 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 5, 24, 0, 22, 47, 0
    com.android, 2152, 4824, 0, 1492, 9013, 56
    android.hardware, 4, 12, 0, 8, 42, 0
    android.app, 0, 0, 0, 2, 0, 0
    android.content, 0, 1, 0, 4, 1, 0
    android.net, 1, 7, 0, 3, 4, 0

InternalReferenceRawProfileId: 38926
InternalReferenceCandidateProfileId: 38933

Test: build & benchmark
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b6a26a57e65e2f869c35a54fa3b91e083199dc8)
Merged-In: Icb1d1464ad947837eeb679258af67bc4f0e9ba98
Change-Id: Icb1d1464ad947837eeb679258af67bc4f0e9ba98

NOTE FOR REVIEWERS - errors occurred while applying the patch.
PLEASE REVIEW CAREFULLY.
Errors:
Error applying patch in boot/boot-image-profile.txt, hunk HunkHeader[124,19->124,19]: Hunk cannot be applied
Error applying patch in boot/preloaded-classes, hunk HunkHeader[211,7->212,6]: Hunk cannot be applied
Error applying patch in config/boot-image-profile.txt, hunk HunkHeader[124,19->124,19]: Hunk cannot be applied
Error applying patch in config/preloaded-classes, hunk HunkHeader[211,7->212,6]: Hunk cannot be applied
Error applying patch in services/art-profile, hunk HunkHeader[13,7->13,6]: Hunk cannot be applied

Original patch:
 From 4b6a26a5 Mon Sep 17 00:00:00 2001
From: art-benchmark-service <art-benchmark-service@google.com>
Date: Fri, 22 Mar 2024 09:25:24 -0700
Subject: [PATCH] Update boot image and system server profiles [M46C41P62S0PP]

Bug: 254051423
Bug: 324079793

Test: go/art-benchmark?p=BootImageProfileId:38926&f=CandidateName:in:38933

= Perf stats =
(lower is better)

Regular update to the boot image profiles which considers the latest changes in the ART module code instead of depending on the released mainline trains only. Benchmark shows a tiny improvement in App's startup time and Anon RSS+Swap and good improvement in system memory PSS and Private-dirty and almost no impact on boot Time, with a good reduction in code size.

             Avg % [Confidence interval min-max %]
App Startup:           -0.44 [-2.79, 1.9]
App Anon RSS + Swap:   -0.83 [-1.92, 0.25]
Memory(PSS):           -1.4 [-4.28, 1.48]
Memory(Private-dirty): -4.48 [-13.31, 4.34]
Boot time:              0.47 [-0.68, 1.62]
C
[[[Original patch trimmed due to size. Decoded string size: 6329. Decoded string SHA1: 1745d06a463192644cf1206f5ecdb8152786d3ff.]]]

Change-Id: I4c2c63c3361c206b3160901fa2fff3e03dcdde5d

5cbc582b

Mar 25, 2024

Update boot image and system server profiles [M46C41P62S0PP] · 4b6a26a5

art-benchmark-service authored 1 year ago

Bug: 254051423
Bug: 324079793

Test: go/art-benchmark?p=BootImageProfileId:38926&f=CandidateName:in:38933

= Perf stats =
(lower is better)

Regular update to the boot image profiles which considers the latest changes in the ART module code instead of depending on the released mainline trains only. Benchmark shows a tiny improvement in App's startup time and Anon RSS+Swap and good improvement in system memory PSS and Private-dirty and almost no impact on boot Time, with a good reduction in code size.

             Avg % [Confidence interval min-max %]
App Startup:           -0.44 [-2.79, 1.9]
App Anon RSS + Swap:   -0.83 [-1.92, 0.25]
Memory(PSS):           -1.4 [-4.28, 1.48]
Memory(Private-dirty): -4.48 [-13.31, 4.34]
Boot time:              0.47 [-0.68, 1.62]
Code size:             -0.79MB (-0.92%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.46
image_class_threshold: 0.41
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.032857142
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.032857142
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.032857142
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.032857142
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.029285714
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.032857142
}

=Profile stats=

Data info:
- total aggregations: 2263
- number of (device types, builds): 169

File boot-image-profile.txt
  - hot methods: 1427 added, 1398 removed
  - methods: 1427 added, 1398 removed
  - classes: 113 added, 215 removed
  - totals now: 32625 hot methods, 32625 methods, 17753 classes
  - totals before: 32596 hot methods, 32596 methods, 17855 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 684, 825, 2, 64, 21052, 10391
    com.android, 65, 89, 14, 21, 2342, 3504
    java, 590, 420, 86, 115, 7239, 2112
    android.view, 171, 223, 2, 8, 3415, 1140
    android.hardware, 2, 12, 0, 5, 484, 878
    android.animation, 59, 59, 0, 0, 413, 89
    android.app, 44, 85, 0, 15, 2936, 1178
    android.content, 56, 57, 0, 3, 1916, 641
    android.graphics, 65, 69, 0, 0, 1975, 371
    android.icu, 43, 43, 0, 0, 2048, 1485
    android.media, 3, 3, 0, 0, 792, 633
    android.net, 8, 8, 0, 6, 252, 222
    android.widget, 53, 53, 0, 0, 1404, 443

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 120 added, 214 removed
  - totals now: 0 hot methods, 0 methods, 17655 classes
  - totals before: 0 hot methods, 0 methods, 17749 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 14, 59, 0, 10339
    com.android, 0, 0, 15, 19, 0, 3480
    java, 0, 0, 80, 117, 0, 2098
    android.view, 0, 0, 1, 4, 0, 1130
    android.hardware, 0, 0, 3, 4, 0, 877
    android.app, 0, 0, 1, 17, 0, 1173
    android.content, 0, 0, 1, 3, 0, 637
    android.media, 0, 0, 0, 2, 0, 627
    android.net, 0, 0, 0, 6, 0, 222

File boot-image-profile.txt
  - hot methods: 723 added, 890 removed
  - methods: 723 added, 890 removed
  - classes: 2 added, 80 removed
  - totals now: 22497 hot methods, 22497 methods, 14542 classes
  - totals before: 22664 hot methods, 22664 methods, 14620 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 683, 824, 2, 64, 20988, 10360
    com.android, 40, 66, 0, 14, 1412, 3095
    java, 0, 0, 0, 1, 2, 115
    android.view, 171, 223, 2, 8, 3415, 1140
    android.hardware, 2, 12, 0, 5, 484, 878
    android.animation, 59, 59, 0, 0, 413, 89
    android.app, 44, 85, 0, 15, 2936, 1178
    android.content, 56, 57, 0, 3, 1916, 641
    android.graphics, 65, 69, 0, 0, 1975, 371
    android.icu, 43, 43, 0, 0, 2048, 1485
    android.media, 3, 3, 0, 0, 792, 633
    android.net, 8, 8, 0, 6, 252, 222
    android.widget, 53, 53, 0, 0, 1404, 443

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 15 added, 72 removed
  - totals now: 0 hot methods, 0 methods, 14465 classes
  - totals before: 0 hot methods, 0 methods, 14522 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 14, 59, 0, 10308
    com.android, 0, 0, 1, 11, 0, 3072
    java, 0, 0, 0, 1, 0, 115
    android.view, 0, 0, 1, 4, 0, 1130
    android.hardware, 0, 0, 3, 4, 0, 877
    android.app, 0, 0, 1, 17, 0, 1173
    android.content, 0, 0, 1, 3, 0, 637
    android.media, 0, 0, 0, 2, 0, 627
    android.net, 0, 0, 0, 6, 0, 222

File art-profile
  - hot methods: 2157 added, 4848 removed
  - methods: 2157 added, 4848 removed
  - classes: 0 added, 1547 removed
  - totals now: 9060 hot methods, 9060 methods, 57 classes
  - totals before: 11751 hot methods, 11751 methods, 1604 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 5, 24, 0, 22, 47, 0
    com.android, 2152, 4824, 0, 1492, 9013, 56
    android.hardware, 4, 12, 0, 8, 42, 0
    android.app, 0, 0, 0, 2, 0, 0
    android.content, 0, 1, 0, 4, 1, 0
    android.net, 1, 7, 0, 3, 4, 0

InternalReferenceRawProfileId: 38926
InternalReferenceCandidateProfileId: 38933

Test: build & benchmark

Change-Id: Icb1d1464ad947837eeb679258af67bc4f0e9ba98

4b6a26a5

Mar 15, 2024

Update boot image and system server profiles [M33C28P64S0PP] · add95626

art-benchmark-service authored 1 year ago

Bug: 254051423

Test: go/art-benchmark?p=BootImageProfileId:38696&f=CandidateName:in:38704
Test: ATP test https://android-build.corp.google.com/abtd/run/L45000030002490953

= Perf stats =
(lower is better)

Regular update to the boot image profiles, Benchmark shows almost no impact on system memory and boot Time, but shows an improvement for apps cold startup time, apps rss memory and a good reduction for code size.

             Avg % [Confidence interval min-max %]
App Startup: -1.64 [-3.76, 0.48]
App RSS:     -1.49 [-2.32, -0.65]
Memory(PSS):  0.89 [-0.79, 2.57]
Boot time:    0.55 [-0.64, 1.75]
Code size:   -0.6MB (-0.66%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.33
image_class_threshold: 0.28
preloaded_classes_threshold: 0.64
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.02
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.02357143
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.02
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.02357143
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.02
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.02357143
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.02
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.02357143
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.02
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.02357143
}

=Profile stats=

Data info:
- total aggregations: 377
- number of (device types, builds): 105

File boot-image-profile.txt
  - hot methods: 1152 added, 879 removed
  - methods: 1152 added, 879 removed
  - classes: 298 added, 64 removed
  - totals now: 32596 hot methods, 32596 methods, 17855 classes
  - totals before: 32323 hot methods, 32323 methods, 17621 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 628, 400, 232, 41, 21193, 10453
    com.android, 76, 44, 56, 12, 2366, 3511
    java, 383, 371, 4, 6, 7069, 2141
    android.view, 102, 49, 42, 0, 3467, 1146
    android.hardware, 14, 10, 17, 3, 494, 883
    android.animation, 14, 14, 1, 0, 413, 89
    android.app, 70, 20, 29, 0, 2977, 1193
    android.content, 61, 34, 19, 0, 1917, 644
    android.graphics, 17, 11, 4, 4, 1979, 371
    android.icu, 45, 45, 1, 15, 2048, 1485
    android.media, 9, 9, 7, 0, 792, 633
    android.net, 16, 15, 0, 0, 252, 228
    android.widget, 12, 12, 11, 0, 1404, 443

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 654 added, 63 removed
  - totals now: 0 hot methods, 0 methods, 17750 classes
  - totals before: 0 hot methods, 0 methods, 17159 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 537, 41, 0, 10385
    com.android, 0, 0, 56, 12, 0, 3484
    java, 0, 0, 44, 6, 0, 2135
    android.view, 0, 0, 88, 0, 0, 1134
    android.hardware, 0, 0, 24, 3, 0, 878
    android.animation, 0, 0, 14, 0, 0, 89
    android.app, 0, 0, 81, 0, 0, 1189
    android.content, 0, 0, 47, 0, 0, 639
    android.graphics, 0, 0, 30, 4, 0, 371
    android.icu, 0, 0, 24, 15, 0, 1485
    android.media, 0, 0, 26, 0, 0, 629
    android.net, 0, 0, 4, 0, 0, 228
    android.widget, 0, 0, 45, 0, 0, 441

File boot-image-profile.txt
  - hot methods: 683 added, 427 removed
  - methods: 683 added, 427 removed
  - classes: 294 added, 55 removed
  - totals now: 22664 hot methods, 22664 methods, 14620 classes
  - totals before: 22408 hot methods, 22408 methods, 14381 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 627, 399, 232, 41, 21129, 10422
    com.android, 56, 28, 56, 12, 1438, 3109
    java, 0, 0, 1, 0, 2, 116
    android.view, 102, 49, 42, 0, 3467, 1146
    android.hardware, 14, 10, 17, 3, 494, 883
    android.animation, 14, 14, 1, 0, 413, 89
    android.app, 70, 20, 29, 0, 2977, 1193
    android.content, 61, 34, 19, 0, 1917, 644
    android.graphics, 17, 11, 4, 4, 1979, 371
    android.icu, 45, 45, 1, 15, 2048, 1485
    android.media, 9, 9, 7, 0, 792, 633
    android.net, 16, 15, 0, 0, 252, 228
    android.widget, 12, 12, 11, 0, 1404, 443

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 591 added, 54 removed
  - totals now: 0 hot methods, 0 methods, 14523 classes
  - totals before: 0 hot methods, 0 methods, 13986 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 537, 41, 0, 10354
    com.android, 0, 0, 48, 12, 0, 3082
    java, 0, 0, 1, 0, 0, 116
    android.view, 0, 0, 88, 0, 0, 1134
    android.hardware, 0, 0, 24, 3, 0, 878
    android.animation, 0, 0, 14, 0, 0, 89
    android.app, 0, 0, 81, 0, 0, 1189
    android.content, 0, 0, 47, 0, 0, 639
    android.graphics, 0, 0, 30, 4, 0, 371
    android.icu, 0, 0, 24, 15, 0, 1485
    android.media, 0, 0, 26, 0, 0, 629
    android.net, 0, 0, 4, 0, 0, 228
    android.widget, 0, 0, 45, 0, 0, 441

File art-profile
  - hot methods: 3026 added, 5535 removed
  - methods: 3026 added, 5535 removed
  - classes: 276 added, 100 removed
  - totals now: 11751 hot methods, 11751 methods, 1604 classes
  - totals before: 14260 hot methods, 14260 methods, 1428 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 17, 30, 1, 4, 66, 22
    com.android, 3009, 5499, 268, 94, 11685, 1548
    java, 0, 0, 1, 0, 0, 1
    android.hardware, 16, 29, 0, 4, 50, 8
    android.content, 0, 0, 1, 0, 2, 4
    android.net, 1, 1, 0, 0, 10, 3

InternalReferenceRawProfileId: 38696
InternalReferenceCandidateProfileId: 38704

Test: build & benchmark

Change-Id: I4053e27e32e350030cdffb47fbeb04f43e94ef8e

add95626

Feb 27, 2024

Use Profiling flag at build time · 32c46ea2

Carmen Jackson authored 1 year ago

This change uses the flag to toggle the Profiling module in the platform
bootclasspath.

Bug: 293957254
Bug: 325523640
Test: Built locally on trunk_food (where flag is disabled) and
trunk_staging (where flag is enabled.)

Change-Id: Id386b2d57e78362e12bd6e4cb1f0bdb2dabe3ce6

32c46ea2

Feb 14, 2024

Refactor Geocoder Provider System APIs · 8e54d085

Soonil Nagarkar authored 1 year ago

1) Deprecate old GeocoderProvider API which is not part of any published
   API surface.
2) Create new GeocoderProviderBase API which lives in normal SystemApi
   surface.
3) Cleanup various callback APIs and geocoding POJOs used internally.

Bug: 279319276
Bug: 229872126
Test: CTS
Change-Id: I1da453ba5f9fd98b08ecdbbbacf640497ed6cd42

8e54d085

Feb 07, 2024

Update boot image and system server profiles [M31C26P62S0PP] · d567c8b0

art-benchmark-service authored 1 year ago

Bug: 254051423

Test: go/art-benchmark?p=BootImageProfileId:37886&f=CandidateName:in:37892
Test: ATP test https://android-build.googleplex.com/builds/abtd/run/L00700030001838546

= Perf stats =
(lower is better)

Regular update to the boot image profiles, Benchmark shows almost no impact on app cold startup time, boot-time and memory besides some code size reduction.

         Avg % [Confidence interval min-max %]
Startup: -0.66 [-2.97, 1.64]
Memory(PSS): 0.65 [-1.65, 2.97]
Boot time: 0.14 [-1.27, 1.55]
Code size (.oat + .art + .odex): -0.19MB (-0.22%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.31
image_class_threshold: 0.26
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.022142857
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.022142857
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.022142857
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.022142857
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.022142857
}

=Profile stats=

Data info:
- total aggregations: 21
- number of (device types, builds): 8

File boot-image-profile.txt
  - hot methods: 3096 added, 3337 removed
  - methods: 3096 added, 3337 removed
  - classes: 445 added, 92 removed
  - totals now: 32323 hot methods, 32323 methods, 17621 classes
  - totals before: 32564 hot methods, 32564 methods, 17268 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1827, 1941, 366, 54, 20965, 10262
    com.android, 137, 229, 23, 37, 2334, 3467
    java, 889, 923, 43, 1, 7057, 2143
    android.view, 352, 389, 56, 10, 3414, 1104
    android.hardware, 20, 26, 11, 1, 490, 869
    android.animation, 21, 19, 6, 0, 413, 88
    android.app, 119, 146, 56, 0, 2927, 1164
    android.content, 193, 196, 40, 0, 1890, 625
    android.graphics, 160, 161, 26, 0, 1973, 371
    android.icu, 233, 233, 25, 0, 2048, 1499
    android.media, 19, 19, 22, 0, 792, 626
    android.net, 40, 41, 8, 0, 251, 228
    android.widget, 149, 148, 35, 0, 1404, 432

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 25 added, 92 removed
  - totals now: 0 hot methods, 0 methods, 17159 classes
  - totals before: 0 hot methods, 0 methods, 17226 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 23, 54, 0, 9889
    com.android, 0, 0, 2, 37, 0, 3440
    java, 0, 0, 0, 1, 0, 2097
    android.view, 0, 0, 0, 10, 0, 1046
    android.hardware, 0, 0, 0, 1, 0, 857
    android.app, 0, 0, 1, 0, 0, 1108
    android.content, 0, 0, 9, 0, 0, 592
    android.icu, 0, 0, 2, 0, 0, 1476
    android.media, 0, 0, 2, 0, 0, 603
    android.net, 0, 0, 4, 0, 0, 224

File boot-image-profile.txt
  - hot methods: 1925 added, 2028 removed
  - methods: 1925 added, 2028 removed
  - classes: 382 added, 56 removed
  - totals now: 22408 hot methods, 22408 methods, 14381 classes
  - totals before: 22511 hot methods, 22511 methods, 14055 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1828, 1925, 366, 54, 20901, 10231
    com.android, 97, 103, 15, 2, 1410, 3065
    android.view, 357, 392, 56, 10, 3414, 1104
    android.hardware, 20, 26, 11, 1, 490, 869
    android.animation, 19, 17, 6, 0, 413, 88
    android.app, 118, 143, 56, 0, 2927, 1164
    android.content, 194, 196, 40, 0, 1890, 625
    android.graphics, 160, 161, 26, 0, 1973, 371
    android.icu, 233, 234, 25, 0, 2048, 1499
    android.media, 18, 18, 22, 0, 792, 626
    android.net, 41, 42, 8, 0, 251, 228
    android.widget, 149, 149, 35, 0, 1404, 432

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 23 added, 56 removed
  - totals now: 0 hot methods, 0 methods, 13986 classes
  - totals before: 0 hot methods, 0 methods, 14019 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 21, 54, 0, 9858
    com.android, 0, 0, 2, 2, 0, 3046
    android.view, 0, 0, 0, 10, 0, 1046
    android.hardware, 0, 0, 0, 1, 0, 857
    android.app, 0, 0, 1, 0, 0, 1108
    android.content, 0, 0, 9, 0, 0, 592
    android.icu, 0, 0, 2, 0, 0, 1476
    android.media, 0, 0, 2, 0, 0, 603
    android.net, 0, 0, 4, 0, 0, 224

File art-profile
  - hot methods: 2917 added, 2661 removed
  - methods: 2917 added, 2661 removed
  - classes: 15 added, 81 removed
  - totals now: 14260 hot methods, 14260 methods, 1428 classes
  - totals before: 14004 hot methods, 14004 methods, 1494 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 10, 17, 0, 0, 79, 25
    com.android, 2901, 2644, 14, 79, 14175, 1374
    android.hardware, 10, 17, 0, 0, 63, 12

InternalReferenceRawProfileId: 37886
InternalReferenceCandidateProfileId: 37892

Test: build & benchmark

Change-Id: I4fffd2b2601f09a3b0acfdcdaebb0e2d6768fe64

d567c8b0

Feb 01, 2024
- Add profiling module to bootclasspath · b0540e87
  Yisroel Forta authored 1 year ago
  
  Test: m, presubmit Bug: 293957254 Change-Id: I50d024c167094dc559070f529a91af6e9cb49872
  b0540e87
Jan 18, 2024

Revert^2 "[CrashRecovery] Add module lib to Android SDK" · 1f4501f6

Harshit Mahajan authored 1 year ago

ed0743da

Bug:b/289203818
Test: m nothing

Change-Id: Id156c0fd4b7b783c5b9f1488914f5650e30ffed5
Merged-In: If6789fee9a908231babd7624280b40515d377dfe

1f4501f6

Jan 17, 2024

[CrashRecovery] Add module lib to Android SDK · 919593c8

Harshit Mahajan authored 1 year ago

Adding the module libraries to combined_apis for them to be added to
Android SDK.
Also adding bootclasspath-fragment to platform-bootclasspath.

Bug: b/289203818
Change-Id: If6789fee9a908231babd7624280b40515d377dfe
Test: m

919593c8

Jan 13, 2024

hiddenapi: Enable nfc to perform its own hidden API processing · bfb2e310

Roshan Pius authored 1 year ago

Used https://googleplex-android-review.git.corp.google.com/q/topic:%22wifi-hiddenapi%22
as reference.

Bug: 303286040
Test: Compiles
Change-Id: I5226808760a0f80bb541673fead9033c3643e214

bfb2e310

boot(api): Add framework-nfc to NFC apex · 9667b043

Roshan Pius authored 1 year ago

Adding a conditional boot entry for framework-nfc.jar to be delivered
via NFC apex.

Also, rename the existing soong_config namespace for bootclasspath
entries to more generic "bootclasspath" (modified the existing usage to
match).

Bug: 303286040
Test: Compiles (with RELEASE_PACKAGE_NFC_STACK=NfcNci)
Test: Compiles (with RELEASE_PACKAGE_NFC_STACK=com.android.nfcservices)
Test: Device boots up after flashing
Test: atest CtsNfcTestCases
Change-Id: If170240fe60120a61dcceb68f9c581261aeee49f

9667b043

Nov 28, 2023

refactor(magnification): Renaming IWindowMagnificationConnection as IMagnificationConnection · 27ca5590

Candice Lo authored 1 year ago

Considering the connection is handling functions more than window
magnification operations, we would like to rename it as
IMagnificationconnection.

Bug: 310109308
Test: manually. Renaming the class and methods
      atest IMagnificationConnectionTest
      atest android.view.accessibility.AccessibilityManagerTest
      atest MagnificationTest
      atest CommandQueueTest
      atest com.android.server.accessibility.magnification.FullScreenMagnificationControllerTest
      atest MagnificationConnectionWrapperTest
      atest MagnificationControllerTest
      atest MagnificationConnectionManagerTest
      atest WindowMagnificationGestureHandlerTest
Flag: NA
Change-Id: I6a19621dcf83e3c37b99204631e9bc022e894b5a

27ca5590

Nov 15, 2023

Revert "[CrashRecovery] Add module lib to Android SDK" · ed0743da

Harshit Mahajan authored 1 year ago

Revert submission 2789412-cherrypicker-L65800000963076834:N61100001405784943

Reason for revert: Leading to merge conflict
Bug: b/311082270

Reverted changes: /q/submissionid:2789412-cherrypicker-L65800000963076834:N61100001405784943

Change-Id: Ic80afd7a8e09cf2e0cf6e453cbe004db0c9fcbd7
Merged-In: I5c65d85d50b214926f5473908694070b4e896201

ed0743da

Nov 09, 2023

Add back removed inline cache. · 30f0c1c2

islamelbanna authored 1 year ago

This is a partial revert to https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/24913102

Bug: 254051423
Bug: 303339619
Bug: 303378282
Bug: 303394972

Test: ART benchmark go/art-benchmark?p=BootImageProfileId:37045
Test: ATP test https://android-build.corp.google.com/abtd/run/L92000030000204927/

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

Change-Id: Ie3e80163b281c27a381c28b890b6571c8aea9720

30f0c1c2

Nov 06, 2023

Update boot image and system server profiles [M29C24P60S0PP] · 83428e48

art-benchmark-service authored 1 year ago

Bug: 254051423
Bug: 303356546
Bug: 303339619
Bug: 303378282
Bug: 303394972

Test: go/art-benchmark?p=BootImageProfileId:36833&f=CandidateName:in:36861
Test: ATP test https://android-build.googleplex.com/builds/abtd/run/L85800030000096758

= Perf stats =
(lower is better)

Regular update to the boot image profiles, Benchmark shows an no impact on app cold startup time, boot-time and good memory reduction for system-server process besides fixing some regressions from the prev update, but with a small increase in code size which could be an acceptable cost.

         Avg % [Confidence interval min-max %]
Startup: -0.14 [-2.34, 2.06]
Memory(PSS): -0.15 [-1.82, 1.51]
Boot time: 0.19 [-0.68, 1.06]
Code size (.oat + .art + .odex): 0.88MB (1.06%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.29
image_class_threshold: 0.24
preloaded_classes_threshold: 0.6
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.017142856
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.020714285
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.017142856
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.020714285
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.017142856
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.020714285
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.017142856
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.020714285
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.017142856
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.020714285
}

=Profile stats=

Data info:
- total aggregations: 50
- number of (device types, builds): 18

File boot-image-profile.txt
  - hot methods: 201 added, 225 removed
  - methods: 201 added, 225 removed
  - classes: 0 added, 2 removed
  - totals now: 32532 hot methods, 32532 methods, 17268 classes
  - totals before: 32556 hot methods, 32556 methods, 17270 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 137, 154, 0, 2, 21053, 9950
    com.android, 8, 9, 0, 0, 2425, 3481
    java, 40, 47, 0, 0, 7086, 2101
    android.view, 62, 66, 0, 0, 3444, 1058
    android.hardware, 3, 9, 0, 0, 495, 859
    android.app, 6, 8, 0, 0, 2952, 1108
    android.content, 11, 12, 0, 0, 1892, 585
    android.graphics, 8, 8, 0, 0, 1973, 345
    android.icu, 10, 10, 0, 0, 2048, 1474
    android.media, 1, 1, 0, 0, 792, 604
    android.widget, 14, 15, 0, 2, 1403, 397

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 14 added, 2 removed
  - totals now: 0 hot methods, 0 methods, 17228 classes
  - totals before: 0 hot methods, 0 methods, 17216 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 14, 2, 0, 9922
    android.view, 0, 0, 9, 0, 0, 1056
    android.app, 0, 0, 3, 0, 0, 1107
    android.content, 0, 0, 1, 0, 0, 583
    android.widget, 0, 0, 1, 2, 0, 396

File boot-image-profile.txt
  - hot methods: 144 added, 162 removed
  - methods: 144 added, 162 removed
  - classes: 0 added, 2 removed
  - totals now: 22501 hot methods, 22501 methods, 14055 classes
  - totals before: 22519 hot methods, 22519 methods, 14057 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 137, 154, 0, 2, 20989, 9919
    com.android, 7, 8, 0, 0, 1415, 3052
    android.view, 62, 66, 0, 0, 3444, 1058
    android.hardware, 3, 9, 0, 0, 495, 859
    android.app, 6, 8, 0, 0, 2952, 1108
    android.content, 11, 12, 0, 0, 1892, 585
    android.graphics, 8, 8, 0, 0, 1973, 345
    android.icu, 10, 10, 0, 0, 2048, 1474
    android.media, 1, 1, 0, 0, 792, 604
    android.widget, 14, 15, 0, 2, 1403, 397

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 14 added, 2 removed
  - totals now: 0 hot methods, 0 methods, 14019 classes
  - totals before: 0 hot methods, 0 methods, 14007 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 14, 2, 0, 9891
    android.view, 0, 0, 9, 0, 0, 1056
    android.app, 0, 0, 3, 0, 0, 1107
    android.content, 0, 0, 1, 0, 0, 583
    android.widget, 0, 0, 1, 2, 0, 396

File art-profile
  - hot methods: 2073 added, 821 removed
  - methods: 2073 added, 821 removed
  - classes: 10 added, 2 removed
  - totals now: 14004 hot methods, 14004 methods, 1494 classes
  - totals before: 12752 hot methods, 12752 methods, 1486 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 21, 26, 0, 0, 86, 25
    com.android, 2052, 795, 9, 2, 13918, 1439
    android.hardware, 20, 25, 0, 0, 70, 12
    android.net, 1, 1, 0, 0, 10, 3

InternalReferenceRawProfileId: 36833
InternalReferenceCandidateProfileId: 36861

Test: build & benchmark

Change-Id: If26794e3e9e3605a8059e846472c300f289dba0e

83428e48

Oct 30, 2023

Revert "[CrashRecovery] Add module lib to Android SDK" · 3816f262

Harshit Mahajan authored 1 year ago

Revert submission 24444827-crashrecovery

Reason for revert: Since the module is not behind any flags, it is getting included in 24Q1 Beta release.

Reverted changes: /q/submissionid:24444827-crashrecovery
Bug: b/305826937
Change-Id: I5c65d85d50b214926f5473908694070b4e896201

3816f262

Oct 23, 2023

Update boot image and system server profiles [M27C22P58S0PP] · 1cd49df4

art-benchmark-service authored 1 year ago

Bug: 254051423

Test: go/art-benchmark?p=BootImageProfileId:36711&f=CandidateName:in:36720
Test: ATP test https://android-build.googleplex.com/builds/abtd/run/L47100000963607173

= Perf stats =
(lower is better)

Regular update to the boot image profiles, Benchmark shows an improvement in app cold startup time and good code size reduction, besides no noticeable impact on memory and boot time. This change also will resolve some of the regressions from the prev updates.

         Avg % [Confidence interval min-max %]
Startup: -1.37 [-2.51, -0.23]
Memory(PSS): -0.13 [-2.38, 2.13]
Boot time: 0.09 [-0.9, 1.09]
Code size (.oat + .art + .odex): -0.61MB (-0.73%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.27
image_class_threshold: 0.22
preloaded_classes_threshold: 0.58
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.015714286
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.019285714
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.015714286
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.019285714
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.015714286
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.019285714
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.015714286
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.019285714
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.015714286
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.019285714
}

=Profile stats=

Data info:
- total aggregations: 84
- number of (device types, builds): 28

File boot-image-profile.txt
  - hot methods: 157 added, 87 removed
  - methods: 157 added, 87 removed
  - classes: 15 added, 9 removed
  - totals now: 32556 hot methods, 32556 methods, 17270 classes
  - totals before: 32486 hot methods, 32486 methods, 17264 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 120, 48, 15, 8, 21070, 9952
    java, 37, 38, 0, 0, 7093, 2101
    android.view, 41, 10, 7, 1, 3448, 1058
    android.hardware, 8, 4, 0, 0, 501, 859
    android.animation, 14, 0, 7, 0, 411, 82
    android.app, 17, 5, 1, 0, 2954, 1108
    android.content, 16, 11, 0, 0, 1893, 585
    android.graphics, 5, 0, 0, 0, 1973, 345
    android.widget, 2, 0, 0, 0, 1404, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 30 added, 10 removed
  - totals now: 0 hot methods, 0 methods, 17216 classes
  - totals before: 0 hot methods, 0 methods, 17196 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 23, 9, 0, 9910
    com.android, 0, 0, 6, 0, 0, 3475
    java, 0, 0, 1, 0, 0, 2098
    android.view, 0, 0, 6, 0, 0, 1047
    android.hardware, 0, 0, 5, 0, 0, 858
    android.animation, 0, 0, 2, 0, 0, 75
    android.app, 0, 0, 6, 0, 0, 1104
    android.media, 0, 0, 1, 0, 0, 601

File boot-image-profile.txt
  - hot methods: 120 added, 48 removed
  - methods: 120 added, 48 removed
  - classes: 15 added, 10 removed
  - totals now: 22519 hot methods, 22519 methods, 14057 classes
  - totals before: 22447 hot methods, 22447 methods, 14052 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 120, 48, 15, 8, 21006, 9921
    java, 0, 0, 0, 1, 2, 115
    android.view, 41, 10, 7, 1, 3448, 1058
    android.hardware, 8, 4, 0, 0, 501, 859
    android.animation, 14, 0, 7, 0, 411, 82
    android.app, 17, 5, 1, 0, 2954, 1108
    android.content, 16, 11, 0, 0, 1893, 585
    android.graphics, 5, 0, 0, 0, 1973, 345
    android.widget, 2, 0, 0, 0, 1404, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 29 added, 9 removed
  - totals now: 0 hot methods, 0 methods, 14007 classes
  - totals before: 0 hot methods, 0 methods, 13987 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 23, 7, 0, 9879
    com.android, 0, 0, 6, 0, 0, 3046
    java, 0, 0, 0, 1, 0, 115
    android.view, 0, 0, 6, 0, 0, 1047
    android.hardware, 0, 0, 5, 0, 0, 858
    android.animation, 0, 0, 2, 0, 0, 75
    android.app, 0, 0, 6, 0, 0, 1104
    android.media, 0, 0, 1, 0, 0, 601

File art-profile
  - hot methods: 2492 added, 4332 removed
  - methods: 2492 added, 4332 removed
  - classes: 11 added, 1219 removed
  - totals now: 12752 hot methods, 12752 methods, 1486 classes
  - totals before: 14592 hot methods, 14592 methods, 2694 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 30, 30, 1, 21, 91, 25
    com.android, 2462, 4302, 10, 1181, 12661, 1432
    android.hardware, 28, 29, 0, 17, 75, 12
    android.app, 0, 1, 0, 2, 0, 2
    android.content, 0, 0, 0, 1, 2, 3
    android.net, 2, 0, 0, 0, 10, 3

InternalReferenceRawProfileId: 36711
InternalReferenceCandidateProfileId: 36720

Test: build & benchmark

Change-Id: Ibd13bc54c1fd8927030d41f3670021379ebaccc8

1cd49df4

Oct 16, 2023

[CrashRecovery] Add module lib to Android SDK · 9c3742af

Harshit Mahajan authored 1 year ago

Adding the module libraries to combined_apis for them to be added to
Android SDK.
Also adding bootclasspath-fragment to platform-bootclasspath.

Bug: b/289203818
Test: m

Change-Id: Ica9b0bddc2f9cb6621a01dcd3859c39357144b5f

9c3742af

Oct 02, 2023

Update boot image and system server profiles [M25C20P56S0PP] · 03fe31e6

art-benchmark-service authored 1 year ago

Bug: 254051423
Bug: 299558523
Bug: 299514114
Bug: 299595206
Bug: 299572243

Test: go/art-benchmark?p=BootImageProfileId:36420&f=CandidateName:in:36422
Test: ATP test https://android-build.googleplex.com/builds/abtd/run/L12500000963261237

= Perf stats =
(lower is better)

Regular update to the boot image profiles, Benchmark shows an improvement in boot time and great code size reduction, besides no noticeable impact on memory and startup time. This change also will resolve some of the regressions from the prev updates.

         Avg % (Confidence interval min-max %)
Startup: 0.12 (-1.19 -> 1.43)
Memory(PSS): -0.53 (-2.16 -> 1.1)
Boot time: -1.09 (-1.8 -> -0.38)
Code size (.oat + .art + .odex): -0.51MB (-0.62%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.25
image_class_threshold: 0.2
preloaded_classes_threshold: 0.56
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.014285714
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.017857144
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.014285714
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.017857144
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.014285714
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.017857144
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.014285714
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.017857144
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.014285714
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.017857144
}

=Profile stats=

Data info:
- total aggregations: 31
- number of (device types, builds): 16

File boot-image-profile.txt
  - hot methods: 3145 added, 3473 removed
  - methods: 3145 added, 3473 removed
  - classes: 24 added, 123 removed
  - totals now: 32486 hot methods, 32486 methods, 17264 classes
  - totals before: 32814 hot methods, 32814 methods, 17363 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1842, 2107, 20, 122, 20998, 9945
    com.android, 146, 181, 4, 1, 2426, 3481
    java, 917, 944, 0, 0, 7094, 2101
    android.view, 348, 422, 7, 2, 3417, 1052
    android.hardware, 18, 29, 1, 0, 497, 859
    android.animation, 17, 34, 0, 7, 397, 75
    android.app, 136, 140, 8, 0, 2942, 1107
    android.content, 196, 200, 1, 0, 1888, 585
    android.graphics, 158, 165, 0, 0, 1968, 345
    android.icu, 232, 239, 0, 0, 2048, 1474
    android.media, 19, 20, 0, 0, 792, 604
    android.net, 44, 43, 0, 1, 252, 220
    android.widget, 147, 154, 1, 1, 1402, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 0 added, 139 removed
  - totals now: 0 hot methods, 0 methods, 17194 classes
  - totals before: 0 hot methods, 0 methods, 17333 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 0, 135, 0, 9894
    com.android, 0, 0, 0, 3, 0, 3469
    java, 0, 0, 0, 1, 0, 2097
    android.view, 0, 0, 0, 6, 0, 1041
    android.hardware, 0, 0, 0, 4, 0, 853
    android.animation, 0, 0, 0, 9, 0, 73
    android.media, 0, 0, 0, 1, 0, 600
    android.net, 0, 0, 0, 1, 0, 220
    android.widget, 0, 0, 0, 1, 0, 397

File boot-image-profile.txt
  - hot methods: 1938 added, 2238 removed
  - methods: 1938 added, 2238 removed
  - classes: 24 added, 125 removed
  - totals now: 22447 hot methods, 22447 methods, 14052 classes
  - totals before: 22747 hot methods, 22747 methods, 14153 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1838, 2103, 20, 122, 20934, 9914
    com.android, 100, 135, 4, 1, 1416, 3052
    java, 0, 0, 0, 2, 2, 116
    android.view, 348, 422, 7, 2, 3417, 1052
    android.hardware, 18, 29, 1, 0, 497, 859
    android.animation, 17, 34, 0, 7, 397, 75
    android.app, 136, 140, 8, 0, 2942, 1107
    android.content, 196, 200, 1, 0, 1888, 585
    android.graphics, 158, 165, 0, 0, 1968, 345
    android.icu, 232, 239, 0, 0, 2048, 1474
    android.media, 19, 20, 0, 0, 792, 604
    android.net, 44, 43, 0, 1, 252, 220
    android.widget, 147, 154, 1, 1, 1402, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 0 added, 140 removed
  - totals now: 0 hot methods, 0 methods, 13987 classes
  - totals before: 0 hot methods, 0 methods, 14127 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 0, 135, 0, 9863
    com.android, 0, 0, 0, 3, 0, 3040
    java, 0, 0, 0, 2, 0, 116
    android.view, 0, 0, 0, 6, 0, 1041
    android.hardware, 0, 0, 0, 4, 0, 853
    android.animation, 0, 0, 0, 9, 0, 73
    android.media, 0, 0, 0, 1, 0, 600
    android.net, 0, 0, 0, 1, 0, 220
    android.widget, 0, 0, 0, 1, 0, 397

File art-profile
  - hot methods: 5705 added, 3202 removed
  - methods: 5705 added, 3202 removed
  - classes: 1243 added, 14 removed
  - totals now: 14592 hot methods, 14592 methods, 2694 classes
  - totals before: 12089 hot methods, 12089 methods, 1465 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 46, 21, 21, 8, 91, 45
    com.android, 5659, 3181, 1205, 5, 14501, 2603
    java, 0, 0, 0, 1, 0, 0
    android.hardware, 45, 19, 17, 1, 76, 29
    android.app, 1, 0, 2, 0, 1, 4
    android.content, 0, 0, 1, 1, 2, 4
    android.net, 0, 2, 0, 0, 8, 3

InternalReferenceRawProfileId: 36420
InternalReferenceCandidateProfileId: 36422

Test: build & benchmark

Change-Id: Ia2d60e41a204ef584c4a1ef91759e97ce37813ce

03fe31e6

Sep 22, 2023

Make bootclasspath srcjar available to make · 26c63d26

Anton Hansson authored 1 year ago

Create a genrule, which creates an entry in Android.mk.

Bug: 151360309
Test: m platform-bootclasspath.srcjar
Change-Id: I23e62e72d369059a41ddd566c378b9a8bf0ad6ec

26c63d26

Sep 07, 2023

Update boot image and system server profiles [M31C26P62S0PP] · 1c45a255

art-benchmark-service authored 1 year ago

Bug: 254051423
Bug: 294603422
Test: go/art-benchmark?p=BootImageProfileId:36349
Test: ATP test http://shortn/_aT2kwyTb9i

= Perf stats =
(lower is better)

Regular update to the boot image profiles, which is adding some missing inline cache to the boot image profiles. Benchmark shows slight improvement in startup time, memory and no noticeable impact on the total boot time, with a very small increase in code size which could be an acceptable cost.

         Avg % (Confidence interval min-max %)
Startup: -0.35% (-1.57 -> 0.87)
Memory(PSS): -0.85% (-2.26 -> 0.55)
Boot time: 0.11 (-4.85% -> 5.08)
Code size (.oat + .art + .odex): 0.02MB (0.02%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.31
image_class_threshold: 0.26
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.022142857
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.022142857
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.022142857
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.022142857
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.018571427
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.022142857
}

=Profile stats=

Data info:
- total aggregations: 5691
- number of (device types, builds): 136

File boot-image-profile.txt
  - hot methods: 2140 added, 2289 removed
  - methods: 2140 added, 2289 removed
  - classes: 1 added, 4 removed
  - totals now: 32814 hot methods, 32814 methods, 17363 classes
  - totals before: 32963 hot methods, 32963 methods, 17366 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1354, 1481, 1, 1, 21263, 10047
    com.android, 106, 117, 0, 1, 2461, 3478
    java, 508, 513, 0, 1, 7121, 2101
    android.view, 249, 272, 0, 0, 3491, 1047
    android.hardware, 14, 27, 0, 0, 508, 858
    android.animation, 28, 29, 0, 0, 414, 82
    android.app, 85, 112, 0, 0, 2946, 1099
    android.content, 137, 143, 0, 0, 1892, 584
    android.graphics, 138, 142, 0, 0, 1975, 345
    android.icu, 196, 205, 0, 0, 2055, 1474
    android.media, 31, 32, 0, 0, 793, 604
    android.net, 17, 18, 1, 0, 251, 221
    android.widget, 139, 147, 0, 0, 1409, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 1 added, 1 removed
  - totals now: 0 hot methods, 0 methods, 17333 classes
  - totals before: 0 hot methods, 0 methods, 17333 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 1, 0, 0, 10029
    com.android, 0, 0, 0, 1, 0, 3472
    android.net, 0, 0, 1, 0, 0, 221

File boot-image-profile.txt
  - hot methods: 1426 added, 1564 removed
  - methods: 1426 added, 1564 removed
  - classes: 1 added, 2 removed
  - totals now: 22747 hot methods, 22747 methods, 14153 classes
  - totals before: 22885 hot methods, 22885 methods, 14154 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1350, 1477, 1, 1, 21199, 10016
    com.android, 76, 87, 0, 1, 1451, 3049
    android.view, 249, 272, 0, 0, 3491, 1047
    android.hardware, 14, 27, 0, 0, 508, 858
    android.animation, 28, 29, 0, 0, 414, 82
    android.app, 85, 112, 0, 0, 2946, 1099
    android.content, 137, 143, 0, 0, 1892, 584
    android.graphics, 138, 142, 0, 0, 1975, 345
    android.icu, 196, 205, 0, 0, 2055, 1474
    android.media, 31, 32, 0, 0, 793, 604
    android.net, 17, 18, 1, 0, 251, 221
    android.widget, 139, 147, 0, 0, 1409, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 1 added, 1 removed
  - totals now: 0 hot methods, 0 methods, 14127 classes
  - totals before: 0 hot methods, 0 methods, 14127 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 1, 0, 0, 9998
    com.android, 0, 0, 0, 1, 0, 3043
    android.net, 0, 0, 1, 0, 0, 221

File art-profile
  - hot methods: 1386 added, 2383 removed
  - methods: 1386 added, 2383 removed
  - classes: 5 added, 22 removed
  - totals now: 12089 hot methods, 12089 methods, 1465 classes
  - totals before: 13086 hot methods, 13086 methods, 1482 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1, 14, 4, 0, 66, 32
    com.android, 1385, 2369, 0, 21, 12023, 1403
    java, 0, 0, 1, 0, 0, 1
    android.hardware, 1, 14, 0, 0, 50, 13

InternalReferenceRawProfileId: 36330
InternalReferenceCandidateProfileId: 36335

Test: build & benchmark

Change-Id: I4613ceb8f5b25bc52f2f23ca9c106391ebb7d22f

1c45a255

Aug 30, 2023

Exclude SLatencyTrackerHolder to be preloaded. · 031c7def

islamelbanna authored 1 year ago

Since this class should have a lazy loading behavior.

Bug: 297836588
Test: Running ATP `v2/android-crystalball-eng/health/microbench/systemui/systemui-foldable-latency-suite` test
Change-Id: I7f7ee0e8d0db6aa6c58a2b1a0fe8d249887ca97a

031c7def

Aug 24, 2023

Update boot image and system server profiles [M21C16P62S0PP] · dca8e111

art-benchmark-service authored 1 year ago

Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:36190&f=CandidateName:in:36196

= Perf stats =
(lower is better)

Regular update to the boot image profiles. Benchmark shows an improvement in total boot time, and no noticeable impact for startup and memory, with a small increase in code size which could be an acceptable cost.

         Avg % (Confidence interval min-max %)
Startup: 0.19% (-1.01% -> 1.4%)
Memory(PSS): -0.21% (-1.58% -> 1.17%)
Boot time: -1.4% (-2.41% -> -0.38%)
Code size (.oat + .art + .odex): 0.24MB (0.28%)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.21
image_class_threshold: 0.16
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.015
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.015
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.015
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.015
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.015
}

=Profile stats=

Data info:
- total aggregations: 1365
- number of (device types, builds): 70

File boot-image-profile.txt
  - hot methods: 1058 added, 1176 removed
  - methods: 1058 added, 1176 removed
  - classes: 0 added, 14 removed
  - totals now: 32963 hot methods, 32963 methods, 17366 classes
  - totals before: 33081 hot methods, 33081 methods, 17380 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 670, 765, 0, 7, 21390, 10047
    com.android, 72, 85, 0, 6, 2472, 3479
    java, 253, 258, 0, 0, 7126, 2102
    android.view, 184, 209, 0, 1, 3514, 1047
    android.hardware, 20, 23, 0, 0, 521, 858
    android.animation, 17, 17, 0, 0, 415, 82
    android.app, 37, 89, 0, 5, 2973, 1099
    android.content, 77, 77, 0, 0, 1898, 584
    android.graphics, 86, 89, 0, 0, 1979, 345
    android.icu, 49, 49, 0, 0, 2064, 1474
    android.media, 16, 21, 0, 0, 794, 604
    android.net, 14, 14, 0, 0, 252, 220
    android.widget, 65, 67, 0, 0, 1417, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 0 added, 13 removed
  - totals now: 0 hot methods, 0 methods, 17334 classes
  - totals before: 0 hot methods, 0 methods, 17347 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 0, 7, 0, 10028
    com.android, 0, 0, 0, 6, 0, 3474
    android.view, 0, 0, 0, 1, 0, 1047
    android.app, 0, 0, 0, 5, 0, 1098

File boot-image-profile.txt
  - hot methods: 718 added, 826 removed
  - methods: 718 added, 826 removed
  - classes: 0 added, 14 removed
  - totals now: 22885 hot methods, 22885 methods, 14154 classes
  - totals before: 22993 hot methods, 22993 methods, 14168 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 670, 765, 0, 7, 21326, 10016
    com.android, 48, 61, 0, 6, 1462, 3050
    android.view, 184, 209, 0, 1, 3514, 1047
    android.hardware, 20, 23, 0, 0, 521, 858
    android.animation, 17, 17, 0, 0, 415, 82
    android.app, 37, 89, 0, 5, 2973, 1099
    android.content, 77, 77, 0, 0, 1898, 584
    android.graphics, 86, 89, 0, 0, 1979, 345
    android.icu, 49, 49, 0, 0, 2064, 1474
    android.media, 16, 21, 0, 0, 794, 604
    android.net, 14, 14, 0, 0, 252, 220
    android.widget, 65, 67, 0, 0, 1417, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 0 added, 13 removed
  - totals now: 0 hot methods, 0 methods, 14128 classes
  - totals before: 0 hot methods, 0 methods, 14141 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 0, 7, 0, 9997
    com.android, 0, 0, 0, 6, 0, 3045
    android.view, 0, 0, 0, 1, 0, 1047
    android.app, 0, 0, 0, 5, 0, 1098

File art-profile
  - hot methods: 1040 added, 941 removed
  - methods: 1040 added, 941 removed
  - classes: 5 added, 2 removed
  - totals now: 13086 hot methods, 13086 methods, 1482 classes
  - totals before: 12987 hot methods, 12987 methods, 1479 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 4, 2, 0, 1, 79, 28
    com.android, 1036, 939, 4, 0, 13007, 1424
    java, 0, 0, 0, 1, 0, 0
    android.hardware, 4, 2, 0, 0, 63, 13

InternalReferenceRawProfileId: 36190
InternalReferenceCandidateProfileId: 36196

Test: build & benchmark

Change-Id: Ib1c3a4f2e42907191c68de754d3e997639426ecc

dca8e111

Aug 15, 2023

[CrashRecovery] Add module lib to Android SDK · e0168afe

Harshit Mahajan authored 1 year ago

Adding the module libraries to combined_apis for them to be added to
Android SDK.
Also adding bootclasspath-fragment to platform-bootclasspath.

Bug: b/289203818
Test: m

Change-Id: Ica9b0bddc2f9cb6621a01dcd3859c39357144b5f

e0168afe

Aug 03, 2023

Update boot image and system server profiles [M21C16P62S0PP] · 6c7d0314

art-benchmark-service authored 1 year ago

Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:36076&f=CandidateName:in:36081

= Perf stats =
(lower is better)

Improvements in total boot time, no noticeable impact for startup and memory, and great reduction in code size.

Startup: 0.63%
Memory(PSS): -0.15%
Boot time: -2.09%
Code size (.oat + .art + .odex): -0.83% (-0.71 MB reduction)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.21
image_class_threshold: 0.16
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.015
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.015
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.015
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.015
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.011428571
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.015
}

=Profile stats=

Data info:
- total aggregations: 2977
- number of (device types, builds): 82

File boot-image-profile.txt
  - hot methods: 1713 added, 2030 removed
  - methods: 1713 added, 2030 removed
  - classes: 2 added, 121 removed
  - totals now: 33081 hot methods, 33081 methods, 17380 classes
  - totals before: 33398 hot methods, 33398 methods, 17499 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1211, 1373, 1, 88, 21485, 10054
    com.android, 65, 74, 0, 8, 2485, 3485
    java, 344, 463, 0, 0, 7131, 2102
    android.view, 315, 345, 0, 0, 3539, 1048
    android.hardware, 9, 10, 0, 0, 524, 858
    android.bluetooth, 0, 6, 0, 10, 0, 0
    android.animation, 11, 11, 0, 0, 415, 82
    android.app, 88, 87, 0, 11, 3025, 1104
    android.content, 117, 121, 0, 0, 1898, 584
    android.graphics, 110, 111, 0, 0, 1982, 345
    android.icu, 80, 92, 0, 0, 2064, 1474
    android.media, 18, 19, 0, 3, 799, 604
    android.net, 28, 88, 0, 40, 252, 220
    android.widget, 122, 124, 0, 0, 1419, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 0 added, 109 removed
  - totals now: 0 hot methods, 0 methods, 17347 classes
  - totals before: 0 hot methods, 0 methods, 17456 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 0, 76, 0, 10035
    com.android, 0, 0, 0, 8, 0, 3480
    android.bluetooth, 0, 0, 0, 5, 0, 0
    android.app, 0, 0, 0, 10, 0, 1103
    android.media, 0, 0, 0, 2, 0, 601
    android.net, 0, 0, 0, 39, 0, 220

File boot-image-profile.txt
  - hot methods: 1276 added, 3604 removed
  - methods: 1276 added, 3604 removed
  - classes: 2 added, 941 removed
  - totals now: 22993 hot methods, 22993 methods, 14168 classes
  - totals before: 25321 hot methods, 25321 methods, 15107 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1213, 1415, 1, 104, 21421, 10023
    com.android, 63, 72, 0, 11, 1475, 3056
    java, 0, 1986, 0, 668, 2, 118
    android.view, 315, 345, 0, 0, 3539, 1048
    android.hardware, 9, 10, 0, 0, 524, 858
    android.bluetooth, 0, 6, 0, 10, 0, 0
    android.animation, 11, 11, 0, 0, 415, 82
    android.app, 88, 87, 0, 11, 3025, 1104
    android.content, 117, 121, 0, 0, 1898, 584
    android.graphics, 110, 111, 0, 0, 1982, 345
    android.icu, 82, 91, 0, 0, 2064, 1474
    android.media, 18, 19, 0, 3, 799, 604
    android.net, 28, 86, 0, 39, 252, 220
    android.widget, 122, 124, 0, 0, 1419, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 0 added, 928 removed
  - totals now: 0 hot methods, 0 methods, 14141 classes
  - totals before: 0 hot methods, 0 methods, 15069 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 0, 92, 0, 10004
    com.android, 0, 0, 0, 11, 0, 3051
    java, 0, 0, 0, 667, 0, 118
    android.bluetooth, 0, 0, 0, 5, 0, 0
    android.app, 0, 0, 0, 10, 0, 1103
    android.media, 0, 0, 0, 2, 0, 601
    android.net, 0, 0, 0, 38, 0, 220

File art-profile
  - hot methods: 826 added, 7772 removed
  - methods: 826 added, 7772 removed
  - classes: 1 added, 3524 removed
  - totals now: 12987 hot methods, 12987 methods, 1479 classes
  - totals before: 19933 hot methods, 19933 methods, 5002 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 6, 4582, 0, 2507, 77, 29
    com.android, 820, 1844, 1, 436, 12910, 1420
    java, 0, 1289, 0, 397, 0, 1
    android.view, 0, 526, 0, 239, 0, 0
    android.hardware, 6, 155, 0, 236, 61, 13
    android.bluetooth, 0, 24, 0, 24, 0, 0
    android.animation, 0, 39, 0, 13, 0, 0
    android.app, 0, 766, 0, 402, 0, 2
    android.content, 0, 707, 0, 255, 2, 4
    android.graphics, 0, 203, 0, 61, 0, 0
    android.icu, 0, 13, 0, 7, 0, 0
    android.media, 0, 157, 0, 191, 0, 0
    android.net, 0, 200, 0, 114, 10, 3
    android.widget, 0, 50, 0, 32, 0, 0

InternalReferenceRawProfileId: 36076
InternalReferenceCandidateProfileId: 36081

Test: build & benchmark

Change-Id: I34b8ef4d89dafb5ce77adbf85f8de829d78f3047

6c7d0314

Jul 25, 2023

Update boot image and system server profiles [M23C18P64S0PP] · 84f185c9

art-benchmark-service authored 1 year ago

Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:36003&f=CandidateName:in:36015

= Perf stats =
(lower is better)

Improvements in Startup, no noticeable impact for boot-time and memory at the cost of a slight increase in code size, which could be an acceptable cost. Also to keep the profile up to date with the code base.

Startup: -1.05%
Memory(PSS): 0.13%
Boot time: 0.22%
Code size (.oat + .art + .odex): 2.75% (2.29 MB increase)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.23
image_class_threshold: 0.18
preloaded_classes_threshold: 0.64
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:CLASS:android"
  value: 0.012857144
}
priority_packages_thresholds {
  key: "service-appsearch.jar.prof:METHOD:android"
  value: 0.016428571
}
priority_packages_thresholds {
  key: "service-art.jar.prof:CLASS:android"
  value: 0.012857144
}
priority_packages_thresholds {
  key: "service-art.jar.prof:METHOD:android"
  value: 0.016428571
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:CLASS:android"
  value: 0.012857144
}
priority_packages_thresholds {
  key: "service-connectivity.jar.prof:METHOD:android"
  value: 0.016428571
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:CLASS:android"
  value: 0.012857144
}
priority_packages_thresholds {
  key: "service-wifi.jar.prof:METHOD:android"
  value: 0.016428571
}
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.012857144
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.016428571
}

=Profile stats=

Data info:
- total aggregations: 3267
- number of (device types, builds): 53

File boot-image-profile.txt
  - hot methods: 2776 added, 2269 removed
  - methods: 2776 added, 2269 removed
  - classes: 183 added, 62 removed
  - totals now: 33398 hot methods, 33398 methods, 17499 classes
  - totals before: 32891 hot methods, 32891 methods, 17378 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1643, 1324, 126, 17, 21647, 10141
    com.android, 176, 119, 20, 28, 2494, 3493
    java, 757, 667, 25, 9, 7250, 2102
    android.view, 376, 291, 7, 2, 3569, 1048
    android.hardware, 51, 18, 8, 2, 525, 858
    android.bluetooth, 6, 0, 10, 0, 6, 10
    android.animation, 32, 21, 9, 0, 415, 82
    android.app, 116, 110, 17, 2, 3024, 1115
    android.content, 135, 133, 0, 1, 1902, 584
    android.graphics, 93, 87, 0, 0, 1983, 345
    android.icu, 160, 132, 0, 0, 2076, 1474
    android.media, 38, 30, 4, 1, 800, 607
    android.net, 86, 29, 40, 3, 312, 260
    android.widget, 125, 112, 0, 0, 1421, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 173 added, 61 removed
  - totals now: 0 hot methods, 0 methods, 17456 classes
  - totals before: 0 hot methods, 0 methods, 17344 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 114, 16, 0, 10111
    com.android, 0, 0, 23, 28, 0, 3488
    java, 0, 0, 25, 9, 0, 2098
    android.view, 0, 0, 7, 2, 0, 1048
    android.hardware, 0, 0, 7, 2, 0, 857
    android.bluetooth, 0, 0, 5, 0, 0, 5
    android.animation, 0, 0, 9, 0, 0, 82
    android.app, 0, 0, 15, 1, 0, 1113
    android.content, 0, 0, 0, 1, 0, 582
    android.media, 0, 0, 3, 1, 0, 603
    android.net, 0, 0, 39, 3, 0, 259

File boot-image-profile.txt
  - hot methods: 3931 added, 1398 removed
  - methods: 3931 added, 1398 removed
  - classes: 995 added, 46 removed
  - totals now: 25321 hot methods, 25321 methods, 15107 classes
  - totals before: 22788 hot methods, 22788 methods, 14158 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1683, 1324, 142, 17, 21623, 10126
    com.android, 130, 73, 23, 28, 1484, 3067
    java, 1986, 0, 672, 0, 1988, 786
    android.view, 376, 291, 7, 2, 3569, 1048
    android.hardware, 51, 18, 8, 2, 525, 858
    android.bluetooth, 6, 0, 10, 0, 6, 10
    android.animation, 32, 21, 9, 0, 415, 82
    android.app, 116, 110, 17, 2, 3024, 1115
    android.content, 135, 133, 0, 1, 1902, 584
    android.graphics, 93, 87, 0, 0, 1983, 345
    android.icu, 159, 134, 0, 0, 2073, 1474
    android.media, 38, 30, 4, 1, 800, 607
    android.net, 84, 29, 39, 3, 310, 259
    android.widget, 125, 112, 0, 0, 1421, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 985 added, 45 removed
  - totals now: 0 hot methods, 0 methods, 15069 classes
  - totals before: 0 hot methods, 0 methods, 14129 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 130, 16, 0, 10096
    com.android, 0, 0, 26, 28, 0, 3062
    java, 0, 0, 671, 0, 0, 785
    android.view, 0, 0, 7, 2, 0, 1048
    android.hardware, 0, 0, 7, 2, 0, 857
    android.bluetooth, 0, 0, 5, 0, 0, 5
    android.animation, 0, 0, 9, 0, 0, 82
    android.app, 0, 0, 15, 1, 0, 1113
    android.content, 0, 0, 0, 1, 0, 582
    android.media, 0, 0, 3, 1, 0, 603
    android.net, 0, 0, 38, 3, 0, 258

File art-profile
  - hot methods: 10322 added, 2590 removed
  - methods: 10322 added, 2590 removed
  - classes: 3578 added, 188 removed
  - totals now: 19933 hot methods, 19933 methods, 5002 classes
  - totals before: 12201 hot methods, 12201 methods, 1612 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 4600, 10, 2515, 2, 4653, 2536
    com.android, 4376, 2580, 481, 184, 13934, 1855
    java, 1289, 0, 398, 0, 1289, 398
    android.view, 526, 0, 239, 0, 526, 239
    android.hardware, 172, 9, 237, 0, 210, 249
    android.bluetooth, 24, 0, 24, 0, 24, 24
    android.animation, 39, 0, 13, 0, 39, 13
    android.app, 766, 0, 404, 0, 766, 404
    android.content, 707, 0, 256, 1, 709, 259
    android.graphics, 203, 0, 61, 0, 203, 61
    android.icu, 13, 0, 7, 0, 13, 7
    android.media, 157, 0, 191, 0, 157, 191
    android.net, 201, 1, 114, 1, 210, 117
    android.widget, 50, 0, 32, 0, 50, 32

InternalReferenceRawProfileId: 36003
InternalReferenceCandidateProfileId: 36015

Test: build & benchmark

Change-Id: If8d53eb3c9624604b12fe84886dca7832d29d146

84f185c9

Jun 09, 2023

Revert "Update boot image and system server profiles [M28C24P49S0PP]" · d7380572

Karuna Ramkumar authored 1 year ago

Revert submission 23615721-u-profiles-v10

Reason for revert: DroidMonitor: Potential culprit for Bug b/286550234 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:23615721-u-profiles-v10

Change-Id: I0648be943a1910b82d71b649db381eb294711792

d7380572

Update boot image and system server profiles [M28C24P49S0PP] · c50bfff3

art-benchmark-service authored 1 year ago

Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:35486&f=CandidateName:in:35492

= Perf stats =
(lower is better)

Improvements in Startup, no noticeable impact for boot-time and memory at the cost of a slight increase in code size, which could be an acceptable cost.

Startup: -2.68%
Memory(PSS): -0.44%
Boot time: -0.09%
Code size (.oat + .art + .odex): 0.60% (0.52 MB increase)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.28
image_class_threshold: 0.24
preloaded_classes_threshold: 0.49
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.017142856
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.02
}

=Profile stats=

Data info:
- total aggregations: 1164
- number of (device types, builds): 42

File boot-image-profile.txt
  - hot methods: 2052 added, 1777 removed
  - methods: 2052 added, 1777 removed
  - classes: 178 added, 40 removed
  - totals now: 33166 hot methods, 33166 methods, 17516 classes
  - totals before: 32891 hot methods, 32891 methods, 17378 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1211, 1053, 123, 8, 21486, 10147
    com.android, 98, 81, 19, 28, 2454, 3492
    java, 611, 528, 24, 0, 7243, 2110
    android.view, 269, 229, 9, 2, 3524, 1050
    android.hardware, 23, 9, 8, 0, 506, 860
    android.bluetooth, 3, 0, 8, 0, 3, 8
    android.animation, 33, 23, 9, 0, 414, 82
    android.app, 74, 71, 17, 1, 3021, 1116
    android.content, 52, 62, 0, 1, 1890, 584
    android.graphics, 89, 87, 0, 0, 1979, 345
    android.icu, 172, 155, 0, 0, 2065, 1474
    android.media, 22, 21, 4, 0, 793, 608
    android.net, 74, 17, 39, 0, 312, 262
    android.widget, 98, 99, 0, 0, 1407, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 174 added, 39 removed
  - totals now: 0 hot methods, 0 methods, 17479 classes
  - totals before: 0 hot methods, 0 methods, 17344 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 114, 7, 0, 10120
    com.android, 0, 0, 23, 28, 0, 3488
    java, 0, 0, 25, 0, 0, 2107
    android.view, 0, 0, 7, 2, 0, 1048
    android.hardware, 0, 0, 7, 0, 0, 859
    android.bluetooth, 0, 0, 5, 0, 0, 5
    android.animation, 0, 0, 9, 0, 0, 82
    android.app, 0, 0, 15, 0, 0, 1114
    android.content, 0, 0, 0, 1, 0, 582
    android.media, 0, 0, 3, 0, 0, 604
    android.net, 0, 0, 39, 0, 0, 262

File boot-image-profile.txt
  - hot methods: 3422 added, 1113 removed
  - methods: 3422 added, 1113 removed
  - classes: 985 added, 37 removed
  - totals now: 25097 hot methods, 25097 methods, 15106 classes
  - totals before: 22788 hot methods, 22788 methods, 14158 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1245, 1056, 139, 8, 21453, 10132
    com.android, 73, 56, 22, 28, 1444, 3066
    java, 1972, 0, 669, 0, 1974, 783
    android.view, 269, 229, 9, 2, 3524, 1050
    android.hardware, 23, 9, 8, 0, 506, 860
    android.bluetooth, 3, 0, 8, 0, 3, 8
    android.animation, 33, 23, 9, 0, 414, 82
    android.app, 74, 71, 17, 1, 3021, 1116
    android.content, 52, 62, 0, 1, 1890, 584
    android.graphics, 89, 87, 0, 0, 1979, 345
    android.icu, 165, 161, 0, 0, 2052, 1474
    android.media, 22, 21, 4, 0, 793, 608
    android.net, 73, 17, 38, 0, 311, 261
    android.widget, 98, 99, 0, 0, 1407, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 979 added, 36 removed
  - totals now: 0 hot methods, 0 methods, 15072 classes
  - totals before: 0 hot methods, 0 methods, 14129 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 130, 7, 0, 10105
    com.android, 0, 0, 26, 28, 0, 3062
    java, 0, 0, 668, 0, 0, 782
    android.view, 0, 0, 7, 2, 0, 1048
    android.hardware, 0, 0, 7, 0, 0, 859
    android.bluetooth, 0, 0, 5, 0, 0, 5
    android.animation, 0, 0, 9, 0, 0, 82
    android.app, 0, 0, 15, 0, 0, 1114
    android.content, 0, 0, 0, 1, 0, 582
    android.media, 0, 0, 3, 0, 0, 604
    android.net, 0, 0, 38, 0, 0, 261

File art-profile
  - hot methods: 8483 added, 2290 removed
  - methods: 8483 added, 2290 removed
  - classes: 3545 added, 171 removed
  - totals now: 18394 hot methods, 18394 methods, 4986 classes
  - totals before: 12201 hot methods, 12201 methods, 1612 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 4391, 9, 2495, 2, 4445, 2516
    com.android, 2766, 2281, 479, 167, 12623, 1870
    java, 1269, 0, 394, 0, 1269, 394
    android.view, 511, 0, 244, 0, 511, 244
    android.hardware, 137, 8, 236, 0, 176, 248
    android.bluetooth, 19, 0, 23, 0, 19, 23
    android.animation, 39, 0, 13, 0, 39, 13
    android.app, 727, 0, 387, 0, 727, 387
    android.content, 688, 0, 257, 1, 690, 260
    android.graphics, 199, 0, 61, 0, 199, 61
    android.icu, 13, 0, 7, 0, 13, 7
    android.media, 140, 0, 187, 0, 140, 187
    android.net, 186, 1, 114, 1, 195, 117
    android.widget, 49, 0, 32, 0, 49, 32

InternalReferenceRawProfileId: 35486
InternalReferenceCandidateProfileId: 35492

Test: build & benchmark

Change-Id: I4f342f62d4fd8fda86149a67cbbffe35e73d7bfa

c50bfff3

Jun 06, 2023

Revert "Update boot image and system server profiles [M24C20P47S0PP]" · 4d9df061

Islam Elbanna authored 1 year ago

Revert submission 23539173-u-profiles-v9

Reason for revert: It seems causing a regression at b/286024404

Reverted changes: /q/submissionid:23539173-u-profiles-v9

Change-Id: I89d9305878044ebed4de65fb1134b58f2852ccad

4d9df061

Jun 05, 2023

Update boot image and system server profiles [M24C20P47S0PP] · 0a0d9202

art-benchmark-service authored 1 year ago

Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:35460&f=CandidateName:in:35466

= Perf stats =
(lower is better)

Improvements in Startup and boot times, no noticeable impact for memory at the cost of a slight increase in code size, which could be an acceptable cost.

Startup: -2.02%
Memory(PSS): -0.39%
Boot time: -0.60%
Code size (.oat + .art + .odex): 1.04% (0.99 MB increase)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.24
image_class_threshold: 0.2
preloaded_classes_threshold: 0.47
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.014285714
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.017142856
}

=Profile stats=

Data info:
- total aggregations: 4702
- number of (device types, builds): 128

File boot-image-profile.txt
  - hot methods: 3348 added, 3043 removed
  - methods: 3348 added, 3043 removed
  - classes: 173 added, 40 removed
  - totals now: 33196 hot methods, 33196 methods, 17511 classes
  - totals before: 32891 hot methods, 32891 methods, 17378 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 2085, 1961, 118, 8, 21452, 10142
    com.android, 164, 151, 19, 28, 2450, 3492
    java, 928, 780, 24, 0, 7308, 2110
    android.view, 371, 372, 6, 2, 3483, 1047
    android.hardware, 28, 18, 8, 0, 502, 860
    android.bluetooth, 4, 0, 8, 0, 4, 8
    android.animation, 94, 84, 9, 0, 414, 82
    android.app, 225, 221, 16, 1, 3022, 1115
    android.content, 219, 222, 0, 1, 1897, 584
    android.graphics, 185, 185, 0, 0, 1977, 345
    android.icu, 213, 197, 0, 0, 2064, 1474
    android.media, 17, 15, 4, 0, 794, 608
    android.net, 89, 36, 39, 0, 308, 262
    android.widget, 118, 120, 0, 0, 1406, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 159 added, 39 removed
  - totals now: 0 hot methods, 0 methods, 17464 classes
  - totals before: 0 hot methods, 0 methods, 17344 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 100, 7, 0, 10106
    com.android, 0, 0, 22, 28, 0, 3487
    java, 0, 0, 25, 0, 0, 2107
    android.view, 0, 0, 4, 2, 0, 1045
    android.hardware, 0, 0, 7, 0, 0, 859
    android.bluetooth, 0, 0, 5, 0, 0, 5
    android.animation, 0, 0, 2, 0, 0, 75
    android.app, 0, 0, 15, 0, 0, 1114
    android.content, 0, 0, 0, 1, 0, 582
    android.media, 0, 0, 3, 0, 0, 604
    android.net, 0, 0, 36, 0, 0, 259

File boot-image-profile.txt
  - hot methods: 4351 added, 2072 removed
  - methods: 4351 added, 2072 removed
  - classes: 980 added, 37 removed
  - totals now: 25067 hot methods, 25067 methods, 15101 classes
  - totals before: 22788 hot methods, 22788 methods, 14158 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 2121, 1966, 134, 8, 21419, 10127
    com.android, 118, 105, 22, 28, 1440, 3066
    java, 1980, 0, 669, 0, 1982, 783
    android.view, 371, 372, 6, 2, 3483, 1047
    android.hardware, 28, 18, 8, 0, 502, 860
    android.bluetooth, 4, 0, 8, 0, 4, 8
    android.animation, 94, 84, 9, 0, 414, 82
    android.app, 225, 221, 16, 1, 3022, 1115
    android.content, 219, 222, 0, 1, 1897, 584
    android.graphics, 185, 185, 0, 0, 1977, 345
    android.icu, 207, 203, 0, 0, 2052, 1474
    android.media, 17, 15, 4, 0, 794, 608
    android.net, 89, 36, 38, 0, 308, 261
    android.widget, 118, 120, 0, 0, 1406, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 964 added, 36 removed
  - totals now: 0 hot methods, 0 methods, 15057 classes
  - totals before: 0 hot methods, 0 methods, 14129 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 116, 7, 0, 10091
    com.android, 0, 0, 25, 28, 0, 3061
    java, 0, 0, 668, 0, 0, 782
    android.view, 0, 0, 4, 2, 0, 1045
    android.hardware, 0, 0, 7, 0, 0, 859
    android.bluetooth, 0, 0, 5, 0, 0, 5
    android.animation, 0, 0, 2, 0, 0, 75
    android.app, 0, 0, 15, 0, 0, 1114
    android.content, 0, 0, 0, 1, 0, 582
    android.media, 0, 0, 3, 0, 0, 604
    android.net, 0, 0, 35, 0, 0, 258

InternalReferenceRawProfileId: 35460
InternalReferenceCandidateProfileId: 35466

Test: build & benchmark

Change-Id: I8379223a4a6972abab46f79fce1d3e6e86121a3e

0a0d9202

Apr 04, 2023

Revert "Update boot image and system server profiles [M20C15P70S...", RESTRICT... · 998a75e3

Islam Elbanna authored 1 year ago

Revert "Update boot image and system server profiles [M20C15P70S...", RESTRICT AUTOMERGE Since these are profiles for T release only.

Revert submission 22278342-t-profiles-v8

Reason for revert: Memory regression at b/275595328

Reverted changes: /q/submissionid:22278342-t-profiles-v8

Change-Id: I0fa202869230a7aeeb0f9b7b8221bb4ea9760112

998a75e3

Apr 03, 2023
- Update owners for some ART related files. · 039c8f49
  Nicolas Geoffray authored 1 year ago
  
  Test: N/A Change-Id: If37223f5bbb741fa6cd85552a69af7cbbf68f656
  039c8f49
Mar 31, 2023

ActivityManager: Use the default UidObserver implementation. · eebca7af

Austin Borger authored 1 year ago

A class which overrides IUidObserver.Stub with empty callback
implementations was added in change
I2ff1e868586861e4dcd6586ad22139ba84eaf39c to simplify BroadcastQueue
interface complexity. Using this default implementation will mean less
churn when new callbacks are added to IUidObserver, or existing callback
method signatures are changed.

Also rename ActivityManager.UidObserver to MyUidObserver to remove any
ambiguity.

Bug: 274486653
Test: Presubmit, smoke test on cuttlefish.
Change-Id: I6e30a4e116a7baaca1e411ca0cc4a4dca37a32bd

eebca7af

Mar 29, 2023

[TeX] Source code moved to modules-utils · 171ea519

Vova Sharaienko authored 2 years ago

- to be used as a static lib by mainline modules

Bug: 271127104
Test: m
Change-Id: I80b03fb6dbcff95dd7fc0d5c4af6e868629cce64

171ea519

Mar 27, 2023

Update boot image and system server profiles [M20C15P70S0PP], RESTRICT... · 4fc02706

art-benchmark-service authored 1 year ago

Update boot image and system server profiles [M20C15P70S0PP], RESTRICT AUTOMERGE Since these are profiles for T release only.

Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:33626

= Perf stats =
(lower is better)

Improvements in Startup time, boot time and drop in the generated code size at the cost of a slight increase in memory, which could be an acceptable cost.

Startup: -0.83%
Memory(PSS): 1.43%
Boot time: -0.72%
Code size (.oat + .art + .odex): -2.44% (2.89 MB drop)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.2
image_class_threshold: 0.15
preloaded_classes_threshold: 0.7
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.01875
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.025
}

=Profile stats=

Data info:
- total aggregations: 23
- number of (device types, builds): 9

File boot-image-profile.txt
  - hot methods: 1893 added, 1590 removed
  - methods: 1893 added, 1590 removed
  - classes: 117 added, 1 removed
  - totals now: 32655 hot methods, 32655 methods, 16928 classes
  - totals before: 32352 hot methods, 32352 methods, 16812 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1210, 1012, 77, 0, 21083, 9595
    com.android, 135, 54, 32, 1, 2561, 3562
    java, 478, 460, 5, 0, 7073, 2047
    android.view, 236, 189, 11, 0, 3426, 960
    android.hardware, 13, 5, 5, 0, 480, 812
    android.animation, 11, 11, 0, 0, 393, 73
    android.app, 225, 159, 24, 0, 2990, 1053
    android.content, 161, 146, 1, 0, 1872, 565
    android.graphics, 81, 71, 0, 0, 1989, 336
    android.icu, 70, 67, 0, 0, 2038, 1472
    android.media, 12, 8, 14, 0, 802, 590
    android.net, 20, 20, 2, 0, 255, 221
    android.widget, 50, 43, 0, 0, 1403, 381

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 404 added, 4 removed
  - totals now: 0 hot methods, 0 methods, 16831 classes
  - totals before: 0 hot methods, 0 methods, 16431 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 233, 0, 0, 9524
    com.android, 0, 0, 69, 3, 0, 3550
    java, 0, 0, 29, 1, 0, 2039
    android.view, 0, 0, 38, 0, 0, 953
    android.hardware, 0, 0, 18, 0, 0, 807
    android.animation, 0, 0, 2, 0, 0, 73
    android.app, 0, 0, 41, 0, 0, 1030
    android.content, 0, 0, 10, 0, 0, 562
    android.graphics, 0, 0, 5, 0, 0, 336
    android.icu, 0, 0, 1, 0, 0, 1472
    android.media, 0, 0, 22, 0, 0, 587
    android.net, 0, 0, 3, 0, 0, 219
    android.widget, 0, 0, 5, 0, 0, 380

File boot-image-profile.txt
  - hot methods: 1335 added, 1056 removed
  - methods: 1335 added, 1056 removed
  - classes: 111 added, 1 removed
  - totals now: 22667 hot methods, 22667 methods, 13777 classes
  - totals before: 22388 hot methods, 22388 methods, 13667 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1208, 1010, 77, 0, 21020, 9564
    com.android, 127, 46, 32, 1, 1551, 3140
    android.view, 236, 189, 11, 0, 3426, 960
    android.hardware, 13, 5, 5, 0, 480, 812
    android.animation, 11, 11, 0, 0, 393, 73
    android.app, 225, 159, 24, 0, 2990, 1053
    android.content, 161, 146, 1, 0, 1872, 565
    android.graphics, 81, 71, 0, 0, 1989, 336
    android.icu, 70, 67, 0, 0, 2038, 1472
    android.media, 12, 8, 14, 0, 802, 590
    android.net, 20, 20, 2, 0, 255, 221
    android.widget, 50, 43, 0, 0, 1403, 381

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 332 added, 3 removed
  - totals now: 0 hot methods, 0 methods, 13690 classes
  - totals before: 0 hot methods, 0 methods, 13361 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 233, 0, 0, 9493
    com.android, 0, 0, 57, 3, 0, 3128
    android.view, 0, 0, 38, 0, 0, 953
    android.hardware, 0, 0, 18, 0, 0, 807
    android.animation, 0, 0, 2, 0, 0, 73
    android.app, 0, 0, 41, 0, 0, 1030
    android.content, 0, 0, 10, 0, 0, 562
    android.graphics, 0, 0, 5, 0, 0, 336
    android.icu, 0, 0, 1, 0, 0, 1472
    android.media, 0, 0, 22, 0, 0, 587
    android.net, 0, 0, 3, 0, 0, 219
    android.widget, 0, 0, 5, 0, 0, 380

File art-profile
  - hot methods: 2293 added, 24736 removed
  - methods: 2286 added, 50806 removed
  - classes: 6 added, 3905 removed
  - totals now: 10167 hot methods, 10167 methods, 1285 classes
  - totals before: 32610 hot methods, 58687 methods, 5184 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 22, 397, 0, 118, 66, 25
    com.android, 2271, 24333, 6, 3718, 10101, 1242
    android.hardware, 20, 315, 0, 85, 51, 14
    android.app, 0, 2, 0, 3, 0, 0
    android.content, 0, 0, 0, 2, 1, 3
    android.net, 2, 64, 0, 21, 12, 6

InternalReferenceRawProfileId: 33626
InternalReferenceCandidateProfileId: 33629

Test: build & benchmark

Change-Id: Ib85d606d48727fd6dc0c0ecd094f7948e00464ca

4fc02706

Update boot image and system server profiles [M22C17P72S0PP] · 922a5539

art-benchmark-service authored 2 years ago

Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:33618

= Perf stats =
(lower is better)

Improvements in Startup time, memory and no noticeable impact for boot time at the cost of a slight increase in code size, which could be an acceptable cost.

Startup: -0.99%
Memory(PSS): -0.84%
Boot time: 0.46%
Code size (.oat + .art + .odex): 0.79% (0.68 MB increase)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.22
image_class_threshold: 0.17
preloaded_classes_threshold: 0.72
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.02125
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.0275
}

=Profile stats=

Data info:
- total aggregations: 426
- number of (device types, builds): 20

File boot-image-profile.txt
  - hot methods: 1697 added, 1322 removed
  - methods: 1697 added, 1322 removed
  - classes: 87 added, 15 removed
  - totals now: 32891 hot methods, 32891 methods, 17378 classes
  - totals before: 32516 hot methods, 32516 methods, 17306 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1165, 838, 61, 8, 21328, 10032
    com.android, 45, 22, 16, 7, 2437, 3501
    java, 407, 387, 5, 0, 7160, 2086
    android.view, 321, 199, 11, 1, 3484, 1043
    android.hardware, 26, 9, 4, 3, 492, 852
    android.animation, 24, 24, 0, 0, 404, 73
    android.app, 120, 36, 9, 0, 3018, 1100
    android.content, 90, 71, 3, 1, 1900, 585
    android.graphics, 87, 79, 2, 0, 1977, 345
    android.icu, 112, 107, 0, 0, 2048, 1474
    android.media, 15, 12, 0, 0, 792, 604
    android.net, 7, 6, 1, 0, 255, 223
    android.widget, 75, 68, 2, 0, 1408, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 429 added, 11 removed
  - totals now: 0 hot methods, 0 methods, 17344 classes
  - totals before: 0 hot methods, 0 methods, 16926 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 351, 7, 0, 10013
    com.android, 0, 0, 42, 4, 0, 3493
    java, 0, 0, 6, 0, 0, 2082
    android.view, 0, 0, 50, 1, 0, 1043
    android.hardware, 0, 0, 35, 3, 0, 852
    android.app, 0, 0, 56, 0, 0, 1099
    android.content, 0, 0, 18, 0, 0, 583
    android.graphics, 0, 0, 4, 0, 0, 345
    android.icu, 0, 0, 1, 0, 0, 1474
    android.media, 0, 0, 10, 0, 0, 601
    android.net, 0, 0, 5, 0, 0, 223
    android.widget, 0, 0, 7, 0, 0, 398

File boot-image-profile.txt
  - hot methods: 1207 added, 856 removed
  - methods: 1207 added, 856 removed
  - classes: 80 added, 15 removed
  - totals now: 22788 hot methods, 22788 methods, 14158 classes
  - totals before: 22437 hot methods, 22437 methods, 14093 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 1162, 835, 61, 8, 21264, 10001
    com.android, 43, 20, 16, 7, 1427, 3072
    android.view, 321, 199, 11, 1, 3484, 1043
    android.hardware, 26, 9, 4, 3, 492, 852
    android.animation, 24, 24, 0, 0, 404, 73
    android.app, 120, 36, 9, 0, 3018, 1100
    android.content, 90, 71, 3, 1, 1900, 585
    android.graphics, 87, 79, 2, 0, 1977, 345
    android.icu, 112, 107, 0, 0, 2048, 1474
    android.media, 15, 12, 0, 0, 792, 604
    android.net, 7, 6, 1, 0, 255, 223
    android.widget, 75, 68, 2, 0, 1408, 399

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 412 added, 11 removed
  - totals now: 0 hot methods, 0 methods, 14129 classes
  - totals before: 0 hot methods, 0 methods, 13728 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 351, 7, 0, 9982
    com.android, 0, 0, 38, 4, 0, 3064
    android.view, 0, 0, 50, 1, 0, 1043
    android.hardware, 0, 0, 35, 3, 0, 852
    android.app, 0, 0, 56, 0, 0, 1099
    android.content, 0, 0, 18, 0, 0, 583
    android.graphics, 0, 0, 4, 0, 0, 345
    android.icu, 0, 0, 1, 0, 0, 1474
    android.media, 0, 0, 10, 0, 0, 601
    android.net, 0, 0, 5, 0, 0, 223
    android.widget, 0, 0, 7, 0, 0, 398

File art-profile
  - hot methods: 1741 added, 2436 removed
  - methods: 1741 added, 2436 removed
  - classes: 185 added, 49 removed
  - totals now: 12201 hot methods, 12201 methods, 1612 classes
  - totals before: 12896 hot methods, 12896 methods, 1476 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 7, 23, 0, 0, 63, 23
    com.android, 1734, 2413, 184, 48, 12138, 1558
    android.hardware, 6, 21, 0, 0, 47, 12
    android.net, 1, 1, 0, 0, 10, 4

InternalReferenceRawProfileId: 33618
InternalReferenceCandidateProfileId: 33621

Test: build & benchmark

Change-Id: I137e6d45fc17143855f5c2458050fa650771d509

922a5539

Mar 03, 2023

Revert "Update boot image and system server profiles [M60C35P85S0PP]" · f93b0ad6

Islam Elbanna authored 2 years ago

Revert submission 21609950-u-profiles-v7

BUG: 271469319
Reason for revert: Possible regression for startup time, will merge a better candidate later

Reverted changes: /q/submissionid:21609950-u-profiles-v7

Change-Id: I73d5b3f45ae4bb082e9312ad47c32f5e21fa073c

f93b0ad6

Mar 01, 2023

Update boot image and system server profiles [M60C35P85S0PP] · 5cbfb0cf

art-benchmark-service authored 2 years ago

Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:32538

= Perf stats =
(lower is better)

No noticeable impact for startup time, memory and boot time and a nice drop for code sizes (mainly ~4MB drop).

Startup: 0.03%
Memory(PSS): -0.93%
Boot time: 0.54%
Code size (.oat + .art + .odex): -4.93% (4.04 MB drop)

Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code

=Generation Strategy=

method_threshold: 0.6
image_class_threshold: 0.35
preloaded_classes_threshold: 0.85
priority_packages_thresholds {
  key: "services.jar.prof:CLASS:android"
  value: 0.04375
}
priority_packages_thresholds {
  key: "services.jar.prof:METHOD:android"
  value: 0.075
}

=Profile stats=

Data info:
- total aggregations: 2789
- number of (device types, builds): 62

File boot-image-profile.txt
  - hot methods: 1134 added, 1164 removed
  - methods: 1134 added, 1164 removed
  - classes: 0 added, 295 removed
  - totals now: 32486 hot methods, 32486 methods, 17011 classes
  - totals before: 32516 hot methods, 32516 methods, 17306 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 741, 766, 0, 236, 20976, 9743
    com.android, 27, 30, 0, 34, 2411, 3458
    java, 302, 304, 0, 2, 7138, 2079
    android.view, 198, 206, 0, 16, 3354, 1017
    android.hardware, 8, 9, 0, 26, 474, 825
    android.animation, 12, 12, 0, 0, 404, 73
    android.app, 35, 45, 0, 43, 2924, 1048
    android.content, 85, 89, 0, 12, 1877, 571
    android.graphics, 94, 93, 0, 1, 1970, 342
    android.icu, 86, 86, 0, 1, 2043, 1473
    android.media, 2, 3, 0, 8, 788, 596
    android.net, 11, 11, 0, 4, 254, 218
    android.widget, 53, 53, 0, 3, 1401, 394

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 0 added, 19 removed
  - totals now: 0 hot methods, 0 methods, 16908 classes
  - totals before: 0 hot methods, 0 methods, 16927 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 0, 9, 0, 9660
    com.android, 0, 0, 0, 8, 0, 3447
    java, 0, 0, 0, 1, 0, 2076
    android.view, 0, 0, 0, 3, 0, 991

File boot-image-profile.txt
  - hot methods: 765 added, 793 removed
  - methods: 765 added, 793 removed
  - classes: 0 added, 286 removed
  - totals now: 22409 hot methods, 22409 methods, 13807 classes
  - totals before: 22437 hot methods, 22437 methods, 14093 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 740, 765, 0, 236, 20912, 9712
    com.android, 25, 28, 0, 30, 1401, 3033
    android.view, 198, 206, 0, 16, 3354, 1017
    android.hardware, 8, 9, 0, 26, 474, 825
    android.animation, 12, 12, 0, 0, 404, 73
    android.app, 35, 45, 0, 43, 2924, 1048
    android.content, 85, 89, 0, 12, 1877, 571
    android.graphics, 94, 93, 0, 1, 1970, 342
    android.icu, 86, 86, 0, 1, 2043, 1473
    android.media, 2, 3, 0, 8, 788, 596
    android.net, 11, 11, 0, 4, 254, 218
    android.widget, 53, 53, 0, 3, 1401, 394

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 0 added, 17 removed
  - totals now: 0 hot methods, 0 methods, 13711 classes
  - totals before: 0 hot methods, 0 methods, 13728 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 0, 9, 0, 9629
    com.android, 0, 0, 0, 8, 0, 3022
    android.view, 0, 0, 0, 3, 0, 991

File art-profile
  - hot methods: 382 added, 5965 removed
  - methods: 382 added, 5965 removed
  - classes: 0 added, 33 removed
  - totals now: 7313 hot methods, 7313 methods, 1443 classes
  - totals before: 12896 hot methods, 12896 methods, 1476 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 55, 0, 2, 24, 21
    com.android, 382, 5910, 0, 30, 7289, 1392
    android.hardware, 0, 52, 0, 0, 10, 12
    android.content, 0, 0, 0, 1, 2, 3
    android.net, 0, 2, 0, 1, 8, 3

InternalReferenceRawProfileId: 32502
InternalReferenceCandidateProfileId: 32516

Test: build & benchmark

Change-Id: I6e540f8ec146e6aea4f87b85c694a52bb176e3ab

5cbfb0cf