Skip to content
Snippets Groups Projects
  1. Oct 24, 2023
  2. Oct 23, 2023
  3. Oct 20, 2023
  4. Oct 16, 2023
  5. Sep 22, 2023
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · eb695e1f
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      eb695e1f
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 5ae8b810
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      5ae8b810
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 3904fb61
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      3904fb61
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 6fe75d9d
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      6fe75d9d
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · db60b2f5
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      db60b2f5
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · d28f10d8
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      d28f10d8
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 598dc664
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      598dc664
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 6fe53e86
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      6fe53e86
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · b4aaf180
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      b4aaf180
  6. Sep 21, 2023
    • beatricemarch's avatar
      Add more BackupManagerMonitor events to PerformUnifiedRestoreTask. · 501eeee2
      beatricemarch authored
      In particular
      add events to cover
      -If this is KV or Full restore
      -For each package, when the restore started and when it ended
      -When a restore operation starts, if it is system restore or restore at install
      -Any errors
      
      Test: manual testing. Run `adb shell bmgr restore 1` and verify that the
      new restore events are added to the dumpsys
      atest CtsBackupHostTestCases, GtsBackupHostTestCases
      atest BackupManagerMonitorDumpsysUtilsTest,
      BackupManagerMonitorEventSenderTest, UserBackupManagerServiceTest,
      PerformUnifiedRestoreTaskTest, BmgrTest
      Bug: 290747920
      
      Change-Id: I0d221f10932fea3e8fb90a1827c7f1b5bf21d25d
      501eeee2
  7. Sep 12, 2023
  8. Sep 07, 2023
  9. Sep 06, 2023
  10. Sep 05, 2023
  11. Sep 01, 2023
  12. Aug 28, 2023
  13. Aug 24, 2023
  14. Aug 23, 2023
  15. Aug 22, 2023
  16. Aug 18, 2023
  17. Aug 15, 2023
  18. Aug 09, 2023
    • Eric Biggers's avatar
      Make locksettings commands go through "cmd lock_settings" · 7d4a9fd5
      Eric Biggers authored
      This greatly improves the performance of locksettings commands, and it
      eliminates the need for LockSettingsCmd.java.
      
      Bug: 177985929
      Test: locksettings command still works
      Change-Id: I5881fa074681f6bf1ad2f5969a282d928121ddb2
      Merged-In: I5881fa074681f6bf1ad2f5969a282d928121ddb2
      (cherry picked from commit 4d38b0cd)
      7d4a9fd5
  19. Jul 27, 2023
    • Vova Sharaienko's avatar
      RESTRICT AUTOMERGE Make log reader thread a class member · 5a0f6c5b
      Vova Sharaienko authored
      pushedEventThread references class members after detaching. Making
      pushedEventThread as class member and joining in statsService
      destructor. Adding a method to stop readLogs thread.
      
      Ignore-AOSP-First: Bug is in still security triage and fuzzer is
      crashing on startup.
      Test: atest statsd_test
      Test: m statsd_service_fuzzer && adb sync data && adb shell
      /data/fuzz/arm64/statsd_service_fuzzer/statsd_service_fuzzer -runs=10000
      Bug: 285645039
      
      Change-Id: I1e886f9ccb7203714216da061c35e793b2a63d8a
      Merged-In: I1e886f9ccb7203714216da061c35e793b2a63d8a
      5a0f6c5b
    • Vova Sharaienko's avatar
      RESTRICT AUTOMERGE Make log reader thread a class member · 03de4e4f
      Vova Sharaienko authored
      pushedEventThread references class members after detaching. Making
      pushedEventThread as class member and joining in statsService
      destructor. Adding a method to stop readLogs thread.
      
      Ignore-AOSP-First: Bug is in still security triage and fuzzer is
      crashing on startup.
      Test: atest statsd_test
      Test: m statsd_service_fuzzer && adb sync data && adb shell
      /data/fuzz/arm64/statsd_service_fuzzer/statsd_service_fuzzer -runs=10000
      Bug: 285645039
      
      Change-Id: I1e886f9ccb7203714216da061c35e793b2a63d8a
      03de4e4f
  20. Jul 11, 2023
    • Yurii Zubrytskyi's avatar
      Reland "Use reference counted pointers for ApkAssets" · 1cf74939
      Yurii Zubrytskyi authored
      This reverts commit cf6e79f8
      
      Updates:
          Prepare the shared pointers for the whole operation at once
          instead of re-locking them on each iteration.
          Still a regression of about 5% for changing theme's
          AssetManager object, vs the original 40%
      
          + change the log message to a warning as it doesn't break
            the app
      
      Original comment:
      
          Use reference counted pointers for ApkAssets
      
          The primary reason for memory corruption is freed ApkAssets
          Java expected them to only be freed in the finalizers, but
          there are explicit close() calls now, destroying objects that
          are still in use in some AssetManager2 objects
      
          This CL makes sure those AssetManagers don't assume ApkAssets
          always exist, but instead tries to lock them in memory for any
          access
      
          It also adds logging in case of deleting an assets object with
          any weak pointers still existing. Those will get into the
          bugreports attached to related bugs to help with investigation.
      
          Benchmarks don't regress, and the device appears to be working.
          Given that the crashes used to be pretty rare, let's wait for
          any new reports or lack of those.
      
          + add a missing .clang-format file to the jni directory
          + enabled C++23 in the project that uses AssetManager headers
      
          Bug: 197260547
          Bug: 276922628
          Test: unit tests + boot + benchmarks
          Old change id: I495fd9e012fe370a1f725dbb0265b4ee1be8d805
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b3455190124b41e2deb1774d9c05b396b73b41a2)
      Merged-In: Id668fbcf07db17b09691a344c04e98df83006f97
      Change-Id: Id668fbcf07db17b09691a344c04e98df83006f97
      1cf74939
  21. Jul 05, 2023
  22. Jul 01, 2023
    • Oleg Lyovin's avatar
      bootanimation: do not create texture for parts with count=1 · 6a4b84d2
      Oleg Lyovin authored
      
      When bootanimation contains part that is played only once,
      there is no need to create a separate texture for its frames.
      
      Such an approach allows to reduce memory consumption for
      typical use case of such an animations, when a part
      consists of a lot of frames played only once.
      
      Actually, it was already implemented earlier, but part of it
      was lost in 'd711ac48'.
      Moreover, the remained part leads to memory leak in
      current implementation on BootAnimation.cpp:1712.
      
      Test: play bootanimation with part.count=1 and a lot of
      frames, and check memory consumption.
      
      Change-Id: If3a0fa890f6f9e7abc0db2fe96b5635a1663fb8a
      Signed-off-by: default avatarOleg Lyovin <ovlevin@sberdevices.ru>
      6a4b84d2
  23. May 26, 2023
    • Dominik Laskowski's avatar
      screencap: Allow virtual display ID in -d switch · 622c4aef
      Dominik Laskowski authored
      Ibe3679d810602456205e157fe2cb8cc510062215 restricted the argument to
      PhysicalDisplayId, which prevents capture of virtual displays.
      
      Fixes: 280785757
      Test: screencap -d <id>
      Change-Id: I41a8d1adaa51c6804c03f1b3084ac04ff6b4f1fa
      622c4aef
  24. May 19, 2023
    • Pawan Wagh's avatar
      Check for null ferr · 428871d0
      Pawan Wagh authored
      fout is double checked for nullptr instead of ferr which forces
      to call fclose on null ferr.
      
      Test: atest incidentd_test
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      with clusterfuzz testcase
      Bug: 283453191
      
      Change-Id: I3a4912cf70f4f32cb66fb870febbbfff1a7c6adc
      428871d0
  25. May 16, 2023
    • Pawan Wagh's avatar
      Fix null-deref crash while fuzzing · 54826461
      Pawan Wagh authored
      When random parcel is sent to incidentd, AIDL service
      crashes with null pointer dereference.
      
      Test: atest incidentd_test
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Bug: 282963041
      Change-Id: I0e0ebc479acbfd3f5e9f56b629380b5d90021f45
      54826461
    • Shen Lin's avatar
      Fix typo in Dynamic coloring section · fac902a4
      Shen Lin authored
        - thrid -> third
        - Reorganize command flags to match docs below.
      
      Test: Manual
      Bug: 282802119
      Change-Id: I87b7f42312c35d2770775869cc0be4c83f09e719
      fac902a4
Loading