Skip to content
Snippets Groups Projects
  1. Oct 24, 2023
  2. Oct 23, 2023
  3. Oct 20, 2023
  4. Sep 28, 2023
  5. Sep 22, 2023
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · eb695e1f
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      eb695e1f
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 5ae8b810
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      5ae8b810
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 3904fb61
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      3904fb61
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 6fe75d9d
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      6fe75d9d
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · db60b2f5
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      db60b2f5
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · d28f10d8
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      d28f10d8
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 598dc664
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      598dc664
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · 6fe53e86
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      6fe53e86
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · b4aaf180
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      Merged-In: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      (cherry picked from commit ba78ef27)
      b4aaf180
  6. Sep 21, 2023
    • beatricemarch's avatar
      Add more BackupManagerMonitor events to PerformUnifiedRestoreTask. · 501eeee2
      beatricemarch authored
      In particular
      add events to cover
      -If this is KV or Full restore
      -For each package, when the restore started and when it ended
      -When a restore operation starts, if it is system restore or restore at install
      -Any errors
      
      Test: manual testing. Run `adb shell bmgr restore 1` and verify that the
      new restore events are added to the dumpsys
      atest CtsBackupHostTestCases, GtsBackupHostTestCases
      atest BackupManagerMonitorDumpsysUtilsTest,
      BackupManagerMonitorEventSenderTest, UserBackupManagerServiceTest,
      PerformUnifiedRestoreTaskTest, BmgrTest
      Bug: 290747920
      
      Change-Id: I0d221f10932fea3e8fb90a1827c7f1b5bf21d25d
      501eeee2
  7. Sep 12, 2023
  8. Sep 07, 2023
  9. Sep 06, 2023
  10. Sep 05, 2023
  11. Sep 01, 2023
  12. Aug 30, 2023
    • Yurii Zubrytskyi's avatar
      Clean up the attribute searching func · e7de40d9
      Yurii Zubrytskyi authored
      Don't convert each attribute name but instead only
      do it once for the string they're compared to
      
      Bug: 282215580
      Test: build + atest idmap2_tests
      Change-Id: I09f6d0f90f6c09632ceac8cdde7c20801f41524e
      e7de40d9
  13. Aug 28, 2023
  14. Aug 24, 2023
  15. Aug 23, 2023
  16. Aug 22, 2023
  17. Aug 18, 2023
  18. Aug 15, 2023
  19. Aug 11, 2023
  20. Aug 09, 2023
    • Jeremy Meyer's avatar
      Allow AssetFileDescriptors to be used to create FRROs · c04bcb39
      Jeremy Meyer authored
      Before this change, if a (system) app tried to use an image from its
      assets to create an FRRO it would succeed but no image would display.
      That is because when it is an asset we have an AssetFileDescriptor which
      internally has a file descriptor, offset, and size and the file
      descriptor would point at the apk itself. When this would get passed to
      the native layer to create the frro only the file descriptor would get
      passed so we would copy the whole apk, not just the image.
      
      This allows apps to pass in an AssetFileDescriptor directly which we can
      then use to also pass down the offset and size to the native layer and
      only copy the image part.
      
      Fixes: 289739832
      Test: atest FabricatedOverlayTest
      Change-Id: I80dceb19229a6a3c02851a5451ea6d46798981b3
      c04bcb39
    • Eric Biggers's avatar
      Make locksettings commands go through "cmd lock_settings" · 7d4a9fd5
      Eric Biggers authored
      This greatly improves the performance of locksettings commands, and it
      eliminates the need for LockSettingsCmd.java.
      
      Bug: 177985929
      Test: locksettings command still works
      Change-Id: I5881fa074681f6bf1ad2f5969a282d928121ddb2
      Merged-In: I5881fa074681f6bf1ad2f5969a282d928121ddb2
      (cherry picked from commit 4d38b0cd)
      7d4a9fd5
  21. Jul 31, 2023
    • jeimysantiago's avatar
      Update Error Status Check · 8ee92d11
      jeimysantiago authored
      Updating check for captureDisplay ID error status.
      
      Bug: 287081404
      Test: atest displayScreenshot
      Test: atest ScreenCaptureTest#captureDisplayWithUid
      Change-Id: Ic1cdf47a5e5044ac25ab6b7e420d29b8421c8b5d
      8ee92d11
  22. Jul 28, 2023
  23. Jul 27, 2023
    • Vova Sharaienko's avatar
      RESTRICT AUTOMERGE Make log reader thread a class member · 5a0f6c5b
      Vova Sharaienko authored
      pushedEventThread references class members after detaching. Making
      pushedEventThread as class member and joining in statsService
      destructor. Adding a method to stop readLogs thread.
      
      Ignore-AOSP-First: Bug is in still security triage and fuzzer is
      crashing on startup.
      Test: atest statsd_test
      Test: m statsd_service_fuzzer && adb sync data && adb shell
      /data/fuzz/arm64/statsd_service_fuzzer/statsd_service_fuzzer -runs=10000
      Bug: 285645039
      
      Change-Id: I1e886f9ccb7203714216da061c35e793b2a63d8a
      Merged-In: I1e886f9ccb7203714216da061c35e793b2a63d8a
      5a0f6c5b
    • Vova Sharaienko's avatar
      RESTRICT AUTOMERGE Make log reader thread a class member · 03de4e4f
      Vova Sharaienko authored
      pushedEventThread references class members after detaching. Making
      pushedEventThread as class member and joining in statsService
      destructor. Adding a method to stop readLogs thread.
      
      Ignore-AOSP-First: Bug is in still security triage and fuzzer is
      crashing on startup.
      Test: atest statsd_test
      Test: m statsd_service_fuzzer && adb sync data && adb shell
      /data/fuzz/arm64/statsd_service_fuzzer/statsd_service_fuzzer -runs=10000
      Bug: 285645039
      
      Change-Id: I1e886f9ccb7203714216da061c35e793b2a63d8a
      03de4e4f
Loading