Skip to content
Snippets Groups Projects
  • Brian Delwiche's avatar
    024980ba
    Disallow connect with key length downgrade · 024980ba
    Brian Delwiche authored
    As a guard against the BLUFFS attack, check security parameters of
    incoming connections against cached values and disallow connection if
    these parameters are downgraded or changed from their cached values.
    
    This CL adds the connection-time check for session key length.
    
    To test, please validate that bonding can be established and
    reestablished against devices with session key lengths of 7 and 16 bits,
    that session key lengths of less than 7 bits are refused, and that basic
    LE bonding functionality still works.  If it is possible to configure a
    remote device to establish a bond with a session key length of 16 bits
    and then reduce that key length to <16 bits before reconnection, this
    should fail.
    
    Bug: 314331379
    Test: m libbluetooth
    Test: manual
    
    Tag: #security
    Ignore-AOSP-First: Security
    (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d6e9fdf182afb57cecac6c56603aa20d758090a4)
    Merged-In: I27be1f93598820a0f2a7154ba83f5b041878c21f
    Change-Id: I27be1f93598820a0f2a7154ba83f5b041878c21f
    024980ba
    History
    Disallow connect with key length downgrade
    Brian Delwiche authored
    As a guard against the BLUFFS attack, check security parameters of
    incoming connections against cached values and disallow connection if
    these parameters are downgraded or changed from their cached values.
    
    This CL adds the connection-time check for session key length.
    
    To test, please validate that bonding can be established and
    reestablished against devices with session key lengths of 7 and 16 bits,
    that session key lengths of less than 7 bits are refused, and that basic
    LE bonding functionality still works.  If it is possible to configure a
    remote device to establish a bond with a session key length of 16 bits
    and then reduce that key length to <16 bits before reconnection, this
    should fail.
    
    Bug: 314331379
    Test: m libbluetooth
    Test: manual
    
    Tag: #security
    Ignore-AOSP-First: Security
    (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d6e9fdf182afb57cecac6c56603aa20d758090a4)
    Merged-In: I27be1f93598820a0f2a7154ba83f5b041878c21f
    Change-Id: I27be1f93598820a0f2a7154ba83f5b041878c21f
Code owners
Assign users and groups as approvers for specific file changes. Learn more.