Skip to content
Snippets Groups Projects
Select Git revision
7 results
Search by author
  • Any Author
0 authors
  1. Jul 10, 2024
    • Brian Delwiche's avatar
      Disallow connect with key length downgrade · 024980ba
      Brian Delwiche authored 
      As a guard against the BLUFFS attack, check security parameters of
incoming connections against cached values and disallow connection if
these parameters are downgraded or changed from their cached values.

This CL adds the connection-time check for session key length.

To test, please validate that bonding can be established and
reestablished against devices with session key lengths of 7 and 16 bits,
that session key lengths of less than 7 bits are refused, and that basic
LE bonding functionality still works.  If it is possible to configure a
remote device to establish a bond with a session key length of 16 bits
and then reduce that key length to <16 bits before reconnection, this
should fail.

Bug: 314331379
Test: m libbluetooth
Test: manual

Tag: #security
Ignore-AOSP-First: Security
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d6e9fdf182afb57cecac6c56603aa20d758090a4)
Merged-In: I27be1f93598820a0f2a7154ba83f5b041878c21f
Change-Id: I27be1f93598820a0f2a7154ba83f5b041878c21f
      024980ba
  3. Nov 10, 2023
  5. Mar 24, 2023
    • Adrian Chan's avatar
      floss: Add check to determine if read encryption key size is supported · 22519089
      Adrian Chan authored 
      On some laptops, pairing a bluetooth headset can fail. The ChromeOS
log at /var/log/bluetooth.log shows that this is due to using
`READ_ENCRYPTION_KEY_SIZE` when it is not supported: there is a line
with `UNKNOWN_HCI_COMMAND opcode:0x1408 (READ_ENCRYPTION_KEY_SIZE)`.
To remedy this, add a check before trying to read the encryption key
size on receiving a encryption change event from the controller.

Bug: 273316924
Bug: 273796661
Bug: 274092923
Tag: #floss
Test: Verify that bluetooth headset can be paired on a Dell Latitude
3440, Dell Latitude 3340, and HP Probook 450 G1

Change-Id: I02cb0f938be4430923b4ad8091ef05ae69336c87
      22519089
  7. Feb 07, 2023
  9. Feb 06, 2023
  11. Feb 03, 2023
    • Chris Manton's avatar
      Remove HCI_DISCONNECTION_COMP_EVT · 3b498b4b
      Chris Manton authored 
      Bug: 261272012
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Ia705adbdb30e9e87485b4eb2192cea5e0d061348
      3b498b4b
  13. Jan 30, 2023
  15. Jan 11, 2023
    • Hui Peng's avatar
      Fix an OOB bug in btm_read_rssi_complete · 047a68b1
      Hui Peng authored 
      Bug: 260569232
Test: manual, to add regression
Tag: #security
Ignore-AOSP-First: security
Merged-In: I3d56c64f205c3675ba3856c1e553878b945ec261
Change-Id: I3d56c64f205c3675ba3856c1e553878b945ec261
      047a68b1
  17. Jan 10, 2023
  19. Dec 29, 2022
  21. Dec 28, 2022
  23. Dec 22, 2022
  25. Dec 21, 2022
    • William Escande's avatar
      BT5.3: Set min encryption -- feature flag · 45374a40
      William Escande authored 
      Bug: 248126637
Tag: #feature
Test: Manual end-to-end testing (need 5.3 support in controller)
Change-Id: I95987cafd0a25ea42b29a7adb9096441836dc13f
      45374a40
    • Sunny Kapdi's avatar
      BT5.3 Features: ADI and Encrypt key size · c4eca1e4
      Sunny Kapdi authored 
      Snapshot of:
cfb019d7b43a103dd1749f66c20de93554d5d1bf
b513db3e630666ff4b58fc3a5f568aad4d9214cd
8a51e278f0a4318411cbef7af80937905b6a39ec
c1eed243784f2d87dd3659d8304bd29afee6833f

Sponsor: wescande@
Bug: 248126637
Tag: #feature
Test: Manual end-to-end testing (need 5.3 support in controller)
Change-Id: Ibafca123d2f89529619a2133527078df638f4e20
      c4eca1e4
  27. Dec 14, 2022
    • William Escande's avatar
      Remove unused logging · 0a278835
      William Escande authored 
      Bug: 245578454
Test: atest BluetoothInstrumentationTests
Test: Build + Pre-submit
Merged-In: If698c5a951043d877a05cf513d82c4d0e50de01b
Change-Id: If698c5a951043d877a05cf513d82c4d0e50de01b
      0a278835
  29. Dec 12, 2022
    • William Escande's avatar
      Remove unused logging · 204942db
      William Escande authored 
      Bug: 245578454
Test: atest BluetoothInstrumentationTests
Test: Build + Pre-submit
Merged-In: If698c5a951043d877a05cf513d82c4d0e50de01b
Change-Id: If698c5a951043d877a05cf513d82c4d0e50de01b
(cherry picked from commit f1739af0e4e84c867f37496181f6a7f7effb23d7)
      204942db
    • Hui Peng's avatar
      Fix an OOB bug in btm_ble_read_remote_features_complete · e2cfbf26
      Hui Peng authored 
      Bug: 254445952
Test: manual
Ignore-AOSP-First: security
Change-Id: I25f928cc9fa4b3338b1885412e5f894b4155da71
      e2cfbf26
  31. Dec 10, 2022
  33. Dec 08, 2022
    • William Escande's avatar
      Remove unused logging · 91cac49d
      William Escande authored 
      Bug: 245578454
Test: atest BluetoothInstrumentationTests
Test: Build + Pre-submit
Change-Id: If698c5a951043d877a05cf513d82c4d0e50de01b
(cherry picked from commit f1739af0e4e84c867f37496181f6a7f7effb23d7)
      91cac49d
  35. Nov 09, 2022
  37. Nov 08, 2022
  39. Nov 03, 2022
  41. Oct 28, 2022
    • En-Shuo Hsu's avatar
      Floss: Ignore SCO packets with invalid handle · f81dae45
      En-Shuo Hsu authored 
      Print out the error log and ignore the invalid packet without crashing
the stack.

Bug: 249598812
Tag: #floss
Test: Build, deploy and verify SCO works
Change-Id: I03ae086153f30d753d2d59aacca1993c07f9eae9
      f81dae45