- Jan 18, 2017
-
-
Jack He authored
* Convert top level Android.mk into build templates in build/Android.bp and build/fluoride.go * Initial conversion is done by "androidmk Android.mk > Android.bp" * Android.bp does not allow source inclusion from external directories and therefore they have to be made in to cc_library_static in their respective sub-directories and linked using whole_static_libs in the modules where they are used * As Android.bp does not allow multiple modules of the same name, same-name mudules for different target are merged into one definition with target specific setup * Generated proto header path has to be changed in osi/src/metrics.cc as Android.bp only generate header path relative to the Android.bp file instead of top-level directory such as system/bt * Android.bp does not support resource copying yet and hence conf files are left un-touched. * Android.bp does support conditional module declaration and therefore test-vendor libs are left untouched except for unit tests * The goal of this CL is to direct (almost) translate Android.mk to Android.bp first with Android.bp specific optimizations coming later Bug: 32958753 Test: Code compilation, manual testing by test team Change-Id: I5249e1f2135c4121205619b1d735ce448feb7499
-
Treehugger Robot authored
-
Sanket Agarwal authored
Bug: b/33552136 Test: adb shell dumpsys bluetooth_manager Change-Id: I3cb6c28bffe6b335cf82cac63dc78ce4957d78f4
-
Hemant Gupta authored
Usecase: 1) User tried to connect to HID Device. 2) SDP is internally performed by DUT. SDP is at stage, where L2CAP connection, configuration is done, and data fetch is ongoing. 3) BT was turned off from UI. Observation: BT crashed while accessing memory that was freed already because BT turn off, caused ACL disconnection, leading to L2CAP disconnect indication in stack, leading to sdp disconnect indication. backtrace: #00 pc 000f98d4 /system/lib/hw/bluetooth.default.so (SDP_FindServiceUUIDInDb+51) #1 pc 000b5dbd /system/lib/hw/bluetooth.default.so (hidh_search_callback+0x40) #02 pc 000f770b /system/lib/hw/bluetooth.default.so (sdp_disconnect_ind+0x5e) #03 pc 00107a5f /system/lib/hw/bluetooth.default.so (l2c_csm_execute+3446) #04 pc 001080e7 /system/lib/hw/bluetooth.default.so (l2c_link_hci_disc_comp+122) #05 pc 000fda81 /system/lib/hw/bluetooth.default.so (btu_hcif_process_event+588) #06 pc 000fec81 /system/lib/hw/bluetooth.default.so (btu_hci_msg_ready+96) #07 pc 00118191 /system/lib/hw/bluetooth.default.so #08 pc 0011917f /system/lib/hw/bluetooth.default.so #09 pc 00041993 /system/lib/libc.so (_ZL15__pthread_startPv+30) #10 pc 000192b5 /system/lib/libc.so (__start_thread+6) Register Dump pid: 15740, tid: 15761, name: bluedroid wake/ >>> com.android.bluetooth <<< signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x20000 r0 815a5cac r1 a1a2f370 r2 00000000 r3 85d4e541 r4 00020000 r5 815a5cac r6 a1a2f370 r7 b6d3ae40 r8 00000000 r9 b6d3ae40 sl 00000002 fp 00000013 ip a228c050 sp a1a2f360 lr a20eddc1 pc a21318d4 cpsr 200e0030 Rootcause The above scenario could lead to crash we see as below, as bta_hh_cb.p_disc_db would be freed during HID Host cleanup, and would be accessed via callback received for parsing SDP results on SDP completion. Fix: While cleaning up HID Host, Cancel SDP search before freeing and resetting bta_hh_cb.p_disc_db. This will internally send L2CAP disconnect request for SDP, and would lead to sdp_disconnect_cfm call when L2CAP is disconnected, and would lead to call of hidh_search_callback with result code as SDP_CANCEL. Change-Id: I63563cb23dd69946f87a70cafa203c44edc9b753
-
- Jan 17, 2017
-
-
Pavlin Radoslavov authored
Codecs like aptX and aptX-HD are supported on the device if the corresponding shared library is installed. Fix the unit tests to conditionally test for aptX/aptX-HD. Also, update function descriptions in files a2dp_sbc.h and a2dp_vendor_ldac.h . Test: Running unit tests on a device that doesn't have aptX/aptX-HD Change-Id: I44dc275ca6e0cb5438ee6ed0b6213213d56592f4
-
liuchao authored
This fixes a potential NULL-pointer access in case cb is returned NULL Test: mm -j 8 Change-Id: Iaf7aa0ba736b5cb161811726b4aaea7f1ab7e5b3
-
Treehugger Robot authored
-
Jakub Pawlowski authored
Those services are automatically added by the stack, and overriding them results in invalid GATT database being created. Bug: 34280184 Test: Manual test Change-Id: Ie6a09e9d606e40066bef6f6a2c934eacd17bf53b
-
Jakub Pawlowski authored
When doing a discovery of invalid GATT database, where two services are added with same start handle, characteristics are added to the first one, where descriptors are added to the later. This cause NPE when adding descriptor. Bug: 34280184 Test: manual test Change-Id: I27619098df33a641cb089b82cf4d4ffd3c6e6aea
-
Pavlin Radoslavov authored
Also, fixed a typo in a log message. Test: A2DP streaming to headset, and capturing "adb logcat" output Change-Id: I525d78e3ebde334857261f0cbd256a7f6a946e96
-
Reddy Praveen authored
With BT 5.0 extended advertisement scan parameter length is configured with correct value. Test: BT scan from settings menu Change-Id: I749099282a9f2cf190d4f9576649aefe88564809 Signed-off-by:
Reddy Praveen <praveen.reddy@intel.com>
-
- Jan 11, 2017
-
-
Pavlin Radoslavov authored
The feeding_init call is not used anymore - it has been superseded by the newer A2dpCodecs.setCodecAudioConfig() mechanism. Also, moved aptx_init_framing_params() and aptx_hd_init_framing_params() calls to the corresponding encoder_update functions. Test: A2DP streaming to Bluetooth headsets Change-Id: I52f42b4701d04fe2ddb8f115bb9cd57fe38e2b38
-
- Jan 10, 2017
-
-
Pavlin Radoslavov authored
* Add compile-time dependency on the libldacBT_enc module in external/libldac * Use the <ldacBT.h> header and remove local typedefs and defines Also, fix an initialization issue of the LDAC handler inside file a2dp_vendor_ldac_encoder.cc Bug: 30958229 Test: A2DP streaming to LDAC headset Change-Id: I3757230c9901509daab36f2b2018faa05490171d
-
Treehugger Robot authored
-
- Jan 09, 2017
-
-
Jakub Pawlowski authored
Bug: 30622771 Test: sl4a UniqueFilteringTest BleOpportunisticScanTest Change-Id: I0e6ca8ed3d7d98057277a5187e684246f410d978
-
Jakub Pawlowski authored
Bug: 30622771 Test: sl4a FilteringTest Change-Id: Ib4edfa40038ca59c37ae1dfc763f0cac563177d7
-
Jakub Pawlowski authored
Bug: 30622771 Test: sl4a FilteringTest Change-Id: I93b4f1275b9437a20cf1429d184dbefa79451986
-
Jakub Pawlowski authored
Bug: 30622771 Test: sl4a FilteringTest Change-Id: I58f3c335e84b4d7ee578c321109125084826efa0
-
Jakub Pawlowski authored
Calls to BleScannerInterface are already made using jni thread. Also all this calls do is scheduling to BTA thread, so remove unnecessary call to do_in_jni_thread Bug: 30622771 Test: sl4a FilteringTest Change-Id: I2c799dde720f9bc694fecacd6d3959b96c1b9ba8
-
Jakub Pawlowski authored
This patch use callbacks, instead of custom event queue when scheduling LE filter VSC. Bug: 30622771 Test: sl4a FilteringTest Change-Id: I64ac4392883c647d1e500c257c31a8d3e740a0a8
-
Jakub Pawlowski authored
Test: start connectable advertising using bluetoothtbd Change-Id: Ie7e42570748d43a27bc7691378aee85ab1565a05
-
Jakub Pawlowski authored
Test: start advertising using bluetooth-cli Change-Id: Iead31c5e73a70850c6a209b6bbbeaeb792202608
-
Jack He authored
* libpower dependency was introduced in change I1e8d49b087eff6301373e1e90e8d868f15847c34 * It is never used in any part of the system/bt stack and therefore should be removed from the shared library dependency list Bug: 34079981 Test: code compilation, no user visible effect Change-Id: Ic8e3ad0c369839fb9ced446695c72fdf0ffad1ca
-
Ivan Podogov authored
Currently the upper java layers have full support for all four connection states, yet the lower stack only reports about "connected" and "disconnected". This patch adds sending "connecting" and "disconnecting" messages when bta_hd_connect_act and bta_hd_disconnect_act finish successfully. Test: build, run, logcat Change-Id: I00f9f414daa3854198ff9eee19e9c98a2e18f603
-
Jakub Pawlowski authored
Name must be appended at end, not beginning. Test: run bt-example-hr-server --advertise Change-Id: I70909e0bfc94521c396908d0dcb78cf4439a7e63
-
Jakub Pawlowski authored
Test: build with ninja and mma Change-Id: I31688da8a554ed71b580c30a0e4c000ea4903d70
-
Jakub Pawlowski authored
Test: build with ninja Change-Id: I4993dae7f76479da9bfad70aae88cc51fd7127d5
-
- Jan 06, 2017
-
-
Pavlin Radoslavov authored
* The names of the expected aptX and aptX-HD shared libraries are updated to reflect better their purpose: - aptX: libaptX.so -> libaptX_encoder.so - aptX-HD: libaptXHD.so -> libaptXHD_encoder.so Also: * Add a missing upcall with the codec info the first time the codec is selected internally * Minor cleanup Bug: 30958229 Test: A2DP streaming to aptX/aptX-HD headsets Change-Id: Ib2bfc83823190fb7a057353eb47cd71c5b4d5a3a
-
- Jan 05, 2017
-
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Pavlin Radoslavov authored
The codec can be used if the encoding shared library is installed on the device: libldacBT_enc.so Also, increased the maximum number of SEPs AVDT_NUM_SEPS from 3 to 6 to accomodate Sink devices that support more than 3 codecs. Test: A2DP streaming to LDAC headsets Bug: 30958229 Change-Id: I114c3e6be2ebe1ac8aece62a3146637d37cd938e
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Jack He authored
* Fixed A2DP duration counting. It is now counting from music play start to music play end. * Start logging a2dp connection as Bluetooth sessions. Currently, only A2DP connections are logged. Thus the bluetooth session length will be the total connection length and the length within A2DP session message will be the audio connection length. * Add a audio_duration_millis field in A2DPSession to record audio duration * Add bonded memory constraint for metrics entries * Use a builder mechanism to only build metrics upon dumping * Refactor metrics module into BluetoothMetricsLogger class * Created unit test for BluetoothMetricsLogger Bug: 33694310 Test: Code compilation, Unit test, BtFunhausMetricsTest Change-Id: Iea2a997c4ea074687a5d50860e9229f0e1b82659
-
Jack He authored
* LeakyBondedQueue is a fixed size queue that leaks oldest item when reaching its capacity. This is useful in creating memory bonded data structure where freshness is more important than full coverage. * The queue is protected by a simple mutex and is thread-safe, although improvements could be made to lock enqueue and dequeue separately, it is not implemented at this moment due to lack of demand * The queue uses unique_ptr to automatically free its content when it is destructed * Add several tests to verify its API and memory management * This data structure will be firstly used in the metrics module Bug: 33781460 Test: Code compilation, unit tests Change-Id: I51cb73666ac58e4792d9cba0d6f16dad30a0ff39
-
Pavlin Radoslavov authored
Each of the codecs can be used if the corresponding encoding shared library is installed on the device: - aptX: libaptX.so - aptX-HD: libaptXHD.so Test: A2DP streaming to aptX and aptX-HD headsets Bug: 30958229 Change-Id: I1ca36da653721576f5a5b6bdac186b9ea2790c85
-
- Jan 04, 2017
-
-
Ruchi Kandoi authored
Script erroronously modifies UINT8_TO_BE_STREAM() to uint8_t_TO_BE_STREAM(). Modidy the script to prevent that. Test: Manual; Run the script on system/nfc Change-Id: I9e130b8eb79e400282233fad7da206b4bb1301af Signed-off-by:
Ruchi Kandoi <kandoiruchi@google.com>
-
liuchao authored
This fixes an inappropriate sscanf return value judgment that res check here is not needed while res2 is the one that need to be checked Test: mm -j 8 Change-Id: I3e332286c9434d5b9d01421f5f421039f84ad6c7
-
Ivan Podogov authored
By default, enabling the HID Device service is only possible during disabling the HID Host service. If, on the other hand, the HID Host service was never initialized, then a request to enable the HID Device service should just be executed immediately. Test: manual, on a device without the HID Host profile. Change-Id: I2ab4b8aec413b66d57eb322d38660f1b4c48ba32
-
Treehugger Robot authored
-