Skip to content
Snippets Groups Projects
  1. Jan 20, 2017
    • Satish Kodishala's avatar
      Bluetooth: Handle get RSSI timeout gracefully · 72728794
      Satish Kodishala authored
      Usecase:
      1. Turn ON BT
      2. Pair and connect with Headset
      3. Play Music over A2DP
      4. Make GetRssi timeout
      5. Bt app crashes
      
      Failure:
      BT app crashes.
      
      Rootcause:
      Calling callback with NULL and in callback handling NULL check with assert.
      
      Fix:
      Call the callback with error instead of NULL.
      
      Change-Id: I20a9e504a513697945cd76d218ec12a0ef1e3330
      72728794
    • Sanket Agarwal's avatar
      BTA HF CLIENT: Unset initial SCO value · 35b01a9a
      Sanket Agarwal authored
      Initialize the block with invalid SCO state so that while allocating the
      if condition does not ignore the block. This was causing the stack to
      not initiate a SCO connection to the remote (AG role)
      
      Bug: b/33555377
      Test: Check for SCO initialied on audio call
      Change-Id: I3f5619c69288483bfa45c2a1adcf22008e353841
      35b01a9a
    • Jack He's avatar
      Fix A2DP Metrics Logging Capacity · 9bebcc06
      Jack He authored
      * Set the maximum number of wake events logged to 1000
      * Stop logging wake log name as it takes too much memory
      * Add counters for each of the repeated values in BluetoothLog so that
        the true number of events can be determined while oldest event get
        dropped
      * Log Bluetooth session disconnect reasons using enum instead of string
        in order to save memory usage
      * Apply other branch changes to bluetooth.proto on system/bt
      
      Bug: 33694310
      Test: Code compilation and unit tests
      Change-Id: I2cc6f9304725938b63b211d615eb1941eac60edf
      (cherry picked from commit 7ab4b59672013eddcb706e288962ab7309a75628)
      9bebcc06
  2. Jan 19, 2017
  3. Jan 18, 2017
    • Jack He's avatar
      Convert build system to soong using Android.bp · 65b2a57b
      Jack He authored
      * Convert top level Android.mk into build templates in build/Android.bp
        and build/fluoride.go
      * Initial conversion is done by "androidmk Android.mk > Android.bp"
      * Android.bp does not allow source inclusion from external directories
        and therefore they have to be made in to cc_library_static in their
        respective sub-directories and linked using whole_static_libs in the
        modules where they are used
      * As Android.bp does not allow multiple modules of the same name,
        same-name mudules for different target are merged into one definition
        with target specific setup
      * Generated proto header path has to be changed in osi/src/metrics.cc as
        Android.bp only generate header path relative to the Android.bp file
        instead of top-level directory such as system/bt
      * Android.bp does not support resource copying yet and hence conf files
        are left un-touched.
      * Android.bp does support conditional module declaration and therefore
        test-vendor libs are left untouched except for unit tests
      * The goal of this CL is to direct (almost) translate Android.mk to
        Android.bp first with Android.bp specific optimizations coming later
      
      Bug: 32958753
      Test: Code compilation, manual testing by test team
      
      Change-Id: I5249e1f2135c4121205619b1d735ce448feb7499
      65b2a57b
    • Treehugger Robot's avatar
    • Sanket Agarwal's avatar
      HF CLIENT BTA: Reduce logging for non-allocated blocks · 2134bb66
      Sanket Agarwal authored
      Bug: b/33552136
      Test: adb shell dumpsys bluetooth_manager
      Change-Id: I3cb6c28bffe6b335cf82cac63dc78ce4957d78f4
      2134bb66
    • Hemant Gupta's avatar
      HID: Prevent crash by Cancelling SDP during cleanup · 10008bcd
      Hemant Gupta authored
      Usecase:
      1) User tried to connect to HID Device.
      2) SDP is internally performed by DUT. SDP is at stage,
         where L2CAP connection, configuration is done, and data
         fetch is ongoing.
      3) BT was turned off from UI.
      Observation:
      BT crashed while accessing memory that was freed already because BT turn off,
      caused ACL disconnection, leading to L2CAP disconnect indication in stack,
      leading to sdp disconnect indication.
      backtrace:
          #00 pc 000f98d4  /system/lib/hw/bluetooth.default.so (SDP_FindServiceUUIDInDb+51)
          #1 pc 000b5dbd  /system/lib/hw/bluetooth.default.so (hidh_search_callback+0x40)
          #02 pc 000f770b  /system/lib/hw/bluetooth.default.so (sdp_disconnect_ind+0x5e)
          #03 pc 00107a5f  /system/lib/hw/bluetooth.default.so (l2c_csm_execute+3446)
          #04 pc 001080e7  /system/lib/hw/bluetooth.default.so (l2c_link_hci_disc_comp+122)
          #05 pc 000fda81  /system/lib/hw/bluetooth.default.so (btu_hcif_process_event+588)
          #06 pc 000fec81  /system/lib/hw/bluetooth.default.so (btu_hci_msg_ready+96)
          #07 pc 00118191  /system/lib/hw/bluetooth.default.so
          #08 pc 0011917f  /system/lib/hw/bluetooth.default.so
          #09 pc 00041993  /system/lib/libc.so (_ZL15__pthread_startPv+30)
          #10 pc 000192b5  /system/lib/libc.so (__start_thread+6)
      Register Dump
      pid: 15740, tid: 15761, name: bluedroid wake/  >>> com.android.bluetooth <<<
      signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x20000
          r0 815a5cac  r1 a1a2f370  r2 00000000  r3 85d4e541
          r4 00020000  r5 815a5cac  r6 a1a2f370  r7 b6d3ae40
          r8 00000000  r9 b6d3ae40  sl 00000002  fp 00000013
          ip a228c050  sp a1a2f360  lr a20eddc1  pc a21318d4  cpsr 200e0030
      Rootcause
      The above scenario could lead to crash we see as below, as bta_hh_cb.p_disc_db would be freed
      during HID Host cleanup, and would be accessed via callback received for parsing SDP results on
      SDP completion.
      Fix:
      While cleaning up HID Host, Cancel SDP search before freeing and resetting bta_hh_cb.p_disc_db.
      This will internally send L2CAP disconnect request for SDP, and would lead to sdp_disconnect_cfm
      call when L2CAP is disconnected, and would lead to call of hidh_search_callback with result code
      as SDP_CANCEL.
      
      Change-Id: I63563cb23dd69946f87a70cafa203c44edc9b753
      10008bcd
  4. Jan 17, 2017
  5. Jan 11, 2017
    • Pavlin Radoslavov's avatar
      Removed the feeding_init call from tA2DP_ENCODER_INTERFACE · 3e6ec10a
      Pavlin Radoslavov authored
      The feeding_init call is not used anymore - it has been superseded
      by the newer A2dpCodecs.setCodecAudioConfig() mechanism.
      
      Also, moved aptx_init_framing_params() and aptx_hd_init_framing_params()
      calls to the corresponding encoder_update functions.
      
      Test: A2DP streaming to Bluetooth headsets
      Change-Id: I52f42b4701d04fe2ddb8f115bb9cd57fe38e2b38
      3e6ec10a
  6. Jan 10, 2017
  7. Jan 09, 2017
  8. Jan 06, 2017
    • Pavlin Radoslavov's avatar
      Renamed the aptX and aptX-HD shared libraries · 4fd1b4b2
      Pavlin Radoslavov authored
      * The names of the expected aptX and aptX-HD shared libraries are
        updated to reflect better their purpose:
        - aptX: libaptX.so -> libaptX_encoder.so
        - aptX-HD: libaptXHD.so -> libaptXHD_encoder.so
      
      Also:
      * Add a missing upcall with the codec info the first time the codec
        is selected internally
      * Minor cleanup
      
      Bug: 30958229
      Test: A2DP streaming to aptX/aptX-HD headsets
      Change-Id: Ib2bfc83823190fb7a057353eb47cd71c5b4d5a3a
      4fd1b4b2
  9. Jan 05, 2017
Loading