- Apr 05, 2018
-
-
Stanley Tng authored
Added error check and handling code in gatts_process_read_req to make sure that the packet length is correct. Please note that there is another earlier CL that is reverted and this is the updated one. Bug: 73172115 Test: Run the test program, poc, that was attached in the bug report Change-Id: Ia9b4e502fa8f8384bf9767e68f73b48a0915141b
-
Stanley Tng authored
This reverts commit f4ef07fb. There will be a newer fix uploaded later. Bug: 73172115 Test: None
-
- Apr 02, 2018
-
-
Stanley Tng authored
Added error check and handling code in gatts_process_read_req to make sure that the packet length is correct. Bug: 73172115 Test: Run the test program, poc, that was attached in the bug report Change-Id: I375853987010c87432e73b75d659eabee852ec9c
-
- Mar 31, 2018
-
-
Pavlin Radoslavov authored
For every periodic aptX / aptX HD data packet, use a single read operation for all PCM data that needs to be encoded, instead of using multiple reads of smaller blocks of data. Bug: 70899260 Test: Manual: stream to aptX/aptX HD headset, change the sample rate Change-Id: Ifcb8302589f24f5d7ab89c645c50d6905197fb7f Merged-In: Ifcb8302589f24f5d7ab89c645c50d6905197fb7f (cherry picked from commit fbfffe53)
-
Myles Watson authored
Change I63b857d031c55d3a0754e4101e330843eb422b2a caused a double free. Move the free call to pan_data_buf_ind_cb(). Free the buffer before every return in pan_data_buf_ind_cb. Bug: 74950468 Test: manual tethering test with DUT sharing its connection Change-Id: If4526f3042699581e2cdde79a362eef0f83768eb Merged-In: If4526f3042699581e2cdde79a362eef0f83768eb
-
- Mar 30, 2018
-
-
TreeHugger Robot authored
-
TreeHugger Robot authored
-
TreeHugger Robot authored
-
Jack He authored
* Log every instance of RFCOMM unexpected disconnection * Log every time when RFCOMM channel (DLCI) is changed * Refactor some RFCOMM code to be more readable and easier for logging * Remove excessive logging in power manager * Assign HSP default version more appropriate location * Replace some usage of NULL with nullptr Bug: 77224743 Test: make, no functional changes Change-Id: I5e62dd6d338f7e92a8b8d39c1fe155b71396034c (cherry picked from commit 0f5a1da4)
-
Joseph Pirozzo authored
Process play status updates when seeking forward and backward. Bug: 67568875 Test: seek forward and backward on paired phone and observe updates. Change-Id: Id280f0e877cfea0a0da7603ab6d7bcfaf667d482 (cherry picked from commit 5a6d6815)
-
Joseph Pirozzo authored
Register to be notified when the addressed media player changes so we can update the AVRCP controller. Bug: 72495854 Test: Change media player on phone, verify media source is updated. Change-Id: I932a25b9861734ecc6e1fdcf40f02cdde1fd049a (cherry picked from commit 43d6f51a)
-
TreeHugger Robot authored
-
Stanley Tng authored
Drop the LE CoC data fragments when the received fragment size is too big. Test: Runs LE CoC SL4A test, BleCocTest. Bug: 75298652 Change-Id: I529944341e9e67a39e7ec7e740d5ada3db8cc23a
-
- Mar 29, 2018
-
-
TreeHugger Robot authored
-
Ajay Panicker authored
Use the current media ID on the path stack to retrieve folder contents. Bug: 77237565 Test: run host native test net-test-avrcp Change-Id: I88d0862f76d18a071a8530cd31954447b4e180fc (cherry picked from commit 3c25e8d1) Merged-In: I88d0862f76d18a071a8530cd31954447b4e180fc
-
Ajay Panicker authored
Bug: 77237301 Test: run host native tests net-test-btpackets and net-test-avrcp Change-Id: Ic9a2c8d8cf5dd4c5be02a83975caa92e335ca2b9 (cherry picked from commit c3ad060f) Merged-In: Ic9a2c8d8cf5dd4c5be02a83975caa92e335ca2b9
-
TreeHugger Robot authored
-
Jakub Pawlowski authored
In bta_dm_remove_device, if the device is not connected, and we don't know the transport for given address, we make two calls to BTM_ReadConnectedTransportAddress, to determine the device address on the other transport. If the address provided is LE, first call will fill the other_address variable with the Classic address, and the second call will fill it back with LE addres. This mean we never try to remove Classic entry, instead we remove LE entry twice. Bug: 67907612 Test: establish LE connnection between two phones, trigger Bonding. After bonding complete, try to remove bond using LE address. Verify config file is cleaned of both LE and classic entry. Change-Id: Ia5dd53f96b95478a07009cecc5b4a3c79f15c59b
-
- Mar 28, 2018
-
-
TreeHugger Robot authored
-
Srinu Jella authored
Steps: 1. Pair and connect with HID mouse. 2. Once the settings UI shows paired and connected 3. Try to unpair the device, but UI still shows connected. Failure: Unable to unpair HID mouse due to LMP response timeout occurred for remote version and remote feature request. Root Cause: Remote version, Remote features, Authentication requested commands go simultaneously to the remote device which can't handle the multiple commands at a time. Fix: Serialize the Remote version, Remote features, Authentication requested commands. Test: Tested manually with apple magic mouse. Bug: 35125883 Change-Id: I4448c291a60ee637dc5927806547e67f26571d86 (cherry picked from commit 485f6429)
-
Hansong Zhang authored
This reverts commit 87b96013. Reason for revert: Connected HID keyboard won't unpair Bug: 76907578 Test: SL4A Change-Id: I7d289183ac05b5f926c145799418461377228569 (cherry picked from commit 25694ec900e61d5235ee65461d46495b5ae4cdcf)
-
Pavlin Radoslavov authored
Previously, the default configured sample rate for aptX and aptX-HD was 44.1kHz. However, during AVDTP codec setup, the initial codec setup to 44.1kHz was followed immediately with automatic codec reconfiguration to 48.0kHz (if supported by the remote device) so the highest possible sample rate will be used. Changing the default sample rate to 48.0kHz eliminates the transient initial codec setup of 44.1kHz, because it is unnecessary and error-prone. Bug: 69276823 Test: Manual: connect to aptX / aptX-HD headsets and examine the AVDTP codec configuration in the btsnoop logs. Change-Id: I9e22365e0f07690c87503ea52fd9bb4d1ad4d5ff (cherry picked from commit 50a8659e)
-
TreeHugger Robot authored
-
TreeHugger Robot authored
-
Jack He authored
* Store discovered HFP version to btif config file so that a reconnection session knows the HFP version before SDP * Check stored HFP version when RFCOMM channel is open before any AT command is processed * Set peer HFP version to 0 on control block allocation Bug: 67938255 Test: Connect with HFP 1.7 headsets Change-Id: I43e7aa04dee17ea7ba9e7d3992ec0860c11d23bc (cherry picked from commit 483217bf)
-
Joseph Pirozzo authored
Correct parameter order. Bug: 77009945 Test: observe log message Change-Id: I69d4bc04936c322707111c825864007b7f257cc4 (cherry picked from commit bbd4f009)
-
Pavlin Radoslavov authored
If OTA A2DP codec configuration is accepted from the remote device, then don't trigger codec reconfiguration. Bug: 74521894 Test: Manual: accept connection and codec config from A2DP Sink Change-Id: Ic2f6ff08d130adf85cad68a54ab9fbc0a711534c (cherry picked from commit d578ae12)
-
- Mar 27, 2018
-
-
Pavlin Radoslavov authored
Use the existing mechanism for selecting the A2DP Source codec to select the A2DP Sink codec when the local device is A2DP Sink. * Added new method BtaAvCo::SelectSinkCodec() similar to SelectSourceCodec() and use the new method to select the actual codec based on the AVDTP Codec capability discovery. * Renamed method BtaAvCo::UpdateSelectableCodec() to UpdateSelectableSourceCodec() and added similar UpdateSelectableSinkCodec() * Renamed method BtaAvCo::AttemptCodecSelection() to AttemptSourceCodecSelection() and added similar AttemptSinkCodecSelection * Renamed AudioSinkHasContentProtection() to AudioSepHasContentProtection() because it can be used for either A2DP Source or Sink * Removed method BtaAvCo::FindPeerSourceSepForCurrentCodec() because it is not needed anymore. * Added new method A2dpCodecs::findSinkCodecConfig() similar to findSourceCodecConfig() * Added new function A2DP_SinkCodecIndex() similar to A2DP_SourceCodecIndex() * Added new method A2dpCodecs::setSinkCodecConfig() * Reorganize the SBC and AAC Source/Sink codec config classes: - Virtual method A2dpCodecConfig::setCodecConfig() is now implemented for Sink codecs as well: SBC Sink, AAC Sink - Renamed A2dpCodecConfigSbc to A2dpCodecConfigSbcSource - Renamed A2dpCodecConfigAac to A2dpCodecConfigAacSource - Added base class A2dpCodecConfigSbcBase. That class implements method setCodecConfig() for both A2dpCodecConfigSbcSource and A2dpCodecConfigSbcSink - Added base class A2dpCodecConfigAacBase. That class implements method setCodecConfig() for both A2dpCodecConfigAacSource and A2dpCodecConfigAacSink - Updated the A2dpCodecConfigAacBase::setCodecConfig() so it computes correctly the AAC Variable Bit Rate Support flag in the result codec config: The Variable Bit Rate Support is disabled if either side disables it. * Removed A2DP_BuildSrc2SinkConfig() because it is not needed anymore. The correspinding A2DP_BuildSrc2SinkConfigSbc() and A2DP_BuildSrc2SinkConfigAac() are removed as well. * Renamed a2dp_sbc_caps inside a2dp_sbc.cc to a2dp_sbc_source_caps * Renamed a2dp_aac_caps inside a2dp_aac.cc to a2dp_aac_source_caps * Added corresponding unit tests Bug: 74521894 Test: Manual: initiate connection from A2DP Sink. Unit tests in system/bt: test/run_unit_tests.sh net_test_stack Change-Id: I3fc541a068993c123e8d61c209896bb758fd3764 (cherry picked from commit ebc2dab0)
-
- Mar 26, 2018
-
-
TreeHugger Robot authored
-
Ajay Panicker authored
-
Jakub Pawlowski authored
-
Jakub Pawlowski authored
Bug: 76217773 Change-Id: I50188e9c69dbcd42286097cb6fbc1aa715877c80 (cherry picked from 60911bea640978984fffb925248e630ea9590a61)
-
Ajay Panicker authored
You can now use the new AVRCP Profile by setting persist.bluetooth.enablenewavrcp to true. Also fix a misundestanding with connection_handler.cc. AVRCP Control callbacks return a null address when disconnecting. Bug: 68854188 Test: Check to see that the profile is used when property is true and is not used when property is false. Change-Id: I4aa285c6bf009716cc80a80b813ba0acd3d8f9d8 (cherry picked from commit ce1a2b3f8d44a017c13a55b5e53abb51886297ad) Merged-In: I4aa285c6bf009716cc80a80b813ba0acd3d8f9d8
-
Ajay Panicker authored
Allows the AVRCP Service Interface to be retrieved via bt_interface_t. Bug: 68854188 Test: Compile Change-Id: I0d9464ea19d3bd382d07134bff057a5515501b95 (cherry picked from commit 66401790c29f13b30c15f035933366f36637df21) Merged-In: I0d9464ea19d3bd382d07134bff057a5515501b95
-
- Mar 24, 2018
-
-
Jakub Pawlowski authored
There is no functional change, just making the code pretty, and updating names to match 5.0 specification. Test: sl4a AdvertisingSetTest:test_reenabling Bug: 74198564 Change-Id: I1811e19bd18470adda55f7af7cfee23bcc4d1871 (cherry picked from commit 8e6b9a9760efa5aba116355b4216610e75a54a49)
-
Jakub Pawlowski authored
Fail on calls to ACPF when it's not supported in controller. Right now we sent such commands when starting/stopping the regular scan. Bug: 69116550 Test: Enable bluetooth on platform without ACPF, start/stop scan Change-Id: I334114d36a8af8c8f58d230f75ab3a00f009c4c5 (cherry picked from commit cf811d66915a6d2c76a7ada2b7f64f0c4014e671)
-
Nitin Shivpure authored
Usecase: 1) Connect to HOGP device. (Because of some condition encryption fails with Connection Timeout, remote device turned off when connection was initiated) 2) Try to connect again to HoGP device Expected Result: Connection should be successful Observed Result: UI stuck in connecting state and connection never succeeds. Root cause: When encryption fails in previous iteration, encryption happens before HoGP Server starts security procedure, leading to Encryption Complete event being received with wrong status. Fix: Update the status to success when sending encryption complete event if link is already encrypted Test: Issue is not seen after above steps Fixes: 76133015 Change-Id: Ib404cf157289170ea300eae40f51393606c35105 (cherry picked from commit 17d692578102d73bcf30b00442cdd456e92a7912)
-
- Mar 23, 2018
-
-
Jakub Pawlowski authored
Bug: 75311714 Test: Test scenario described in bug Change-Id: Ib2da24134205277ae03cf28394db74758de17e5d (cherry picked from commit 61dfe5ccf014aa17cbe800b1195afdb7e474a376)
-
Jakub Pawlowski authored
Reject invalid data length for advertisement data. Also, don't attempt to resolve anonymous advertising addresses. Test: LE scanning tests Bug: 73193883 Change-Id: I1cb330bc30fdcaebc86527cd2656c9dd7932b318 (cherry picked from commit 47efa5b569e8dfa6c4397f0a9598d8137f71a05f)
-
Pavlin Radoslavov authored
Test: Code compilation Bug: 74952724 Change-Id: I022e16940c73181f991d528b9c96e2d26151369f (cherry picked from commit e445b5b8b9225a882136a1c941cf77055540a554)
-