Skip to content
Snippets Groups Projects
  1. Apr 05, 2018
  2. Apr 02, 2018
    • Stanley Tng's avatar
      Handle bad packet length in gatts_process_read_req · f4ef07fb
      Stanley Tng authored
      Added error check and handling code in gatts_process_read_req to
      make sure that the packet length is correct.
      
      Bug: 73172115
      Test: Run the test program, poc, that was attached in the bug report
      Change-Id: I375853987010c87432e73b75d659eabee852ec9c
      f4ef07fb
  3. Mar 31, 2018
    • Pavlin Radoslavov's avatar
      Reduce the number of PCM data reads for aptX and aptX HD · 7fc5d7dc
      Pavlin Radoslavov authored
      For every periodic aptX / aptX HD data packet, use a single read
      operation for all PCM data that needs to be encoded, instead of
      using multiple reads of smaller blocks of data.
      
      Bug: 70899260
      Test: Manual: stream to aptX/aptX HD headset, change the sample rate
      Change-Id: Ifcb8302589f24f5d7ab89c645c50d6905197fb7f
      Merged-In: Ifcb8302589f24f5d7ab89c645c50d6905197fb7f
      (cherry picked from commit fbfffe53)
      7fc5d7dc
    • Myles Watson's avatar
      PAN: Always allocate in bta_pan_data_buf_ind_cback · 15c2e335
      Myles Watson authored
      Change I63b857d031c55d3a0754e4101e330843eb422b2a caused a double
      free.  Move the free call to pan_data_buf_ind_cb().
      
      Free the buffer before every return in pan_data_buf_ind_cb.
      
      Bug: 74950468
      Test: manual tethering test with DUT sharing its connection
      Change-Id: If4526f3042699581e2cdde79a362eef0f83768eb
      Merged-In: If4526f3042699581e2cdde79a362eef0f83768eb
      15c2e335
  4. Mar 30, 2018
  5. Mar 29, 2018
  6. Mar 28, 2018
    • TreeHugger Robot's avatar
    • Srinu Jella's avatar
      Serialize the commands during Pairing process · 2a280477
      Srinu Jella authored
      Steps:
      1. Pair and connect with HID mouse.
      2. Once the settings UI shows paired and connected
      3. Try to unpair the device, but UI still shows connected.
      
      Failure: Unable to unpair HID mouse due to LMP
      response timeout occurred for  remote version and remote
      feature request.
      
      Root Cause: Remote version, Remote features, Authentication
      requested commands go simultaneously to the remote device
      which can't handle the multiple commands at a time.
      
      Fix: Serialize the Remote version, Remote features, Authentication
      requested commands.
      
      Test: Tested manually with apple magic mouse.
      Bug: 35125883
      
      Change-Id: I4448c291a60ee637dc5927806547e67f26571d86
      (cherry picked from commit 485f6429)
      2a280477
    • Hansong Zhang's avatar
      Revert "HID: Fix the behavior of virtual_cable_unplug" · ec948407
      Hansong Zhang authored
      This reverts commit 87b96013.
      
      Reason for revert: Connected HID keyboard won't unpair
      Bug: 76907578
      Test: SL4A
      Change-Id: I7d289183ac05b5f926c145799418461377228569
      (cherry picked from commit 25694ec900e61d5235ee65461d46495b5ae4cdcf)
      ec948407
    • Pavlin Radoslavov's avatar
      Changed the default configured sample rate for aptX/aptX-HD to 48.0kHz · d32815dc
      Pavlin Radoslavov authored
      Previously, the default configured sample rate for aptX and aptX-HD
      was 44.1kHz. However, during AVDTP codec setup, the initial codec
      setup to 44.1kHz was followed immediately with automatic codec
      reconfiguration to 48.0kHz (if supported by the remote device)
      so the highest possible sample rate will be used.
      
      Changing the default sample rate to 48.0kHz eliminates the
      transient initial codec setup of 44.1kHz, because it is unnecessary
      and error-prone.
      
      Bug: 69276823
      Test: Manual: connect to aptX / aptX-HD headsets and examine the AVDTP codec
            configuration in the btsnoop logs.
      Change-Id: I9e22365e0f07690c87503ea52fd9bb4d1ad4d5ff
      (cherry picked from commit 50a8659e)
      d32815dc
    • TreeHugger Robot's avatar
    • TreeHugger Robot's avatar
      Merge "Fix crash in Log" into pi-dev · 55e7ad04
      TreeHugger Robot authored
      55e7ad04
    • Jack He's avatar
      HFP: Save discovered HFP version to config file · 0ea9ee0d
      Jack He authored
      * Store discovered HFP version to btif config file so that a
        reconnection session knows the HFP version before SDP
      * Check stored HFP version when RFCOMM channel is open before any AT
        command is processed
      * Set peer HFP version to 0 on control block allocation
      
      Bug: 67938255
      Test: Connect with HFP 1.7 headsets
      Change-Id: I43e7aa04dee17ea7ba9e7d3992ec0860c11d23bc
      (cherry picked from commit 483217bf)
      0ea9ee0d
    • Joseph Pirozzo's avatar
      Fix crash in Log · a07f1914
      Joseph Pirozzo authored
      Correct parameter order.
      
      Bug: 77009945
      Test: observe log message
      Change-Id: I69d4bc04936c322707111c825864007b7f257cc4
      (cherry picked from commit bbd4f009)
      a07f1914
    • Pavlin Radoslavov's avatar
      Suppress unnecessary A2DP codec reconfiguration · dcd4c5c4
      Pavlin Radoslavov authored
      If OTA A2DP codec configuration is accepted from the remote
      device, then don't trigger codec reconfiguration.
      
      Bug: 74521894
      Test: Manual: accept connection and codec config from A2DP Sink
      Change-Id: Ic2f6ff08d130adf85cad68a54ab9fbc0a711534c
      (cherry picked from commit d578ae12)
      dcd4c5c4
  7. Mar 27, 2018
    • Pavlin Radoslavov's avatar
      A2DP Sink: add a mechanism for selecting the codec · 5e740cc6
      Pavlin Radoslavov authored
      Use the existing mechanism for selecting the A2DP Source codec to
      select the A2DP Sink codec when the local device is A2DP Sink.
      
      * Added new method BtaAvCo::SelectSinkCodec() similar to
        SelectSourceCodec() and use the new method to select the actual
        codec based on the AVDTP Codec capability discovery.
      * Renamed method BtaAvCo::UpdateSelectableCodec() to
        UpdateSelectableSourceCodec() and added similar
        UpdateSelectableSinkCodec()
      * Renamed method BtaAvCo::AttemptCodecSelection() to
        AttemptSourceCodecSelection() and added similar
        AttemptSinkCodecSelection
      * Renamed AudioSinkHasContentProtection() to AudioSepHasContentProtection()
        because it can be used for either A2DP Source or Sink
      * Removed method BtaAvCo::FindPeerSourceSepForCurrentCodec() because it
        is not needed anymore.
      * Added new method A2dpCodecs::findSinkCodecConfig() similar to
        findSourceCodecConfig()
      * Added new function A2DP_SinkCodecIndex() similar to
        A2DP_SourceCodecIndex()
      * Added new method A2dpCodecs::setSinkCodecConfig()
      * Reorganize the SBC and AAC Source/Sink codec config classes:
        - Virtual method A2dpCodecConfig::setCodecConfig() is now implemented
          for Sink codecs as well: SBC Sink, AAC Sink
        - Renamed A2dpCodecConfigSbc to A2dpCodecConfigSbcSource
        - Renamed A2dpCodecConfigAac to A2dpCodecConfigAacSource
        - Added base class A2dpCodecConfigSbcBase. That class implements
          method setCodecConfig() for both A2dpCodecConfigSbcSource and
          A2dpCodecConfigSbcSink
        - Added base class A2dpCodecConfigAacBase. That class implements
          method setCodecConfig() for both A2dpCodecConfigAacSource and
          A2dpCodecConfigAacSink
        - Updated the A2dpCodecConfigAacBase::setCodecConfig() so it computes
          correctly the AAC Variable Bit Rate Support flag in the result codec
          config: The Variable Bit Rate Support is disabled if either side
          disables it.
      * Removed A2DP_BuildSrc2SinkConfig() because it is not needed anymore.
        The correspinding A2DP_BuildSrc2SinkConfigSbc() and
        A2DP_BuildSrc2SinkConfigAac() are removed as well.
      * Renamed a2dp_sbc_caps inside a2dp_sbc.cc to a2dp_sbc_source_caps
      * Renamed a2dp_aac_caps inside a2dp_aac.cc to a2dp_aac_source_caps
      * Added corresponding unit tests
      
      Bug: 74521894
      Test: Manual: initiate connection from A2DP Sink.
            Unit tests in system/bt: test/run_unit_tests.sh net_test_stack
      
      Change-Id: I3fc541a068993c123e8d61c209896bb758fd3764
      (cherry picked from commit ebc2dab0)
      5e740cc6
  8. Mar 26, 2018
  9. Mar 24, 2018
    • Jakub Pawlowski's avatar
      Use proper HCI_ERR_* constants in advertisement termination handling · 1afeb16b
      Jakub Pawlowski authored
      There is no functional change, just making the code pretty, and updating
      names to match 5.0 specification.
      
      Test: sl4a AdvertisingSetTest:test_reenabling
      Bug: 74198564
      Change-Id: I1811e19bd18470adda55f7af7cfee23bcc4d1871
      (cherry picked from commit 8e6b9a9760efa5aba116355b4216610e75a54a49)
      1afeb16b
    • Jakub Pawlowski's avatar
      Guard ACPF with proper checks · 1014501a
      Jakub Pawlowski authored
      Fail on calls to  ACPF when it's not supported in controller.
      Right now we sent such commands when starting/stopping the regular scan.
      
      Bug: 69116550
      Test: Enable bluetooth on platform without ACPF, start/stop scan
      Change-Id: I334114d36a8af8c8f58d230f75ab3a00f009c4c5
      (cherry picked from commit cf811d66915a6d2c76a7ada2b7f64f0c4014e671)
      1014501a
    • Nitin Shivpure's avatar
      HOGP: Update status to OK, if link is already encrypted · 9798f308
      Nitin Shivpure authored
      Usecase:
      1) Connect to HOGP device. (Because of some condition encryption fails with Connection
         Timeout, remote device turned off when connection was initiated)
      2) Try to connect again to HoGP device
      
      Expected Result:
      Connection should be successful
      
      Observed Result:
      UI stuck in connecting state and connection never succeeds.
      
      Root cause:
      When encryption fails in previous iteration, encryption happens before HoGP Server starts
      security procedure, leading to Encryption Complete event being received with wrong status.
      
      Fix:
      Update the status to success when sending encryption complete event if link is already
      encrypted
      
      Test: Issue is not seen after above steps
      
      Fixes: 76133015
      Change-Id: Ib404cf157289170ea300eae40f51393606c35105
      (cherry picked from commit 17d692578102d73bcf30b00442cdd456e92a7912)
      9798f308
  10. Mar 23, 2018
Loading