Skip to content
Snippets Groups Projects
  1. Aug 08, 2018
  2. Aug 07, 2018
    • Joseph Pirozzo's avatar
      Reduce Media State change callbacks · 306c6ca1
      Joseph Pirozzo authored
      Eliminate the 2 second timer and only update media state when it
      changes.
      
      Bug: 28917369
      Test: Play music, pause and change its position observe status is
      correct.
      
      Change-Id: Iaf17e8cde570651706c55603b01c5100d4c60aa4
      306c6ca1
    • Pirama Arumuga Nainar's avatar
      Reorder static libs to appease ld.gold linker · 9ecbd6eb
      Pirama Arumuga Nainar authored
      Bug: http://b/112277682
      Bug: http://b/79419131
      
      Lld, which is the default linker for the platform, is able to resolve
      symbols across libraries irrespective of the order they appear in the
      command line.  This was not the case for ld.gold and other linkers.
      Unfortunately, there are some targets that still rely on ld.gold
      (pgo-taimen-config1 in internal release branch being one of
      them).
      
      With http://aosp/721652, libbt-stack should be added before libbt-common
      so MessageLoopThread::~MessageLoopThread is resolved correctly.  If not,
      the following error is reported by gold:
      
      system/bt/stack/btu/btu_init.cc:41: error: undefined reference to
      'bluetooth::common::MessageLoopThread::MessageLoopThread(std::__1::basic_string<char,
      std::__1::char_traits<char>, std::__1::allocator<char> > const&)'
      
      Test: m USE_CLANG_LLD=false
      Change-Id: I9c8208218ffb4bb027ad75b51bcd484e9bb37368
      9ecbd6eb
    • Joseph Pirozzo's avatar
      AVRCP Controller metadata feature · 46398430
      Joseph Pirozzo authored
      Process the METADATA feature flag separately from the VENDOR feature
      flag to ensure it doesn't get overwritten.
      
      Bug: 110039732
      Test: connect avrcp from phone verify getCapabilities events supported
      is sent.
      
      Change-Id: Ib5d54c13d6c912904f20e8760f1632fa5737b98f
      46398430
  3. Aug 06, 2018
  4. Aug 03, 2018
  5. Aug 02, 2018
    • Jack He's avatar
      Use MessageLoopThread in A2DP source, JNI, BTA, HCI and module bring-up · ca544f4a
      Jack He authored
      am: 63d2fa3e
      
      Change-Id: I1093576b83d19cac3a11ff4d81173d97604d2a4d
      ca544f4a
    • Jack He's avatar
      Add MessageLoopThread, ExecutionBarrier, and performance tests · 148a4b50
      Jack He authored
      am: 0ac5b1b6
      
      Change-Id: I040d328e642b351420f9a1f4eb35e6c0dc09a74e
      148a4b50
    • Jack He's avatar
      Use MessageLoopThread in A2DP source, JNI, BTA, HCI and module bring-up · 63d2fa3e
      Jack He authored
      * Replace OSI thread with MessageLoopThread in
        - btif_a2dp_source (A2DP encoding thread)
        - btif_core (JNI thread)
        - btu_init (BTA thread)
        - hci_layer (HCI thread)
        - module (module bring up thread)
        - various unit test threads
      * Code that uses reactor from OSI thread is not replaced in this change
        because they need to move from using reactor to message loop first
      * Main difference:
        - HCI layer no longer has access to mutex protecting message loop
          set up and tear down. Messages posted to thread after ShutDown()
          is called become no-op
        - In all cases QuitClosure() is used instead of QuitWhenIdleClosure().
          This means that we will never force kill a thread. An infinite loop
          will delay the shutdown of Bluetooth stack.
      * do_in_hci_thread is actually do_in_bta_thread
      * Move the definition of do_in_bta_thread from bta to btu since btu is
        where the thread actually lives
      * Remove bta_closure_api.h and replace it with stack/include/btu.h
      * Remove header inclusion in bta_sys.h and include stack/include/btu.h
        in individual compilation units
      * Fixed a bug in btif_cleanup_bluetooth where btif_jni_disassociate()
        was not called on the JNI thread
      * Make setting real time priority a requirement
      * Crash during the following scenario:
        - When btif_profile_queue cleanup failed to be scheduled on JNI thread
        - When A2DP encoder thread failed to gain real time priority
        - When BTA thread failed to start up
        - When BTA thread failed to gain real time priority
        - When BTA thread failed to schedule its first callback
      * Turn off Bluetooth in the following scenario:
        - When HCI thread failed to gain real time priority
        - When bt_workqueue thread failed to gain real time priority
      
      Bug: 110303473
      Test: make, native and Java unit tests,
            Connect to headset and listen to music through A2DP,
            testplans/details/184455/3975
      Change-Id: Ib448992fc0ba5af82c2d117dd65f1abd45d2acb6
      63d2fa3e
    • Jack He's avatar
      Add MessageLoopThread, ExecutionBarrier, and performance tests · 0ac5b1b6
      Jack He authored
      * Add MessageLoopThread to abstract thread implementation to our code
      * Add ExecutionBarrier utility class to help with thread synchronization
      * Add more performance tests and performance benchmarks to evaluate
        execution efficiency in both batch and sequential usages, for various
        thread implementations including:
        - libosi reactor on pthread
        - MessageLoop on libosi reactor on pthread
        - MessageLoop on STL std::thread
        - MessageLoop on Posix pthread
        - MessageLoop on libchrome base::Thread
        - MessageLoop on MessageLoopThread
      
      Bug: 110303473
      Test: make, native and Java unit tests,
            test/run_benchmarks.sh net_benchmark_thread_performance,
            test/run_unit_tests.sh net_test_performance,
            test/run_unit_tests.sh bluetooth_test_common,
            testplans/details/184455/3975
      Change-Id: I5b4ce2ee910a0f1d2edf95e0296916dea04d3f89
      0ac5b1b6
  6. Aug 01, 2018
  7. Jul 31, 2018
  8. Jul 30, 2018
  9. Jul 27, 2018
  10. Jul 26, 2018
  11. Jul 25, 2018
  12. Jul 24, 2018
  13. Jul 18, 2018
    • Hansong Zhang's avatar
      Clean up style in BLE White List code · c69dbfbf
      Hansong Zhang authored
      am: 555a8d03
      
      Change-Id: Ia4cee8a5437c430dc75fbf16db9cc381ed4f2e1c
      c69dbfbf
    • Hansong Zhang's avatar
      Clean up style in BLE White List code · 555a8d03
      Hansong Zhang authored
      * Remove unused code
      * Update BgConnHash to return size_t for hashcode
      * Change BLE scan_int and scan_win to uint16_t according to spec
      
      Bug: 111562702
      Test: SL4A BLE test and manual with BLE mouse
      Change-Id: Ieff3acbfaa95b7d804e57021d562218d9fbe42cc
      555a8d03
    • Cheney Ni's avatar
      Ignore SDP failure while bonding if SDP was not attempted · 22062116
      Cheney Ni authored
      When bonding, there is an ACL_UP event to the upper layers and some apps
      may want to fetch SDP in return. This can break pairing. In cases SDP fails,
      it causes the procedure to be finished before the LinkKey is generated.
      And thus the LinkKey is not committed to NVRAM and the device is not paired.
      
      Bug: 111189110
      Test: : Pair / Unpair BT accessories manually
      Change-Id: Iaefbe8b6c1fc3e78f0f120220992df84699a2eb8
      22062116
  14. Jul 17, 2018
Loading