Skip to content
Snippets Groups Projects
  1. Jun 06, 2024
  2. Jun 04, 2024
  3. Jun 03, 2024
    • Ioannis Ilkos's avatar
      Publish TracingServiceProxy after storage has been unlocked · 5a104f2b
      Ioannis Ilkos authored
      TracingServiceProxy depends on external system services to forward its
      requests to. There is an edge case where reportTrace was called before
      the encrypted storage was unlocked and before external services can be
      bound (e.g. occurs when reportTrace is concurrent to system_server
      starting up).
      
      This change defers the registration of the service until we are ready to
      accept requests. As a side-effect this also means that the device needs
      to be unlocked before the service is published.
      
      Bug: 333846370
      Test: atest PerfettoReporterTest
      Test: boot device without lock and invoke perfetto reporting (verify the report is accepted immediately)
      Test: boot device with lock and invoke perfetto reporting (verify the report is accepted after unlocking)
      Test: invoke perfetto reporting concurrent to kill -9 `pidof system_server`
      Change-Id: Ibb75c3e314d30b18cdc32e3774be1ee8022960b1
      5a104f2b
    • Olivier Gaillard's avatar
      Increase the dropbox disk quota to 20Mb for user debug builds as we add more... · fc26cff6
      Olivier Gaillard authored
      Increase the dropbox disk quota to 20Mb for user debug builds as we add more debug to dropbox for user debug.
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ea261f6a2a9d1034abfaf2ebdaae72c9869c8c90)
      Merged-In: Ib758fa6fa47cfd26e895bf8d7b9d5bde98c99461
      Change-Id: Ib758fa6fa47cfd26e895bf8d7b9d5bde98c99461
      fc26cff6
    • Mitch Phillips's avatar
      Workaround bad GC of tombstone watcher. · 476ed072
      Mitch Phillips authored
      There's some bad behaviour going on that's exclusive to WatchOS
      (discovered on the Pixel Watch 2). The TombstoneWatcher class is
      responsible for watching the /data/tombstones/ directory. It is a member
      of the NativeTombstoneManager class, which is created when
      ActivityManager starts, and lives until the device is powered off.
      
      Unfortunately, some bad behaviour (unclear exactly what at this stage)
      means that the TombstoneWatcher class is spuriously garbage collected,
      even though the parent NativeTombstoneMenager class is still alive and
      reachable. I chatted with hboehm@ from the ART team, and his hypothesis
      is that because the TombstoneWatcher member is initialized in the
      constructor and never used again, some optimiser is doing the wrong
      thing and thinking that it's unused and can be GC'd.
      
      The TombstoneWatcher uses inotify in native code to execute a callback
      when a file is added to a directory, so it's clearly in use, but
      unfortunately the bug allows this class to be GC'd anyway.
      
      What this means, in practice, is that app native crashes on WatchOS are
      not being handled correctly. This includes:
       - Apps cannot get their own crashes through the
         ApplicationExitInfo::getHistoricalProcessExitReasons API.
       - Crash reports are never sent to Google, with the exception of
         tombstones that last until the next reboot, where they're one-time
         scooped up and sent to Google. This has substantially increased
         latency (requires a reboot) and also probably drops quite a number of
         reports because there's a limit of tombstones on the device, and a
         rate limit of how many are sent by GMS.
      
      Bug: 339371242
      Test: atest CtsGwpAsanTestCases on eos (Pixel Watch 2, WatchOS)
      Change-Id: I9226e4368b03bd4742fccdafde6018f145da63e6
      476ed072
    • lijilou's avatar
      AccessibilityWindowsPopulator:fix CWE problem by add mLock in dump · c6feab91
      lijilou authored
      method.
      
      Accessing mDisplayInfos, mInputWindowHandlesOnDisplays and other
      collections should add mLock lock according to AOSP requirements.
      
      Test: OEM monkey test
      Bug: 344434136
      Change-Id: Icb18683680c40939e0ebd352818702f90b79179f
      c6feab91
    • b0202.jung's avatar
      Fix focused error of embedded task fragments · a209eafe
      b0202.jung authored
      If a display has freeform windowing environments such as Desktop
      or XR device, then resumed activity of task fragment will be set
      to focused app. However, it can break focused state in embedded
      task fragments.
      
      Thus, allow it only if a focused task is different from a next task.
      
      Bug: 343252725
      Test: Settings(AE) > Launch SubSettings > Check focused app/window
      Change-Id: Ib62ecb7c8e0fe453149f51c610c34d97bbde7cb1
      a209eafe
  4. Jun 02, 2024
  5. May 31, 2024
  6. May 29, 2024
  7. May 28, 2024
    • Edward Savage-Jones's avatar
      Add missing newline in notification cmd usage · 9df37a58
      Edward Savage-Jones authored
      The help/usage text for the notification cmd is not wrapped
      correctly when displaying the 'allow_dnd' parameter.
      
      This was introduced in commit 08d381b8.
      
      Test: manual, run cmd notification and check the wrapping
      Change-Id: I9a7af1d9e3de91c9124f21eb66817bb73a3512be
      9df37a58
  8. May 25, 2024
  9. May 24, 2024
  10. May 22, 2024
  11. May 20, 2024
  12. May 17, 2024
  13. May 16, 2024
    • 张倞诚's avatar
      Fixed device restart caused by starting Activity under split-screen root task. · 2f5d3e9f
      张倞诚 authored
      The root task used for split screen contains two or more sub-tasks. In this case, the activity should not be allowed to be started under the root task, which will cause a null pointer and cause the device to restart. Therefore, when the activity is started by specifying the taskid, check that the task is leaftask.
      
      Change-Id: I095feb549ce2d3a4e61d999a342f64bea8264288
      2f5d3e9f
  14. May 15, 2024
    • Suprabh Shukla's avatar
      Use metered firewalls for metered uid policy · 68e9bc59
      Suprabh Shukla authored
      Since the underlying code in connectivity manager is moving to metered
      firewalls to denote the uid policy for metered restrictions, NPMS can
      start using them now.
      Rather than having a single PENALTY_BOX, we have separate firewalls for
      user and admin imposed restrictions. Once NPMS uses the appropriate
      firewalls for these, it does not need to separately convey the blocked
      reasons for metered restrictions on uids to the ConnectivityManager.
      
      Flag: com.android.server.net.use_metered_firewall_chains
      
      Test: atest FrameworksServicesTests:NetworkManagementServiceTest
      Test: atest FrameworksServicesTests:NetworkPolicyManagerTest
      Test: atest CtsHostsideNetworkPolicyTests
      
      Bug: 336693007
      Change-Id: I8da11ff663257d3dafcb5e22ae3313a9255ef0a6
      Merged-In: I8da11ff663257d3dafcb5e22ae3313a9255ef0a6
      68e9bc59
    • Fabien Sanglard's avatar
      Add vm name and version to am capabilities · 40a79783
      Fabien Sanglard authored
      This CL is part of the go/kddm project, to deprecate DDM protocol.
      HELO packet currently return the VM name and version, this CL allows
      to retrieves the same invo from a tool accessible from shell.
      
      The data is retrieved the same way it is retrieved in DdmHandleHello.
      handleHELO (System.getproperty).
      
      Test: NA
      Bug: go/kddm
      
      Change-Id: Id5cf9bf768f397bf3595e577f0da7a001b7ec394
      40a79783
    • 张倞诚's avatar
      Fix incorrect gid config leads to process/system cannot start. · a7d6c674
      张倞诚 authored
      We found that if the system application misconfigures the gid in the permissions, -1 will be added to the application's gid list, which will cause the application process or system startup to fail, so consider adding a check to prevent this unexpected situation.
      
      Change-Id: Ic3133067285ecfd9310b4bca56ff402180e7c2aa
      a7d6c674
  15. May 14, 2024
    • Divya Dubey's avatar
      Do not overwrite user set or live wallpapers · 5d602200
      Divya Dubey authored
      WallpaperUpdateReceiver unconditionally updates the wallpaper
      to the default_wallpaper when DEVICE_CUSTOMIZATION_READY is
      received.
      
      This overwrites live wallpapers and user set wallpapers.
      Just clear the wallpaper when there is no live wallpaper to
      avoid this from happening.
      
      Test: set a wallpaper and run
      adb shell am broadcast \
        -a android.intent.action.DEVICE_CUSTOMIZATION_READY \
        -f 0x01000000
      
      Bug: 159673283
      Change-Id: I385c28be84b9146e8620910258495f5d71b9c04e
      5d602200
    • guangkui.ren's avatar
      Fix potential crash issue in NonRequiredPackageDeleteObserver · 43d93da7
      guangkui.ren authored
      mLatch.notifyAll() will not help wake the thread which is blocked by
      mLatch.await, instead, it will cause system server crash.
      
      So, mark state as failed if any package is failed to be deleted, and let
      mLatch.countDown work until it comes to 0 and wake the thread blocked by
      await.
      
      Bug: 333845008
      Change-Id: Ida1c3c128ddef376aaaacda1358717d0d4e9ca8b
      43d93da7
    • xialei6's avatar
      [Bugfix] Fix the issue where the spatializer available status could not be updated · 3a8f2e01
      xialei6 authored
      
      When a device (such as a projection device) is connected, the spatializer available status should be updated regardless of whether this feature is turned on or not. Because other functions (such as the spatializer UI switch) need to change according to the spatializer available status.
      
      Change-Id: I43d6d5d0ea4d69a0d4559390dcf34885b96bc488
      Signed-off-by: default avatarxialei6 <xialei6@xiaomi.com>
      3a8f2e01
  16. May 13, 2024
  17. May 11, 2024
  18. May 10, 2024
    • Shrinidhi Hegde's avatar
      Update rollback reason in logging. · fcbc9671
      Shrinidhi Hegde authored
      Noticed that Rollback reason during boot loop was getting logged and
      unknown because of a missing reason to string map. Updated that.
      
      Test: manual
      Bug: 291137901
      Change-Id: I2ea6206d07099a413aeeca464e0d1ebd97c04840
      fcbc9671
    • liutianxiang's avatar
      audio: add USAGE_UNKNOWN to mediaActive condition · 1bd69280
      liutianxiang authored
      
      1.If an app play media but the usage of attributes is unknown, musicActivecheck should be started.
      2.USAGE_UNKNOWN default value is MEDIA.
      3.Otherwise, the mMusicActiveMs will not increase for safe volume when above safe volume.
      4.Users listen to music until 20 hours later but the volume does not drop.
      
      Change-Id: I5f84b2c6376b283376d65d398e880a8716c98f59
      Signed-off-by: default avatarliutianxiang <liutianxiang@xiaomi.com>
      1bd69280
    • 张倞诚's avatar
      Support dumping according to package name in the PermissionService · 8c717188
      张倞诚 authored
      Package name is more commonly used than appid, so we hope to support obtaining permission and appop status based on package name.
      
      Change-Id: I4f0e9bcb979132d99222cadaf306034bf58e092a
      8c717188
  19. May 09, 2024
    • Alexei Nicoara's avatar
      Update OWNERS · 65ff85f1
      Alexei Nicoara authored
      Bug: 335982533
      Change-Id: I975641f193917101645cfcf2b78e198801c59a2c
      65ff85f1
    • Harshit Mahajan's avatar
      Fix RescuePartyTest · 00e50067
      Harshit Mahajan authored
      Disable flags in old test, these could be removed during flag cleanup
      
      Bug: 333720513
      Test: atest RescuePartyTest
      Change-Id: If659c702e3348c1c814f922f55d97776b99f2ff8
      00e50067
    • lijilou's avatar
      AppDataHelper:fix ArrayIndexOutOfBoundsException happen in fixAppsDataOnBoot... · 5d3eb229
      lijilou authored
      AppDataHelper:fix ArrayIndexOutOfBoundsException happen in fixAppsDataOnBoot method due to forget add lock.
      
         from the code:
          @GuardedBy("mPm.mInstallLock")
          void reconcileAppsDataLI(String volumeUuid, int userId, @StorageManager.StorageFlags int flags,
                  boolean migrateAppData) {
              reconcileAppsDataLI(volumeUuid, userId, flags, migrateAppData, false /* onlyCoreApps */);
          }
          we should call the  reconcileAppsDataLI method by mPm.mInstallLock.
      
      Bug: 338600619
      Change-Id: I05f8aa84d71d5083c27427e3a9957b456ac57ce4
      5d3eb229
Loading