- May 03, 2024
-
-
Oriol Prieto Gasco authored
Set the container field of aconfig flags Test: printflags --format='{package}:{container}:' | grep "::" Bug: 312769710 Flag: NONE Change-Id: I84fda0d5e9813940609436d825738ff786908ff0
-
- Mar 15, 2024
-
-
Daniel Norman authored
Bug: 329862519 Change-Id: Idf2791496f91a5f0a178d75e2d0020a49e4c2d52
-
- Feb 26, 2024
-
-
Susan Lin authored
Previously, the primary pointer was always set to the most recent pointer down. That is not the expected behavior, as the primary pointer is meant to be the pointer that has been down the longest. This change fixes this so that when a new pointer goes down, the primary pointer is only changed if it is the start of a new pressed gesture. Test: Manual Steps: 1. Run `adb shell setprop log.tag.TouchExplorer DEBUG` to enable TouchExplorer Logs. Restart your device. 2. Install a 3P A11y Service that has Touch Exploration Enabled. 3. Now run `adb logcat | grep "ReceivedPointerTracker”`. 4. Place multiple fingers on the screen and then lift the first one. Note that the `Primary Pointer` is set to the pointer that has been there the longest (not the most recent). Change-Id: Ie05f0aa3da90250327d56f08a347231a4e743b2c
-
- Dec 12, 2023
-
-
Thiébaud Weksteen authored
Enable the linter and capture the current status by annotating Stub classes with @SuppressWarnings. The intent of this series of change is to ensure that all exposed Binder methods from system_server are annotated. Service owners can start using the following annotations on each method: - @EnforcePermission, if a permission is required. The same annotation will be defined on the AIDL interface definition. - @RequiresNoPermission, if no permission is required. - @PermissionManuallyEnforced, if a specific mechanism to enforce permission is required. See go/aidl-enforce-howto for more background information and details on how to migrate interfaces. Test: m lint-check Bug: 220214993 Change-Id: I4a6a48545251dfccad4464bb76a219005d7633b2
-
- Dec 09, 2023
-
-
Jean Chen authored
feat(MultiFingerMultiTap): Use a two-finger double tap instead of a two-finger triple tap in magnification NO_IFTTT=add the multi-finger multi-tap feature without syncing to the old state Bug: 315264770 Test: manual Test:atest FullScreenMagnificationGestureHandlerTest Test:atest WindowMagnificationGestureHandlerTest Change-Id: Ia5993d94f3782b9d805147d4caba6ff72966dbac
-
- Dec 08, 2023
-
-
Candice Lo authored
refactor(magnification): Renaming IWindowMagnificationConnectionCallback as IMagnificationConnectionCallback Considering the connection callback is handling functions more than window magnification operations, we would like to rename it as IMagnificationConnectionCallback. Bug: 310109308 Test: manually. Renaming the class and methods atest IMagnificationConnectionTest atest MagnificationConnectionManagerTest atest MagnificationConnectionWrapperTest Flag: NA Change-Id: Ic2e17dcb40602b97e07c5491f668ae6815240dd9
-
- Dec 07, 2023
-
-
Jean Chen authored
fix(MultiFingerMultiTap): Two-Finger triple tap while zoomed in doesn't zoom out full screen magnification The root cause lies in the state transitioning to another state before the multi-finger multi-tap gesture is completed. After test, we still need to implement a delay to determine whether the gesture is a single tap or a multi-tap. If it is a multi-tap, the ACTION_UP event will interrupt the magnification transition to the panning state. Otherwise, we need to interrupt the magnification transition to the delegating state in ACTION_MOVE to ensure the reachability of the two-finger triple tap (triggerable with ACTION_UP) NO_IFTTT=add the multi-finger multi-tap feature without syncing to the old state Bug: 315225078 Test: manual Test: atest FullScreenMagnificationGestureHandlerTest Change-Id: Ic6176857baf3f006b26b7737a913efe69b7e061f
-
Abirami Kalyan authored
Test: Manual Bug: 312652056 Change-Id: I63ec51b3d842527f88406813e26494f7d3a30f25
-
Linnan Li authored
Because MotionEvent can reuse, so if we async use MotionEvent, we should use it's copy, or it will cause some exception randomly. Bug: 280130713 Test: existing internal+CTS gesture tests Test: atest TwoFingersDownOrSwipeTest Change-Id: I5d123ac19e158a490f0f05e3f3112403ddf4e03e Signed-off-by:
Linnan Li <lilinnan@xiaomi.corp-partner.google.com>
-
- Dec 05, 2023
-
-
Daniel Norman authored
This new location provides a single source of truth for whether the warning must be shown. A11yManagerService is the central system service with complete knowledge of the state of enabled services & service shortcuts. Clients (SysUI, Settings, etc.) should not be calculating this decision themselves. Note: renames flag to cleanup_accessibility_warning_dialog. This flag is not yet rolled out so the rename is effectively just deleting the old flag & adding a new one. NO_IFTTT=New IFTTT tags Bug: 303511250 Test: atest AccessibilityShortcutChooserActivityTest Test: atest AccessibilityManagerServiceTest Test: m RunSettingsRoboTests ROBOTEST_FILTER=ToggleAccessibilityServicePreferenceFragmentTest Change-Id: I76b012443cf510b36cc5b3f7f9ed0a7731312a06
-
- Dec 01, 2023
-
-
Ameer Armaly authored
Bug: 297595990 Test: atest AccessibilityEndToEndTest Change-Id: Ic6fbcdb00ea18f2a5ee2796462eed4ea3cce0e7b
-
Sally authored
This copies some existing classes like AccessibilityCache(ag/6154093) and TouchExplorer and should make it easier to debug problems our clients encounter. Test: manual, "adb shell setprop log.tag.ProxyManager D" and restart Bug: 229123285 Change-Id: I853c08bb5c807797a7983291bcec775129a96484
-
Jean Chen authored
1. ACTION_POINTER_DONW: The two-finger triple tap and two-finger swipe are closely similar gestures when the user doesn't complete the triple tap. To differentiate between these gestures, we implement a delay and utilize the ACTION_UP event to determine whether it's a multi-tap or single-tap gesture. 2. ACTION_MOVE: When the ACTION_MOVE event is triggered before ACTION_PINTER_DONW for second tap, mSecondPointerDownLocation has already been set during the ACTION_POINTER_DOWN of first tap and we stop it transition to the panning state due to a two-finger triple tap (ACTION_UP), so, we need to check the value of mCompletedTapCount for second tap. NO_IFTTT=add the multi-finger multi-tap feature without syncing to the old state Bug: 313721606 Test: manual Test: atest FullScreenMagnificationGestureHandlerTest Change-Id: I136185e96b621f595d4feb8cc774264161237493
-
- Nov 28, 2023
-
-
Candice Lo authored
Considering the connection is handling functions more than window magnification operations, we would like to rename it as IMagnificationconnection. Bug: 310109308 Test: manually. Renaming the class and methods atest IMagnificationConnectionTest atest android.view.accessibility.AccessibilityManagerTest atest MagnificationTest atest CommandQueueTest atest com.android.server.accessibility.magnification.FullScreenMagnificationControllerTest atest MagnificationConnectionWrapperTest atest MagnificationControllerTest atest MagnificationConnectionManagerTest atest WindowMagnificationGestureHandlerTest Flag: NA Change-Id: I6a19621dcf83e3c37b99204631e9bc022e894b5a
-
Candice Lo authored
We would like to rename the methods setScale() as setScaleForWindowMagnification() to provide more precise method names. Bug: 310109308 Test: manually. Renaming methods atest MagnificationTest atest MagnificationConnectionManagerTest atest MagnificationControllerTest atest WindowMagnificationControllerTest atest MagnificationConnectionWrapperTest Flag: NA Change-Id: I0fca90e2f3e99685dc90ea5df03414fb72c6c4a0
-
Candice Lo authored
refactor(magnification): Renaming WindowMagnificationManager class as MagnificationConnectionManager The class WindowMagnificationManager handles stuffs more than magnification window mode. Therefore, we would like to rename the class to improve the readability of our codebase and avoid confusion. Since the class targets at managing the magnification connection operations, we will name it MagnificationConnectionManager. Bug: 310109308 Test: manually. Renaming the class atest MagnificationProcessorTest atest MagnificationControllerTest atest MagnificationConnectionManagerTest atest WindowMagnificationGestureHandlerTest atest AccessibilityManagerServiceTest Flag: NA Change-Id: Ie4d53ba63aa6d6cadf4cf455f1ece534a54cad0a
-
- Nov 23, 2023
-
-
Jean Chen authored
NO_IFTTT=add the multi-finger multi-tap feature without syncing to the old state Bug: 309534286 Test: adb shell device_config put accessibility com.android.server.accessibility.enable_magnification_multiple_finger_multiple_tap_gesture true adb shell stop && adb shell start atest FullScreenMagnificationGestureHandlerTest Change-Id: If17fb390aab0c8a4cdbc968167acd0c85646946b
-
- Nov 22, 2023
-
-
Melody Hsu authored
Flag needs to be read-only, but the flag cannot be updated. A new flag must be created, and this also tests if old flags can be deleted. Bug: 293445881 Test: presubmit Change-Id: Ifbf187ea4b49e41772f537563fcdfffe117d8d74
-
- Nov 17, 2023
-
-
Daniel Norman authored
Bug: 309426390 Test: atest CtsAccessibilityTestCases:AccessibilityManagerTest Change-Id: I4a63583dcd1c7a7c388fb278ec1c1c53c135e934
-
- Nov 16, 2023
-
-
Jean Chen authored
feat(MultiFingerMultiTap): Implement two finger triple tap feature on FullScreenMagnificationGestureHandler NO_IFTTT=add the multi-finger multi-tap feature without syncing to the old state Bug: 297805269 Test: manual Test: adb shell device_config put accessibility com.android.server.accessibility.enable_magnification_multiple_finger_multiple_tap_gesture true adb shell stop && adb shell start atest FullScreenMagnificationGestureHandlerTest Change-Id: Ib2ed22edf47673aa43eab758aaebe69f2020c349
-
Melody Hsu authored
Replace with methods that use ScreenCapture#captureLayers so ScreenCapture#captureDisplay can be removed. Usages in ColorFade are not removed due to b/301083608. Bug: 293445881 Test: Rotate screen with wm.debug.shell disabled Test: Lock and unlock device Test: Take screenshots Test: atest AccessibilityTakeScreenshotTest Change-Id: I71ce63421e018342111d235521b0486ae23840e4
-
- Nov 14, 2023
-
-
Jean Chen authored
The new detecting state and new view port dragging state will overwrite the motion event of the current state, enabling the implementation of the two-finger triple tap feature. NO_IFTTT=copy the code and add IFTTT Bug: 297805269 Test: manual Change-Id: I85c5ff7e170c8c46402b3e97c389ec1c4c48a37c
-
Yabin Huang authored
Change IMMI#onSessionForAccessibilityCreated() and IMMI#unbindAccessibilityFromCurrentClient() to take a user ID. The main motivation is to unblock our on-going project that aims to add concurrent multi-user support in IMMS. All the planned use cases of A11yIME remain unchanged: 1. This CL just makes it clear that A11yIME APIs are not intended to be used from UiAutomator and Proxy A11yService. 2. IMMS does not use user ID yet. A subsequent CL will introduce a user ID verification but our plan is to not break any existing use cases. This is a pure mechanical refactoring (internal IMMS refactoring), which won’t be under any feature flag. Bug: 305829876 Test: atest WmTests && atest FrameworksServicesTests Test: atest CtsAccessibilityTestCases && atest CtsInputMethodTestCases && atest CtsAccessibilityServiceTestCases Change-Id: I835e2ab07cdcbe6367698675f87d5cda160a9b5b
-
- Nov 13, 2023
-
-
Candice Lo authored
refactor(magnification): Renaming WindowMagnificationConnectionWrapper class as MagnificationConnectionWrapper The class handles not only the window mode, but also the fullscreen fullscreen mode. Therefore, we would like to remove "window" from the name to avoid the confusion. Bug: 310109308 Test: manually atest MagnificationConnectionWrapperTest atest WindowMagnificationManagerTest Flag: NA Change-Id: Id09c8609041f34a18934ffaad758982250e1ca77
-
- Nov 08, 2023
-
-
Jean Chen authored
feat(MultiFingerMultiTap): Implement two finger triple tap feature on WindowMagnificationGestureHandler Bug: 297805269 Test: manual Test: adb shell device_config put accessibility com.android.server.accessibility.enable_magnification_multiple_finger_multiple_tap_gesture true adb shell stop && adb shell start atest WindowMagnificationGestureHandlerTest Change-Id: I54dc6727cd29c1d3e83be7817aae624db3994413
-
- Nov 01, 2023
-
-
Jean Chen authored
refactor(MultiFingerMultiTap): Create a list to collect all gestures and finally send them to the GesturesObserver This refactor to makes us easy to monitor new gestures in the codebase with flags. Bug: 297805269 Test: manual Test: atest WindowMagnificationGestureHandlerTest Change-Id: I6dd3a37231f3563d5b79b7a6a675215729553559
-
Jean Chen authored
feat(MultiFingerMultiTap): Request connection and keep the mag button when two finger triple tap is enabled Bug: 297805269 Test: manual Test: atest AccessibilityManagerServiceTest Change-Id: Iccc65e4a615607b375c4a3ed8222655008e4d2ed
-
- Oct 30, 2023
-
-
Jean Chen authored
feat(MultiFingerMultiTap): Send Setting value, SingleFingerTripleTap and TwoFingerTripleTap, to MagnificationGestureHandle for enable feature Add TwoFingerTripleTap to the constructor for AccessibilityInputFilter, which will enable us to implement the feature on window magnification and fullscreen magnification. Add the feature flag check when setting the value of mDetectTwoFingerTripleTap in MagnifictionGestureHandler (not client side) to ensure that the feature is enabled and apply on window and fullscreen Mag. Bug: 297805269 Test: manual Test: atest MagnificationGestureHandlerTest Test: atest FullScreenMagnificationGestureHandlerTest Test: atest WindowMagnificationGestureHandlerTest Change-Id: I851d1ce055a2348044cb9cf2e92942ffb9255b15
-
- Oct 27, 2023
-
-
Ameer Armaly authored
Fix: 271490102 Test: atest AccessibilityOverlayTest Change-Id: I1443d2c98c6ba4801a2e71b247fac7d662173bdf
-
Jean Chen authored
Bug: 297805269 Test: manual Change-Id: I6cc7e2e307bb4d0cb808ff985d9546726d2598ea
-
- Oct 26, 2023
-
-
Jean Chen authored
feat(MultiFingerMultiTap): Add a feature flag and update its value from observing the settings value for AccessibilityInputFilter Add a feature flag and update its value from observing the settings value, so that magnification gesture handler will be update once gesture change. Then settings value ACCESSIBILITY_DISPLAY_MAGNIFICATION_ENABLED will be replaced ACCESSIBILITY_MAGNIFICATION_GESTURE once the feature completement. Bug: 297805269 Test: manual Change-Id: I9e83a2bdccd1e1f73389eccb606f2dff807c6cd2
-
- Oct 25, 2023
-
-
Marvin Ramin authored
Immediately registering VirtualDeviceListener during the AccessibilityManagerService start can lead to issues as this depends on the timing of VirtualDeviceManagerService starting. Instead, only register VirtualDeviceListener when a a11y proxy is registered. Bug: 302519290 Test: atest ProxyManagerTest AccessibilityDisplayProxyTest Change-Id: I80b5213107107de358adcf5d8193fa438ffe55c0
-
- Oct 20, 2023
-
-
Daniel Norman authored
Change-Id: I49d7b92169602c97cff992f44539aaf0e8860669
-
- Oct 19, 2023
-
-
Jean Chen authored
refactor(MultiFingerMultiTap): Rename mDisplayMagnificationEnabledUri to mMagnificationSingleFingerTripleTapEnabledUri Bug: 297805269 Test: manual Change-Id: I1059c915077a132b0ebd1fe433cf9f873b0e9e81
-
Tyler Freeman authored
This avoids a race condition where we start receiving events and trying to send them to the input filter before it's been installed. Fix: 290271948 Test: manual: 1. Turn on magnification shortcut button 2. Tap it repeatedly quickly for like 30 seconds 3. Should not crash. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:f509803cad6652c79871bb0a7b509ba2d1054b67) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6bf1032b01bbbe6956623ae501f96d9964d0e39b) Merged-In: I24f0eafb2479ac7427ba28077e45ba26a9127cc8 Change-Id: I24f0eafb2479ac7427ba28077e45ba26a9127cc8
-
- Oct 18, 2023
-
-
Jean Chen authored
refactor(TwoFingerTripleTap): Rename FLAG_FEATURE_SCREEN_MAGNIFIER to FLAG_FEATURE_MAGNIFICATION_SINGLE_FINGER_TRIPLE_TAP Rename flag and related parameters are used to improve readability Bug: 297805269 Test: manual Change-Id: If9d1e4025534d4d5206652a80919bbdc4828fd09
-
- Oct 17, 2023
-
-
Riley Jones authored
Change involves reorganizing relevant code so that it is testable. Exposed code is documented. Feature flag: -namespace: accessibility -flag: com.android.server.accessibility.disable_continuous_shortcut_on_force_stop Bug: 198018180 Test: atest A11yManagerServiceTest Change-Id: Ic54591590af402115607f2d0f524276d1ec365f7
-
- Oct 13, 2023
-
-
Ameer Armaly authored
This change alters touch exploration behavior by requiring that the finger move a number of pixels defined by the system's scaled touch slop value before it sends a hover event. Fix: 303677860 Test: atest CtsAccessibilityServiceTestCases:TouchExplorerTest FrameworksServicesTests:TouchExplorerTest Change-Id: Ib8dd4de60d5c71f38f8873b9c5c2af1d0c6e6010
-
Daniel Norman authored
Package resource parsing can randomly take a very long time, so we shouldn't hold the singular A11y mLock while doing this parsing or else unrelated threads will be blocked. Introduces a new flag: - namespace: accessibility - flag: com.android.server.accessibility.scan_packages_without_lock Bug: 295969873 Test: Enable/disable the flag. Observe unchanged behavior when installing and uninstalling a11y packages and switching users. Test: atest AccessibilityManagerServiceTest Change-Id: I1bc05403c14bfdd8da7c6621048d93df98f1ddf5
-
- Oct 12, 2023
-
-
Jean Chen authored
refactor(MultiFingerMultiTap): Rename mDetectTriple to mDetectSingleFingerTripleTap before implement TwoFingerTripleTap 1. Enhance naming accuracy to enable clear differentiation between new and existing features. Then add new boolean parameter, mDetectTwoFingerTripleTap, for feature. 2. Remove unnecessary local variables, mDetectTripleTap, in Detecting State and use global variables directly. Bug: 297805269 Test: manual Test: atest MagnificationGestureHandlerTest Test: atest WindowMagnificationGestureHandlerTest Test: atest FullScreenMagnificationGestureHandlerTest Change-Id: I94eb9bc6114a7d562e9f8f8f90970fa96e24c473
-