Skip to content
Snippets Groups Projects
  1. Dec 08, 2023
  2. Nov 03, 2023
  3. Nov 02, 2023
  4. Oct 30, 2023
  5. Oct 27, 2023
  6. Oct 24, 2023
  7. Oct 16, 2023
  8. Oct 13, 2023
  9. Oct 11, 2023
  10. Aug 16, 2023
  11. Jul 14, 2023
    • Nino Jagar's avatar
      Check consents for content protection flow · 6818d765
      Nino Jagar authored
      Specifically:
        1. Package verifier user consent wasn't denied
        2. User is not organization managed
      
      BYPASS_INCLUSIVE_LANGUAGE_REASON=Existing code
      
      Bug: 289127231
      Test: New units, manual end-to-end with Test DPC
      Change-Id: Ice005233cbbb440a09efa162060de40607d8380a
      6818d765
  12. Jun 08, 2023
  13. Jun 05, 2023
  14. Jun 02, 2023
  15. May 31, 2023
  16. May 30, 2023
  17. May 24, 2023
    • Nino Jagar's avatar
      Add flags and options for content protection · 424a88c7
      Nino Jagar authored
      BYPASS_INCLUSIVE_LANGUAGE_REASON=All issues are in the existing code
      which is already in production. New code has no issues.
      
      Bug: 275732576
      Test: Added new tests
      
      Change-Id: I1273107f2d925586271da2638d36094a1ab84c60
      424a88c7
  18. May 19, 2023
  19. May 17, 2023
  20. Mar 22, 2023
    • Kai Li's avatar
      Do not flush when sending view tree appearing event. · d83b1fb1
      Kai Li authored
      This can mitigate the IPC spam by half, since the view tree appearing
      event always comes with a view tree appeared event, and we just need to
      flush at the view tree appeared time.
      
      BYPASS_INCLUSIVE_LANGUAGE_REASON=existing API
      
      Bug: 269435271
      Change-Id: I0ba3f7df7d6b511d155ac9509826d39633b668f6
      Merged-in: I0ba3f7df7d6b511d155ac9509826d39633b668f6
      Test: some unit tests & I've manually tested it locally.
      (cherry picked from commit 624070c9)
      d83b1fb1
  21. Feb 22, 2023
    • Kai Li's avatar
      Do not flush when sending view tree appearing event. · 624070c9
      Kai Li authored
      This can mitigate the IPC spam by half, since the view tree appearing
      event always comes with a view tree appeared event, and we just need to
      flush at the view tree appeared time.
      
      BYPASS_INCLUSIVE_LANGUAGE_REASON=existing API
      
      Bug: 269435271
      Change-Id: I0ba3f7df7d6b511d155ac9509826d39633b668f6
      Test: some unit tests & I've manually tested it locally.
      624070c9
  22. Nov 15, 2022
    • Cole Faust's avatar
      Fix errorprone warnings that should be errors · 7da659bb
      Cole Faust authored
      This commit is part of a large scale change to fix errorprone
      errors that have been downgraded to warnings in the android
      source tree, so that they can be promoted to errors again.
      The full list of changes include the following, but not all
      will be present in any one individual commit:
      
      BadAnnotationImplementation
      BadShiftAmount
      BanJNDI
      BoxedPrimitiveEquality
      ComparableType
      ComplexBooleanConstant
      CollectionToArraySafeParameter
      ConditionalExpressionNumericPromotion
      DangerousLiteralNull
      DoubleBraceInitialization
      DurationFrom
      DurationTemporalUnit
      EmptyTopLevelDeclaration
      EqualsNull
      EqualsReference
      FormatString
      FromTemporalAccessor
      GetClassOnAnnotation
      GetClassOnClass
      HashtableContains
      IdentityBinaryExpression
      IdentityHashMapBoxing
      InstantTemporalUnit
      InvalidTimeZoneID
      InvalidZoneId
      IsInstanceIncompatibleType
      JUnitParameterMethodNotFound
      LockOnBoxedPrimitive
      MathRoundIntLong
      MislabeledAndroidString
      MisusedDayOfYear
      MissingSuperCall
      MisusedWeekYear
      ModifyingCollectionWithItself
      NoCanIgnoreReturnValueOnClasses
      NonRuntimeAnnotation
      NullableOnContainingClass
      NullTernary
      OverridesJavaxInjectableMethod
      ParcelableCreator
      PeriodFrom
      PreconditionsInvalidPlaceholder
      ProtoBuilderReturnValueIgnored
      ProtoFieldNullComparison
      RandomModInteger
      RectIntersectReturnValueIgnored
      ReturnValueIgnored
      SelfAssignment
      SelfComparison
      SelfEquals
      SizeGreaterThanOrEqualsZero
      StringBuilderInitWithChar
      TreeToString
      TryFailThrowable
      UnnecessaryCheckNotNull
      UnusedCollectionModifiedInPlace
      XorPower
      
      See https://errorprone.info/bugpatterns for more
      information on the checks.
      
      Bug: 253827323
      Test: m RUN_ERROR_PRONE=true javac-check
      Change-Id: I8446f9076a45ebf7e7ffa06cb0d4ddb1001b6c00
      7da659bb
  23. Nov 02, 2022
  24. Oct 12, 2022
    • Joanne's avatar
      Report ActivityId in Content capture ActivityEvent · 43af15ea
      Joanne authored
      Currently, the ActivityEvent only reports ComponentName and the event
      type. It may be a problem when launching the split mode for tablet.
      If the Activity launch mode is standard or singleTop, system allows
      to launch the same Activity in split mode. The ContentCaptureService
      cannot identify two different Activities instances in the split mode.
      
      To resolve this problem, the system will also report ActivityId in
      ActivityEvent to help ContentCaptureService to identify the Activity.
      
      Bug: 245023463
      Test: atest CtsContentCaptureServiceTestCases
      Change-Id: I8a79633a8ff0e5a99dc154bb4002a418b2e98219
      43af15ea
  25. Sep 20, 2022
    • Joanne's avatar
      Add event log for content capture · 37daac44
      Joanne authored
      Add event log for content capute connect and set allowlist to help
      the debugging.
      
      Some examples:
      I cc_connect_state_changed( 1762): [com.google.android.as/com.google
      .android.apps.miphone.aiai.app.AiAiContentCaptureService,1]
      I cc_set_allowlist: [14,0]
      
      Doesn't have MemoryOnBoot regression for com.google.intelligence.sense
      after this change. The reason is caused by the crash when the service
      calling set allowlist. This change fixes the NPE when calling set
      allowlist, the result is as below:
      before: go/cc_eventlog_memtest_before
      after: go/cc_eventlog_memtest_after
      issue: go/cc_eventlog_memtest_issue
      
      Bug: 233040086
      Test: manual. To watch event log
      Test: atest CtsContentCaptureServiceTestCases
      BYPASS_INCLUSIVE_LANGUAGE_REASON=existing APIs
      
      Change-Id: I9b3a97b808c65902d8ff346e6aa890be852fa598
      37daac44
  26. Jul 21, 2022
  27. Jul 20, 2022
    • Joanne Chung's avatar
      Add event log for content capture · 9fa9fc8b
      Joanne Chung authored
      Add event log for content capute connect and set allowlist to help
      the debugging.
      
      Some examples:
      I cc_connect_state_changed( 1762): [com.google.android.as/com.google
      .android.apps.miphone.aiai.app.AiAiContentCaptureService,1]
      I cc_set_allowlist: [14,0]
      
      Bug: 233040086
      Test: manual. To watch event log
      Change-Id: I9e836928896bd34ae41289059e83c74bf7aa3969
      9fa9fc8b
  28. Jul 01, 2022
    • Hani Kazmi's avatar
      Migrate Bundle/Intent APIs to new, type checked, variants · 4f221e5c
      Hani Kazmi authored
      Part of go/safer-parcel. Follow up to ag/16639043. Migrates the following unsafe APIs:
      
      * Parcel.readArray()
      * Parcel.readParcelableArray()
      * Bundle.getSerializable()
      * Bundle.getParcelable()
      * Bundle.getParcelableArrayList()
      * Bundle.getParcelableArray()
      * Bundle.getSparseParcelableArray()
      * Intent.getSerializableExtra()
      * Intent.getParcelableExtra()
      * Intent.getParcelableArrayExtra()
      * Intent.getParcelableArrayListExtra
      
      Bug: 227458983
      Test: m and presubmit pass
      Change-Id: I72f206cb18eb5c669a7fff07a6845bed1c433fdb
      4f221e5c
  29. May 26, 2022
    • Joanne Chung's avatar
      Revert "Rebind ContentCaptureService when the binderDied." · fa414929
      Joanne Chung authored
      This reverts commit 4fc5c86b.
      
      We introduce a rebind mechanism to rebind died ContentCaptureService
      because the apps tht has dependency with ContentCaptureService. But
      it looks like the rate is raised for app to get the null content
      capture manager.
      
      Because the underlying issue is fixed, we don't need this workaround
      now. We can also monitor if the null content capture sympton is
      resolved.
      
      Bug: 227353916
      Test: manual. Add dependency and update the app, the ContentCapture
      can be rebind without the this fix.
      Reason for revert: To monitor if the null content capture issue
      caused by this change.
      
      Change-Id: Ibe5d6e2b5f1434243b655289fdc60174ff33a5c0
      fa414929
  30. May 23, 2022
    • Adam Bookatz's avatar
      SystemService.isUserSupported uses isProfile · e554479c
      Adam Bookatz authored
      Previously, SystemService's isUserSupported() used isManagedProfile, but
      in many cases, it makes more sense to use isProfile:
      most of the particular cases already done probably just care about profile,
      not managed profile.
      
      So we introduce an isProfile(). We also modify how the userType is
      stored in this class, to make it more extensible in the future.
      
      Bug: 170249807
      Test: treehugger. This is a no-op since there currently aren't really
      other supported profile types anyway
      
      Change-Id: I43168939001d0e68ed6de95127161f1197683b10
      e554479c
  31. May 13, 2022
  32. Nov 02, 2021
    • Sergey Volnov's avatar
      Ensure we clear mPackagesWithShareRequests when a remote exception · 063fe636
      Sergey Volnov authored
      happens at write() or start().
      
      Bug: 203784652
      Test: atest CtsContentCaptureServiceTestCases
      Change-Id: I35d8c8056dc126c44f03b74a04090861224a9407
      (cherry picked from commit 39d8062a)
      063fe636
    • Joanne Chung's avatar
      Rebind ContentCaptureService when the binderDied. · 4fc5c86b
      Joanne Chung authored
      If the ContentCaptureService has package dependency with other
      package, if the package is updating, ContentCaptureService will also
      be killed.
      
      In the normal case, if the service will be reconnected but in this
      case the binding is cleared without any notification to the
      ContentCaptureManagerService. The bug is in the core platform infra.
      In the Content Capture code, we only see the binderDied.
      
      This change is a short term solution in S, we will rebind the service
      when the binderDied. To avoid crash loop, we only bind the service
      with limit rebind counts.
      
      Bug: 199609306
      Test: manual. Add addPackageDependency to package and update the
      package. Make sure the state is not zombie.
      
      Change-Id: I09a4cf6281a5a259a9a759ca640d6f075726e562
      4fc5c86b
  33. Nov 01, 2021
  34. Oct 01, 2021
  35. Sep 22, 2021
  36. Jul 27, 2021
  37. Mar 18, 2021
    • Alex Mang's avatar
      Switch over RemoteCallbackList to handle callbacks. · e1d8be7a
      Alex Mang authored
      Increases complexity, but given the limited # of apps a user has, this shouldn't be a big problem.
      
      Bug: 162609730
      Tested: atest WhitelistTest, Manually on device
      Change-Id: I4504b7eb7b503a95d663c375f481c997022d23fe
      e1d8be7a
Loading