- Nov 27, 2023
-
-
Reema Bajwa authored
Bug: 308470501 Test: Built & deployed locally Change-Id: I20b32ba3ac7a995efd6adde2cfeb9d75e56e7959
-
Becca Hughes authored
Test: atest FrameworksServicesTests Bug: 304815869 Change-Id: I719c5f9b80723967602321b82fbf889fd5e105f9
-
- Nov 01, 2023
-
-
Becca Hughes authored
The isEnabledCredentialProviderService is currently throwing an NPE when called. This updates the logic of that method to be aligned with the rest of the class and fix the error. Test: AndroidVault custom logic Bug: 307592997 Change-Id: If0091cd68f8c773d64acf37058893117555d4d73
-
- Oct 11, 2023
-
-
Becca Hughes authored
This reverts commit 81f2fdfc. Reason for revert: b/304709047 Change-Id: Ie9b73dd00a1fb774648f9f5e7dc6b92418c497df
-
- Oct 10, 2023
-
-
Reema Bajwa authored
Test: Built locally & deployed to device Bug: 303835719 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a75c8e7b68f9d3ff0eac572190fe2894a768345c) Merged-In: If03e146a069b9162d41eee26b7070ea52827fddf Change-Id: If03e146a069b9162d41eee26b7070ea52827fddf
-
Reema Bajwa authored
Test: Built locally & deployed to device Bug: 303835719 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a75c8e7b68f9d3ff0eac572190fe2894a768345c) Merged-In: If03e146a069b9162d41eee26b7070ea52827fddf Change-Id: If03e146a069b9162d41eee26b7070ea52827fddf
-
- Oct 09, 2023
-
-
Becca Hughes authored
If there are no primary provider on write then erase the additional providers. Also covers when apps are uninstalled and should be removed from stored providers. Test: ondevice flash Bug: 286174398 Change-Id: If9d6a3ff1f5603fef7d174529cd4530ff153f650
-
- Oct 06, 2023
-
-
Reema Bajwa authored
Test: Built locally & deployed to device Bug: 303835719 Change-Id: If03e146a069b9162d41eee26b7070ea52827fddf
-
Daniel authored
Currently, we bundle credential options from multiple views into a single credential request. During the bundling, the information of which view the option originates from gets lost. To retain the view association for autofill purposes, pass the autofillId to credential option when requesting to credman and pass the autofillId again when the credential entry gets returned from credman. Bug: 299344479 Test: Built locally Change-Id: I2cae247c3aff274afc47646bfa72483c8c6c053c
-
- Sep 19, 2023
-
-
Reema Bajwa authored
All new classes are hidden Bug: 299321990 Test: Built & deployed locally Change-Id: Iffa808dee493319abb1f1db7a3b6f7c96d822d6d
-
- Sep 18, 2023
-
-
Reema Bajwa authored
This API will be used by the CredentialAutofillService to get a list of all candidate credentials to be shown on dropdown or inline suggestions Bug: 299321990 Test: Built & deployed locally Change-Id: I33136dff0555e880b83e661f0c569d8e3d4ef7c0
-
- Aug 24, 2023
-
-
Becca Hughes authored
*this is a cherry pick from main* This CL updates the primary provider logic from not working correctly by replacing the use of strings with component info so that it is parsed and string formatting issues won't affect the new logic. Test: gts Bug: 291215735 Change-Id: I230fe6e22fd441e7fb986e899a8cade38f9e3b36 Merged-In: I230fe6e22fd441e7fb986e899a8cade38f9e3b36
-
Reema Bajwa authored
Revert to enabling the register/unregister APIs based on the feature flag, as opposed to always enabling them. Bug: 297279775 Test: Cts tests Change-Id: I806ffe993ab01da05a449a54d7dc30e3c222a83f
-
- Aug 23, 2023
-
-
Becca Hughes authored
This CL updates the primary provider logic from not working correctly by replacing the use of strings with component info so that it is parsed and string formatting issues won't affect the new logic. Test: gts Bug: 291215735 Change-Id: I230fe6e22fd441e7fb986e899a8cade38f9e3b36
-
- Jul 12, 2023
-
-
James Willcox authored
We cannot change the flag that this is using, so abandon it entirely and turn it on the registry all the time. Bug: 289435946 Test: local (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d0b8f0a90f7d91ddee515d58da2f34f1d586c7f4) Merged-In: I7f509eacaf8a973a290f9e429b3705d975bbfccf Change-Id: I7f509eacaf8a973a290f9e429b3705d975bbfccf
-
- Jun 30, 2023
-
-
James Willcox authored
We cannot change the flag that this is using, so abandon it entirely and turn it on the registry all the time. Bug: 289435946 Test: local Change-Id: I7f509eacaf8a973a290f9e429b3705d975bbfccf
-
- Jun 29, 2023
-
-
James Willcox authored
This makes them act more like remote providers and allows existing checks regarding when to show the UI work as expected. Bug: 288913298 Test: manually (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:df8461c4e00de2b44f1eb56136d02dbf2b152d94) Merged-In: Ia12cef3031c41206ab74616154c75fd415b31a0e Change-Id: Ia12cef3031c41206ab74616154c75fd415b31a0e
-
- Jun 26, 2023
-
-
James Willcox authored
This makes them act more like remote providers and allows existing checks regarding when to show the UI work as expected. Bug: 288913298 Test: manually Change-Id: Ia12cef3031c41206ab74616154c75fd415b31a0e
-
- Jun 22, 2023
-
-
Omer Ozer authored
Fixed the issue caused by intent creation without system context and the npe caused by null action chip list. Dropping then restoring caller id before intent creation and passing an empty list to avoid npe. Using uuid to distinguish different cred options in session. Bug: 287538489 Bug: 287529343 Bug: 287689739 Test: local Change-Id: I5612dd0f08a90a762c5ca5794a55a7abccecad2f
-
- Jun 13, 2023
-
-
Reema Bajwa authored
This is a bug discovered by our QA team. The bug causes the calling app to crash and hence, is critical to fix. Bug: 286519644 Test: Built & deployed locally on device Change-Id: Ie66e667dd0b8f581402e2e6202dee6c532e6d165
-
- May 18, 2023
-
-
Arpan Kaphle authored
After searching around, I discovered that our cts unittest location is unable to find the correct dependencies for the build (even though aidegen was able to). I discovered, instead, that we need to land our unittests in the services/tests directory, since the MetricUtilities are found in the services/.../server package. I've left TODOs where necessary. Bug: 273339472 Test: These are Metric Unit Tests Change-Id: Idf84ec5fc05ced6ca39c4b9bde557a04542823b1
-
- May 12, 2023
-
-
Reema Bajwa authored
When setAllowedProvider is specified, currently we are filtering out all the system providers. With this change, we will always ping the system providers + the providers specified in the allow list. Bug: 277773297 Test: built locally & deployed on devive Change-Id: I8a82f68edbd75b9a879d7e32aa32413af3a35cd9
-
Arpan Kaphle authored
This fixes any final issues in the metric collection and emission system, including logs. The fixes primarily focus on ensuring the timestamps are properly recorded, the aggregations are done properly for the total canddiate, and that all types and values are recorded or collected as they should be and emitted when they should be. Statuses and TODOs are also fixed here, alongside any final logs. Bug: 271135048 Bug: 270568738 Test: Build, won't submit without E2E Test (No Affect + Validate Metric Emits) Change-Id: I3637bf4a84596ba72bdab9ef225e4e5c77ab0bb6
-
- May 11, 2023
-
-
Reema Bajwa authored
Test: built & deployed locally Bug: 281849060 Change-Id: Id3617ecf725bbca32e371ddded617deb8967655e
-
- May 10, 2023
-
-
Arpan Kaphle authored
This adds our 'quick metric' to check the status of our other API methods. Final changes to come soon. Bug: 271135048 Test: Build Test Change-Id: I52efc7fdceb03df1e57d494c516425cd77679703
-
Arpan Kaphle authored
This adds a bit to indicate which candidate provider is a candidate in the candidate metric, within the flow where we know who the candidates are, but not who the calling app is. Bug: 271135048 Test: Build Test Change-Id: I531c1be0ed67c29ebd01c6d8a52d08ec83144421
-
Arpan Kaphle authored
This captures, for any API flows, if the chosen provider was the primary provider. It's the first of a few changes that capture these additional details and smaller API metrics. Bug: 271135048 Test: Build and Won't Submit without E2E Test Change-Id: Ib3870fb1f1f0ce870dd05bc1fc3901b5ef9e8200
-
Arpan Kaphle authored
This finds a proper spot to emit the aggregate phase of track 1. Since we emit final phases of both track 1 and 2 using the same information right afterwards, the aggregate phase can go right before that. That's because it needs to fully collect the authentication entry clicks, which may loop quite a while after the candidate finishes. Bug: 271135048 Test: Build and won't submit without E2E Test Change-Id: I94e95ead6e558fcb1f6be10d617f311b65eed7c3
-
Arpan Kaphle authored
This finalizes the aggregate candidate to fully combine the information from authentication entries and candidate entries, and emits the combined flow. Clean up is still required. Bug: 271135048 Test: Build + Won't Submit without E2E Test Change-Id: I72140e75ccec92779a7803524cc2746b9eed2ab5
-
Reema Bajwa authored
The problem is that we send an exception to the client and then send the pending data to the UI. As part of sending the exception, we also finish the session and in that finish logic, we are cancelling the pending intent. The status update is async so there's race condition. For now, I'm removing the cancellation of the pending intent so as part of the finish logic. It is still cancelled when a new pending intent is created for the same session but won't be cancelled when the session ends. May send out a follow up that addresses cancelling the pending intent with session finish in a safe way. Bug: 281615828 Test: built and deployed locally Change-Id: I9f30a0236da2125b56d8de42217fa70cc5e65191
-
Arpan Kaphle authored
This collects status and exception information for the auth entry metric and continues the combination of this metric with the total candidate metric. Bug: 271135048 Test: Build and Won't Submit without E2E Test Change-Id: Ib3db0b2723189d02f4af84b3101d0d45e24cd936
-
- May 09, 2023
-
-
Reema Bajwa authored
Test: Built locally Bug: 281599707 Change-Id: I94db6c7a3b68ac2dc40da09be2a777225bdeb169
-
Arpan Kaphle authored
This CL focuses on setting up the emit for the authentication entry metrics, by identifying where in the API flow this may occur. Further CLs will add more details. Bug: 271135048 Test: Build + Won't Submit before E2E Test Change-Id: I82c2f7477f585b0c43a6cf06e7a1f4982cbf5907
-
Arpan Kaphle authored
Since auth entries could repeat multiple times, maybe across multiple providers, this ensures that the aggregate and single case properly handle such sequential amounts of calls and emit them accordingly. Bug: 271135048 Test: Build and Won't Submit without E2E Test Change-Id: If4b77e0865761c22bd2e63b333bd46647f25d976
-
Arpan Kaphle authored
This adds the auth entries response collective into the candidate average metric, thereby creating a full aggregate for the response information. It also sets up the Get emit logic, and is a step towards final completion of the collection system. The threaded timed get emit system was removed in favor of an immediate function-based buffer/queue logging system that will be added once all changes are in. Bug: 271135048 Test: Build and Won't Submit without E2E Test Change-Id: I17ac83de23dee1486a10d7ce02bfc334ceef5581
-
- May 08, 2023
-
-
Arpan Kaphle authored
When we know the calling app, this sets up the final phase emit, where we do not know the providers. The session ID is properly transferred and different. We call this the 'track one' emit for the final phase. Bug: 271135048 Test: Build and won't submit without E2E test. Change-Id: If8cf0831f49eec7171c549fab1db471825fe6282
-
- May 06, 2023
-
-
Omer Ozer authored
Bug: 274494843 Bug: 273353677 Test: manual Change-Id: I90b1fa367a7a77dfdb91be67f7de7ceb4606338a
-
- May 05, 2023
-
-
Jerry Shi authored
Test: build local Bug: 281121157 Change-Id: I3d9f8a57ab4fc89bbc91c43d050fc0d05ee998e7
-
Reema Bajwa authored
Test: Built & deplyed locally Bug: 280869004 Change-Id: Id3e23b94b9169c3d5cca3d5b2695c25cb2758934
-
Becca Hughes authored
When updating settings it was reading stale data from the service so this updates it to get the provider list straight from the source. Test: ondevice Bug: 280908763 Change-Id: I2bd4f8dc4d92041569040c3412189412a4c5db30
-