Skip to content
Snippets Groups Projects
  1. Jan 17, 2024
    • Girish's avatar
      media: adding MediaFormat.KEY_IMPORTANCE · 39e5dad7
      Girish authored
      Bug: 289097671
      Test: atest android.media.misc.cts.ResourceManagerTest
            atest android.media.misc.cts.ResourceManagerMultiTest
      Merged-In: I750ef5a7585b7bba94f0dfb7bb8e70ec12bf70f5
      Change-Id: I750ef5a7585b7bba94f0dfb7bb8e70ec12bf70f5
      39e5dad7
  2. Jan 09, 2024
  3. Jan 06, 2024
    • Yifan Hong's avatar
      recovery: Delete internal verifyPackageCompatibility. · 16da32b0
      Yifan Hong authored
      Non-A/B has been deprecated for long. During non-A/B updates,
      compatibility.zip is checked with VintfObject.verify(), which
      is another deprecated function that always returns compatible
      if a list of package VINTF XMLs are supplied. (see below.) Hence, the private
      RecoverySystem.verifyPackageCompatibility was just useless code
      that unconditionally returns true except for invalid ZIP file.
      Remove it. Replace the public RecoverySystem.verifyPackageCompatibility
      and make it return true unconditonally.
      
      VintfObject.verify() with OTA XMLs are deprecated per
      http://b/139300422 [VINTF] Delete OTA vintf checking code
      in http://r.android.com/1194233 ("Delete VINTF compatibility checks
      during OTA."), in 2019. We had decided that compatibility checks
      during OTA should be removed, and moved to OTA generation time instead.
      Using an old libvintf on the device to check against new libvintf
      metadata required forward compatibility of libvintf, which cannot be
      achieved. Instead, the device should verify the signature of the OTA to
      verify its source.
      
      Test: TH
      Bug: 270169217
      Bug: 139300422
      Change-Id: I775d29e4cd1d165233e07cfb820d1fe343fa4757
      16da32b0
  4. Dec 19, 2023
    • Paul Duffin's avatar
      Remove erroneous duplicate baseline entry · 4a6e5cca
      Paul Duffin authored
      Due to a bug in Metalava the `VisiblySynchronized` check would report
      an erroneous duplicate baseline entry that referenced some internal
      implementation detail, e.g. `PsiThisExpression` instead of an actual
      API element. Another entry with the same message and correct API
      element was also written.
      
      The Metalava bug has been fixed so this change removes the erroneous
      entry.
      
      Bug: 311690008
      Test: m checkapi
      Merged-In: If5550b8cc0a97f02fb7fb1bd949f8e5517007d4c
      Change-Id: I79b3c9802e40e74ba7f0c9b102dc201d01ddeab5
      4a6e5cca
  5. Dec 13, 2023
  6. Dec 11, 2023
  7. Dec 07, 2023
  8. Dec 06, 2023
    • Eran Messeri's avatar
      Revert^2 "MGF1 Digest setter: Handle case of flag off" · e8e91b50
      Eran Messeri authored
      This reverts commit 468c8fe6.
      Additionally, this adds a guard for reading the flag: If
      the calling app does not have the right permission to read the device
      configuration, the code will assume it is not set.
      
      Reason for revert: Fixed flag reading code
      
      Bug: 314744703
      Test: atest CtsWebkitTestCases:android.webkit.cts.WebViewSslTest#testProceedClientCertRequestKeyWithAndroidKeystoreKey
      Change-Id: I29c58bc8c5960c0ab9af70f93440bd9a1db12dc7
      e8e91b50
  9. Nov 30, 2023
    • Nick Wille's avatar
      Revert "MGF1 Digest setter: Handle case of flag off" · 468c8fe6
      Nick Wille authored
      This reverts commit e0c8ad86.
      
      Reason for revert: 314140771
      
      Change-Id: Ied1f3042aee8ac8642237a4cdcfa75be7a02e7e8
      468c8fe6
    • Eran Messeri's avatar
      MGF1 Digest setter: Handle case of flag off · e0c8ad86
      Eran Messeri authored
      In case the MGF1 Digest setter flag is turned off (that is, it is not
      possible to specify MGF1 Digests using the new API introduced), then the
      old behaviour has to take place.
      
      The old behaviour was to set all primary digests specified, as MGF1 Digests.
      This behaviour has been added when the flag isn't set.
      
      Bug: 308378912
      Bug: 308069562
      Test: atest CtsKeystoreTestCases:android.keystore.cts.CipherTest#testKatBasicWithDifferentProviders CtsKeystoreWycheproofTestCases:RsaOaepTest
      Change-Id: I5d4541ce952e1bad7c8fdd55a00176274b0b66f3
      e0c8ad86
  10. Nov 22, 2023
  11. Nov 15, 2023
    • Eran Messeri's avatar
      Make MGF1 Digest setter NotNull · e0f6c088
      Eran Messeri authored
      The MGF1 Digest setter should not accept a null vararg. It should not
      take in null at all.
      
      Bug: 302280420
      Test: m
      Change-Id: I9db395d09e2fd0e609cd9019f3d3aedbb3244ef3
      e0f6c088
  12. Nov 14, 2023
  13. Nov 09, 2023
    • Jihoon Kang's avatar
      Add overriding method of a default method to signature files · ec4e94e1
      Jihoon Kang authored
      Currently, the signature file elides overrides of a default method,
      as they are not essential for the compilation of the stubs.
      However, in some scenarios, the overrides of a default method may be
      essential for the compilation of the reverse dependency of the stubs.
      In the scenario seen below:
      ```
      // API
      interface ApiInterface {
          public default void bar() {};
      }
      class ApiClass implements AnotherParentInterface{
          public void bar() {}
      }
      
      // App depending on the API
      interface AppInterface {
          public void bar();
      }
      public class AppClass extends ApiClass implements AppInterface {
      }
      ```
      Removal of `ApiClass.bar()` will lead to not overriding an abstract method
      `AppInterface.bar()` compilation error in `AppClass`.
      Therefore, this change adds the overrides of a default method to the
      signature files.
      
      Test: checkapi
      Bug: 299366704
      Change-Id: I212bd9aa895088fa9de33c7e3521453dea30c350
      ec4e94e1
    • Roshan Pius's avatar
      nfc(api): Add formal APIs for new ApduServiceInfo params · 530d4930
      Roshan Pius authored
      These are used by nfc stack, so should be formal APIs
      
      Bug: 301090456
      Test: CtsVerifier
      Change-Id: I60ce07e30bbec5458ca72b6e11b57b0f0058d589
      530d4930
  14. Nov 08, 2023
    • Kangping Dong's avatar
      [Thread] add Thread network permissions · fa35b426
      Kangping Dong authored
      Defines permissions for guarding access to Thread network API.
      
      The permissions are also granted to shell for CTS tests, see the
      instructions here: go/ctswrite#write-a-test-to-test-an-api-that-requires-system-permission
      
      Design doc: go/thread-android-api
      
      Bug: 262683651
      Merged-In: Ib15d5589bbd304d68840ee52a193676d12110512
      Change-Id: Ifc6c1d55cc170a5a200dfb5d531f5e0f86a9507a
      fa35b426
  15. Nov 01, 2023
    • James Willcox's avatar
      Add BiometricManager.getLastAuthenticationTime() · 8f0b73b7
      James Willcox authored
      This obtains the time (via SystemClock.elapsedRealtime()) when the
      user last authenticated using any of the passed authenticators.
      
      Test: manual, atest AuthServiceTest, CTS
      Bug: 303839446
      Change-Id: Id22bee7b05271ce38816f932b3696cb450ab025d
      8f0b73b7
  16. Oct 31, 2023
  17. Oct 30, 2023
  18. Oct 27, 2023
  19. Oct 24, 2023
  20. Oct 23, 2023
  21. Oct 19, 2023
    • Roshan Pius's avatar
      nfc(api): Create privileged setReaderMode API · 5ed8f129
      Roshan Pius authored
      Since NFC is becoming a mainline module, the existing CameraServiceProxy
      usage of raw INfcAdapter aidl interface will not be mainline compatible.
      So, create a system api to formalize this API usage. This has also been
      requested by the DCK team previously.
      
      Also, preserve the existing INfcAdapter usage behind the flag by
      including INfcAdapter file directly inside services/core.
      
      Bug: 303286040
      Bug: 290843937
      Test: atest CtsNfcTestCases
      Change-Id: I09b9bc58bd4f7cea705a0a17268448dde2bfef0a
      5ed8f129
  22. Oct 18, 2023
    • Shaquille Johnson's avatar
      biometric: Add nullable to api for crypto · 3266711a
      Shaquille Johnson authored
      The javadocs mention that the functions getMac(), getKeyAgreement,
      getCipher() can return nullable but this isn't show in the API.
      Updating these to reflect that
      
      Bug: 304697130
      Test: atest FrameworksCoreTests
      Change-Id: Icda5a087775174517abca7b4d1078a6ea0719170
      3266711a
  23. Oct 16, 2023
    • Paul Duffin's avatar
      Add additional overriding methods to signature files · d93cd390
      Paul Duffin authored
      This change adds overriding methods that are essential to compile the
      stubs generated from the signature files.
      
      More information and the background for this change is available at
      go/add-overriding-one-pager.
      
      Test: m checkbuild --build-from-text-stub
      Bug: 299366704
      Change-Id: Ia8f0ae4b4e47a2974016fd844242aa0564027131
      Merged-In: Ifc1876eb60a4b716f72c86003dc9bea0081e9a4c
      d93cd390
  24. Oct 10, 2023
    • Mateus Azis's avatar
      Mark Message.peekData as returning a nullable value. · e8edb9d1
      Mateus Azis authored
      This API is not currently annotated. This will highlight this
      possibility to any callers and hopefully enable better static analysis.
      
      Bug: 274764512
      Test: m framework -j
      Change-Id: I4b46c828625dd5ccff9d45cb56e5cfaf4c184917
      e8edb9d1
    • Paul Duffin's avatar
      Prepare for keeping concrete overrides of abstract methods · 48379f81
      Paul Duffin authored
      Currently, metalava will discard concrete overrides of abstract methods
      from the API signature files which causes problems when attempting to
      generate stubs from those files and also discards information that may
      be important in API reviews. This change is the first step in the
      process of changing that behavior.
      
      This change hard codes the current behavior for discarding the concrete
      overrides (`add-additional-overrides=no`) into those signature files
      that will (or are likely) to be affected by the change in behavior.
      That allows the default behavior to be changed for all the other files
      without affecting these.
      
      Follow up changes will remove the hard coding from the signature files
      and will update the contents which will include the concrete overrides
      of the abstract methods.
      
      More information and the background for this change is available at
      go/add-overriding-one-pager.
      
      Test: m checkapi
      Bug: 299366704
      Change-Id: Ibe0dbfa29f88d1040798ae394e8d456436259aea
      48379f81
    • Jack Wu's avatar
      BatteryManager: make stateOfHealth a public api · 4807a3f3
      Jack Wu authored
      
      Bug: 288842045
      Test: m update-api
      Change-Id: I923f84bff4849053a8faa921bf31e39748ed5075
      Signed-off-by: default avatarJack Wu <wjack@google.com>
      4807a3f3
  25. Oct 09, 2023
  26. Oct 03, 2023
  27. Sep 28, 2023
  28. Sep 27, 2023
    • Mårten Kongstad's avatar
      Expand @FlaggedApi(Flags.FLAG) in *all* API signature files · 85f6bee5
      Mårten Kongstad authored
      A previous CL added the auto-generated aconfig Flags.FLAG sources to
      metalava's input when generating core/api/current.txt, so metalava would
      expand the Flags.FLAG to their values.
      
      Do the same for the build targets for the other (system, module-lib,
      test) API signature files in core/api.
      
      Also update the API signature files accordingly.
      
      (cherry picked from commit 162ae2a1)
      
      Bug: 301859633
      Test: m checkapi
      Merged-In: Id06d77e897ecfddeaa42f75cba4d6d37bee9d1b1
      Change-Id: Id06d77e897ecfddeaa42f75cba4d6d37bee9d1b1
      85f6bee5
  29. Sep 25, 2023
  30. Sep 22, 2023
    • Eran Messeri's avatar
      MGF1 Digest: Add separate setter · d61656c5
      Eran Messeri authored
      Add a separate setter for the digests used by the MGF1 mask generation
      function (for RSA OAEP operations).
      
      Previously the MGF1 digests were specified according to the primary
      digests specification, which is not accurate enough.
      
      With the new setter:
      * If the user does not explicitly specify MGF1 digests, then the
        default (SHA-1) will be specified in the tag passed to Keystore.
      * If the user does explicitly specify MGF1 digests, only those
        digests will be specified in the tag passed to Keystore.
        The SHA-1 digest will not be added.
      
      Bug: 284140060
      Test: atest android.security.keystore.KeyGenParameterSpecTest android.security.ParcelableKeyGenParameterSpecTest
      Test: atest CtsKeystoreTestCases:android.keystore.cts.CipherTest#testKatBasicWithDifferentProviders
      Change-Id: I1521e9b4399ece33c2d17b79133543d490d3b377
      d61656c5
Loading